From cec53e907fd0d375ac6cfbc4f0cda6c03368cf7b Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 4 Apr 2024 01:17:41 -0400 Subject: [PATCH 01/10] Move static deserializers to base class --- .../Deserializers/AACS.cs | 22 +---- .../Deserializers/ArchiveDotOrg.cs | 33 +------ .../Deserializers/AttractMode.cs | 22 +---- .../Deserializers/BDPlus.cs | 22 +---- .../Deserializers/BFPK.cs | 22 +---- SabreTools.Serialization/Deserializers/BSP.cs | 22 +---- .../Deserializers/BaseBinaryDeserializer.cs | 88 +++++++++++++++++++ SabreTools.Serialization/Deserializers/CFB.cs | 22 +---- SabreTools.Serialization/Deserializers/CIA.cs | 22 +---- .../Deserializers/Catalog.cs | 21 ----- .../Deserializers/ClrMamePro.cs | 1 + .../Deserializers/CueSheet.cs | 22 +---- .../Deserializers/DosCenter.cs | 22 +---- .../Deserializers/EverdriveSMDB.cs | 22 +---- SabreTools.Serialization/Deserializers/GCF.cs | 22 +---- .../Deserializers/Hashfile.cs | 1 + SabreTools.Serialization/Deserializers/IRD.cs | 22 +---- .../Deserializers/InstallShieldCabinet.cs | 22 +---- .../Deserializers/JsonFile.cs | 1 + .../Deserializers/LinearExecutable.cs | 22 +---- .../Deserializers/Listrom.cs | 22 +---- .../Deserializers/Listxml.cs | 33 +------ .../Deserializers/Logiqx.cs | 33 +------ SabreTools.Serialization/Deserializers/M1.cs | 33 +------ .../Deserializers/MSDOS.cs | 22 +---- .../Deserializers/MicrosoftCabinet.cs | 22 +---- .../Deserializers/MoPaQ.cs | 22 +---- .../Deserializers/N3DS.cs | 22 +---- SabreTools.Serialization/Deserializers/NCF.cs | 22 +---- .../Deserializers/NewExecutable.cs | 22 +---- .../Deserializers/Nitro.cs | 22 +---- .../Deserializers/OfflineList.cs | 33 +------ .../Deserializers/OpenMSX.cs | 33 +------ SabreTools.Serialization/Deserializers/PAK.cs | 22 +---- SabreTools.Serialization/Deserializers/PFF.cs | 22 +---- SabreTools.Serialization/Deserializers/PIC.cs | 22 +---- .../Deserializers/PlayJAudio.cs | 15 +--- .../Deserializers/PlayJPlaylist.cs | 22 +---- .../Deserializers/PortableExecutable.cs | 22 +---- .../Deserializers/Quantum.cs | 22 +---- .../Deserializers/RomCenter.cs | 22 +---- SabreTools.Serialization/Deserializers/SGA.cs | 22 +---- .../Deserializers/SeparatedValue.cs | 1 + .../Deserializers/SoftwareList.cs | 33 +------ .../Deserializers/VBSP.cs | 22 +---- SabreTools.Serialization/Deserializers/VPK.cs | 22 +---- SabreTools.Serialization/Deserializers/WAD.cs | 22 +---- SabreTools.Serialization/Deserializers/XZP.cs | 22 +---- .../Deserializers/XmlFile.cs | 1 + Test/Program.cs | 3 + 50 files changed, 138 insertions(+), 973 deletions(-) create mode 100644 SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs diff --git a/SabreTools.Serialization/Deserializers/AACS.cs b/SabreTools.Serialization/Deserializers/AACS.cs index 7ac4b721..2ec4f669 100644 --- a/SabreTools.Serialization/Deserializers/AACS.cs +++ b/SabreTools.Serialization/Deserializers/AACS.cs @@ -9,19 +9,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class AACS : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static MediaKeyBlock? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new AACS(); - return deserializer.Deserialize(data, offset); - } - /// public MediaKeyBlock? Deserialize(byte[]? data, int offset) { @@ -42,13 +36,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static MediaKeyBlock? DeserializeFile(string? path) - { - var deserializer = new AACS(); - return deserializer.Deserialize(path); - } - /// public MediaKeyBlock? Deserialize(string? path) { @@ -60,13 +47,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static MediaKeyBlock? DeserializeStream(Stream? data) - { - var deserializer = new AACS(); - return deserializer.Deserialize(data); - } - /// public MediaKeyBlock? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/ArchiveDotOrg.cs b/SabreTools.Serialization/Deserializers/ArchiveDotOrg.cs index acedfcb6..8fb3a960 100644 --- a/SabreTools.Serialization/Deserializers/ArchiveDotOrg.cs +++ b/SabreTools.Serialization/Deserializers/ArchiveDotOrg.cs @@ -3,37 +3,6 @@ namespace SabreTools.Serialization.Deserializers public class ArchiveDotOrg : XmlFile { - #region IByteDeserializer - - /// - public static Models.ArchiveDotOrg.Files? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new ArchiveDotOrg(); - return deserializer.Deserialize(data, offset); - } - - #endregion - - #region IFileDeserializer - - /// - public static Models.ArchiveDotOrg.Files? DeserializeFile(string? path) - { - var deserializer = new ArchiveDotOrg(); - return deserializer.Deserialize(path); - } - - #endregion - - #region IStreamDeserializer - - /// - public static Models.ArchiveDotOrg.Files? DeserializeStream(System.IO.Stream? data) - { - var deserializer = new ArchiveDotOrg(); - return deserializer.Deserialize(data); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/AttractMode.cs b/SabreTools.Serialization/Deserializers/AttractMode.cs index 4b852b0a..3d615f8a 100644 --- a/SabreTools.Serialization/Deserializers/AttractMode.cs +++ b/SabreTools.Serialization/Deserializers/AttractMode.cs @@ -9,6 +9,7 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class AttractMode : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer @@ -23,13 +24,6 @@ namespace SabreTools.Serialization.Deserializers #region IByteDeserializer - /// - public static MetadataFile? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new AttractMode(); - return deserializer.Deserialize(data, offset); - } - /// public MetadataFile? Deserialize(byte[]? data, int offset) { @@ -50,13 +44,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static MetadataFile? DeserializeFile(string? path) - { - var deserializer = new AttractMode(); - return deserializer.Deserialize(path); - } - /// public MetadataFile? Deserialize(string? path) { @@ -68,13 +55,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static MetadataFile? DeserializeStream(Stream? data) - { - var deserializer = new AttractMode(); - return deserializer.Deserialize(data); - } - /// public MetadataFile? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/BDPlus.cs b/SabreTools.Serialization/Deserializers/BDPlus.cs index 1fa34bd6..deddbee0 100644 --- a/SabreTools.Serialization/Deserializers/BDPlus.cs +++ b/SabreTools.Serialization/Deserializers/BDPlus.cs @@ -8,19 +8,13 @@ using static SabreTools.Models.BDPlus.Constants; namespace SabreTools.Serialization.Deserializers { public class BDPlus : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static SVM? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new BDPlus(); - return deserializer.Deserialize(data, offset); - } - /// public SVM? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static SVM? DeserializeFile(string? path) - { - var deserializer = new BDPlus(); - return deserializer.Deserialize(path); - } - /// public SVM? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static SVM? DeserializeStream(Stream? data) - { - var deserializer = new BDPlus(); - return deserializer.Deserialize(data); - } - /// public SVM? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/BFPK.cs b/SabreTools.Serialization/Deserializers/BFPK.cs index ea1bbb3c..800dfe03 100644 --- a/SabreTools.Serialization/Deserializers/BFPK.cs +++ b/SabreTools.Serialization/Deserializers/BFPK.cs @@ -8,19 +8,13 @@ using static SabreTools.Models.BFPK.Constants; namespace SabreTools.Serialization.Deserializers { public class BFPK : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Archive? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new BFPK(); - return deserializer.Deserialize(data, offset); - } - /// public Archive? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Archive? DeserializeFile(string? path) - { - var deserializer = new BFPK(); - return deserializer.Deserialize(path); - } - /// public Archive? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Archive? DeserializeStream(Stream? data) - { - var deserializer = new BFPK(); - return deserializer.Deserialize(data); - } - /// public Archive? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/BSP.cs b/SabreTools.Serialization/Deserializers/BSP.cs index 2d56c89d..c214023d 100644 --- a/SabreTools.Serialization/Deserializers/BSP.cs +++ b/SabreTools.Serialization/Deserializers/BSP.cs @@ -9,19 +9,13 @@ using static SabreTools.Models.BSP.Constants; namespace SabreTools.Serialization.Deserializers { public class BSP : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.BSP.File? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new BSP(); - return deserializer.Deserialize(data, offset); - } - /// public Models.BSP.File? Deserialize(byte[]? data, int offset) { @@ -42,13 +36,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.BSP.File? DeserializeFile(string? path) - { - var deserializer = new BSP(); - return deserializer.Deserialize(path); - } - /// public Models.BSP.File? Deserialize(string? path) { @@ -60,13 +47,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.BSP.File? DeserializeStream(Stream? data) - { - var deserializer = new BSP(); - return deserializer.Deserialize(data); - } - /// public Models.BSP.File? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs b/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs new file mode 100644 index 00000000..359bc0c9 --- /dev/null +++ b/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs @@ -0,0 +1,88 @@ +using System; +using System.Collections.Generic; +using System.IO; +using System.Linq; +using System.Reflection; +using SabreTools.Serialization.Interfaces; + +namespace SabreTools.Serialization.Deserializers +{ + /// + /// Base class for all binary deserializers + /// + /// Type of the model to deserialize + /// These methods assume there is a concrete implementation of the deserialzier for the model available + public abstract class BaseBinaryDeserializer + { + #region Static Implementations + + /// + public static TModel? DeserializeBytes(byte[]? data, int offset) + { + var deserializer = GetType>(); + if (deserializer == null) + return default; + + return deserializer.Deserialize(data, offset); + } + + /// + public static TModel? DeserializeFile(string? path) + { + var deserializer = GetType>(); + if (deserializer == null) + return default; + return deserializer.Deserialize(path); + } + + /// + public static TModel? DeserializeStream(Stream? data) + { + var deserializer = GetType>(); + if (deserializer == null) + return default; + + return deserializer.Deserialize(data); + } + + #endregion + + /// + /// Get a constructed instance of a type, if possible + /// + /// Deserializer type to construct + /// Deserializer of the requested type, null on error + private static TDeserializer? GetType() + { + var assembly = Assembly.GetExecutingAssembly(); + if (assembly == null) + return default; + + // If not all types can be loaded, use the ones that could be + List assemblyTypes = []; + try + { + assemblyTypes = assembly.GetTypes().ToList(); + } + catch (ReflectionTypeLoadException rtle) + { + assemblyTypes = rtle.Types.Where(t => t != null)!.ToList(); + } + + // Loop through all types + foreach (Type type in assemblyTypes) + { + // If the type isn't a class or doesn't implement the interface + if (!type.IsClass || type.GetInterface(typeof(TDeserializer).Name) == null) + continue; + + // Try to create a concrete instance of the type + var instance = (TDeserializer?)Activator.CreateInstance(type); + if (instance != null) + return instance; + } + + return default; + } + } +} \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/CFB.cs b/SabreTools.Serialization/Deserializers/CFB.cs index fc3e6674..17676753 100644 --- a/SabreTools.Serialization/Deserializers/CFB.cs +++ b/SabreTools.Serialization/Deserializers/CFB.cs @@ -10,19 +10,13 @@ using static SabreTools.Models.CFB.Constants; namespace SabreTools.Serialization.Deserializers { public class CFB : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Binary? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new CFB(); - return deserializer.Deserialize(data, offset); - } - /// public Binary? Deserialize(byte[]? data, int offset) { @@ -43,13 +37,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Binary? DeserializeFile(string? path) - { - var deserializer = new CFB(); - return deserializer.Deserialize(path); - } - /// public Binary? Deserialize(string? path) { @@ -61,13 +48,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Binary? DeserializeStream(Stream? data) - { - var deserializer = new CFB(); - return deserializer.Deserialize(data); - } - /// public Binary? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/CIA.cs b/SabreTools.Serialization/Deserializers/CIA.cs index d08c549c..2eb6051b 100644 --- a/SabreTools.Serialization/Deserializers/CIA.cs +++ b/SabreTools.Serialization/Deserializers/CIA.cs @@ -8,19 +8,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class CIA : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.N3DS.CIA? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new CIA(); - return deserializer.Deserialize(data, offset); - } - /// public Models.N3DS.CIA? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.N3DS.CIA? DeserializeFile(string? path) - { - var deserializer = new CIA(); - return deserializer.Deserialize(path); - } - /// public Models.N3DS.CIA? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.N3DS.CIA? DeserializeStream(Stream? data) - { - var deserializer = new CIA(); - return deserializer.Deserialize(data); - } - /// public Models.N3DS.CIA? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/Catalog.cs b/SabreTools.Serialization/Deserializers/Catalog.cs index 481c9d92..e6e5d028 100644 --- a/SabreTools.Serialization/Deserializers/Catalog.cs +++ b/SabreTools.Serialization/Deserializers/Catalog.cs @@ -8,13 +8,6 @@ namespace SabreTools.Serialization.Deserializers { #region IByteDeserializer - /// - public static Models.Xbox.Catalog? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new Catalog(); - return deserializer.Deserialize(data, offset); - } - /// Catalog.js file is encoded as UTF-16 LE public override Models.Xbox.Catalog? Deserialize(byte[]? data, int offset) => Deserialize(data, offset, new UnicodeEncoding()); @@ -23,13 +16,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.Xbox.Catalog? DeserializeFile(string? path) - { - var deserializer = new Catalog(); - return deserializer.Deserialize(path); - } - /// Catalog.js file is encoded as UTF-16 LE public override Models.Xbox.Catalog? Deserialize(string? path) => Deserialize(path, new UnicodeEncoding()); @@ -38,13 +24,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.Xbox.Catalog? DeserializeStream(Stream? data) - { - var deserializer = new Catalog(); - return deserializer.Deserialize(data); - } - /// Catalog.js file is encoded as UTF-16 LE public override Models.Xbox.Catalog? Deserialize(Stream? data) => Deserialize(data, new UnicodeEncoding()); diff --git a/SabreTools.Serialization/Deserializers/ClrMamePro.cs b/SabreTools.Serialization/Deserializers/ClrMamePro.cs index 2de58a4c..4830a900 100644 --- a/SabreTools.Serialization/Deserializers/ClrMamePro.cs +++ b/SabreTools.Serialization/Deserializers/ClrMamePro.cs @@ -9,6 +9,7 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class ClrMamePro : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer diff --git a/SabreTools.Serialization/Deserializers/CueSheet.cs b/SabreTools.Serialization/Deserializers/CueSheet.cs index d77c7f5a..1181b1ce 100644 --- a/SabreTools.Serialization/Deserializers/CueSheet.cs +++ b/SabreTools.Serialization/Deserializers/CueSheet.cs @@ -10,19 +10,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class CueSheet : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.CueSheets.CueSheet? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new CueSheet(); - return deserializer.Deserialize(data, offset); - } - /// public Models.CueSheets.CueSheet? Deserialize(byte[]? data, int offset) { @@ -43,13 +37,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.CueSheets.CueSheet? DeserializeFile(string? path) - { - var deserializer = new CueSheet(); - return deserializer.Deserialize(path); - } - /// public Models.CueSheets.CueSheet? Deserialize(string? path) { @@ -61,13 +48,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.CueSheets.CueSheet? DeserializeStream(Stream? data) - { - var deserializer = new CueSheet(); - return deserializer.Deserialize(data); - } - /// public Models.CueSheets.CueSheet? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/DosCenter.cs b/SabreTools.Serialization/Deserializers/DosCenter.cs index b6a10eb7..769a7e75 100644 --- a/SabreTools.Serialization/Deserializers/DosCenter.cs +++ b/SabreTools.Serialization/Deserializers/DosCenter.cs @@ -8,19 +8,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class DosCenter : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static MetadataFile? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new DosCenter(); - return deserializer.Deserialize(data, offset); - } - /// public MetadataFile? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static MetadataFile? DeserializeFile(string? path) - { - var deserializer = new DosCenter(); - return deserializer.Deserialize(path); - } - /// public MetadataFile? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static MetadataFile? DeserializeStream(Stream? data) - { - var deserializer = new DosCenter(); - return deserializer.Deserialize(data); - } - /// public MetadataFile? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs b/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs index 52c3e4af..8edde60c 100644 --- a/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs +++ b/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs @@ -9,19 +9,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class EverdriveSMDB : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static MetadataFile? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new EverdriveSMDB(); - return deserializer.Deserialize(data, offset); - } - /// public MetadataFile? Deserialize(byte[]? data, int offset) { @@ -42,13 +36,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static MetadataFile? DeserializeFile(string? path) - { - var deserializer = new EverdriveSMDB(); - return deserializer.Deserialize(path); - } - /// public MetadataFile? Deserialize(string? path) { @@ -60,13 +47,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static MetadataFile? DeserializeStream(Stream? data) - { - var deserializer = new EverdriveSMDB(); - return deserializer.Deserialize(data); - } - /// public MetadataFile? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/GCF.cs b/SabreTools.Serialization/Deserializers/GCF.cs index 011ab320..47b8a806 100644 --- a/SabreTools.Serialization/Deserializers/GCF.cs +++ b/SabreTools.Serialization/Deserializers/GCF.cs @@ -8,19 +8,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class GCF : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.GCF.File? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new GCF(); - return deserializer.Deserialize(data, offset); - } - /// public Models.GCF.File? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.GCF.File? DeserializeFile(string? path) - { - var deserializer = new GCF(); - return deserializer.Deserialize(path); - } - /// public Models.GCF.File? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.GCF.File? DeserializeStream(Stream? data) - { - var deserializer = new GCF(); - return deserializer.Deserialize(data); - } - /// public Models.GCF.File? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/Hashfile.cs b/SabreTools.Serialization/Deserializers/Hashfile.cs index 503fc038..fd2fd97b 100644 --- a/SabreTools.Serialization/Deserializers/Hashfile.cs +++ b/SabreTools.Serialization/Deserializers/Hashfile.cs @@ -9,6 +9,7 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class Hashfile : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer diff --git a/SabreTools.Serialization/Deserializers/IRD.cs b/SabreTools.Serialization/Deserializers/IRD.cs index c5426b4b..d81f5e5f 100644 --- a/SabreTools.Serialization/Deserializers/IRD.cs +++ b/SabreTools.Serialization/Deserializers/IRD.cs @@ -6,19 +6,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class IRD : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.IRD.File? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new IRD(); - return deserializer.Deserialize(data, offset); - } - /// public Models.IRD.File? Deserialize(byte[]? data, int offset) { @@ -39,13 +33,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.IRD.File? DeserializeFile(string? path) - { - var deserializer = new IRD(); - return deserializer.Deserialize(path); - } - /// public Models.IRD.File? Deserialize(string? path) { @@ -57,13 +44,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.IRD.File? DeserializeStream(Stream? data) - { - var deserializer = new IRD(); - return deserializer.Deserialize(data); - } - /// public Models.IRD.File? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs b/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs index 069a9d8d..06330c10 100644 --- a/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs +++ b/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs @@ -10,19 +10,13 @@ namespace SabreTools.Serialization.Deserializers { // TODO: Add multi-cabinet reading public class InstallShieldCabinet : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Cabinet? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new InstallShieldCabinet(); - return deserializer.Deserialize(data, offset); - } - /// public Cabinet? Deserialize(byte[]? data, int offset) { @@ -43,13 +37,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Cabinet? DeserializeFile(string? path) - { - var deserializer = new InstallShieldCabinet(); - return deserializer.Deserialize(path); - } - /// public Cabinet? Deserialize(string? path) { @@ -61,13 +48,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Cabinet? DeserializeStream(Stream? data) - { - var deserializer = new InstallShieldCabinet(); - return deserializer.Deserialize(data); - } - /// public Cabinet? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/JsonFile.cs b/SabreTools.Serialization/Deserializers/JsonFile.cs index 5683d6b6..82781837 100644 --- a/SabreTools.Serialization/Deserializers/JsonFile.cs +++ b/SabreTools.Serialization/Deserializers/JsonFile.cs @@ -10,6 +10,7 @@ namespace SabreTools.Serialization.Deserializers /// /// public class JsonFile : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer diff --git a/SabreTools.Serialization/Deserializers/LinearExecutable.cs b/SabreTools.Serialization/Deserializers/LinearExecutable.cs index 78e18246..f05e46ec 100644 --- a/SabreTools.Serialization/Deserializers/LinearExecutable.cs +++ b/SabreTools.Serialization/Deserializers/LinearExecutable.cs @@ -9,19 +9,13 @@ using static SabreTools.Models.LinearExecutable.Constants; namespace SabreTools.Serialization.Deserializers { public class LinearExecutable : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Executable? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new LinearExecutable(); - return deserializer.Deserialize(data, offset); - } - /// public Executable? Deserialize(byte[]? data, int offset) { @@ -42,13 +36,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Executable? DeserializeFile(string? path) - { - var deserializer = new LinearExecutable(); - return deserializer.Deserialize(path); - } - /// public Executable? Deserialize(string? path) { @@ -60,13 +47,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Executable? DeserializeStream(Stream? data) - { - var deserializer = new LinearExecutable(); - return deserializer.Deserialize(data); - } - /// public Executable? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/Listrom.cs b/SabreTools.Serialization/Deserializers/Listrom.cs index 6bc87733..54b94201 100644 --- a/SabreTools.Serialization/Deserializers/Listrom.cs +++ b/SabreTools.Serialization/Deserializers/Listrom.cs @@ -8,19 +8,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class Listrom : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static MetadataFile? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new Listrom(); - return deserializer.Deserialize(data, offset); - } - /// public MetadataFile? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static MetadataFile? DeserializeFile(string? path) - { - var deserializer = new Listrom(); - return deserializer.Deserialize(path); - } - /// public MetadataFile? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static MetadataFile? DeserializeStream(Stream? data) - { - var deserializer = new Listrom(); - return deserializer.Deserialize(data); - } - /// public MetadataFile? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/Listxml.cs b/SabreTools.Serialization/Deserializers/Listxml.cs index 6b0c3611..92c4b148 100644 --- a/SabreTools.Serialization/Deserializers/Listxml.cs +++ b/SabreTools.Serialization/Deserializers/Listxml.cs @@ -3,37 +3,6 @@ namespace SabreTools.Serialization.Deserializers public class Listxml : XmlFile { - #region IByteDeserializer - - /// - public static Models.Listxml.Mame? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new Listxml(); - return deserializer.Deserialize(data, offset); - } - - #endregion - - #region IFileDeserializer - - /// - public static Models.Listxml.Mame? DeserializeFile(string? path) - { - var deserializer = new Listxml(); - return deserializer.Deserialize(path); - } - - #endregion - - #region IStreamDeserializer - - /// - public static Models.Listxml.Mame? DeserializeStream(System.IO.Stream? data) - { - var deserializer = new Listxml(); - return deserializer.Deserialize(data); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/Logiqx.cs b/SabreTools.Serialization/Deserializers/Logiqx.cs index 71849c4e..86844be8 100644 --- a/SabreTools.Serialization/Deserializers/Logiqx.cs +++ b/SabreTools.Serialization/Deserializers/Logiqx.cs @@ -3,37 +3,6 @@ namespace SabreTools.Serialization.Deserializers public class Logiqx : XmlFile { - #region IByteDeserializer - - /// - public static Models.Logiqx.Datafile? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new Logiqx(); - return deserializer.Deserialize(data, offset); - } - - #endregion - - #region IFileDeserializer - - /// - public static Models.Logiqx.Datafile? DeserializeFile(string? path) - { - var deserializer = new Logiqx(); - return deserializer.Deserialize(path); - } - - #endregion - - #region IStreamDeserializer - - /// - public static Models.Logiqx.Datafile? DeserializeStream(System.IO.Stream? data) - { - var deserializer = new Logiqx(); - return deserializer.Deserialize(data); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/M1.cs b/SabreTools.Serialization/Deserializers/M1.cs index c7d8e3e0..0f033b0e 100644 --- a/SabreTools.Serialization/Deserializers/M1.cs +++ b/SabreTools.Serialization/Deserializers/M1.cs @@ -3,37 +3,6 @@ namespace SabreTools.Serialization.Deserializers public class M1 : XmlFile { - #region IByteDeserializer - - /// - public static Models.Listxml.M1? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new M1(); - return deserializer.Deserialize(data, offset); - } - - #endregion - - #region IFileDeserializer - - /// - public static Models.Listxml.M1? DeserializeFile(string? path) - { - var deserializer = new M1(); - return deserializer.Deserialize(path); - } - - #endregion - - #region IStreamDeserializer - - /// - public static Models.Listxml.M1? DeserializeStream(System.IO.Stream? data) - { - var deserializer = new M1(); - return deserializer.Deserialize(data); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/MSDOS.cs b/SabreTools.Serialization/Deserializers/MSDOS.cs index 6a8d4815..bf724586 100644 --- a/SabreTools.Serialization/Deserializers/MSDOS.cs +++ b/SabreTools.Serialization/Deserializers/MSDOS.cs @@ -8,19 +8,13 @@ using static SabreTools.Models.MSDOS.Constants; namespace SabreTools.Serialization.Deserializers { public class MSDOS : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Executable? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new MSDOS(); - return deserializer.Deserialize(data, offset); - } - /// public Executable? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Executable? DeserializeFile(string? path) - { - var deserializer = new MSDOS(); - return deserializer.Deserialize(path); - } - /// public Executable? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Executable? DeserializeStream(Stream? data) - { - var deserializer = new MSDOS(); - return deserializer.Deserialize(data); - } - /// public Executable? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs b/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs index 4e58a589..1e45735c 100644 --- a/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs +++ b/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs @@ -9,19 +9,13 @@ namespace SabreTools.Serialization.Deserializers { // TODO: Add multi-cabinet reading public class MicrosoftCabinet : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Cabinet? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new MicrosoftCabinet(); - return deserializer.Deserialize(data, offset); - } - /// public Cabinet? Deserialize(byte[]? data, int offset) { @@ -42,13 +36,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Cabinet? DeserializeFile(string? path) - { - var deserializer = new MicrosoftCabinet(); - return deserializer.Deserialize(path); - } - /// public Cabinet? Deserialize(string? path) { @@ -60,13 +47,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Cabinet? DeserializeStream(Stream? data) - { - var deserializer = new MicrosoftCabinet(); - return deserializer.Deserialize(data); - } - /// public Cabinet? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/MoPaQ.cs b/SabreTools.Serialization/Deserializers/MoPaQ.cs index 286e06b4..cf9f9bb3 100644 --- a/SabreTools.Serialization/Deserializers/MoPaQ.cs +++ b/SabreTools.Serialization/Deserializers/MoPaQ.cs @@ -10,19 +10,13 @@ using static SabreTools.Models.MoPaQ.Constants; namespace SabreTools.Serialization.Deserializers { public class MoPaQ : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Archive? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new MoPaQ(); - return deserializer.Deserialize(data, offset); - } - /// public Archive? Deserialize(byte[]? data, int offset) { @@ -43,13 +37,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Archive? DeserializeFile(string? path) - { - var deserializer = new MoPaQ(); - return deserializer.Deserialize(path); - } - /// public Archive? Deserialize(string? path) { @@ -61,13 +48,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Archive? DeserializeStream(Stream? data) - { - var deserializer = new MoPaQ(); - return deserializer.Deserialize(data); - } - /// public Archive? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/N3DS.cs b/SabreTools.Serialization/Deserializers/N3DS.cs index 09a8a915..2f4e2d79 100644 --- a/SabreTools.Serialization/Deserializers/N3DS.cs +++ b/SabreTools.Serialization/Deserializers/N3DS.cs @@ -9,19 +9,13 @@ using static SabreTools.Models.N3DS.Constants; namespace SabreTools.Serialization.Deserializers { public class N3DS : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Cart? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new N3DS(); - return deserializer.Deserialize(data, offset); - } - /// public Cart? Deserialize(byte[]? data, int offset) { @@ -42,13 +36,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Cart? DeserializeFile(string? path) - { - var deserializer = new N3DS(); - return deserializer.Deserialize(path); - } - /// public Cart? Deserialize(string? path) { @@ -60,13 +47,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Cart? DeserializeStream(Stream? data) - { - var deserializer = new N3DS(); - return deserializer.Deserialize(data); - } - /// public Cart? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/NCF.cs b/SabreTools.Serialization/Deserializers/NCF.cs index d3aa0a90..b39c2587 100644 --- a/SabreTools.Serialization/Deserializers/NCF.cs +++ b/SabreTools.Serialization/Deserializers/NCF.cs @@ -8,19 +8,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class NCF : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.NCF.File? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new NCF(); - return deserializer.Deserialize(data, offset); - } - /// public Models.NCF.File? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.NCF.File? DeserializeFile(string? path) - { - var deserializer = new NCF(); - return deserializer.Deserialize(path); - } - /// public Models.NCF.File? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.NCF.File? DeserializeStream(Stream? data) - { - var deserializer = new NCF(); - return deserializer.Deserialize(data); - } - /// public Models.NCF.File? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/NewExecutable.cs b/SabreTools.Serialization/Deserializers/NewExecutable.cs index acb89e57..ed298872 100644 --- a/SabreTools.Serialization/Deserializers/NewExecutable.cs +++ b/SabreTools.Serialization/Deserializers/NewExecutable.cs @@ -10,19 +10,13 @@ using static SabreTools.Models.NewExecutable.Constants; namespace SabreTools.Serialization.Deserializers { public class NewExecutable : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Executable? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new NewExecutable(); - return deserializer.Deserialize(data, offset); - } - /// public Executable? Deserialize(byte[]? data, int offset) { @@ -43,13 +37,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Executable? DeserializeFile(string? path) - { - var deserializer = new NewExecutable(); - return deserializer.Deserialize(path); - } - /// public Executable? Deserialize(string? path) { @@ -61,13 +48,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Executable? DeserializeStream(Stream? data) - { - var deserializer = new NewExecutable(); - return deserializer.Deserialize(data); - } - /// public Executable? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/Nitro.cs b/SabreTools.Serialization/Deserializers/Nitro.cs index 3ccca111..820099a1 100644 --- a/SabreTools.Serialization/Deserializers/Nitro.cs +++ b/SabreTools.Serialization/Deserializers/Nitro.cs @@ -8,19 +8,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class Nitro : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Cart? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new Nitro(); - return deserializer.Deserialize(data, offset); - } - /// public Cart? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Cart? DeserializeFile(string? path) - { - var deserializer = new Nitro(); - return deserializer.Deserialize(path); - } - /// public Cart? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Cart? DeserializeStream(Stream? data) - { - var deserializer = new Nitro(); - return deserializer.Deserialize(data); - } - /// public Cart? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/OfflineList.cs b/SabreTools.Serialization/Deserializers/OfflineList.cs index 5ee37f43..7d96b2df 100644 --- a/SabreTools.Serialization/Deserializers/OfflineList.cs +++ b/SabreTools.Serialization/Deserializers/OfflineList.cs @@ -3,37 +3,6 @@ namespace SabreTools.Serialization.Deserializers public class OfflineList : XmlFile { - #region IByteDeserializer - - /// - public static Models.OfflineList.Dat? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new OfflineList(); - return deserializer.Deserialize(data, offset); - } - - #endregion - - #region IFileDeserializer - - /// - public static Models.OfflineList.Dat? DeserializeFile(string? path) - { - var deserializer = new OfflineList(); - return deserializer.Deserialize(path); - } - - #endregion - - #region IStreamDeserializer - - /// - public static Models.OfflineList.Dat? DeserializeStream(System.IO.Stream? data) - { - var deserializer = new OfflineList(); - return deserializer.Deserialize(data); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/OpenMSX.cs b/SabreTools.Serialization/Deserializers/OpenMSX.cs index c0d454a8..b95c37f7 100644 --- a/SabreTools.Serialization/Deserializers/OpenMSX.cs +++ b/SabreTools.Serialization/Deserializers/OpenMSX.cs @@ -3,37 +3,6 @@ namespace SabreTools.Serialization.Deserializers public class OpenMSX : XmlFile { - #region IByteDeserializer - - /// - public static Models.OpenMSX.SoftwareDb? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new OpenMSX(); - return deserializer.Deserialize(data, offset); - } - - #endregion - - #region IFileDeserializer - - /// - public static Models.OpenMSX.SoftwareDb? DeserializeFile(string? path) - { - var deserializer = new OpenMSX(); - return deserializer.Deserialize(path); - } - - #endregion - - #region IStreamDeserializer - - /// - public static Models.OpenMSX.SoftwareDb? DeserializeStream(System.IO.Stream? data) - { - var deserializer = new OpenMSX(); - return deserializer.Deserialize(data); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/PAK.cs b/SabreTools.Serialization/Deserializers/PAK.cs index f997e25f..4bf1ac5a 100644 --- a/SabreTools.Serialization/Deserializers/PAK.cs +++ b/SabreTools.Serialization/Deserializers/PAK.cs @@ -8,19 +8,13 @@ using static SabreTools.Models.PAK.Constants; namespace SabreTools.Serialization.Deserializers { public class PAK : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.PAK.File? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new PAK(); - return deserializer.Deserialize(data, offset); - } - /// public Models.PAK.File? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.PAK.File? DeserializeFile(string? path) - { - var deserializer = new PAK(); - return deserializer.Deserialize(path); - } - /// public Models.PAK.File? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.PAK.File? DeserializeStream(Stream? data) - { - var deserializer = new PAK(); - return deserializer.Deserialize(data); - } - /// public Models.PAK.File? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/PFF.cs b/SabreTools.Serialization/Deserializers/PFF.cs index 3857d8cc..c716756e 100644 --- a/SabreTools.Serialization/Deserializers/PFF.cs +++ b/SabreTools.Serialization/Deserializers/PFF.cs @@ -8,19 +8,13 @@ using static SabreTools.Models.PFF.Constants; namespace SabreTools.Serialization.Deserializers { public class PFF : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Archive? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new PFF(); - return deserializer.Deserialize(data, offset); - } - /// public Archive? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Archive? DeserializeFile(string? path) - { - var deserializer = new PFF(); - return deserializer.Deserialize(path); - } - /// public Archive? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Archive? DeserializeStream(Stream? data) - { - var deserializer = new PFF(); - return deserializer.Deserialize(data); - } - /// public Archive? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/PIC.cs b/SabreTools.Serialization/Deserializers/PIC.cs index d90a6aaa..952714e5 100644 --- a/SabreTools.Serialization/Deserializers/PIC.cs +++ b/SabreTools.Serialization/Deserializers/PIC.cs @@ -9,19 +9,13 @@ using static SabreTools.Models.PIC.Constants; namespace SabreTools.Serialization.Deserializers { public class PIC : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static DiscInformation? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new PIC(); - return deserializer.Deserialize(data, offset); - } - /// public DiscInformation? Deserialize(byte[]? data, int offset) { @@ -42,13 +36,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static DiscInformation? DeserializeFile(string? path) - { - var deserializer = new PIC(); - return deserializer.Deserialize(path); - } - /// public DiscInformation? Deserialize(string? path) { @@ -60,13 +47,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static DiscInformation? DeserializeStream(Stream? data) - { - var deserializer = new PIC(); - return deserializer.Deserialize(data); - } - /// public DiscInformation? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/PlayJAudio.cs b/SabreTools.Serialization/Deserializers/PlayJAudio.cs index ba036b36..8612b589 100644 --- a/SabreTools.Serialization/Deserializers/PlayJAudio.cs +++ b/SabreTools.Serialization/Deserializers/PlayJAudio.cs @@ -8,19 +8,13 @@ using static SabreTools.Models.PlayJ.Constants; namespace SabreTools.Serialization.Deserializers { public class PlayJAudio : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static AudioFile? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new PlayJAudio(); - return deserializer.Deserialize(data, offset); - } - /// public AudioFile? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static AudioFile? DeserializeFile(string? path) - { - var deserializer = new PlayJAudio(); - return deserializer.Deserialize(path); - } - /// public AudioFile? Deserialize(string? path) { diff --git a/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs b/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs index 2db03e7e..218653e2 100644 --- a/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs +++ b/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs @@ -6,19 +6,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class PlayJPlaylist : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Playlist? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new PlayJPlaylist(); - return deserializer.Deserialize(data, offset); - } - /// public Playlist? Deserialize(byte[]? data, int offset) { @@ -39,13 +33,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Playlist? DeserializeFile(string? path) - { - var deserializer = new PlayJPlaylist(); - return deserializer.Deserialize(path); - } - /// public Playlist? Deserialize(string? path) { @@ -57,13 +44,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Playlist? DeserializeStream(Stream? data) - { - var deserializer = new PlayJPlaylist(); - return deserializer.Deserialize(data); - } - /// public Playlist? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/PortableExecutable.cs b/SabreTools.Serialization/Deserializers/PortableExecutable.cs index 516da87d..d68246f3 100644 --- a/SabreTools.Serialization/Deserializers/PortableExecutable.cs +++ b/SabreTools.Serialization/Deserializers/PortableExecutable.cs @@ -11,19 +11,13 @@ using static SabreTools.Models.PortableExecutable.Constants; namespace SabreTools.Serialization.Deserializers { public class PortableExecutable : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Executable? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new PortableExecutable(); - return deserializer.Deserialize(data, offset); - } - /// public Executable? Deserialize(byte[]? data, int offset) { @@ -44,13 +38,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Executable? DeserializeFile(string? path) - { - var deserializer = new PortableExecutable(); - return deserializer.Deserialize(path); - } - /// public Executable? Deserialize(string? path) { @@ -62,13 +49,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Executable? DeserializeStream(Stream? data) - { - var deserializer = new PortableExecutable(); - return deserializer.Deserialize(data); - } - /// public Executable? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/Quantum.cs b/SabreTools.Serialization/Deserializers/Quantum.cs index 1a604c39..6039d2bf 100644 --- a/SabreTools.Serialization/Deserializers/Quantum.cs +++ b/SabreTools.Serialization/Deserializers/Quantum.cs @@ -8,19 +8,13 @@ using static SabreTools.Models.Quantum.Constants; namespace SabreTools.Serialization.Deserializers { public class Quantum : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Archive? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new Quantum(); - return deserializer.Deserialize(data, offset); - } - /// public Archive? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Archive? DeserializeFile(string? path) - { - var deserializer = new Quantum(); - return deserializer.Deserialize(path); - } - /// public Archive? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Archive? DeserializeStream(Stream? data) - { - var deserializer = new Quantum(); - return deserializer.Deserialize(data); - } - /// public Archive? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/RomCenter.cs b/SabreTools.Serialization/Deserializers/RomCenter.cs index caa5b884..38eb3027 100644 --- a/SabreTools.Serialization/Deserializers/RomCenter.cs +++ b/SabreTools.Serialization/Deserializers/RomCenter.cs @@ -9,19 +9,13 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class RomCenter : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static MetadataFile? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new RomCenter(); - return deserializer.Deserialize(data, offset); - } - /// public MetadataFile? Deserialize(byte[]? data, int offset) { @@ -42,13 +36,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static MetadataFile? DeserializeFile(string? path) - { - var deserializer = new RomCenter(); - return deserializer.Deserialize(path); - } - /// public MetadataFile? Deserialize(string? path) { @@ -60,13 +47,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static MetadataFile? DeserializeStream(Stream? data) - { - var deserializer = new RomCenter(); - return deserializer.Deserialize(data); - } - /// public MetadataFile? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/SGA.cs b/SabreTools.Serialization/Deserializers/SGA.cs index b72bb55e..af03f6b6 100644 --- a/SabreTools.Serialization/Deserializers/SGA.cs +++ b/SabreTools.Serialization/Deserializers/SGA.cs @@ -9,19 +9,13 @@ using static SabreTools.Models.SGA.Constants; namespace SabreTools.Serialization.Deserializers { public class SGA : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.SGA.File? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new SGA(); - return deserializer.Deserialize(data, offset); - } - /// public Models.SGA.File? Deserialize(byte[]? data, int offset) { @@ -42,13 +36,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.SGA.File? DeserializeFile(string? path) - { - var deserializer = new SGA(); - return deserializer.Deserialize(path); - } - /// public Models.SGA.File? Deserialize(string? path) { @@ -60,13 +47,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.SGA.File? DeserializeStream(Stream? data) - { - var deserializer = new SGA(); - return deserializer.Deserialize(data); - } - /// public Models.SGA.File? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/SeparatedValue.cs b/SabreTools.Serialization/Deserializers/SeparatedValue.cs index 21d98f03..56830106 100644 --- a/SabreTools.Serialization/Deserializers/SeparatedValue.cs +++ b/SabreTools.Serialization/Deserializers/SeparatedValue.cs @@ -9,6 +9,7 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { public class SeparatedValue : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer diff --git a/SabreTools.Serialization/Deserializers/SoftwareList.cs b/SabreTools.Serialization/Deserializers/SoftwareList.cs index 4646a88b..ee951734 100644 --- a/SabreTools.Serialization/Deserializers/SoftwareList.cs +++ b/SabreTools.Serialization/Deserializers/SoftwareList.cs @@ -3,37 +3,6 @@ namespace SabreTools.Serialization.Deserializers public class SoftwareList : XmlFile { - #region IByteDeserializer - - /// - public static Models.SoftwareList.SoftwareList? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new SoftwareList(); - return deserializer.Deserialize(data, offset); - } - - #endregion - - #region IFileDeserializer - - /// - public static Models.SoftwareList.SoftwareList? DeserializeFile(string? path) - { - var deserializer = new SoftwareList(); - return deserializer.Deserialize(path); - } - - #endregion - - #region IStreamDeserializer - - /// - public static Models.SoftwareList.SoftwareList? DeserializeStream(System.IO.Stream? data) - { - var deserializer = new SoftwareList(); - return deserializer.Deserialize(data); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/VBSP.cs b/SabreTools.Serialization/Deserializers/VBSP.cs index e807efc7..7c6ff24d 100644 --- a/SabreTools.Serialization/Deserializers/VBSP.cs +++ b/SabreTools.Serialization/Deserializers/VBSP.cs @@ -8,19 +8,13 @@ using static SabreTools.Models.VBSP.Constants; namespace SabreTools.Serialization.Deserializers { public class VBSP : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.VBSP.File? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new VBSP(); - return deserializer.Deserialize(data, offset); - } - /// public Models.VBSP.File? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.VBSP.File? DeserializeFile(string? path) - { - var deserializer = new VBSP(); - return deserializer.Deserialize(path); - } - /// public Models.VBSP.File? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.VBSP.File? DeserializeStream(Stream? data) - { - var deserializer = new VBSP(); - return deserializer.Deserialize(data); - } - /// public Models.VBSP.File? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/VPK.cs b/SabreTools.Serialization/Deserializers/VPK.cs index 1a551270..f7cddf8b 100644 --- a/SabreTools.Serialization/Deserializers/VPK.cs +++ b/SabreTools.Serialization/Deserializers/VPK.cs @@ -9,19 +9,13 @@ using static SabreTools.Models.VPK.Constants; namespace SabreTools.Serialization.Deserializers { public class VPK : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.VPK.File? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new VPK(); - return deserializer.Deserialize(data, offset); - } - /// public Models.VPK.File? Deserialize(byte[]? data, int offset) { @@ -42,13 +36,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.VPK.File? DeserializeFile(string? path) - { - var deserializer = new VPK(); - return deserializer.Deserialize(path); - } - /// public Models.VPK.File? Deserialize(string? path) { @@ -60,13 +47,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.VPK.File? DeserializeStream(Stream? data) - { - var deserializer = new VPK(); - return deserializer.Deserialize(data); - } - /// public Models.VPK.File? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/WAD.cs b/SabreTools.Serialization/Deserializers/WAD.cs index 04b65562..1b2bb9aa 100644 --- a/SabreTools.Serialization/Deserializers/WAD.cs +++ b/SabreTools.Serialization/Deserializers/WAD.cs @@ -8,19 +8,13 @@ using static SabreTools.Models.WAD.Constants; namespace SabreTools.Serialization.Deserializers { public class WAD : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.WAD.File? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new WAD(); - return deserializer.Deserialize(data, offset); - } - /// public Models.WAD.File? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.WAD.File? DeserializeFile(string? path) - { - var deserializer = new WAD(); - return deserializer.Deserialize(path); - } - /// public Models.WAD.File? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.WAD.File? DeserializeStream(Stream? data) - { - var deserializer = new WAD(); - return deserializer.Deserialize(data); - } - /// public Models.WAD.File? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/XZP.cs b/SabreTools.Serialization/Deserializers/XZP.cs index dc7fccf5..088ab421 100644 --- a/SabreTools.Serialization/Deserializers/XZP.cs +++ b/SabreTools.Serialization/Deserializers/XZP.cs @@ -8,19 +8,13 @@ using static SabreTools.Models.XZP.Constants; namespace SabreTools.Serialization.Deserializers { public class XZP : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer - /// - public static Models.XZP.File? DeserializeBytes(byte[]? data, int offset) - { - var deserializer = new XZP(); - return deserializer.Deserialize(data, offset); - } - /// public Models.XZP.File? Deserialize(byte[]? data, int offset) { @@ -41,13 +35,6 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer - /// - public static Models.XZP.File? DeserializeFile(string? path) - { - var deserializer = new XZP(); - return deserializer.Deserialize(path); - } - /// public Models.XZP.File? Deserialize(string? path) { @@ -59,13 +46,6 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer - /// - public static Models.XZP.File? DeserializeStream(Stream? data) - { - var deserializer = new XZP(); - return deserializer.Deserialize(data); - } - /// public Models.XZP.File? Deserialize(Stream? data) { diff --git a/SabreTools.Serialization/Deserializers/XmlFile.cs b/SabreTools.Serialization/Deserializers/XmlFile.cs index 01351f44..a103078b 100644 --- a/SabreTools.Serialization/Deserializers/XmlFile.cs +++ b/SabreTools.Serialization/Deserializers/XmlFile.cs @@ -11,6 +11,7 @@ namespace SabreTools.Serialization.Deserializers /// /// public class XmlFile : + BaseBinaryDeserializer, IByteDeserializer, IFileDeserializer, IStreamDeserializer diff --git a/Test/Program.cs b/Test/Program.cs index 5fc79b2c..1adf58d9 100644 --- a/Test/Program.cs +++ b/Test/Program.cs @@ -1,4 +1,5 @@ using SabreTools.Serialization; +using SabreTools.Serialization.Deserializers; namespace Test { @@ -6,6 +7,8 @@ namespace Test { public static void Main(string[] args) { + string path = "R:\\BurnOutSharp Testing Files\\FileType\\AACS Media Key Block\\1 (HD-DVD)\\MKBROM.AACS"; + var obj = AACS.DeserializeFile(path); // DO NOTHING FOR NOW } } From 7c21f657230f2d1f22971e7e996da14087ae0a7a Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 4 Apr 2024 01:26:27 -0400 Subject: [PATCH 02/10] Migrate IByteSerializer implementation to base class --- .../Deserializers/AACS.cs | 21 ------------ .../Deserializers/AttractMode.cs | 21 ------------ .../Deserializers/BDPlus.cs | 21 ------------ .../Deserializers/BFPK.cs | 21 ------------ SabreTools.Serialization/Deserializers/BSP.cs | 21 ------------ .../Deserializers/BaseBinaryDeserializer.cs | 25 +++++++++++++++ SabreTools.Serialization/Deserializers/CFB.cs | 21 ------------ SabreTools.Serialization/Deserializers/CIA.cs | 21 ------------ .../Deserializers/ClrMamePro.cs | 32 ------------------- .../Deserializers/CueSheet.cs | 21 ------------ .../Deserializers/DosCenter.cs | 21 ------------ .../Deserializers/EverdriveSMDB.cs | 21 ------------ SabreTools.Serialization/Deserializers/GCF.cs | 21 ------------ .../Deserializers/Hashfile.cs | 3 +- SabreTools.Serialization/Deserializers/IRD.cs | 21 ------------ .../Deserializers/InstallShieldCabinet.cs | 21 ------------ .../Deserializers/JsonFile.cs | 3 +- .../Deserializers/LinearExecutable.cs | 21 ------------ .../Deserializers/Listrom.cs | 21 ------------ .../Deserializers/MSDOS.cs | 21 ------------ .../Deserializers/MicrosoftCabinet.cs | 21 ------------ .../Deserializers/MoPaQ.cs | 21 ------------ .../Deserializers/N3DS.cs | 21 ------------ SabreTools.Serialization/Deserializers/NCF.cs | 21 ------------ .../Deserializers/NewExecutable.cs | 21 ------------ .../Deserializers/Nitro.cs | 21 ------------ SabreTools.Serialization/Deserializers/PAK.cs | 21 ------------ SabreTools.Serialization/Deserializers/PFF.cs | 21 ------------ SabreTools.Serialization/Deserializers/PIC.cs | 21 ------------ .../Deserializers/PlayJAudio.cs | 21 ------------ .../Deserializers/PlayJPlaylist.cs | 21 ------------ .../Deserializers/PortableExecutable.cs | 21 ------------ .../Deserializers/Quantum.cs | 21 ------------ .../Deserializers/RomCenter.cs | 21 ------------ SabreTools.Serialization/Deserializers/SGA.cs | 21 ------------ .../Deserializers/SeparatedValue.cs | 3 +- .../Deserializers/VBSP.cs | 21 ------------ SabreTools.Serialization/Deserializers/VPK.cs | 21 ------------ SabreTools.Serialization/Deserializers/WAD.cs | 21 ------------ SabreTools.Serialization/Deserializers/XZP.cs | 21 ------------ .../Deserializers/XmlFile.cs | 21 ------------ 41 files changed, 28 insertions(+), 794 deletions(-) diff --git a/SabreTools.Serialization/Deserializers/AACS.cs b/SabreTools.Serialization/Deserializers/AACS.cs index 2ec4f669..1fc9b08f 100644 --- a/SabreTools.Serialization/Deserializers/AACS.cs +++ b/SabreTools.Serialization/Deserializers/AACS.cs @@ -10,30 +10,9 @@ namespace SabreTools.Serialization.Deserializers { public class AACS : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public MediaKeyBlock? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/AttractMode.cs b/SabreTools.Serialization/Deserializers/AttractMode.cs index 3d615f8a..fb68e63d 100644 --- a/SabreTools.Serialization/Deserializers/AttractMode.cs +++ b/SabreTools.Serialization/Deserializers/AttractMode.cs @@ -10,7 +10,6 @@ namespace SabreTools.Serialization.Deserializers { public class AttractMode : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { @@ -22,26 +21,6 @@ namespace SabreTools.Serialization.Deserializers #endregion - #region IByteDeserializer - - /// - public MetadataFile? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/BDPlus.cs b/SabreTools.Serialization/Deserializers/BDPlus.cs index deddbee0..d10878cc 100644 --- a/SabreTools.Serialization/Deserializers/BDPlus.cs +++ b/SabreTools.Serialization/Deserializers/BDPlus.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class BDPlus : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public SVM? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/BFPK.cs b/SabreTools.Serialization/Deserializers/BFPK.cs index 800dfe03..ccd2ec96 100644 --- a/SabreTools.Serialization/Deserializers/BFPK.cs +++ b/SabreTools.Serialization/Deserializers/BFPK.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class BFPK : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Archive? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/BSP.cs b/SabreTools.Serialization/Deserializers/BSP.cs index c214023d..37e0a5c6 100644 --- a/SabreTools.Serialization/Deserializers/BSP.cs +++ b/SabreTools.Serialization/Deserializers/BSP.cs @@ -10,30 +10,9 @@ namespace SabreTools.Serialization.Deserializers { public class BSP : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.BSP.File? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs b/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs index 359bc0c9..1a064e7a 100644 --- a/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs +++ b/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs @@ -13,7 +13,28 @@ namespace SabreTools.Serialization.Deserializers /// Type of the model to deserialize /// These methods assume there is a concrete implementation of the deserialzier for the model available public abstract class BaseBinaryDeserializer + : IByteDeserializer { + #region IByteDeserializer + + /// + public virtual TModel? Deserialize(byte[]? data, int offset) + { + // If the data is invalid + if (data == null) + return default; + + // If the offset is out of bounds + if (offset < 0 || offset >= data.Length) + return default; + + // Create a memory stream and parse that + var dataStream = new MemoryStream(data, offset, data.Length - offset); + return DeserializeStream(dataStream); + } + + #endregion + #region Static Implementations /// @@ -47,6 +68,8 @@ namespace SabreTools.Serialization.Deserializers #endregion + #region Helpers + /// /// Get a constructed instance of a type, if possible /// @@ -84,5 +107,7 @@ namespace SabreTools.Serialization.Deserializers return default; } + + #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/CFB.cs b/SabreTools.Serialization/Deserializers/CFB.cs index 17676753..e6bafee5 100644 --- a/SabreTools.Serialization/Deserializers/CFB.cs +++ b/SabreTools.Serialization/Deserializers/CFB.cs @@ -11,30 +11,9 @@ namespace SabreTools.Serialization.Deserializers { public class CFB : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Binary? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/CIA.cs b/SabreTools.Serialization/Deserializers/CIA.cs index 2eb6051b..e1f932e0 100644 --- a/SabreTools.Serialization/Deserializers/CIA.cs +++ b/SabreTools.Serialization/Deserializers/CIA.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class CIA : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.N3DS.CIA? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/ClrMamePro.cs b/SabreTools.Serialization/Deserializers/ClrMamePro.cs index 4830a900..1c112107 100644 --- a/SabreTools.Serialization/Deserializers/ClrMamePro.cs +++ b/SabreTools.Serialization/Deserializers/ClrMamePro.cs @@ -10,41 +10,9 @@ namespace SabreTools.Serialization.Deserializers { public class ClrMamePro : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public static MetadataFile? DeserializeBytes(byte[]? data, int offset, bool quotes = true) - { - var deserializer = new ClrMamePro(); - return deserializer.Deserialize(data, offset, quotes); - } - - /// - public MetadataFile? Deserialize(byte[]? data, int offset) - => Deserialize(data, offset, true); - - /// - public MetadataFile? Deserialize(byte[]? data, int offset, bool quotes) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream, quotes); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/CueSheet.cs b/SabreTools.Serialization/Deserializers/CueSheet.cs index 1181b1ce..7ff9b1c0 100644 --- a/SabreTools.Serialization/Deserializers/CueSheet.cs +++ b/SabreTools.Serialization/Deserializers/CueSheet.cs @@ -11,30 +11,9 @@ namespace SabreTools.Serialization.Deserializers { public class CueSheet : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.CueSheets.CueSheet? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/DosCenter.cs b/SabreTools.Serialization/Deserializers/DosCenter.cs index 769a7e75..92b920d6 100644 --- a/SabreTools.Serialization/Deserializers/DosCenter.cs +++ b/SabreTools.Serialization/Deserializers/DosCenter.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class DosCenter : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public MetadataFile? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs b/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs index 8edde60c..a48a9f99 100644 --- a/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs +++ b/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs @@ -10,30 +10,9 @@ namespace SabreTools.Serialization.Deserializers { public class EverdriveSMDB : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public MetadataFile? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/GCF.cs b/SabreTools.Serialization/Deserializers/GCF.cs index 47b8a806..993eee95 100644 --- a/SabreTools.Serialization/Deserializers/GCF.cs +++ b/SabreTools.Serialization/Deserializers/GCF.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class GCF : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.GCF.File? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/Hashfile.cs b/SabreTools.Serialization/Deserializers/Hashfile.cs index fd2fd97b..359c67a8 100644 --- a/SabreTools.Serialization/Deserializers/Hashfile.cs +++ b/SabreTools.Serialization/Deserializers/Hashfile.cs @@ -10,7 +10,6 @@ namespace SabreTools.Serialization.Deserializers { public class Hashfile : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { @@ -24,7 +23,7 @@ namespace SabreTools.Serialization.Deserializers } /// - public Models.Hashfile.Hashfile? Deserialize(byte[]? data, int offset) + public override Models.Hashfile.Hashfile? Deserialize(byte[]? data, int offset) => Deserialize(data, offset, HashType.CRC32); /// diff --git a/SabreTools.Serialization/Deserializers/IRD.cs b/SabreTools.Serialization/Deserializers/IRD.cs index d81f5e5f..ba9d06b9 100644 --- a/SabreTools.Serialization/Deserializers/IRD.cs +++ b/SabreTools.Serialization/Deserializers/IRD.cs @@ -7,30 +7,9 @@ namespace SabreTools.Serialization.Deserializers { public class IRD : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.IRD.File? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs b/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs index 06330c10..a96ef191 100644 --- a/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs +++ b/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs @@ -11,30 +11,9 @@ namespace SabreTools.Serialization.Deserializers // TODO: Add multi-cabinet reading public class InstallShieldCabinet : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Cabinet? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/JsonFile.cs b/SabreTools.Serialization/Deserializers/JsonFile.cs index 82781837..5c827655 100644 --- a/SabreTools.Serialization/Deserializers/JsonFile.cs +++ b/SabreTools.Serialization/Deserializers/JsonFile.cs @@ -11,14 +11,13 @@ namespace SabreTools.Serialization.Deserializers /// public class JsonFile : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { #region IByteDeserializer /// - public virtual T? Deserialize(byte[]? data, int offset) + public override T? Deserialize(byte[]? data, int offset) => Deserialize(data, offset, new UTF8Encoding(false)); /// diff --git a/SabreTools.Serialization/Deserializers/LinearExecutable.cs b/SabreTools.Serialization/Deserializers/LinearExecutable.cs index f05e46ec..0f260d37 100644 --- a/SabreTools.Serialization/Deserializers/LinearExecutable.cs +++ b/SabreTools.Serialization/Deserializers/LinearExecutable.cs @@ -10,30 +10,9 @@ namespace SabreTools.Serialization.Deserializers { public class LinearExecutable : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Executable? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/Listrom.cs b/SabreTools.Serialization/Deserializers/Listrom.cs index 54b94201..2a0a8996 100644 --- a/SabreTools.Serialization/Deserializers/Listrom.cs +++ b/SabreTools.Serialization/Deserializers/Listrom.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class Listrom : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public MetadataFile? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/MSDOS.cs b/SabreTools.Serialization/Deserializers/MSDOS.cs index bf724586..2099b8cb 100644 --- a/SabreTools.Serialization/Deserializers/MSDOS.cs +++ b/SabreTools.Serialization/Deserializers/MSDOS.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class MSDOS : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Executable? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs b/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs index 1e45735c..ff9514b1 100644 --- a/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs +++ b/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs @@ -10,30 +10,9 @@ namespace SabreTools.Serialization.Deserializers // TODO: Add multi-cabinet reading public class MicrosoftCabinet : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Cabinet? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/MoPaQ.cs b/SabreTools.Serialization/Deserializers/MoPaQ.cs index cf9f9bb3..262a235a 100644 --- a/SabreTools.Serialization/Deserializers/MoPaQ.cs +++ b/SabreTools.Serialization/Deserializers/MoPaQ.cs @@ -11,30 +11,9 @@ namespace SabreTools.Serialization.Deserializers { public class MoPaQ : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Archive? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/N3DS.cs b/SabreTools.Serialization/Deserializers/N3DS.cs index 2f4e2d79..57e3a98a 100644 --- a/SabreTools.Serialization/Deserializers/N3DS.cs +++ b/SabreTools.Serialization/Deserializers/N3DS.cs @@ -10,30 +10,9 @@ namespace SabreTools.Serialization.Deserializers { public class N3DS : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Cart? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/NCF.cs b/SabreTools.Serialization/Deserializers/NCF.cs index b39c2587..1d57b10b 100644 --- a/SabreTools.Serialization/Deserializers/NCF.cs +++ b/SabreTools.Serialization/Deserializers/NCF.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class NCF : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.NCF.File? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/NewExecutable.cs b/SabreTools.Serialization/Deserializers/NewExecutable.cs index ed298872..4ab9685d 100644 --- a/SabreTools.Serialization/Deserializers/NewExecutable.cs +++ b/SabreTools.Serialization/Deserializers/NewExecutable.cs @@ -11,30 +11,9 @@ namespace SabreTools.Serialization.Deserializers { public class NewExecutable : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Executable? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/Nitro.cs b/SabreTools.Serialization/Deserializers/Nitro.cs index 820099a1..4f6de598 100644 --- a/SabreTools.Serialization/Deserializers/Nitro.cs +++ b/SabreTools.Serialization/Deserializers/Nitro.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class Nitro : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Cart? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PAK.cs b/SabreTools.Serialization/Deserializers/PAK.cs index 4bf1ac5a..9be880cd 100644 --- a/SabreTools.Serialization/Deserializers/PAK.cs +++ b/SabreTools.Serialization/Deserializers/PAK.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class PAK : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.PAK.File? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PFF.cs b/SabreTools.Serialization/Deserializers/PFF.cs index c716756e..c0ca7c2a 100644 --- a/SabreTools.Serialization/Deserializers/PFF.cs +++ b/SabreTools.Serialization/Deserializers/PFF.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class PFF : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Archive? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PIC.cs b/SabreTools.Serialization/Deserializers/PIC.cs index 952714e5..29e6b1f2 100644 --- a/SabreTools.Serialization/Deserializers/PIC.cs +++ b/SabreTools.Serialization/Deserializers/PIC.cs @@ -10,30 +10,9 @@ namespace SabreTools.Serialization.Deserializers { public class PIC : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public DiscInformation? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PlayJAudio.cs b/SabreTools.Serialization/Deserializers/PlayJAudio.cs index 8612b589..f5db1e92 100644 --- a/SabreTools.Serialization/Deserializers/PlayJAudio.cs +++ b/SabreTools.Serialization/Deserializers/PlayJAudio.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class PlayJAudio : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public AudioFile? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs b/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs index 218653e2..6acbfccb 100644 --- a/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs +++ b/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs @@ -7,30 +7,9 @@ namespace SabreTools.Serialization.Deserializers { public class PlayJPlaylist : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Playlist? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PortableExecutable.cs b/SabreTools.Serialization/Deserializers/PortableExecutable.cs index d68246f3..34775e23 100644 --- a/SabreTools.Serialization/Deserializers/PortableExecutable.cs +++ b/SabreTools.Serialization/Deserializers/PortableExecutable.cs @@ -12,30 +12,9 @@ namespace SabreTools.Serialization.Deserializers { public class PortableExecutable : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Executable? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/Quantum.cs b/SabreTools.Serialization/Deserializers/Quantum.cs index 6039d2bf..8220c9dc 100644 --- a/SabreTools.Serialization/Deserializers/Quantum.cs +++ b/SabreTools.Serialization/Deserializers/Quantum.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class Quantum : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Archive? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/RomCenter.cs b/SabreTools.Serialization/Deserializers/RomCenter.cs index 38eb3027..a151bae6 100644 --- a/SabreTools.Serialization/Deserializers/RomCenter.cs +++ b/SabreTools.Serialization/Deserializers/RomCenter.cs @@ -10,30 +10,9 @@ namespace SabreTools.Serialization.Deserializers { public class RomCenter : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public MetadataFile? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/SGA.cs b/SabreTools.Serialization/Deserializers/SGA.cs index af03f6b6..9d69a423 100644 --- a/SabreTools.Serialization/Deserializers/SGA.cs +++ b/SabreTools.Serialization/Deserializers/SGA.cs @@ -10,30 +10,9 @@ namespace SabreTools.Serialization.Deserializers { public class SGA : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.SGA.File? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/SeparatedValue.cs b/SabreTools.Serialization/Deserializers/SeparatedValue.cs index 56830106..40ec99c5 100644 --- a/SabreTools.Serialization/Deserializers/SeparatedValue.cs +++ b/SabreTools.Serialization/Deserializers/SeparatedValue.cs @@ -10,7 +10,6 @@ namespace SabreTools.Serialization.Deserializers { public class SeparatedValue : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { @@ -32,7 +31,7 @@ namespace SabreTools.Serialization.Deserializers } /// - public MetadataFile? Deserialize(byte[]? data, int offset) + public override MetadataFile? Deserialize(byte[]? data, int offset) => Deserialize(data, offset, ','); /// diff --git a/SabreTools.Serialization/Deserializers/VBSP.cs b/SabreTools.Serialization/Deserializers/VBSP.cs index 7c6ff24d..b150f874 100644 --- a/SabreTools.Serialization/Deserializers/VBSP.cs +++ b/SabreTools.Serialization/Deserializers/VBSP.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class VBSP : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.VBSP.File? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/VPK.cs b/SabreTools.Serialization/Deserializers/VPK.cs index f7cddf8b..3888d8a7 100644 --- a/SabreTools.Serialization/Deserializers/VPK.cs +++ b/SabreTools.Serialization/Deserializers/VPK.cs @@ -10,30 +10,9 @@ namespace SabreTools.Serialization.Deserializers { public class VPK : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.VPK.File? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/WAD.cs b/SabreTools.Serialization/Deserializers/WAD.cs index 1b2bb9aa..0b6942b5 100644 --- a/SabreTools.Serialization/Deserializers/WAD.cs +++ b/SabreTools.Serialization/Deserializers/WAD.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class WAD : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.WAD.File? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/XZP.cs b/SabreTools.Serialization/Deserializers/XZP.cs index 088ab421..421e8446 100644 --- a/SabreTools.Serialization/Deserializers/XZP.cs +++ b/SabreTools.Serialization/Deserializers/XZP.cs @@ -9,30 +9,9 @@ namespace SabreTools.Serialization.Deserializers { public class XZP : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public Models.XZP.File? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return null; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return null; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return DeserializeStream(dataStream); - } - - #endregion - #region IFileDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/XmlFile.cs b/SabreTools.Serialization/Deserializers/XmlFile.cs index a103078b..db687741 100644 --- a/SabreTools.Serialization/Deserializers/XmlFile.cs +++ b/SabreTools.Serialization/Deserializers/XmlFile.cs @@ -12,30 +12,9 @@ namespace SabreTools.Serialization.Deserializers /// public class XmlFile : BaseBinaryDeserializer, - IByteDeserializer, IFileDeserializer, IStreamDeserializer { - #region IByteDeserializer - - /// - public T? Deserialize(byte[]? data, int offset) - { - // If the data is invalid - if (data == null) - return default; - - // If the offset is out of bounds - if (offset < 0 || offset >= data.Length) - return default; - - // Create a memory stream and parse that - var dataStream = new MemoryStream(data, offset, data.Length - offset); - return Deserialize(dataStream); - } - - #endregion - #region IFileDeserializer /// From ef0efe66bd0ef0821877fc7b3e72f3fa8b2d44ca Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 4 Apr 2024 01:38:08 -0400 Subject: [PATCH 03/10] Migrate IFileDeserializer implementation to base class --- .../Deserializers/AACS.cs | 12 ------- .../Deserializers/AttractMode.cs | 12 ------- .../Deserializers/BDPlus.cs | 12 ------- .../Deserializers/BFPK.cs | 12 ------- SabreTools.Serialization/Deserializers/BSP.cs | 12 ------- .../Deserializers/BaseBinaryDeserializer.cs | 16 +++++++-- SabreTools.Serialization/Deserializers/CFB.cs | 12 ------- SabreTools.Serialization/Deserializers/CIA.cs | 12 ------- .../Deserializers/ClrMamePro.cs | 34 +++++++++++++++++-- .../Deserializers/CueSheet.cs | 12 ------- .../Deserializers/DosCenter.cs | 12 ------- .../Deserializers/EverdriveSMDB.cs | 12 ------- SabreTools.Serialization/Deserializers/GCF.cs | 12 ------- .../Deserializers/Hashfile.cs | 2 +- SabreTools.Serialization/Deserializers/IRD.cs | 12 ------- .../Deserializers/InstallShieldCabinet.cs | 12 ------- .../Deserializers/JsonFile.cs | 3 +- .../Deserializers/LinearExecutable.cs | 12 ------- .../Deserializers/Listrom.cs | 12 ------- .../Deserializers/MSDOS.cs | 12 ------- .../Deserializers/MicrosoftCabinet.cs | 12 ------- .../Deserializers/MoPaQ.cs | 12 ------- .../Deserializers/N3DS.cs | 12 ------- SabreTools.Serialization/Deserializers/NCF.cs | 12 ------- .../Deserializers/NewExecutable.cs | 12 ------- .../Deserializers/Nitro.cs | 12 ------- SabreTools.Serialization/Deserializers/PAK.cs | 12 ------- SabreTools.Serialization/Deserializers/PFF.cs | 12 ------- SabreTools.Serialization/Deserializers/PIC.cs | 12 ------- .../Deserializers/PlayJAudio.cs | 12 ------- .../Deserializers/PlayJPlaylist.cs | 12 ------- .../Deserializers/PortableExecutable.cs | 12 ------- .../Deserializers/Quantum.cs | 12 ------- .../Deserializers/RomCenter.cs | 12 ------- SabreTools.Serialization/Deserializers/SGA.cs | 12 ------- .../Deserializers/SeparatedValue.cs | 3 +- .../Deserializers/VBSP.cs | 12 ------- SabreTools.Serialization/Deserializers/VPK.cs | 12 ------- SabreTools.Serialization/Deserializers/WAD.cs | 12 ------- SabreTools.Serialization/Deserializers/XZP.cs | 12 ------- .../Deserializers/XmlFile.cs | 12 ------- 41 files changed, 49 insertions(+), 441 deletions(-) diff --git a/SabreTools.Serialization/Deserializers/AACS.cs b/SabreTools.Serialization/Deserializers/AACS.cs index 1fc9b08f..7173b7e8 100644 --- a/SabreTools.Serialization/Deserializers/AACS.cs +++ b/SabreTools.Serialization/Deserializers/AACS.cs @@ -10,20 +10,8 @@ namespace SabreTools.Serialization.Deserializers { public class AACS : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public MediaKeyBlock? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/AttractMode.cs b/SabreTools.Serialization/Deserializers/AttractMode.cs index fb68e63d..ccfc54da 100644 --- a/SabreTools.Serialization/Deserializers/AttractMode.cs +++ b/SabreTools.Serialization/Deserializers/AttractMode.cs @@ -10,7 +10,6 @@ namespace SabreTools.Serialization.Deserializers { public class AttractMode : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { #region Constants @@ -21,17 +20,6 @@ namespace SabreTools.Serialization.Deserializers #endregion - #region IFileDeserializer - - /// - public MetadataFile? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/BDPlus.cs b/SabreTools.Serialization/Deserializers/BDPlus.cs index d10878cc..22ad3486 100644 --- a/SabreTools.Serialization/Deserializers/BDPlus.cs +++ b/SabreTools.Serialization/Deserializers/BDPlus.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class BDPlus : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public SVM? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/BFPK.cs b/SabreTools.Serialization/Deserializers/BFPK.cs index ccd2ec96..947b4980 100644 --- a/SabreTools.Serialization/Deserializers/BFPK.cs +++ b/SabreTools.Serialization/Deserializers/BFPK.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class BFPK : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Archive? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/BSP.cs b/SabreTools.Serialization/Deserializers/BSP.cs index 37e0a5c6..7752c023 100644 --- a/SabreTools.Serialization/Deserializers/BSP.cs +++ b/SabreTools.Serialization/Deserializers/BSP.cs @@ -10,20 +10,8 @@ namespace SabreTools.Serialization.Deserializers { public class BSP : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.BSP.File? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs b/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs index 1a064e7a..2fe8858a 100644 --- a/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs +++ b/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs @@ -12,8 +12,9 @@ namespace SabreTools.Serialization.Deserializers /// /// Type of the model to deserialize /// These methods assume there is a concrete implementation of the deserialzier for the model available - public abstract class BaseBinaryDeserializer - : IByteDeserializer + public abstract class BaseBinaryDeserializer : + IByteDeserializer, + IFileDeserializer { #region IByteDeserializer @@ -35,6 +36,17 @@ namespace SabreTools.Serialization.Deserializers #endregion + #region IFileDeserializer + + /// + public virtual TModel? Deserialize(string? path) + { + using var stream = PathProcessor.OpenStream(path); + return DeserializeStream(stream); + } + + #endregion + #region Static Implementations /// diff --git a/SabreTools.Serialization/Deserializers/CFB.cs b/SabreTools.Serialization/Deserializers/CFB.cs index e6bafee5..fd30e34c 100644 --- a/SabreTools.Serialization/Deserializers/CFB.cs +++ b/SabreTools.Serialization/Deserializers/CFB.cs @@ -11,20 +11,8 @@ namespace SabreTools.Serialization.Deserializers { public class CFB : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Binary? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/CIA.cs b/SabreTools.Serialization/Deserializers/CIA.cs index e1f932e0..9b7b8c52 100644 --- a/SabreTools.Serialization/Deserializers/CIA.cs +++ b/SabreTools.Serialization/Deserializers/CIA.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class CIA : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.N3DS.CIA? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/ClrMamePro.cs b/SabreTools.Serialization/Deserializers/ClrMamePro.cs index 1c112107..c6f433a4 100644 --- a/SabreTools.Serialization/Deserializers/ClrMamePro.cs +++ b/SabreTools.Serialization/Deserializers/ClrMamePro.cs @@ -10,9 +10,39 @@ namespace SabreTools.Serialization.Deserializers { public class ClrMamePro : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { + #region IByteDeserializer + + /// + public static MetadataFile? DeserializeBytes(byte[]? data, int offset, bool quotes = true) + { + var deserializer = new ClrMamePro(); + return deserializer.Deserialize(data, offset, quotes); + } + + /// + public override MetadataFile? Deserialize(byte[]? data, int offset) + => Deserialize(data, offset, true); + + /// + public MetadataFile? Deserialize(byte[]? data, int offset, bool quotes) + { + // If the data is invalid + if (data == null) + return default; + + // If the offset is out of bounds + if (offset < 0 || offset >= data.Length) + return default; + + // Create a memory stream and parse that + var dataStream = new MemoryStream(data, offset, data.Length - offset); + return DeserializeStream(dataStream, quotes); + } + + #endregion + #region IFileDeserializer /// @@ -23,7 +53,7 @@ namespace SabreTools.Serialization.Deserializers } /// - public MetadataFile? Deserialize(string? path) + public override MetadataFile? Deserialize(string? path) => Deserialize(path, true); /// diff --git a/SabreTools.Serialization/Deserializers/CueSheet.cs b/SabreTools.Serialization/Deserializers/CueSheet.cs index 7ff9b1c0..b887562b 100644 --- a/SabreTools.Serialization/Deserializers/CueSheet.cs +++ b/SabreTools.Serialization/Deserializers/CueSheet.cs @@ -11,20 +11,8 @@ namespace SabreTools.Serialization.Deserializers { public class CueSheet : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.CueSheets.CueSheet? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/DosCenter.cs b/SabreTools.Serialization/Deserializers/DosCenter.cs index 92b920d6..975011ab 100644 --- a/SabreTools.Serialization/Deserializers/DosCenter.cs +++ b/SabreTools.Serialization/Deserializers/DosCenter.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class DosCenter : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public MetadataFile? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs b/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs index a48a9f99..2c94b8aa 100644 --- a/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs +++ b/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs @@ -10,20 +10,8 @@ namespace SabreTools.Serialization.Deserializers { public class EverdriveSMDB : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public MetadataFile? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/GCF.cs b/SabreTools.Serialization/Deserializers/GCF.cs index 993eee95..a9b6eac3 100644 --- a/SabreTools.Serialization/Deserializers/GCF.cs +++ b/SabreTools.Serialization/Deserializers/GCF.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class GCF : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.GCF.File? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/Hashfile.cs b/SabreTools.Serialization/Deserializers/Hashfile.cs index 359c67a8..2a70c9cb 100644 --- a/SabreTools.Serialization/Deserializers/Hashfile.cs +++ b/SabreTools.Serialization/Deserializers/Hashfile.cs @@ -54,7 +54,7 @@ namespace SabreTools.Serialization.Deserializers } /// - public Models.Hashfile.Hashfile? Deserialize(string? path) + public override Models.Hashfile.Hashfile? Deserialize(string? path) => Deserialize(path, HashType.CRC32); /// diff --git a/SabreTools.Serialization/Deserializers/IRD.cs b/SabreTools.Serialization/Deserializers/IRD.cs index ba9d06b9..3b4dbee8 100644 --- a/SabreTools.Serialization/Deserializers/IRD.cs +++ b/SabreTools.Serialization/Deserializers/IRD.cs @@ -7,20 +7,8 @@ namespace SabreTools.Serialization.Deserializers { public class IRD : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.IRD.File? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs b/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs index a96ef191..79f9cab9 100644 --- a/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs +++ b/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs @@ -11,20 +11,8 @@ namespace SabreTools.Serialization.Deserializers // TODO: Add multi-cabinet reading public class InstallShieldCabinet : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Cabinet? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/JsonFile.cs b/SabreTools.Serialization/Deserializers/JsonFile.cs index 5c827655..24a04fe7 100644 --- a/SabreTools.Serialization/Deserializers/JsonFile.cs +++ b/SabreTools.Serialization/Deserializers/JsonFile.cs @@ -11,7 +11,6 @@ namespace SabreTools.Serialization.Deserializers /// public class JsonFile : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { #region IByteDeserializer @@ -48,7 +47,7 @@ namespace SabreTools.Serialization.Deserializers #region IFileDeserializer /// - public virtual T? Deserialize(string? path) + public override T? Deserialize(string? path) => Deserialize(path, new UTF8Encoding(false)); /// diff --git a/SabreTools.Serialization/Deserializers/LinearExecutable.cs b/SabreTools.Serialization/Deserializers/LinearExecutable.cs index 0f260d37..13945e67 100644 --- a/SabreTools.Serialization/Deserializers/LinearExecutable.cs +++ b/SabreTools.Serialization/Deserializers/LinearExecutable.cs @@ -10,20 +10,8 @@ namespace SabreTools.Serialization.Deserializers { public class LinearExecutable : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Executable? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/Listrom.cs b/SabreTools.Serialization/Deserializers/Listrom.cs index 2a0a8996..d5c784cd 100644 --- a/SabreTools.Serialization/Deserializers/Listrom.cs +++ b/SabreTools.Serialization/Deserializers/Listrom.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class Listrom : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public MetadataFile? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/MSDOS.cs b/SabreTools.Serialization/Deserializers/MSDOS.cs index 2099b8cb..6a5c13f3 100644 --- a/SabreTools.Serialization/Deserializers/MSDOS.cs +++ b/SabreTools.Serialization/Deserializers/MSDOS.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class MSDOS : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Executable? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs b/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs index ff9514b1..e823d564 100644 --- a/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs +++ b/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs @@ -10,20 +10,8 @@ namespace SabreTools.Serialization.Deserializers // TODO: Add multi-cabinet reading public class MicrosoftCabinet : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Cabinet? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/MoPaQ.cs b/SabreTools.Serialization/Deserializers/MoPaQ.cs index 262a235a..103012f6 100644 --- a/SabreTools.Serialization/Deserializers/MoPaQ.cs +++ b/SabreTools.Serialization/Deserializers/MoPaQ.cs @@ -11,20 +11,8 @@ namespace SabreTools.Serialization.Deserializers { public class MoPaQ : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Archive? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/N3DS.cs b/SabreTools.Serialization/Deserializers/N3DS.cs index 57e3a98a..ef538882 100644 --- a/SabreTools.Serialization/Deserializers/N3DS.cs +++ b/SabreTools.Serialization/Deserializers/N3DS.cs @@ -10,20 +10,8 @@ namespace SabreTools.Serialization.Deserializers { public class N3DS : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Cart? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/NCF.cs b/SabreTools.Serialization/Deserializers/NCF.cs index 1d57b10b..c1362951 100644 --- a/SabreTools.Serialization/Deserializers/NCF.cs +++ b/SabreTools.Serialization/Deserializers/NCF.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class NCF : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.NCF.File? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/NewExecutable.cs b/SabreTools.Serialization/Deserializers/NewExecutable.cs index 4ab9685d..fbc9859b 100644 --- a/SabreTools.Serialization/Deserializers/NewExecutable.cs +++ b/SabreTools.Serialization/Deserializers/NewExecutable.cs @@ -11,20 +11,8 @@ namespace SabreTools.Serialization.Deserializers { public class NewExecutable : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Executable? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/Nitro.cs b/SabreTools.Serialization/Deserializers/Nitro.cs index 4f6de598..d98e00da 100644 --- a/SabreTools.Serialization/Deserializers/Nitro.cs +++ b/SabreTools.Serialization/Deserializers/Nitro.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class Nitro : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Cart? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PAK.cs b/SabreTools.Serialization/Deserializers/PAK.cs index 9be880cd..3248e374 100644 --- a/SabreTools.Serialization/Deserializers/PAK.cs +++ b/SabreTools.Serialization/Deserializers/PAK.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class PAK : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.PAK.File? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PFF.cs b/SabreTools.Serialization/Deserializers/PFF.cs index c0ca7c2a..b1718b24 100644 --- a/SabreTools.Serialization/Deserializers/PFF.cs +++ b/SabreTools.Serialization/Deserializers/PFF.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class PFF : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Archive? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PIC.cs b/SabreTools.Serialization/Deserializers/PIC.cs index 29e6b1f2..1cdd562d 100644 --- a/SabreTools.Serialization/Deserializers/PIC.cs +++ b/SabreTools.Serialization/Deserializers/PIC.cs @@ -10,20 +10,8 @@ namespace SabreTools.Serialization.Deserializers { public class PIC : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public DiscInformation? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PlayJAudio.cs b/SabreTools.Serialization/Deserializers/PlayJAudio.cs index f5db1e92..dad9dfff 100644 --- a/SabreTools.Serialization/Deserializers/PlayJAudio.cs +++ b/SabreTools.Serialization/Deserializers/PlayJAudio.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class PlayJAudio : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public AudioFile? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs b/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs index 6acbfccb..69017fce 100644 --- a/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs +++ b/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs @@ -7,20 +7,8 @@ namespace SabreTools.Serialization.Deserializers { public class PlayJPlaylist : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Playlist? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/PortableExecutable.cs b/SabreTools.Serialization/Deserializers/PortableExecutable.cs index 34775e23..aa24b10b 100644 --- a/SabreTools.Serialization/Deserializers/PortableExecutable.cs +++ b/SabreTools.Serialization/Deserializers/PortableExecutable.cs @@ -12,20 +12,8 @@ namespace SabreTools.Serialization.Deserializers { public class PortableExecutable : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Executable? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/Quantum.cs b/SabreTools.Serialization/Deserializers/Quantum.cs index 8220c9dc..56850f7f 100644 --- a/SabreTools.Serialization/Deserializers/Quantum.cs +++ b/SabreTools.Serialization/Deserializers/Quantum.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class Quantum : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Archive? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/RomCenter.cs b/SabreTools.Serialization/Deserializers/RomCenter.cs index a151bae6..78ed674c 100644 --- a/SabreTools.Serialization/Deserializers/RomCenter.cs +++ b/SabreTools.Serialization/Deserializers/RomCenter.cs @@ -10,20 +10,8 @@ namespace SabreTools.Serialization.Deserializers { public class RomCenter : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public MetadataFile? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/SGA.cs b/SabreTools.Serialization/Deserializers/SGA.cs index 9d69a423..45965e28 100644 --- a/SabreTools.Serialization/Deserializers/SGA.cs +++ b/SabreTools.Serialization/Deserializers/SGA.cs @@ -10,20 +10,8 @@ namespace SabreTools.Serialization.Deserializers { public class SGA : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.SGA.File? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/SeparatedValue.cs b/SabreTools.Serialization/Deserializers/SeparatedValue.cs index 40ec99c5..fc5bd747 100644 --- a/SabreTools.Serialization/Deserializers/SeparatedValue.cs +++ b/SabreTools.Serialization/Deserializers/SeparatedValue.cs @@ -10,7 +10,6 @@ namespace SabreTools.Serialization.Deserializers { public class SeparatedValue : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { #region Constants @@ -62,7 +61,7 @@ namespace SabreTools.Serialization.Deserializers } /// - public MetadataFile? Deserialize(string? path) + public override MetadataFile? Deserialize(string? path) => Deserialize(path, ','); /// diff --git a/SabreTools.Serialization/Deserializers/VBSP.cs b/SabreTools.Serialization/Deserializers/VBSP.cs index b150f874..e58522e6 100644 --- a/SabreTools.Serialization/Deserializers/VBSP.cs +++ b/SabreTools.Serialization/Deserializers/VBSP.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class VBSP : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.VBSP.File? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/VPK.cs b/SabreTools.Serialization/Deserializers/VPK.cs index 3888d8a7..762b2efe 100644 --- a/SabreTools.Serialization/Deserializers/VPK.cs +++ b/SabreTools.Serialization/Deserializers/VPK.cs @@ -10,20 +10,8 @@ namespace SabreTools.Serialization.Deserializers { public class VPK : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.VPK.File? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/WAD.cs b/SabreTools.Serialization/Deserializers/WAD.cs index 0b6942b5..4d9b2d20 100644 --- a/SabreTools.Serialization/Deserializers/WAD.cs +++ b/SabreTools.Serialization/Deserializers/WAD.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class WAD : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.WAD.File? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/XZP.cs b/SabreTools.Serialization/Deserializers/XZP.cs index 421e8446..eb9028ff 100644 --- a/SabreTools.Serialization/Deserializers/XZP.cs +++ b/SabreTools.Serialization/Deserializers/XZP.cs @@ -9,20 +9,8 @@ namespace SabreTools.Serialization.Deserializers { public class XZP : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public Models.XZP.File? Deserialize(string? path) - { - using var stream = PathProcessor.OpenStream(path); - return DeserializeStream(stream); - } - - #endregion - #region IStreamDeserializer /// diff --git a/SabreTools.Serialization/Deserializers/XmlFile.cs b/SabreTools.Serialization/Deserializers/XmlFile.cs index db687741..6344664a 100644 --- a/SabreTools.Serialization/Deserializers/XmlFile.cs +++ b/SabreTools.Serialization/Deserializers/XmlFile.cs @@ -12,20 +12,8 @@ namespace SabreTools.Serialization.Deserializers /// public class XmlFile : BaseBinaryDeserializer, - IFileDeserializer, IStreamDeserializer { - #region IFileDeserializer - - /// - public T? Deserialize(string? path) - { - using var data = PathProcessor.OpenStream(path); - return Deserialize(data); - } - - #endregion - #region IStreamDeserializer /// From bc01ce45527898396c306bfd98f764b68c0a966f Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 4 Apr 2024 01:55:05 -0400 Subject: [PATCH 04/10] Enforce IStreamDeserializer in base class --- SabreTools.Serialization/Deserializers/AACS.cs | 11 ++--------- .../Deserializers/ArchiveDotOrg.cs | 3 +-- SabreTools.Serialization/Deserializers/AttractMode.cs | 7 ++----- SabreTools.Serialization/Deserializers/BDPlus.cs | 11 ++--------- SabreTools.Serialization/Deserializers/BFPK.cs | 11 ++--------- SabreTools.Serialization/Deserializers/BSP.cs | 11 ++--------- .../Deserializers/BaseBinaryDeserializer.cs | 10 +++++++++- SabreTools.Serialization/Deserializers/CFB.cs | 11 ++--------- SabreTools.Serialization/Deserializers/CIA.cs | 11 ++--------- SabreTools.Serialization/Deserializers/Catalog.cs | 3 +-- SabreTools.Serialization/Deserializers/ClrMamePro.cs | 7 ++----- SabreTools.Serialization/Deserializers/CueSheet.cs | 11 ++--------- SabreTools.Serialization/Deserializers/DosCenter.cs | 11 ++--------- .../Deserializers/EverdriveSMDB.cs | 11 ++--------- SabreTools.Serialization/Deserializers/GCF.cs | 11 ++--------- SabreTools.Serialization/Deserializers/Hashfile.cs | 9 +++------ SabreTools.Serialization/Deserializers/IRD.cs | 11 ++--------- .../Deserializers/InstallShieldCabinet.cs | 11 ++--------- SabreTools.Serialization/Deserializers/JsonFile.cs | 7 ++----- .../Deserializers/LinearExecutable.cs | 11 ++--------- SabreTools.Serialization/Deserializers/Listrom.cs | 11 ++--------- SabreTools.Serialization/Deserializers/Listxml.cs | 3 +-- SabreTools.Serialization/Deserializers/Logiqx.cs | 3 +-- SabreTools.Serialization/Deserializers/M1.cs | 3 +-- SabreTools.Serialization/Deserializers/MSDOS.cs | 11 ++--------- .../Deserializers/MicrosoftCabinet.cs | 11 ++--------- SabreTools.Serialization/Deserializers/MoPaQ.cs | 11 ++--------- SabreTools.Serialization/Deserializers/N3DS.cs | 11 ++--------- SabreTools.Serialization/Deserializers/NCF.cs | 11 ++--------- .../Deserializers/NewExecutable.cs | 11 ++--------- SabreTools.Serialization/Deserializers/Nitro.cs | 11 ++--------- SabreTools.Serialization/Deserializers/OfflineList.cs | 3 +-- SabreTools.Serialization/Deserializers/OpenMSX.cs | 3 +-- SabreTools.Serialization/Deserializers/PAK.cs | 11 ++--------- SabreTools.Serialization/Deserializers/PFF.cs | 11 ++--------- SabreTools.Serialization/Deserializers/PIC.cs | 7 ++----- SabreTools.Serialization/Deserializers/PlayJAudio.cs | 11 ++--------- .../Deserializers/PlayJPlaylist.cs | 11 ++--------- .../Deserializers/PortableExecutable.cs | 11 ++--------- SabreTools.Serialization/Deserializers/Quantum.cs | 11 ++--------- SabreTools.Serialization/Deserializers/RomCenter.cs | 11 ++--------- SabreTools.Serialization/Deserializers/SGA.cs | 11 ++--------- .../Deserializers/SeparatedValue.cs | 8 +++----- .../Deserializers/SoftwareList.cs | 3 +-- SabreTools.Serialization/Deserializers/VBSP.cs | 11 ++--------- SabreTools.Serialization/Deserializers/VPK.cs | 11 ++--------- SabreTools.Serialization/Deserializers/WAD.cs | 11 ++--------- SabreTools.Serialization/Deserializers/XZP.cs | 11 ++--------- SabreTools.Serialization/Deserializers/XmlFile.cs | 11 ++--------- Test/Program.cs | 3 --- 50 files changed, 99 insertions(+), 357 deletions(-) diff --git a/SabreTools.Serialization/Deserializers/AACS.cs b/SabreTools.Serialization/Deserializers/AACS.cs index 7173b7e8..06aff2eb 100644 --- a/SabreTools.Serialization/Deserializers/AACS.cs +++ b/SabreTools.Serialization/Deserializers/AACS.cs @@ -4,18 +4,13 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.AACS; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class AACS : - BaseBinaryDeserializer, - IStreamDeserializer + public class AACS : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public MediaKeyBlock? Deserialize(Stream? data) + public override MediaKeyBlock? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -443,7 +438,5 @@ namespace SabreTools.Serialization.Deserializers return record; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/ArchiveDotOrg.cs b/SabreTools.Serialization/Deserializers/ArchiveDotOrg.cs index 8fb3a960..fddb3784 100644 --- a/SabreTools.Serialization/Deserializers/ArchiveDotOrg.cs +++ b/SabreTools.Serialization/Deserializers/ArchiveDotOrg.cs @@ -1,7 +1,6 @@ namespace SabreTools.Serialization.Deserializers { - public class ArchiveDotOrg : - XmlFile + public class ArchiveDotOrg : XmlFile { // All logic taken care of in the base class } diff --git a/SabreTools.Serialization/Deserializers/AttractMode.cs b/SabreTools.Serialization/Deserializers/AttractMode.cs index ccfc54da..dda66bf6 100644 --- a/SabreTools.Serialization/Deserializers/AttractMode.cs +++ b/SabreTools.Serialization/Deserializers/AttractMode.cs @@ -4,13 +4,10 @@ using System.Linq; using System.Text; using SabreTools.IO.Readers; using SabreTools.Models.AttractMode; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class AttractMode : - BaseBinaryDeserializer, - IStreamDeserializer + public class AttractMode : BaseBinaryDeserializer { #region Constants @@ -23,7 +20,7 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer /// - public MetadataFile? Deserialize(Stream? data) + public override MetadataFile? Deserialize(Stream? data) { // If the stream is null if (data == null) diff --git a/SabreTools.Serialization/Deserializers/BDPlus.cs b/SabreTools.Serialization/Deserializers/BDPlus.cs index 22ad3486..1d4f7ce3 100644 --- a/SabreTools.Serialization/Deserializers/BDPlus.cs +++ b/SabreTools.Serialization/Deserializers/BDPlus.cs @@ -2,19 +2,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.BDPlus; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.BDPlus.Constants; namespace SabreTools.Serialization.Deserializers { - public class BDPlus : - BaseBinaryDeserializer, - IStreamDeserializer + public class BDPlus : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public SVM? Deserialize(Stream? data) + public override SVM? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -66,7 +61,5 @@ namespace SabreTools.Serialization.Deserializers return svm; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/BFPK.cs b/SabreTools.Serialization/Deserializers/BFPK.cs index 947b4980..080a48aa 100644 --- a/SabreTools.Serialization/Deserializers/BFPK.cs +++ b/SabreTools.Serialization/Deserializers/BFPK.cs @@ -2,19 +2,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.BFPK; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.BFPK.Constants; namespace SabreTools.Serialization.Deserializers { - public class BFPK : - BaseBinaryDeserializer, - IStreamDeserializer + public class BFPK : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Archive? Deserialize(Stream? data) + public override Archive? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -122,7 +117,5 @@ namespace SabreTools.Serialization.Deserializers return fileEntry; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/BSP.cs b/SabreTools.Serialization/Deserializers/BSP.cs index 7752c023..e69acd66 100644 --- a/SabreTools.Serialization/Deserializers/BSP.cs +++ b/SabreTools.Serialization/Deserializers/BSP.cs @@ -3,19 +3,14 @@ using System.Linq; using System.Text; using SabreTools.IO; using SabreTools.Models.BSP; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.BSP.Constants; namespace SabreTools.Serialization.Deserializers { - public class BSP : - BaseBinaryDeserializer, - IStreamDeserializer + public class BSP : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.BSP.File? Deserialize(Stream? data) + public override Models.BSP.File? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -221,7 +216,5 @@ namespace SabreTools.Serialization.Deserializers return texture; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs b/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs index 2fe8858a..2d658462 100644 --- a/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs +++ b/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs @@ -14,7 +14,8 @@ namespace SabreTools.Serialization.Deserializers /// These methods assume there is a concrete implementation of the deserialzier for the model available public abstract class BaseBinaryDeserializer : IByteDeserializer, - IFileDeserializer + IFileDeserializer, + IStreamDeserializer { #region IByteDeserializer @@ -47,6 +48,13 @@ namespace SabreTools.Serialization.Deserializers #endregion + #region IStreamDeserializer + + /// + public abstract TModel? Deserialize(Stream? data); + + #endregion + #region Static Implementations /// diff --git a/SabreTools.Serialization/Deserializers/CFB.cs b/SabreTools.Serialization/Deserializers/CFB.cs index fd30e34c..9abbff25 100644 --- a/SabreTools.Serialization/Deserializers/CFB.cs +++ b/SabreTools.Serialization/Deserializers/CFB.cs @@ -4,19 +4,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.CFB; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.CFB.Constants; namespace SabreTools.Serialization.Deserializers { - public class CFB : - BaseBinaryDeserializer, - IStreamDeserializer + public class CFB : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Binary? Deserialize(Stream? data) + public override Binary? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -365,7 +360,5 @@ namespace SabreTools.Serialization.Deserializers return directoryEntry; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/CIA.cs b/SabreTools.Serialization/Deserializers/CIA.cs index 9b7b8c52..5d4277da 100644 --- a/SabreTools.Serialization/Deserializers/CIA.cs +++ b/SabreTools.Serialization/Deserializers/CIA.cs @@ -3,18 +3,13 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.N3DS; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class CIA : - BaseBinaryDeserializer, - IStreamDeserializer + public class CIA : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.N3DS.CIA? Deserialize(Stream? data) + public override Models.N3DS.CIA? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -504,7 +499,5 @@ namespace SabreTools.Serialization.Deserializers return metaData; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/Catalog.cs b/SabreTools.Serialization/Deserializers/Catalog.cs index e6e5d028..750f5df9 100644 --- a/SabreTools.Serialization/Deserializers/Catalog.cs +++ b/SabreTools.Serialization/Deserializers/Catalog.cs @@ -3,8 +3,7 @@ using System.Text; namespace SabreTools.Serialization.Deserializers { - public class Catalog : - JsonFile + public class Catalog : JsonFile { #region IByteDeserializer diff --git a/SabreTools.Serialization/Deserializers/ClrMamePro.cs b/SabreTools.Serialization/Deserializers/ClrMamePro.cs index c6f433a4..b5fd1755 100644 --- a/SabreTools.Serialization/Deserializers/ClrMamePro.cs +++ b/SabreTools.Serialization/Deserializers/ClrMamePro.cs @@ -4,13 +4,10 @@ using System.IO; using System.Text; using SabreTools.IO.Readers; using SabreTools.Models.ClrMamePro; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class ClrMamePro : - BaseBinaryDeserializer, - IStreamDeserializer + public class ClrMamePro : BaseBinaryDeserializer { #region IByteDeserializer @@ -75,7 +72,7 @@ namespace SabreTools.Serialization.Deserializers } /// - public MetadataFile? Deserialize(Stream? data) + public override MetadataFile? Deserialize(Stream? data) => Deserialize(data, true); /// diff --git a/SabreTools.Serialization/Deserializers/CueSheet.cs b/SabreTools.Serialization/Deserializers/CueSheet.cs index b887562b..935b9138 100644 --- a/SabreTools.Serialization/Deserializers/CueSheet.cs +++ b/SabreTools.Serialization/Deserializers/CueSheet.cs @@ -5,18 +5,13 @@ using System.Linq; using System.Text.RegularExpressions; using SabreTools.IO; using SabreTools.Models.CueSheets; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class CueSheet : - BaseBinaryDeserializer, - IStreamDeserializer + public class CueSheet : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.CueSheets.CueSheet? Deserialize(Stream? data) + public override Models.CueSheets.CueSheet? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -594,7 +589,5 @@ namespace SabreTools.Serialization.Deserializers } #endregion - - #endregion } } diff --git a/SabreTools.Serialization/Deserializers/DosCenter.cs b/SabreTools.Serialization/Deserializers/DosCenter.cs index 975011ab..25eac1d2 100644 --- a/SabreTools.Serialization/Deserializers/DosCenter.cs +++ b/SabreTools.Serialization/Deserializers/DosCenter.cs @@ -3,18 +3,13 @@ using System.IO; using System.Text; using SabreTools.IO.Readers; using SabreTools.Models.DosCenter; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class DosCenter : - BaseBinaryDeserializer, - IStreamDeserializer + public class DosCenter : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public MetadataFile? Deserialize(Stream? data) + public override MetadataFile? Deserialize(Stream? data) { // If the stream is null if (data == null) @@ -215,7 +210,5 @@ namespace SabreTools.Serialization.Deserializers file.ADDITIONAL_ELEMENTS = itemAdditional.ToArray(); return file; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs b/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs index 2c94b8aa..3e12c8a7 100644 --- a/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs +++ b/SabreTools.Serialization/Deserializers/EverdriveSMDB.cs @@ -4,18 +4,13 @@ using System.Linq; using System.Text; using SabreTools.IO.Readers; using SabreTools.Models.EverdriveSMDB; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class EverdriveSMDB : - BaseBinaryDeserializer, - IStreamDeserializer + public class EverdriveSMDB : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public MetadataFile? Deserialize(Stream? data) + public override MetadataFile? Deserialize(Stream? data) { // If the stream is null if (data == null) @@ -63,7 +58,5 @@ namespace SabreTools.Serialization.Deserializers dat.Row = rows.ToArray(); return dat; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/GCF.cs b/SabreTools.Serialization/Deserializers/GCF.cs index a9b6eac3..1239bd6b 100644 --- a/SabreTools.Serialization/Deserializers/GCF.cs +++ b/SabreTools.Serialization/Deserializers/GCF.cs @@ -3,18 +3,13 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.GCF; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class GCF : - BaseBinaryDeserializer, - IStreamDeserializer + public class GCF : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.GCF.File? Deserialize(Stream? data) + public override Models.GCF.File? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -744,7 +739,5 @@ namespace SabreTools.Serialization.Deserializers return dataBlockHeader; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/Hashfile.cs b/SabreTools.Serialization/Deserializers/Hashfile.cs index 2a70c9cb..8f839c4c 100644 --- a/SabreTools.Serialization/Deserializers/Hashfile.cs +++ b/SabreTools.Serialization/Deserializers/Hashfile.cs @@ -4,14 +4,11 @@ using System.IO; using System.Linq; using SabreTools.Hashing; using SabreTools.Models.Hashfile; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class Hashfile : - BaseBinaryDeserializer, - IFileDeserializer, - IStreamDeserializer + // TODO: Create variants for the implemented types + public class Hashfile : BaseBinaryDeserializer { #region IByteDeserializer @@ -76,7 +73,7 @@ namespace SabreTools.Serialization.Deserializers } /// - public Models.Hashfile.Hashfile? Deserialize(Stream? data) + public override Models.Hashfile.Hashfile? Deserialize(Stream? data) => Deserialize(data, HashType.CRC32); /// diff --git a/SabreTools.Serialization/Deserializers/IRD.cs b/SabreTools.Serialization/Deserializers/IRD.cs index 3b4dbee8..18b225f6 100644 --- a/SabreTools.Serialization/Deserializers/IRD.cs +++ b/SabreTools.Serialization/Deserializers/IRD.cs @@ -1,18 +1,13 @@ using System.IO; using System.Text; using SabreTools.IO; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class IRD : - BaseBinaryDeserializer, - IStreamDeserializer + public class IRD : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.IRD.File? Deserialize(Stream? data) + public override Models.IRD.File? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -114,7 +109,5 @@ namespace SabreTools.Serialization.Deserializers return ird; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs b/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs index 79f9cab9..a0edb333 100644 --- a/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs +++ b/SabreTools.Serialization/Deserializers/InstallShieldCabinet.cs @@ -3,20 +3,15 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.InstallShieldCabinet; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.InstallShieldCabinet.Constants; namespace SabreTools.Serialization.Deserializers { // TODO: Add multi-cabinet reading - public class InstallShieldCabinet : - BaseBinaryDeserializer, - IStreamDeserializer + public class InstallShieldCabinet : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Cabinet? Deserialize(Stream? data) + public override Cabinet? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -780,7 +775,5 @@ namespace SabreTools.Serialization.Deserializers } #endregion - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/JsonFile.cs b/SabreTools.Serialization/Deserializers/JsonFile.cs index 24a04fe7..c88efd96 100644 --- a/SabreTools.Serialization/Deserializers/JsonFile.cs +++ b/SabreTools.Serialization/Deserializers/JsonFile.cs @@ -1,7 +1,6 @@ using System.IO; using System.Text; using Newtonsoft.Json; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { @@ -9,9 +8,7 @@ namespace SabreTools.Serialization.Deserializers /// Base class for other JSON serializers /// /// - public class JsonFile : - BaseBinaryDeserializer, - IStreamDeserializer + public class JsonFile : BaseBinaryDeserializer { #region IByteDeserializer @@ -68,7 +65,7 @@ namespace SabreTools.Serialization.Deserializers #region IStreamDeserializer /// - public virtual T? Deserialize(Stream? data) + public override T? Deserialize(Stream? data) => Deserialize(data, new UTF8Encoding(false)); /// diff --git a/SabreTools.Serialization/Deserializers/LinearExecutable.cs b/SabreTools.Serialization/Deserializers/LinearExecutable.cs index 13945e67..5ebb74a8 100644 --- a/SabreTools.Serialization/Deserializers/LinearExecutable.cs +++ b/SabreTools.Serialization/Deserializers/LinearExecutable.cs @@ -3,19 +3,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.LinearExecutable; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.LinearExecutable.Constants; namespace SabreTools.Serialization.Deserializers { - public class LinearExecutable : - BaseBinaryDeserializer, - IStreamDeserializer + public class LinearExecutable : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Executable? Deserialize(Stream? data) + public override Executable? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -1006,7 +1001,5 @@ namespace SabreTools.Serialization.Deserializers return debugInformation; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/Listrom.cs b/SabreTools.Serialization/Deserializers/Listrom.cs index d5c784cd..52c0b72d 100644 --- a/SabreTools.Serialization/Deserializers/Listrom.cs +++ b/SabreTools.Serialization/Deserializers/Listrom.cs @@ -3,18 +3,13 @@ using System.Collections.Generic; using System.IO; using System.Text; using SabreTools.Models.Listrom; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class Listrom : - BaseBinaryDeserializer, - IStreamDeserializer + public class Listrom : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public MetadataFile? Deserialize(Stream? data) + public override MetadataFile? Deserialize(Stream? data) { // If the stream is null if (data == null) @@ -242,7 +237,5 @@ namespace SabreTools.Serialization.Deserializers dat.ADDITIONAL_ELEMENTS = additional.ToArray(); return dat; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/Listxml.cs b/SabreTools.Serialization/Deserializers/Listxml.cs index 92c4b148..cb984858 100644 --- a/SabreTools.Serialization/Deserializers/Listxml.cs +++ b/SabreTools.Serialization/Deserializers/Listxml.cs @@ -1,7 +1,6 @@ namespace SabreTools.Serialization.Deserializers { - public class Listxml : - XmlFile + public class Listxml : XmlFile { // All logic taken care of in the base class } diff --git a/SabreTools.Serialization/Deserializers/Logiqx.cs b/SabreTools.Serialization/Deserializers/Logiqx.cs index 86844be8..aee13e85 100644 --- a/SabreTools.Serialization/Deserializers/Logiqx.cs +++ b/SabreTools.Serialization/Deserializers/Logiqx.cs @@ -1,7 +1,6 @@ namespace SabreTools.Serialization.Deserializers { - public class Logiqx : - XmlFile + public class Logiqx : XmlFile { // All logic taken care of in the base class } diff --git a/SabreTools.Serialization/Deserializers/M1.cs b/SabreTools.Serialization/Deserializers/M1.cs index 0f033b0e..7cb5440d 100644 --- a/SabreTools.Serialization/Deserializers/M1.cs +++ b/SabreTools.Serialization/Deserializers/M1.cs @@ -1,7 +1,6 @@ namespace SabreTools.Serialization.Deserializers { - public class M1 : - XmlFile + public class M1 : XmlFile { // All logic taken care of in the base class } diff --git a/SabreTools.Serialization/Deserializers/MSDOS.cs b/SabreTools.Serialization/Deserializers/MSDOS.cs index 6a5c13f3..b0f3374e 100644 --- a/SabreTools.Serialization/Deserializers/MSDOS.cs +++ b/SabreTools.Serialization/Deserializers/MSDOS.cs @@ -2,19 +2,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.MSDOS; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.MSDOS.Constants; namespace SabreTools.Serialization.Deserializers { - public class MSDOS : - BaseBinaryDeserializer, - IStreamDeserializer + public class MSDOS : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Executable? Deserialize(Stream? data) + public override Executable? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -146,7 +141,5 @@ namespace SabreTools.Serialization.Deserializers return relocationTable; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs b/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs index e823d564..e35b5647 100644 --- a/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs +++ b/SabreTools.Serialization/Deserializers/MicrosoftCabinet.cs @@ -2,20 +2,15 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.MicrosoftCabinet; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.MicrosoftCabinet.Constants; namespace SabreTools.Serialization.Deserializers { // TODO: Add multi-cabinet reading - public class MicrosoftCabinet : - BaseBinaryDeserializer, - IStreamDeserializer + public class MicrosoftCabinet : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Cabinet? Deserialize(Stream? data) + public override Cabinet? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -245,7 +240,5 @@ namespace SabreTools.Serialization.Deserializers return file; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/MoPaQ.cs b/SabreTools.Serialization/Deserializers/MoPaQ.cs index 103012f6..0d947829 100644 --- a/SabreTools.Serialization/Deserializers/MoPaQ.cs +++ b/SabreTools.Serialization/Deserializers/MoPaQ.cs @@ -4,19 +4,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.MoPaQ; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.MoPaQ.Constants; namespace SabreTools.Serialization.Deserializers { - public class MoPaQ : - BaseBinaryDeserializer, - IStreamDeserializer + public class MoPaQ : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Archive? Deserialize(Stream? data) + public override Archive? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -632,7 +627,5 @@ namespace SabreTools.Serialization.Deserializers } #endregion - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/N3DS.cs b/SabreTools.Serialization/Deserializers/N3DS.cs index ef538882..a64a553d 100644 --- a/SabreTools.Serialization/Deserializers/N3DS.cs +++ b/SabreTools.Serialization/Deserializers/N3DS.cs @@ -3,19 +3,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.N3DS; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.N3DS.Constants; namespace SabreTools.Serialization.Deserializers { - public class N3DS : - BaseBinaryDeserializer, - IStreamDeserializer + public class N3DS : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Cart? Deserialize(Stream? data) + public override Cart? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -712,7 +707,5 @@ namespace SabreTools.Serialization.Deserializers return romFSHeader; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/NCF.cs b/SabreTools.Serialization/Deserializers/NCF.cs index c1362951..e3c7d629 100644 --- a/SabreTools.Serialization/Deserializers/NCF.cs +++ b/SabreTools.Serialization/Deserializers/NCF.cs @@ -3,18 +3,13 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.NCF; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class NCF : - BaseBinaryDeserializer, - IStreamDeserializer + public class NCF : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.NCF.File? Deserialize(Stream? data) + public override Models.NCF.File? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -513,7 +508,5 @@ namespace SabreTools.Serialization.Deserializers return checksumEntry; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/NewExecutable.cs b/SabreTools.Serialization/Deserializers/NewExecutable.cs index fbc9859b..ac8810b4 100644 --- a/SabreTools.Serialization/Deserializers/NewExecutable.cs +++ b/SabreTools.Serialization/Deserializers/NewExecutable.cs @@ -4,19 +4,14 @@ using System.Linq; using System.Text; using SabreTools.IO; using SabreTools.Models.NewExecutable; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.NewExecutable.Constants; namespace SabreTools.Serialization.Deserializers { - public class NewExecutable : - BaseBinaryDeserializer, - IStreamDeserializer + public class NewExecutable : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Executable? Deserialize(Stream? data) + public override Executable? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -481,7 +476,5 @@ namespace SabreTools.Serialization.Deserializers return [.. residentNameTable]; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/Nitro.cs b/SabreTools.Serialization/Deserializers/Nitro.cs index d98e00da..e09ade2c 100644 --- a/SabreTools.Serialization/Deserializers/Nitro.cs +++ b/SabreTools.Serialization/Deserializers/Nitro.cs @@ -3,18 +3,13 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.Nitro; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class Nitro : - BaseBinaryDeserializer, - IStreamDeserializer + public class Nitro : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Cart? Deserialize(Stream? data) + public override Cart? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -364,7 +359,5 @@ namespace SabreTools.Serialization.Deserializers return entry; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/OfflineList.cs b/SabreTools.Serialization/Deserializers/OfflineList.cs index 7d96b2df..bcd208ad 100644 --- a/SabreTools.Serialization/Deserializers/OfflineList.cs +++ b/SabreTools.Serialization/Deserializers/OfflineList.cs @@ -1,7 +1,6 @@ namespace SabreTools.Serialization.Deserializers { - public class OfflineList : - XmlFile + public class OfflineList : XmlFile { // All logic taken care of in the base class } diff --git a/SabreTools.Serialization/Deserializers/OpenMSX.cs b/SabreTools.Serialization/Deserializers/OpenMSX.cs index b95c37f7..2b84c0b7 100644 --- a/SabreTools.Serialization/Deserializers/OpenMSX.cs +++ b/SabreTools.Serialization/Deserializers/OpenMSX.cs @@ -1,7 +1,6 @@ namespace SabreTools.Serialization.Deserializers { - public class OpenMSX : - XmlFile + public class OpenMSX : XmlFile { // All logic taken care of in the base class } diff --git a/SabreTools.Serialization/Deserializers/PAK.cs b/SabreTools.Serialization/Deserializers/PAK.cs index 3248e374..c5ceb2d5 100644 --- a/SabreTools.Serialization/Deserializers/PAK.cs +++ b/SabreTools.Serialization/Deserializers/PAK.cs @@ -2,19 +2,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.PAK; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.PAK.Constants; namespace SabreTools.Serialization.Deserializers { - public class PAK : - BaseBinaryDeserializer, - IStreamDeserializer + public class PAK : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.PAK.File? Deserialize(Stream? data) + public override Models.PAK.File? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -109,7 +104,5 @@ namespace SabreTools.Serialization.Deserializers return directoryItem; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/PFF.cs b/SabreTools.Serialization/Deserializers/PFF.cs index b1718b24..52ca2f3a 100644 --- a/SabreTools.Serialization/Deserializers/PFF.cs +++ b/SabreTools.Serialization/Deserializers/PFF.cs @@ -2,19 +2,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.PFF; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.PFF.Constants; namespace SabreTools.Serialization.Deserializers { - public class PFF : - BaseBinaryDeserializer, - IStreamDeserializer + public class PFF : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Archive? Deserialize(Stream? data) + public override Archive? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -184,7 +179,5 @@ namespace SabreTools.Serialization.Deserializers return segment; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/PIC.cs b/SabreTools.Serialization/Deserializers/PIC.cs index 1cdd562d..2fa5e6ac 100644 --- a/SabreTools.Serialization/Deserializers/PIC.cs +++ b/SabreTools.Serialization/Deserializers/PIC.cs @@ -3,19 +3,16 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.PIC; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.PIC.Constants; namespace SabreTools.Serialization.Deserializers { - public class PIC : - BaseBinaryDeserializer, - IStreamDeserializer + public class PIC : BaseBinaryDeserializer { #region IStreamDeserializer /// - public DiscInformation? Deserialize(Stream? data) + public override DiscInformation? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) diff --git a/SabreTools.Serialization/Deserializers/PlayJAudio.cs b/SabreTools.Serialization/Deserializers/PlayJAudio.cs index dad9dfff..bd08254d 100644 --- a/SabreTools.Serialization/Deserializers/PlayJAudio.cs +++ b/SabreTools.Serialization/Deserializers/PlayJAudio.cs @@ -2,17 +2,12 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.PlayJ; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.PlayJ.Constants; namespace SabreTools.Serialization.Deserializers { - public class PlayJAudio : - BaseBinaryDeserializer, - IStreamDeserializer + public class PlayJAudio : BaseBinaryDeserializer { - #region IStreamDeserializer - /// public static AudioFile? DeserializeStream(Stream? data, long adjust = 0) { @@ -21,7 +16,7 @@ namespace SabreTools.Serialization.Deserializers } /// - public AudioFile? Deserialize(Stream? data) + public override AudioFile? Deserialize(Stream? data) => Deserialize(data, 0); /// @@ -351,7 +346,5 @@ namespace SabreTools.Serialization.Deserializers return dataFile; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs b/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs index 69017fce..c5cbfce0 100644 --- a/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs +++ b/SabreTools.Serialization/Deserializers/PlayJPlaylist.cs @@ -1,18 +1,13 @@ using System.IO; using SabreTools.IO; using SabreTools.Models.PlayJ; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class PlayJPlaylist : - BaseBinaryDeserializer, - IStreamDeserializer + public class PlayJPlaylist : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Playlist? Deserialize(Stream? data) + public override Playlist? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -76,7 +71,5 @@ namespace SabreTools.Serialization.Deserializers return playlistHeader; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/PortableExecutable.cs b/SabreTools.Serialization/Deserializers/PortableExecutable.cs index aa24b10b..c335b3c0 100644 --- a/SabreTools.Serialization/Deserializers/PortableExecutable.cs +++ b/SabreTools.Serialization/Deserializers/PortableExecutable.cs @@ -5,19 +5,14 @@ using System.Linq; using System.Text; using SabreTools.IO; using SabreTools.Models.PortableExecutable; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.PortableExecutable.Constants; namespace SabreTools.Serialization.Deserializers { - public class PortableExecutable : - BaseBinaryDeserializer, - IStreamDeserializer + public class PortableExecutable : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Executable? Deserialize(Stream? data) + public override Executable? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -1334,7 +1329,5 @@ namespace SabreTools.Serialization.Deserializers return resourceDirectoryTable; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/Quantum.cs b/SabreTools.Serialization/Deserializers/Quantum.cs index 56850f7f..01544353 100644 --- a/SabreTools.Serialization/Deserializers/Quantum.cs +++ b/SabreTools.Serialization/Deserializers/Quantum.cs @@ -2,19 +2,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.Quantum; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.Quantum.Constants; namespace SabreTools.Serialization.Deserializers { - public class Quantum : - BaseBinaryDeserializer, - IStreamDeserializer + public class Quantum : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Archive? Deserialize(Stream? data) + public override Archive? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -157,7 +152,5 @@ namespace SabreTools.Serialization.Deserializers byte b1 = data.ReadByteValue(); return (b0 << 8) | b1; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/RomCenter.cs b/SabreTools.Serialization/Deserializers/RomCenter.cs index 78ed674c..af187d37 100644 --- a/SabreTools.Serialization/Deserializers/RomCenter.cs +++ b/SabreTools.Serialization/Deserializers/RomCenter.cs @@ -4,18 +4,13 @@ using System.Linq; using System.Text; using SabreTools.IO.Readers; using SabreTools.Models.RomCenter; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class RomCenter : - BaseBinaryDeserializer, - IStreamDeserializer + public class RomCenter : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public MetadataFile? Deserialize(Stream? data) + public override MetadataFile? Deserialize(Stream? data) { // If the stream is null if (data == null) @@ -214,7 +209,5 @@ namespace SabreTools.Serialization.Deserializers } return dat; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/SGA.cs b/SabreTools.Serialization/Deserializers/SGA.cs index 45965e28..a2ac6abb 100644 --- a/SabreTools.Serialization/Deserializers/SGA.cs +++ b/SabreTools.Serialization/Deserializers/SGA.cs @@ -3,19 +3,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.SGA; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.SGA.Constants; namespace SabreTools.Serialization.Deserializers { - public class SGA : - BaseBinaryDeserializer, - IStreamDeserializer + public class SGA : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.SGA.File? Deserialize(Stream? data) + public override Models.SGA.File? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -729,7 +724,5 @@ namespace SabreTools.Serialization.Deserializers return file7; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/SeparatedValue.cs b/SabreTools.Serialization/Deserializers/SeparatedValue.cs index fc5bd747..af710bc3 100644 --- a/SabreTools.Serialization/Deserializers/SeparatedValue.cs +++ b/SabreTools.Serialization/Deserializers/SeparatedValue.cs @@ -4,13 +4,11 @@ using System.Linq; using System.Text; using SabreTools.IO.Readers; using SabreTools.Models.SeparatedValue; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { - public class SeparatedValue : - BaseBinaryDeserializer, - IStreamDeserializer + // TODO: Create variants for the 3 common types: CSV, SSV, TSV + public class SeparatedValue : BaseBinaryDeserializer { #region Constants @@ -83,7 +81,7 @@ namespace SabreTools.Serialization.Deserializers } /// - public MetadataFile? Deserialize(Stream? data) + public override MetadataFile? Deserialize(Stream? data) => Deserialize(data, ','); /// diff --git a/SabreTools.Serialization/Deserializers/SoftwareList.cs b/SabreTools.Serialization/Deserializers/SoftwareList.cs index ee951734..94589e2b 100644 --- a/SabreTools.Serialization/Deserializers/SoftwareList.cs +++ b/SabreTools.Serialization/Deserializers/SoftwareList.cs @@ -1,7 +1,6 @@ namespace SabreTools.Serialization.Deserializers { - public class SoftwareList : - XmlFile + public class SoftwareList : XmlFile { // All logic taken care of in the base class } diff --git a/SabreTools.Serialization/Deserializers/VBSP.cs b/SabreTools.Serialization/Deserializers/VBSP.cs index e58522e6..951f10f7 100644 --- a/SabreTools.Serialization/Deserializers/VBSP.cs +++ b/SabreTools.Serialization/Deserializers/VBSP.cs @@ -2,19 +2,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.VBSP; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.VBSP.Constants; namespace SabreTools.Serialization.Deserializers { - public class VBSP : - BaseBinaryDeserializer, - IStreamDeserializer + public class VBSP : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.VBSP.File? Deserialize(Stream? data) + public override Models.VBSP.File? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -112,7 +107,5 @@ namespace SabreTools.Serialization.Deserializers return lump; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/VPK.cs b/SabreTools.Serialization/Deserializers/VPK.cs index 762b2efe..f9b2a1d9 100644 --- a/SabreTools.Serialization/Deserializers/VPK.cs +++ b/SabreTools.Serialization/Deserializers/VPK.cs @@ -3,19 +3,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.VPK; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.VPK.Constants; namespace SabreTools.Serialization.Deserializers { - public class VPK : - BaseBinaryDeserializer, - IStreamDeserializer + public class VPK : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.VPK.File? Deserialize(Stream? data) + public override Models.VPK.File? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -286,7 +281,5 @@ namespace SabreTools.Serialization.Deserializers return directoryEntry; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/WAD.cs b/SabreTools.Serialization/Deserializers/WAD.cs index 4d9b2d20..67110852 100644 --- a/SabreTools.Serialization/Deserializers/WAD.cs +++ b/SabreTools.Serialization/Deserializers/WAD.cs @@ -2,19 +2,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.WAD; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.WAD.Constants; namespace SabreTools.Serialization.Deserializers { - public class WAD : - BaseBinaryDeserializer, - IStreamDeserializer + public class WAD : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.WAD.File? Deserialize(Stream? data) + public override Models.WAD.File? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -245,7 +240,5 @@ namespace SabreTools.Serialization.Deserializers return lumpInfo; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/XZP.cs b/SabreTools.Serialization/Deserializers/XZP.cs index eb9028ff..668d7f0b 100644 --- a/SabreTools.Serialization/Deserializers/XZP.cs +++ b/SabreTools.Serialization/Deserializers/XZP.cs @@ -2,19 +2,14 @@ using System.IO; using System.Text; using SabreTools.IO; using SabreTools.Models.XZP; -using SabreTools.Serialization.Interfaces; using static SabreTools.Models.XZP.Constants; namespace SabreTools.Serialization.Deserializers { - public class XZP : - BaseBinaryDeserializer, - IStreamDeserializer + public class XZP : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public Models.XZP.File? Deserialize(Stream? data) + public override Models.XZP.File? Deserialize(Stream? data) { // If the data is invalid if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) @@ -248,7 +243,5 @@ namespace SabreTools.Serialization.Deserializers return footer; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Deserializers/XmlFile.cs b/SabreTools.Serialization/Deserializers/XmlFile.cs index 6344664a..26aa56e3 100644 --- a/SabreTools.Serialization/Deserializers/XmlFile.cs +++ b/SabreTools.Serialization/Deserializers/XmlFile.cs @@ -2,7 +2,6 @@ using System.IO; using System.Xml; using System.Xml.Schema; using System.Xml.Serialization; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Deserializers { @@ -10,14 +9,10 @@ namespace SabreTools.Serialization.Deserializers /// Base class for other XML deserializers /// /// - public class XmlFile : - BaseBinaryDeserializer, - IStreamDeserializer + public class XmlFile : BaseBinaryDeserializer { - #region IStreamDeserializer - /// - public T? Deserialize(Stream? data) + public override T? Deserialize(Stream? data) { // If the stream is null if (data == null) @@ -40,7 +35,5 @@ namespace SabreTools.Serialization.Deserializers // Perform the deserialization and return return (T?)serializer.Deserialize(xmlReader); } - - #endregion } } \ No newline at end of file diff --git a/Test/Program.cs b/Test/Program.cs index 1adf58d9..5fc79b2c 100644 --- a/Test/Program.cs +++ b/Test/Program.cs @@ -1,5 +1,4 @@ using SabreTools.Serialization; -using SabreTools.Serialization.Deserializers; namespace Test { @@ -7,8 +6,6 @@ namespace Test { public static void Main(string[] args) { - string path = "R:\\BurnOutSharp Testing Files\\FileType\\AACS Media Key Block\\1 (HD-DVD)\\MKBROM.AACS"; - var obj = AACS.DeserializeFile(path); // DO NOTHING FOR NOW } } From 2a4d24309d7f17f27101cfa0ae943cd0c203c06c Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 4 Apr 2024 02:42:25 -0400 Subject: [PATCH 05/10] Create base class for serializers --- .../Deserializers/BaseBinaryDeserializer.cs | 3 +- .../Interfaces/IByteSerializer.cs | 16 ++ .../Serializers/ArchiveDotOrg.cs | 22 +-- .../Serializers/AttractMode.cs | 46 ++++-- .../Serializers/BaseBinarySerializer.cs | 138 ++++++++++++++++++ .../Serializers/Catalog.cs | 29 +--- .../Serializers/ClrMamePro.cs | 36 ++++- .../Serializers/CueSheet.cs | 44 +----- .../Serializers/DosCenter.cs | 44 +----- .../Serializers/EverdriveSMDB.cs | 44 +----- .../Serializers/Hashfile.cs | 37 ++++- SabreTools.Serialization/Serializers/IRD.cs | 44 +----- .../Serializers/JsonFile.cs | 35 ++++- .../Serializers/Listrom.cs | 44 +----- .../Serializers/Listxml.cs | 25 +--- .../Serializers/Logiqx.cs | 25 ++-- SabreTools.Serialization/Serializers/M1.cs | 25 +--- .../Serializers/OfflineList.cs | 25 +--- .../Serializers/OpenMSX.cs | 25 ++-- .../Serializers/RomCenter.cs | 44 +----- .../Serializers/SeparatedValue.cs | 37 ++++- .../Serializers/SoftwareList.cs | 17 +-- SabreTools.Serialization/Serializers/XMID.cs | 3 +- SabreTools.Serialization/Serializers/XeMID.cs | 3 +- .../Serializers/XmlFile.cs | 43 ++++-- 25 files changed, 385 insertions(+), 469 deletions(-) create mode 100644 SabreTools.Serialization/Interfaces/IByteSerializer.cs create mode 100644 SabreTools.Serialization/Serializers/BaseBinarySerializer.cs diff --git a/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs b/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs index 2d658462..610040a5 100644 --- a/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs +++ b/SabreTools.Serialization/Deserializers/BaseBinaryDeserializer.cs @@ -73,6 +73,7 @@ namespace SabreTools.Serialization.Deserializers var deserializer = GetType>(); if (deserializer == null) return default; + return deserializer.Deserialize(path); } @@ -127,7 +128,7 @@ namespace SabreTools.Serialization.Deserializers return default; } - + #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Interfaces/IByteSerializer.cs b/SabreTools.Serialization/Interfaces/IByteSerializer.cs new file mode 100644 index 00000000..7a2c0edd --- /dev/null +++ b/SabreTools.Serialization/Interfaces/IByteSerializer.cs @@ -0,0 +1,16 @@ +namespace SabreTools.Serialization.Interfaces +{ + /// + /// Defines how to serialize to byte arrays + /// + public interface IByteSerializer + { + /// + /// Serialize a into a byte array + /// + /// Type of object to serialize from + /// Data to serialize + /// Filled object on success, null on error + byte[]? SerializeArray(T? obj); + } +} \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/ArchiveDotOrg.cs b/SabreTools.Serialization/Serializers/ArchiveDotOrg.cs index 1bb696a7..b18888b1 100644 --- a/SabreTools.Serialization/Serializers/ArchiveDotOrg.cs +++ b/SabreTools.Serialization/Serializers/ArchiveDotOrg.cs @@ -2,26 +2,6 @@ namespace SabreTools.Serialization.Serializers { public class ArchiveDotOrg : XmlFile { - #region IFileSerializer - - /// - public static bool SerializeFile(Models.ArchiveDotOrg.Files? obj, string? path) - { - var serializer = new ArchiveDotOrg(); - return serializer.Serialize(obj, path); - } - - #endregion - - #region IStreamSerializer - - /// - public static System.IO.Stream? SerializeStream(Models.ArchiveDotOrg.Files? obj) - { - var serializer = new ArchiveDotOrg(); - return serializer.Serialize(obj); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/AttractMode.cs b/SabreTools.Serialization/Serializers/AttractMode.cs index da6d237e..378d013c 100644 --- a/SabreTools.Serialization/Serializers/AttractMode.cs +++ b/SabreTools.Serialization/Serializers/AttractMode.cs @@ -3,13 +3,10 @@ using System.Linq; using System.Text; using SabreTools.IO.Writers; using SabreTools.Models.AttractMode; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public class AttractMode : - IFileSerializer, - IStreamSerializer + public class AttractMode : BaseBinarySerializer { #region Constants @@ -66,17 +63,44 @@ namespace SabreTools.Serialization.Serializers #endregion - #region IFileSerializer + #region IByteSerializer - /// - public static bool SerializeFile(MetadataFile? obj, string? path, bool longHeader = false) + /// + public static byte[]? SerializeBytes(MetadataFile? obj, bool longHeader = false) { var serializer = new AttractMode(); - return serializer.Serialize(obj, path); + return serializer.SerializeArray(obj, longHeader); } /// - public bool Serialize(MetadataFile? obj, string? path) + public override byte[]? SerializeArray(MetadataFile? obj) + => SerializeArray(obj, false); + + /// + public byte[]? SerializeArray(MetadataFile? obj, bool longHeader) + { + using var stream = SerializeStream(obj, longHeader); + if (stream == null) + return null; + + byte[] bytes = new byte[stream.Length]; + stream.Read(bytes, 0, bytes.Length); + return bytes; + } + + #endregion + + #region IFileSerializer + + /// + public static bool SerializeFile(MetadataFile? obj, string? path, bool longHeader = false) + { + var serializer = new AttractMode(); + return serializer.Serialize(obj, path, longHeader); + } + + /// + public override bool Serialize(MetadataFile? obj, string? path) => Serialize(obj, path, false); /// @@ -98,7 +122,7 @@ namespace SabreTools.Serialization.Serializers #region IStreamSerializer - /// + /// public static Stream? SerializeStream(MetadataFile? obj, bool longHeader = false) { var serializer = new AttractMode(); @@ -106,7 +130,7 @@ namespace SabreTools.Serialization.Serializers } /// - public Stream? Serialize(MetadataFile? obj) + public override Stream? Serialize(MetadataFile? obj) => Serialize(obj, false); /// diff --git a/SabreTools.Serialization/Serializers/BaseBinarySerializer.cs b/SabreTools.Serialization/Serializers/BaseBinarySerializer.cs new file mode 100644 index 00000000..2042c5fc --- /dev/null +++ b/SabreTools.Serialization/Serializers/BaseBinarySerializer.cs @@ -0,0 +1,138 @@ +using System; +using System.Collections.Generic; +using System.IO; +using System.Linq; +using System.Reflection; +using SabreTools.Serialization.Interfaces; + +namespace SabreTools.Serialization.Serializers +{ + /// + /// Base class for all binary serializers + /// + /// Type of the model to serialize + /// These methods assume there is a concrete implementation of the serializer for the model available + public abstract class BaseBinarySerializer : + IByteSerializer, + IFileSerializer, + IStreamSerializer + { + #region IByteSerializer + + /// + public virtual byte[]? SerializeArray(TModel? obj) + { + using var stream = SerializeStream(obj); + if (stream == null) + return null; + + byte[] bytes = new byte[stream.Length]; + stream.Read(bytes, 0, bytes.Length); + return bytes; + } + + #endregion + + #region IFileSerializer + + /// + public virtual bool Serialize(TModel? obj, string? path) + { + if (string.IsNullOrEmpty(path)) + return false; + + using var stream = SerializeStream(obj); + if (stream == null) + return false; + + using var fs = File.OpenWrite(path); + stream.CopyTo(fs); + return true; + } + + #endregion + + #region IStreamSerializer + + /// + public abstract Stream? Serialize(TModel? obj); + + #endregion + + #region Static Implementations + + /// + public static byte[]? SerializeBytes(TModel? obj) + { + var serializer = GetType>(); + if (serializer == null) + return default; + + return serializer.SerializeArray(obj); + } + + /// + public static bool SerializeFile(TModel? obj, string? path) + { + var serializer = GetType>(); + if (serializer == null) + return default; + + return serializer.Serialize(obj, path); + } + + /// + public static Stream? SerializeStream(TModel? obj) + { + var serializer = GetType>(); + if (serializer == null) + return default; + + return serializer.Serialize(obj); + } + + #endregion + + #region Helpers + + /// + /// Get a constructed instance of a type, if possible + /// + /// Serializer type to construct + /// Serializer of the requested type, null on error + private static TSerializer? GetType() + { + var assembly = Assembly.GetExecutingAssembly(); + if (assembly == null) + return default; + + // If not all types can be loaded, use the ones that could be + List assemblyTypes = []; + try + { + assemblyTypes = assembly.GetTypes().ToList(); + } + catch (ReflectionTypeLoadException rtle) + { + assemblyTypes = rtle.Types.Where(t => t != null)!.ToList(); + } + + // Loop through all types + foreach (Type type in assemblyTypes) + { + // If the type isn't a class or doesn't implement the interface + if (!type.IsClass || type.GetInterface(typeof(TSerializer).Name) == null) + continue; + + // Try to create a concrete instance of the type + var instance = (TSerializer?)Activator.CreateInstance(type); + if (instance != null) + return instance; + } + + return default; + } + + #endregion + } +} \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/Catalog.cs b/SabreTools.Serialization/Serializers/Catalog.cs index e91051ed..48274755 100644 --- a/SabreTools.Serialization/Serializers/Catalog.cs +++ b/SabreTools.Serialization/Serializers/Catalog.cs @@ -3,37 +3,10 @@ using System.Text; namespace SabreTools.Serialization.Serializers { - public class Catalog : - JsonFile + public class Catalog : JsonFile { - #region IFileSerializer - - /// - public static bool SerializeFile(Models.Xbox.Catalog? obj, string? path) - { - var serializer = new Catalog(); - return serializer.Serialize(obj, path); - } - - /// Catalog.js file is encoded as UTF-16 LE - public override bool Serialize(Models.Xbox.Catalog? obj, string? path) - => Serialize(obj, path, new UnicodeEncoding()); - - #endregion - - #region IStreamSerializer - - /// - public static Stream? SerializeStream(Models.Xbox.Catalog? obj) - { - var serializer = new Catalog(); - return serializer.Serialize(obj); - } - /// Catalog.js file is encoded as UTF-16 LE public override Stream? Serialize(Models.Xbox.Catalog? obj) => Serialize(obj, new UnicodeEncoding()); - - #endregion } } diff --git a/SabreTools.Serialization/Serializers/ClrMamePro.cs b/SabreTools.Serialization/Serializers/ClrMamePro.cs index dfcf09e9..da21e1eb 100644 --- a/SabreTools.Serialization/Serializers/ClrMamePro.cs +++ b/SabreTools.Serialization/Serializers/ClrMamePro.cs @@ -3,14 +3,38 @@ using System.Linq; using System.Text; using SabreTools.IO.Writers; using SabreTools.Models.ClrMamePro; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public class ClrMamePro : - IFileSerializer, - IStreamSerializer + public class ClrMamePro : BaseBinarySerializer { + #region IByteSerializer + + /// + public static byte[]? SerializeBytes(MetadataFile? obj, bool quotes = false) + { + var serializer = new ClrMamePro(); + return serializer.SerializeArray(obj, quotes); + } + + /// + public override byte[]? SerializeArray(MetadataFile? obj) + => SerializeArray(obj, false); + + /// + public byte[]? SerializeArray(MetadataFile? obj, bool quotes) + { + using var stream = SerializeStream(obj, quotes); + if (stream == null) + return null; + + byte[] bytes = new byte[stream.Length]; + stream.Read(bytes, 0, bytes.Length); + return bytes; + } + + #endregion + #region IFileSerializer /// @@ -21,7 +45,7 @@ namespace SabreTools.Serialization.Serializers } /// - public bool Serialize(MetadataFile? obj, string? path) + public override bool Serialize(MetadataFile? obj, string? path) => Serialize(obj, path, true); /// @@ -51,7 +75,7 @@ namespace SabreTools.Serialization.Serializers } /// - public Stream? Serialize(MetadataFile? obj) + public override Stream? Serialize(MetadataFile? obj) => Serialize(obj, true); /// diff --git a/SabreTools.Serialization/Serializers/CueSheet.cs b/SabreTools.Serialization/Serializers/CueSheet.cs index 15a63c33..428bd7a1 100644 --- a/SabreTools.Serialization/Serializers/CueSheet.cs +++ b/SabreTools.Serialization/Serializers/CueSheet.cs @@ -2,51 +2,13 @@ using System; using System.IO; using System.Text; using SabreTools.Models.CueSheets; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public class CueSheet : - IFileSerializer, - IStreamSerializer + public class CueSheet : BaseBinarySerializer { - #region IFileSerializer - - /// - public static bool SerializeFile(Models.CueSheets.CueSheet? obj, string? path) - { - var serializer = new CueSheet(); - return serializer.Serialize(obj, path); - } - /// - public bool Serialize(Models.CueSheets.CueSheet? obj, string? path) - { - if (string.IsNullOrEmpty(path)) - return false; - - using var stream = SerializeStream(obj); - if (stream == null) - return false; - - using var fs = File.OpenWrite(path); - stream.CopyTo(fs); - return true; - } - - #endregion - - #region IStreamSerializer - - /// - public static Stream? SerializeStream(Models.CueSheets.CueSheet? obj) - { - var serializer = new CueSheet(); - return serializer.Serialize(obj); - } - - /// - public Stream? Serialize(Models.CueSheets.CueSheet? obj) + public override Stream? Serialize(Models.CueSheets.CueSheet? obj) { // If the cuesheet is null if (obj == null) @@ -293,7 +255,5 @@ namespace SabreTools.Serialization.Serializers } #endregion - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/DosCenter.cs b/SabreTools.Serialization/Serializers/DosCenter.cs index 63ceb043..45241d5c 100644 --- a/SabreTools.Serialization/Serializers/DosCenter.cs +++ b/SabreTools.Serialization/Serializers/DosCenter.cs @@ -3,51 +3,13 @@ using System.Linq; using System.Text; using SabreTools.IO.Writers; using SabreTools.Models.DosCenter; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public class DosCenter : - IFileSerializer, - IStreamSerializer + public class DosCenter : BaseBinarySerializer { - #region IFileSerializer - - /// - public static bool SerializeFile(MetadataFile? obj, string? path) - { - var serializer = new DosCenter(); - return serializer.Serialize(obj, path); - } - /// - public bool Serialize(MetadataFile? obj, string? path) - { - if (string.IsNullOrEmpty(path)) - return false; - - using var stream = SerializeStream(obj); - if (stream == null) - return false; - - using var fs = System.IO.File.OpenWrite(path); - stream.CopyTo(fs); - return true; - } - - #endregion - - #region IStreamSerializer - - /// - public static Stream? SerializeStream(MetadataFile? obj) - { - var serializer = new DosCenter(); - return serializer.Serialize(obj); - } - - /// - public Stream? Serialize(MetadataFile? obj) + public override Stream? Serialize(MetadataFile? obj) { // If the metadata file is null if (obj == null) @@ -160,7 +122,5 @@ namespace SabreTools.Serialization.Serializers writer.WriteEndElement(); // file } } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/EverdriveSMDB.cs b/SabreTools.Serialization/Serializers/EverdriveSMDB.cs index 6ec346fb..2684fdaf 100644 --- a/SabreTools.Serialization/Serializers/EverdriveSMDB.cs +++ b/SabreTools.Serialization/Serializers/EverdriveSMDB.cs @@ -4,51 +4,13 @@ using System.Linq; using System.Text; using SabreTools.IO.Writers; using SabreTools.Models.EverdriveSMDB; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public class EverdriveSMDB : - IFileSerializer, - IStreamSerializer + public class EverdriveSMDB : BaseBinarySerializer { - #region IFileSerializer - - /// - public static bool SerializeFile(MetadataFile? obj, string? path) - { - var serializer = new EverdriveSMDB(); - return serializer.Serialize(obj, path); - } - /// - public bool Serialize(MetadataFile? obj, string? path) - { - if (string.IsNullOrEmpty(path)) - return false; - - using var stream = SerializeStream(obj); - if (stream == null) - return false; - - using var fs = System.IO.File.OpenWrite(path); - stream.CopyTo(fs); - return true; - } - - #endregion - - #region IStreamSerializer - - /// - public static Stream? SerializeStream(MetadataFile? obj) - { - var serializer = new EverdriveSMDB(); - return serializer.Serialize(obj); - } - - /// - public Stream? Serialize(MetadataFile? obj) + public override Stream? Serialize(MetadataFile? obj) { // If the metadata file is null if (obj == null) @@ -99,7 +61,5 @@ namespace SabreTools.Serialization.Serializers writer.Flush(); } } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/Hashfile.cs b/SabreTools.Serialization/Serializers/Hashfile.cs index c4439629..f28068e8 100644 --- a/SabreTools.Serialization/Serializers/Hashfile.cs +++ b/SabreTools.Serialization/Serializers/Hashfile.cs @@ -5,14 +5,39 @@ using System.Text; using SabreTools.Hashing; using SabreTools.IO.Writers; using SabreTools.Models.Hashfile; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public class Hashfile : - IFileSerializer, - IStreamSerializer + // TODO: Create variants for the implemented types + public class Hashfile : BaseBinarySerializer { + #region IByteSerializer + + /// + public static byte[]? SerializeBytes(Models.Hashfile.Hashfile? obj, HashType hash = HashType.CRC32) + { + var serializer = new Hashfile(); + return serializer.SerializeArray(obj, hash); + } + + /// + public override byte[]? SerializeArray(Models.Hashfile.Hashfile? obj) + => SerializeArray(obj, HashType.CRC32); + + /// + public byte[]? SerializeArray(Models.Hashfile.Hashfile? obj, HashType hash) + { + using var stream = SerializeStream(obj, hash); + if (stream == null) + return null; + + byte[] bytes = new byte[stream.Length]; + stream.Read(bytes, 0, bytes.Length); + return bytes; + } + + #endregion + #region IFileSerializer /// @@ -23,7 +48,7 @@ namespace SabreTools.Serialization.Serializers } /// - public bool Serialize(Models.Hashfile.Hashfile? obj, string? path) + public override bool Serialize(Models.Hashfile.Hashfile? obj, string? path) => Serialize(obj, path, HashType.CRC32); /// @@ -53,7 +78,7 @@ namespace SabreTools.Serialization.Serializers } /// - public Stream? Serialize(Models.Hashfile.Hashfile? obj) + public override Stream? Serialize(Models.Hashfile.Hashfile? obj) => Serialize(obj, HashType.CRC32); /// diff --git a/SabreTools.Serialization/Serializers/IRD.cs b/SabreTools.Serialization/Serializers/IRD.cs index 573b988e..5e64df16 100644 --- a/SabreTools.Serialization/Serializers/IRD.cs +++ b/SabreTools.Serialization/Serializers/IRD.cs @@ -2,51 +2,13 @@ using System; using System.IO; using System.Linq; using System.Text; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public class IRD : - IFileSerializer, - IStreamSerializer + public class IRD : BaseBinarySerializer { - #region IFileSerializer - - /// - public static bool SerializeFile(Models.IRD.File? obj, string? path) - { - var serializer = new IRD(); - return serializer.Serialize(obj, path); - } - /// - public bool Serialize(Models.IRD.File? obj, string? path) - { - if (string.IsNullOrEmpty(path)) - return false; - - using var stream = SerializeStream(obj); - if (stream == null) - return false; - - using var fs = System.IO.File.OpenWrite(path); - stream.CopyTo(fs); - return true; - } - - #endregion - - #region IStreamSerializer - - /// - public static Stream? SerializeStream(Models.IRD.File? obj) - { - var serializer = new IRD(); - return serializer.Serialize(obj); - } - - /// - public Stream? Serialize(Models.IRD.File? obj) + public override Stream? Serialize(Models.IRD.File? obj) { // If the data is invalid if (obj?.Magic == null) @@ -165,7 +127,5 @@ namespace SabreTools.Serialization.Serializers return stream; } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/JsonFile.cs b/SabreTools.Serialization/Serializers/JsonFile.cs index 66291a28..8b41f716 100644 --- a/SabreTools.Serialization/Serializers/JsonFile.cs +++ b/SabreTools.Serialization/Serializers/JsonFile.cs @@ -1,7 +1,6 @@ using System.IO; using System.Text; using Newtonsoft.Json; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { @@ -9,14 +8,38 @@ namespace SabreTools.Serialization.Serializers /// Base class for other JSON serializers /// /// - public class JsonFile : - IFileSerializer, - IStreamSerializer + public class JsonFile : BaseBinarySerializer { + #region IByteSerializer + + /// + public override byte[]? SerializeArray(T? obj) + => SerializeArray(obj, new UTF8Encoding(false)); + + /// + /// Serialize a into a byte array + /// + /// Type of object to serialize from + /// Data to serialize + /// Encoding to parse text as + /// Filled object on success, null on error + public byte[]? SerializeArray(T? obj, Encoding encoding) + { + using var stream = Serialize(obj, encoding); + if (stream == null) + return null; + + byte[] bytes = new byte[stream.Length]; + stream.Read(bytes, 0, bytes.Length); + return bytes; + } + + #endregion + #region IFileSerializer /// - public virtual bool Serialize(T? obj, string? path) + public override bool Serialize(T? obj, string? path) => Serialize(obj, path, new UTF8Encoding(false)); /// @@ -47,7 +70,7 @@ namespace SabreTools.Serialization.Serializers #region IStreamSerializer /// - public virtual Stream? Serialize(T? obj) + public override Stream? Serialize(T? obj) => Serialize(obj, new UTF8Encoding(false)); /// diff --git a/SabreTools.Serialization/Serializers/Listrom.cs b/SabreTools.Serialization/Serializers/Listrom.cs index 12818c95..8c52473f 100644 --- a/SabreTools.Serialization/Serializers/Listrom.cs +++ b/SabreTools.Serialization/Serializers/Listrom.cs @@ -2,51 +2,13 @@ using System.IO; using System.Linq; using System.Text; using SabreTools.Models.Listrom; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public class Listrom : - IFileSerializer, - IStreamSerializer + public class Listrom : BaseBinarySerializer { - #region IFileSerializer - - /// - public static bool SerializeFile(MetadataFile? obj, string? path) - { - var serializer = new Listrom(); - return serializer.Serialize(obj, path); - } - /// - public bool Serialize(MetadataFile? obj, string? path) - { - if (string.IsNullOrEmpty(path)) - return false; - - using var stream = SerializeStream(obj); - if (stream == null) - return false; - - using var fs = File.OpenWrite(path); - stream.CopyTo(fs); - return true; - } - - #endregion - - #region IStreamSerializer - - /// - public static Stream? SerializeStream(MetadataFile? obj) - { - var serializer = new Listrom(); - return serializer.Serialize(obj); - } - - /// - public Stream? Serialize(MetadataFile? obj) + public override Stream? Serialize(MetadataFile? obj) { // If the metadata file is null if (obj == null) @@ -192,7 +154,5 @@ namespace SabreTools.Serialization.Serializers writer.Flush(); } } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/Listxml.cs b/SabreTools.Serialization/Serializers/Listxml.cs index 964ffac5..5127ea1d 100644 --- a/SabreTools.Serialization/Serializers/Listxml.cs +++ b/SabreTools.Serialization/Serializers/Listxml.cs @@ -1,28 +1,7 @@ namespace SabreTools.Serialization.Serializers { - public class Listxml : - XmlFile + public class Listxml : XmlFile { - #region IFileSerializer - - /// - public static bool SerializeFile(Models.Listxml.Mame? obj, string? path) - { - var serializer = new Listxml(); - return serializer.Serialize(obj, path); - } - - #endregion - - #region IStreamSerializer - - /// - public static System.IO.Stream? SerializeStream(Models.Listxml.Mame? obj) - { - var serializer = new Listxml(); - return serializer.Serialize(obj); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/Logiqx.cs b/SabreTools.Serialization/Serializers/Logiqx.cs index 3a2c4e8a..5ecfce2d 100644 --- a/SabreTools.Serialization/Serializers/Logiqx.cs +++ b/SabreTools.Serialization/Serializers/Logiqx.cs @@ -3,8 +3,7 @@ using SabreTools.Models.Logiqx; namespace SabreTools.Serialization.Serializers { - public class Logiqx : - XmlFile + public class Logiqx : XmlFile { #region Constants @@ -30,15 +29,16 @@ namespace SabreTools.Serialization.Serializers #endregion + #region IByteSerializer + + /// + public override byte[]? SerializeArray(Datafile? obj) + => SerializeArray(obj, DocTypeName, DocTypePubId, DocTypeSysId, DocTypeSysId); + + #endregion + #region IFileSerializer - /// - public static bool SerializeFile(Datafile? obj, string? path) - { - var serializer = new Logiqx(); - return serializer.Serialize(obj, path); - } - /// public override bool Serialize(Datafile? obj, string? path) => Serialize(obj, path, DocTypeName, DocTypePubId, DocTypeSysId, DocTypeSysId); @@ -47,13 +47,6 @@ namespace SabreTools.Serialization.Serializers #region IStreamSerializer - /// - public static Stream? SerializeStream(Datafile? obj) - { - var serializer = new Logiqx(); - return serializer.Serialize(obj); - } - /// public override Stream? Serialize(Datafile? obj) => Serialize(obj, DocTypeName, DocTypePubId, DocTypeSysId, DocTypeSysId); diff --git a/SabreTools.Serialization/Serializers/M1.cs b/SabreTools.Serialization/Serializers/M1.cs index 78541224..25fa12c6 100644 --- a/SabreTools.Serialization/Serializers/M1.cs +++ b/SabreTools.Serialization/Serializers/M1.cs @@ -1,28 +1,7 @@ namespace SabreTools.Serialization.Serializers { - public class M1 : - XmlFile + public class M1 : XmlFile { - #region IFileSerializer - - /// - public static bool SerializeFile(Models.Listxml.M1? obj, string? path) - { - var serializer = new M1(); - return serializer.Serialize(obj, path); - } - - #endregion - - #region IStreamSerializer - - /// - public static System.IO.Stream? SerializeStream(Models.Listxml.M1? obj) - { - var serializer = new M1(); - return serializer.Serialize(obj); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/OfflineList.cs b/SabreTools.Serialization/Serializers/OfflineList.cs index 49342ba8..007acfcc 100644 --- a/SabreTools.Serialization/Serializers/OfflineList.cs +++ b/SabreTools.Serialization/Serializers/OfflineList.cs @@ -1,28 +1,7 @@ namespace SabreTools.Serialization.Serializers { - public class OfflineList : - XmlFile + public class OfflineList : XmlFile { - #region IFileSerializer - - /// - public static bool SerializeFile(Models.OfflineList.Dat? obj, string? path) - { - var serializer = new OfflineList(); - return serializer.Serialize(obj, path); - } - - #endregion - - #region IStreamSerializer - - /// - public static System.IO.Stream? SerializeStream(Models.OfflineList.Dat? obj) - { - var serializer = new OfflineList(); - return serializer.Serialize(obj); - } - - #endregion + // All logic taken care of in the base class } } \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/OpenMSX.cs b/SabreTools.Serialization/Serializers/OpenMSX.cs index 56ab36ce..a6364f0d 100644 --- a/SabreTools.Serialization/Serializers/OpenMSX.cs +++ b/SabreTools.Serialization/Serializers/OpenMSX.cs @@ -3,8 +3,7 @@ using SabreTools.Models.OpenMSX; namespace SabreTools.Serialization.Serializers { - public class OpenMSX : - XmlFile + public class OpenMSX : XmlFile { #region Constants @@ -30,15 +29,16 @@ namespace SabreTools.Serialization.Serializers #endregion + #region IByteSerializer + + /// + public override byte[]? SerializeArray(SoftwareDb? obj) + => SerializeArray(obj, DocTypeName, DocTypePubId, DocTypeSysId, DocTypeSysId); + + #endregion + #region IFileSerializer - /// - public static bool SerializeFile(SoftwareDb? obj, string? path) - { - var serializer = new OpenMSX(); - return serializer.Serialize(obj, path); - } - /// public override bool Serialize(SoftwareDb? obj, string? path) => Serialize(obj, path, DocTypeName, DocTypePubId, DocTypeSysId, DocTypeSysId); @@ -47,13 +47,6 @@ namespace SabreTools.Serialization.Serializers #region IStreamSerializer - /// - public static Stream? SerializeStream(SoftwareDb? obj) - { - var serializer = new OpenMSX(); - return serializer.Serialize(obj); - } - /// public override Stream? Serialize(SoftwareDb? obj) => Serialize(obj, DocTypeName, DocTypePubId, DocTypeSysId, DocTypeSysId); diff --git a/SabreTools.Serialization/Serializers/RomCenter.cs b/SabreTools.Serialization/Serializers/RomCenter.cs index 51f89641..54f38b8d 100644 --- a/SabreTools.Serialization/Serializers/RomCenter.cs +++ b/SabreTools.Serialization/Serializers/RomCenter.cs @@ -3,51 +3,13 @@ using System.Linq; using System.Text; using SabreTools.IO.Writers; using SabreTools.Models.RomCenter; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public class RomCenter : - IFileSerializer, - IStreamSerializer + public class RomCenter : BaseBinarySerializer { - #region IFileSerializer - - /// - public static bool SerializeFile(MetadataFile? obj, string? path) - { - var serializer = new RomCenter(); - return serializer.Serialize(obj, path); - } - /// - public bool Serialize(MetadataFile? obj, string? path) - { - if (string.IsNullOrEmpty(path)) - return false; - - using var stream = SerializeStream(obj); - if (stream == null) - return false; - - using var fs = File.OpenWrite(path); - stream.CopyTo(fs); - return true; - } - - #endregion - - #region IStreamSerializer - - /// - public static Stream? SerializeStream(MetadataFile? obj) - { - var serializer = new RomCenter(); - return serializer.Serialize(obj); - } - - /// - public Stream? Serialize(MetadataFile? obj) + public override Stream? Serialize(MetadataFile? obj) { // If the metadata file is null if (obj == null) @@ -199,7 +161,5 @@ namespace SabreTools.Serialization.Serializers writer.WriteLine(); writer.Flush(); } - - #endregion } } \ No newline at end of file diff --git a/SabreTools.Serialization/Serializers/SeparatedValue.cs b/SabreTools.Serialization/Serializers/SeparatedValue.cs index d83317d6..6e09613e 100644 --- a/SabreTools.Serialization/Serializers/SeparatedValue.cs +++ b/SabreTools.Serialization/Serializers/SeparatedValue.cs @@ -3,14 +3,39 @@ using System.Linq; using System.Text; using SabreTools.IO.Writers; using SabreTools.Models.SeparatedValue; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public class SeparatedValue : - IFileSerializer, - IStreamSerializer + // TODO: Create variants for the 3 common types: CSV, SSV, TSV + public class SeparatedValue : BaseBinarySerializer { + #region IByteSerializer + + /// + public static byte[]? SerializeBytes(MetadataFile? obj, char delim = ',', bool longHeader = false) + { + var serializer = new SeparatedValue(); + return serializer.SerializeArray(obj, delim, longHeader); + } + + /// + public override byte[]? SerializeArray(MetadataFile? obj) + => SerializeArray(obj, ',', false); + + /// + public byte[]? SerializeArray(MetadataFile? obj, char delim, bool longHeader) + { + using var stream = SerializeStream(obj, delim, longHeader); + if (stream == null) + return null; + + byte[] bytes = new byte[stream.Length]; + stream.Read(bytes, 0, bytes.Length); + return bytes; + } + + #endregion + #region IFileSerializer /// @@ -21,7 +46,7 @@ namespace SabreTools.Serialization.Serializers } /// - public bool Serialize(MetadataFile? obj, string? path) + public override bool Serialize(MetadataFile? obj, string? path) => Serialize(obj, path, ',', false); /// @@ -51,7 +76,7 @@ namespace SabreTools.Serialization.Serializers } /// - public Stream? Serialize(MetadataFile? obj) + public override Stream? Serialize(MetadataFile? obj) => Serialize(obj, ',', false); /// diff --git a/SabreTools.Serialization/Serializers/SoftwareList.cs b/SabreTools.Serialization/Serializers/SoftwareList.cs index 083256be..24b04f2c 100644 --- a/SabreTools.Serialization/Serializers/SoftwareList.cs +++ b/SabreTools.Serialization/Serializers/SoftwareList.cs @@ -2,8 +2,7 @@ using System.IO; namespace SabreTools.Serialization.Serializers { - public class SoftwareList : - XmlFile + public class SoftwareList : XmlFile { #region Constants @@ -31,13 +30,6 @@ namespace SabreTools.Serialization.Serializers #region IFileSerializer - /// - public static bool SerializeFile(Models.SoftwareList.SoftwareList? obj, string? path) - { - var serializer = new SoftwareList(); - return serializer.Serialize(obj, path); - } - /// public override bool Serialize(Models.SoftwareList.SoftwareList? obj, string? path) => Serialize(obj, path, DocTypeName, DocTypePubId, DocTypeSysId, DocTypeSysId); @@ -46,13 +38,6 @@ namespace SabreTools.Serialization.Serializers #region IStreamSerializer - /// - public static Stream? SerializeStream(Models.SoftwareList.SoftwareList? obj) - { - var serializer = new SoftwareList(); - return serializer.Serialize(obj); - } - /// public override Stream? Serialize(Models.SoftwareList.SoftwareList? obj) => Serialize(obj, DocTypeName, DocTypePubId, DocTypeSysId, DocTypeSysId); diff --git a/SabreTools.Serialization/Serializers/XMID.cs b/SabreTools.Serialization/Serializers/XMID.cs index 5e829b48..629b412b 100644 --- a/SabreTools.Serialization/Serializers/XMID.cs +++ b/SabreTools.Serialization/Serializers/XMID.cs @@ -3,8 +3,7 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public partial class XMID : - IStringSerializer + public partial class XMID : IStringSerializer { #region IStringSerializer diff --git a/SabreTools.Serialization/Serializers/XeMID.cs b/SabreTools.Serialization/Serializers/XeMID.cs index b7474253..5f92fcae 100644 --- a/SabreTools.Serialization/Serializers/XeMID.cs +++ b/SabreTools.Serialization/Serializers/XeMID.cs @@ -3,8 +3,7 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { - public partial class XeMID : - IStringSerializer + public partial class XeMID : IStringSerializer { #region IStringSerializer diff --git a/SabreTools.Serialization/Serializers/XmlFile.cs b/SabreTools.Serialization/Serializers/XmlFile.cs index 18d8d6d8..a185c675 100644 --- a/SabreTools.Serialization/Serializers/XmlFile.cs +++ b/SabreTools.Serialization/Serializers/XmlFile.cs @@ -2,7 +2,6 @@ using System.IO; using System.Text; using System.Xml; using System.Xml.Serialization; -using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Serializers { @@ -10,14 +9,40 @@ namespace SabreTools.Serialization.Serializers /// Base class for other XML serializers /// /// - public class XmlFile : - IFileSerializer, - IStreamSerializer + public class XmlFile : BaseBinarySerializer { + #region IByteSerializer + + /// + public override byte[]? SerializeArray(T? obj) + => SerializeArray(obj, null, null, null, null); + + /// + /// Serializes the defined type to a byte array + /// + /// Data to serialize + /// Optional DOCTYPE name + /// Optional DOCTYPE pubid + /// Optional DOCTYPE sysid + /// Optional DOCTYPE name + /// Byte array containing serialized data on success, null otherwise + public byte[]? SerializeArray(T? obj, string? name = null, string? pubid = null, string? sysid = null, string? subset = null) + { + using var stream = Serialize(obj, name, pubid, sysid, subset); + if (stream == null) + return null; + + byte[] bytes = new byte[stream.Length]; + stream.Read(bytes, 0, bytes.Length); + return bytes; + } + + #endregion + #region IFileSerializer /// - public virtual bool Serialize(T? obj, string? path) + public override bool Serialize(T? obj, string? path) => Serialize(obj, path, null, null, null, null); /// @@ -49,12 +74,8 @@ namespace SabreTools.Serialization.Serializers #region IStreamSerializer - /// - /// Serializes the defined type to a stream - /// - /// Data to serialize - /// Stream containing serialized data on success, null otherwise - public virtual Stream? Serialize(T? obj) + /// + public override Stream? Serialize(T? obj) => Serialize(obj, null, null, null, null); /// From d768172da1417bfe64c795facbef95312998860b Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 4 Apr 2024 02:42:59 -0400 Subject: [PATCH 06/10] Update README --- README.MD | 1 + 1 file changed, 1 insertion(+) diff --git a/README.MD b/README.MD index 524478ba..e7192066 100644 --- a/README.MD +++ b/README.MD @@ -11,6 +11,7 @@ Below is a table representing the various interfaces that are implemented within | Interface Name | Source Type | Destination Type | | --- | --- | --- | | `IByteDeserializer` | `byte[]?` | Model | +| `IByteSerializer` | Model | `byte[]?` | | `IFileDeserializer` | `string?` path | Model | | `IFileSerializer` | Model | `string?` path | | `IModelSerializer` | Model | Model | From 4b4c17ac24613f723eb2f830a09417c0d5c50301 Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 4 Apr 2024 14:03:02 -0400 Subject: [PATCH 07/10] Make model type inherent to interface --- SabreTools.Serialization/Interfaces/IWrapper.cs | 11 ++++++++++- SabreTools.Serialization/Wrappers/WrapperBase.cs | 5 ++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/SabreTools.Serialization/Interfaces/IWrapper.cs b/SabreTools.Serialization/Interfaces/IWrapper.cs index 5985746e..dc2b9edf 100644 --- a/SabreTools.Serialization/Interfaces/IWrapper.cs +++ b/SabreTools.Serialization/Interfaces/IWrapper.cs @@ -1,11 +1,20 @@ namespace SabreTools.Serialization.Interfaces { - public interface IWrapper + /// + /// Represents a wrapper around a top-level model + /// + /// Top-level model for the wrapper + public interface IWrapper { /// /// Get a human-readable description of the wrapper /// string Description(); + + /// + /// Get the backing model + /// + TModel GetModel(); #if !NETFRAMEWORK /// diff --git a/SabreTools.Serialization/Wrappers/WrapperBase.cs b/SabreTools.Serialization/Wrappers/WrapperBase.cs index 7ab54896..4805c188 100644 --- a/SabreTools.Serialization/Wrappers/WrapperBase.cs +++ b/SabreTools.Serialization/Wrappers/WrapperBase.cs @@ -8,7 +8,7 @@ using SabreTools.Serialization.Interfaces; namespace SabreTools.Serialization.Wrappers { - public abstract class WrapperBase : IWrapper + public abstract class WrapperBase : IWrapper { #region Descriptive Properties @@ -24,6 +24,9 @@ namespace SabreTools.Serialization.Wrappers #region Properties + /// + public T GetModel() => Model; + /// /// Internal model /// From 0696bbab723a6dfb2e242e36724233693b8e94f1 Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 4 Apr 2024 14:06:59 -0400 Subject: [PATCH 08/10] Add MoPaQ wrapper --- .../Wrappers/MicrosoftCabinet.cs | 4 +- SabreTools.Serialization/Wrappers/MoPaQ.cs | 79 +++++++++++++++++++ 2 files changed, 82 insertions(+), 1 deletion(-) create mode 100644 SabreTools.Serialization/Wrappers/MoPaQ.cs diff --git a/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs b/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs index aae4aa05..a021e4a4 100644 --- a/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs +++ b/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs @@ -26,7 +26,9 @@ namespace SabreTools.Serialization.Wrappers : base(model, data) { // All logic is handled by the base class - }/// + } + + /// /// Create a Microsoft Cabinet from a byte array and offset /// /// Byte array representing the cabinet diff --git a/SabreTools.Serialization/Wrappers/MoPaQ.cs b/SabreTools.Serialization/Wrappers/MoPaQ.cs new file mode 100644 index 00000000..43cf9990 --- /dev/null +++ b/SabreTools.Serialization/Wrappers/MoPaQ.cs @@ -0,0 +1,79 @@ +using System.IO; + +namespace SabreTools.Serialization.Wrappers +{ + // TODO: Figure out extension properties + public partial class MoPaQ : WrapperBase + { + #region Descriptive Properties + + /// + public override string DescriptionString => "MoPaQ Archive"; + + #endregion + + #region Constructors + + /// + public MoPaQ(Models.MoPaQ.Archive? model, byte[]? data, int offset) + : base(model, data, offset) + { + // All logic is handled by the base class + } + + /// + public MoPaQ(Models.MoPaQ.Archive? model, Stream? data) + : base(model, data) + { + // All logic is handled by the base class + } + + /// + /// Create a Microsoft Cabinet from a byte array and offset + /// + /// Byte array representing the cabinet + /// Offset within the array to parse + /// A cabinet wrapper on success, null on failure + public static MoPaQ? Create(byte[]? data, int offset) + { + // If the data is invalid + if (data == null) + return null; + + // If the offset is out of bounds + if (offset < 0 || offset >= data.Length) + return null; + + // Create a memory stream and use that + var dataStream = new MemoryStream(data, offset, data.Length - offset); + return Create(dataStream); + } + + /// + /// Create a Microsoft Cabinet from a Stream + /// + /// Stream representing the cabinet + /// A cabinet wrapper on success, null on failure + public static MoPaQ? Create(Stream? data) + { + // If the data is invalid + if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) + return null; + + var cabinet = Deserializers.MoPaQ.DeserializeStream(data); + if (cabinet == null) + return null; + + try + { + return new MoPaQ(cabinet, data); + } + catch + { + return null; + } + } + + #endregion + } +} From d0865739de81b51904f968a02c88ca01f8e253ad Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 4 Apr 2024 14:13:03 -0400 Subject: [PATCH 09/10] Add PIC wrapper --- SabreTools.Serialization/Wrappers/GCF.cs | 2 - .../Wrappers/LinearExecutable.cs | 14 ++-- SabreTools.Serialization/Wrappers/MSDOS.cs | 14 ++-- .../Wrappers/MicrosoftCabinet.cs | 12 +-- SabreTools.Serialization/Wrappers/MoPaQ.cs | 18 ++--- SabreTools.Serialization/Wrappers/PFF.cs | 15 ++-- SabreTools.Serialization/Wrappers/PIC.cs | 79 +++++++++++++++++++ 7 files changed, 118 insertions(+), 36 deletions(-) create mode 100644 SabreTools.Serialization/Wrappers/PIC.cs diff --git a/SabreTools.Serialization/Wrappers/GCF.cs b/SabreTools.Serialization/Wrappers/GCF.cs index 598e9f83..323fae83 100644 --- a/SabreTools.Serialization/Wrappers/GCF.cs +++ b/SabreTools.Serialization/Wrappers/GCF.cs @@ -1,7 +1,5 @@ using System.Collections.Generic; using System.IO; -using SabreTools.Models.CHD; -using SabreTools.Models.CueSheets; namespace SabreTools.Serialization.Wrappers { diff --git a/SabreTools.Serialization/Wrappers/LinearExecutable.cs b/SabreTools.Serialization/Wrappers/LinearExecutable.cs index 78e439ec..0f057e35 100644 --- a/SabreTools.Serialization/Wrappers/LinearExecutable.cs +++ b/SabreTools.Serialization/Wrappers/LinearExecutable.cs @@ -26,12 +26,14 @@ namespace SabreTools.Serialization.Wrappers : base(model, data) { // All logic is handled by the base class - }/// - /// Create an LE/LX executable from a byte array and offset - /// - /// Byte array representing the executable - /// Offset within the array to parse - /// An LE/LX executable wrapper on success, null on failure + } + + /// + /// Create an LE/LX executable from a byte array and offset + /// + /// Byte array representing the executable + /// Offset within the array to parse + /// An LE/LX executable wrapper on success, null on failure public static LinearExecutable? Create(byte[]? data, int offset) { // If the data is invalid diff --git a/SabreTools.Serialization/Wrappers/MSDOS.cs b/SabreTools.Serialization/Wrappers/MSDOS.cs index e70b8ccf..b275439e 100644 --- a/SabreTools.Serialization/Wrappers/MSDOS.cs +++ b/SabreTools.Serialization/Wrappers/MSDOS.cs @@ -25,12 +25,14 @@ namespace SabreTools.Serialization.Wrappers : base(model, data) { // All logic is handled by the base class - }/// - /// Create an MS-DOS executable from a byte array and offset - /// - /// Byte array representing the executable - /// Offset within the array to parse - /// An MS-DOS executable wrapper on success, null on failure + } + + /// + /// Create an MS-DOS executable from a byte array and offset + /// + /// Byte array representing the executable + /// Offset within the array to parse + /// An MS-DOS executable wrapper on success, null on failure public static MSDOS? Create(byte[]? data, int offset) { // If the data is invalid diff --git a/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs b/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs index a021e4a4..af874b2f 100644 --- a/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs +++ b/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs @@ -27,13 +27,13 @@ namespace SabreTools.Serialization.Wrappers { // All logic is handled by the base class } - + /// - /// Create a Microsoft Cabinet from a byte array and offset - /// - /// Byte array representing the cabinet - /// Offset within the array to parse - /// A cabinet wrapper on success, null on failure + /// Create a Microsoft Cabinet from a byte array and offset + /// + /// Byte array representing the cabinet + /// Offset within the array to parse + /// A cabinet wrapper on success, null on failure public static MicrosoftCabinet? Create(byte[]? data, int offset) { // If the data is invalid diff --git a/SabreTools.Serialization/Wrappers/MoPaQ.cs b/SabreTools.Serialization/Wrappers/MoPaQ.cs index 43cf9990..89a9822f 100644 --- a/SabreTools.Serialization/Wrappers/MoPaQ.cs +++ b/SabreTools.Serialization/Wrappers/MoPaQ.cs @@ -27,13 +27,13 @@ namespace SabreTools.Serialization.Wrappers { // All logic is handled by the base class } - + /// - /// Create a Microsoft Cabinet from a byte array and offset - /// - /// Byte array representing the cabinet - /// Offset within the array to parse - /// A cabinet wrapper on success, null on failure + /// Create a MoPaQ archive from a byte array and offset + /// + /// Byte array representing the archive + /// Offset within the array to parse + /// A MoPaQ archive wrapper on success, null on failure public static MoPaQ? Create(byte[]? data, int offset) { // If the data is invalid @@ -50,10 +50,10 @@ namespace SabreTools.Serialization.Wrappers } /// - /// Create a Microsoft Cabinet from a Stream + /// Create a MoPaQ archive from a Stream /// - /// Stream representing the cabinet - /// A cabinet wrapper on success, null on failure + /// Stream representing the archive + /// A MoPaQ archive wrapper on success, null on failure public static MoPaQ? Create(Stream? data) { // If the data is invalid diff --git a/SabreTools.Serialization/Wrappers/PFF.cs b/SabreTools.Serialization/Wrappers/PFF.cs index 0f0d2c1f..736b952a 100644 --- a/SabreTools.Serialization/Wrappers/PFF.cs +++ b/SabreTools.Serialization/Wrappers/PFF.cs @@ -1,5 +1,4 @@ using System.IO; -using System.Text; namespace SabreTools.Serialization.Wrappers { @@ -26,12 +25,14 @@ namespace SabreTools.Serialization.Wrappers : base(model, data) { // All logic is handled by the base class - }/// - /// Create a PFF archive from a byte array and offset - /// - /// Byte array representing the archive - /// Offset within the array to parse - /// A PFF archive wrapper on success, null on failure + } + + /// + /// Create a PFF archive from a byte array and offset + /// + /// Byte array representing the archive + /// Offset within the array to parse + /// A PFF archive wrapper on success, null on failure public static PFF? Create(byte[]? data, int offset) { // If the data is invalid diff --git a/SabreTools.Serialization/Wrappers/PIC.cs b/SabreTools.Serialization/Wrappers/PIC.cs new file mode 100644 index 00000000..c9669fc9 --- /dev/null +++ b/SabreTools.Serialization/Wrappers/PIC.cs @@ -0,0 +1,79 @@ +using System.IO; + +namespace SabreTools.Serialization.Wrappers +{ + // TODO: Figure out extension properties + public class PIC : WrapperBase + { + #region Descriptive Properties + + /// + public override string DescriptionString => "Disc Information"; + + #endregion + + #region Constructors + + /// + public PIC(Models.PIC.DiscInformation? model, byte[]? data, int offset) + : base(model, data, offset) + { + // All logic is handled by the base class + } + + /// + public PIC(Models.PIC.DiscInformation? model, Stream? data) + : base(model, data) + { + // All logic is handled by the base class + } + + /// + /// Create a PIC disc information object from a byte array and offset + /// + /// Byte array representing the information + /// Offset within the array to parse + /// A PIC disc information wrapper on success, null on failure + public static PIC? Create(byte[]? data, int offset) + { + // If the data is invalid + if (data == null) + return null; + + // If the offset is out of bounds + if (offset < 0 || offset >= data.Length) + return null; + + // Create a memory stream and use that + var dataStream = new MemoryStream(data, offset, data.Length - offset); + return Create(dataStream); + } + + /// + /// Create a PIC disc information object from a Stream + /// + /// Stream representing the information + /// A PIC disc information wrapper on success, null on failure + public static PIC? Create(Stream? data) + { + // If the data is invalid + if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) + return null; + + var archive = Deserializers.PIC.DeserializeStream(data); + if (archive == null) + return null; + + try + { + return new PIC(archive, data); + } + catch + { + return null; + } + } + + #endregion + } +} \ No newline at end of file From 1a2e9fb942c1239f25d2b3baaaf2232d87b4024e Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 4 Apr 2024 14:15:27 -0400 Subject: [PATCH 10/10] Add PlayJ playlist wrapper --- SabreTools.Serialization/Wrappers/MoPaQ.cs | 6 +- SabreTools.Serialization/Wrappers/PIC.cs | 6 +- .../Wrappers/PlayJAudioFile.cs | 4 +- .../Wrappers/PlayJPlaylist.cs | 78 +++++++++++++++++++ 4 files changed, 86 insertions(+), 8 deletions(-) create mode 100644 SabreTools.Serialization/Wrappers/PlayJPlaylist.cs diff --git a/SabreTools.Serialization/Wrappers/MoPaQ.cs b/SabreTools.Serialization/Wrappers/MoPaQ.cs index 89a9822f..57659de2 100644 --- a/SabreTools.Serialization/Wrappers/MoPaQ.cs +++ b/SabreTools.Serialization/Wrappers/MoPaQ.cs @@ -60,13 +60,13 @@ namespace SabreTools.Serialization.Wrappers if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) return null; - var cabinet = Deserializers.MoPaQ.DeserializeStream(data); - if (cabinet == null) + var archive = Deserializers.MoPaQ.DeserializeStream(data); + if (archive == null) return null; try { - return new MoPaQ(cabinet, data); + return new MoPaQ(archive, data); } catch { diff --git a/SabreTools.Serialization/Wrappers/PIC.cs b/SabreTools.Serialization/Wrappers/PIC.cs index c9669fc9..ea59ce5d 100644 --- a/SabreTools.Serialization/Wrappers/PIC.cs +++ b/SabreTools.Serialization/Wrappers/PIC.cs @@ -60,13 +60,13 @@ namespace SabreTools.Serialization.Wrappers if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) return null; - var archive = Deserializers.PIC.DeserializeStream(data); - if (archive == null) + var info = Deserializers.PIC.DeserializeStream(data); + if (info == null) return null; try { - return new PIC(archive, data); + return new PIC(info, data); } catch { diff --git a/SabreTools.Serialization/Wrappers/PlayJAudioFile.cs b/SabreTools.Serialization/Wrappers/PlayJAudioFile.cs index 5acd88ce..59512058 100644 --- a/SabreTools.Serialization/Wrappers/PlayJAudioFile.cs +++ b/SabreTools.Serialization/Wrappers/PlayJAudioFile.cs @@ -30,7 +30,7 @@ namespace SabreTools.Serialization.Wrappers /// /// Create a PlayJ audio file from a byte array and offset /// - /// Byte array representing the archive + /// Byte array representing the audio file /// Offset within the array to parse /// A PlayJ audio file wrapper on success, null on failure public static PlayJAudioFile? Create(byte[]? data, int offset) @@ -51,7 +51,7 @@ namespace SabreTools.Serialization.Wrappers /// /// Create a PlayJ audio file from a Stream /// - /// Stream representing the archive + /// Stream representing the audio file /// A PlayJ audio file wrapper on success, null on failure public static PlayJAudioFile? Create(Stream? data) { diff --git a/SabreTools.Serialization/Wrappers/PlayJPlaylist.cs b/SabreTools.Serialization/Wrappers/PlayJPlaylist.cs new file mode 100644 index 00000000..086acaee --- /dev/null +++ b/SabreTools.Serialization/Wrappers/PlayJPlaylist.cs @@ -0,0 +1,78 @@ +using System.IO; + +namespace SabreTools.Serialization.Wrappers +{ + public class PlayJPlaylist : WrapperBase + { + #region Descriptive Properties + + /// + public override string DescriptionString => "PlayJ Playlist"; + + #endregion + + #region Constructors + + /// + public PlayJPlaylist(Models.PlayJ.Playlist? model, byte[]? data, int offset) + : base(model, data, offset) + { + // All logic is handled by the base class + } + + /// + public PlayJPlaylist(Models.PlayJ.Playlist? model, Stream? data) + : base(model, data) + { + // All logic is handled by the base class + } + + /// + /// Create a PlayJ playlist from a byte array and offset + /// + /// Byte array representing the playlist + /// Offset within the array to parse + /// A PlayJ playlist wrapper on success, null on failure + public static PlayJPlaylist? Create(byte[]? data, int offset) + { + // If the data is invalid + if (data == null) + return null; + + // If the offset is out of bounds + if (offset < 0 || offset >= data.Length) + return null; + + // Create a memory stream and use that + var dataStream = new MemoryStream(data, offset, data.Length - offset); + return Create(dataStream); + } + + /// + /// Create a PlayJ playlist from a Stream + /// + /// Stream representing the playlist + /// A PlayJ playlist wrapper on success, null on failure + public static PlayJPlaylist? Create(Stream? data) + { + // If the data is invalid + if (data == null || data.Length == 0 || !data.CanSeek || !data.CanRead) + return null; + + var playlist = Deserializers.PlayJPlaylist.DeserializeStream(data); + if (playlist == null) + return null; + + try + { + return new PlayJPlaylist(playlist, data); + } + catch + { + return null; + } + } + + #endregion + } +} \ No newline at end of file