diff --git a/ExtractionTool/Program.cs b/ExtractionTool/Program.cs index 5f325d8f..a81befdd 100644 --- a/ExtractionTool/Program.cs +++ b/ExtractionTool/Program.cs @@ -20,7 +20,7 @@ namespace ExtractionTool var commandSet = CreateCommands(mainFeature); // If we have no args, show the help and quit - if (args == null || args.Length == 0) + if (args is null || args.Length == 0) { commandSet.OutputAllHelp(); return; diff --git a/InfoPrint/Features/MainFeature.cs b/InfoPrint/Features/MainFeature.cs index 4c1bf7d2..e221d7e7 100644 --- a/InfoPrint/Features/MainFeature.cs +++ b/InfoPrint/Features/MainFeature.cs @@ -172,7 +172,7 @@ namespace InfoPrint.Features var wrapper = WrapperFactory.CreateWrapper(ft, stream); // If we don't have a wrapper - if (wrapper == null) + if (wrapper is null) { Console.WriteLine($"Either {ft} is not supported or something went wrong during parsing!"); Console.WriteLine(); @@ -195,7 +195,7 @@ namespace InfoPrint.Features // Create the output data var builder = wrapper.ExportStringBuilder(); - if (builder == null) + if (builder is null) { Console.WriteLine("No item information could be generated"); return; @@ -235,7 +235,7 @@ namespace InfoPrint.Features { // Get all file hashes for flexibility var hashes = HashTool.GetFileHashes(file); - if (hashes == null) + if (hashes is null) { if (Debug) Console.WriteLine($"Hashes for {file} could not be retrieved"); return null; diff --git a/InfoPrint/Program.cs b/InfoPrint/Program.cs index 5c1990f7..cf6f131b 100644 --- a/InfoPrint/Program.cs +++ b/InfoPrint/Program.cs @@ -15,7 +15,7 @@ namespace InfoPrint var commandSet = CreateCommands(mainFeature); // If we have no args, show the help and quit - if (args == null || args.Length == 0) + if (args is null || args.Length == 0) { commandSet.OutputAllHelp(); return; diff --git a/SabreTools.Serialization/CrossModel/ArchiveDotOrg.Deserializer.cs b/SabreTools.Serialization/CrossModel/ArchiveDotOrg.Deserializer.cs index 6d97d510..ea09cc81 100644 --- a/SabreTools.Serialization/CrossModel/ArchiveDotOrg.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/ArchiveDotOrg.Deserializer.cs @@ -9,7 +9,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Files? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var files = new Files(); @@ -31,7 +31,7 @@ namespace SabreTools.Serialization.CrossModel private static File[] ConvertFromInternalModel(Data.Models.Metadata.Machine item) { var roms = item.Read(Data.Models.Metadata.Machine.RomKey); - if (roms == null) + if (roms is null) return []; return Array.ConvertAll(roms, ConvertFromInternalModel); diff --git a/SabreTools.Serialization/CrossModel/ArchiveDotOrg.Serializer.cs b/SabreTools.Serialization/CrossModel/ArchiveDotOrg.Serializer.cs index 64499609..46027165 100644 --- a/SabreTools.Serialization/CrossModel/ArchiveDotOrg.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/ArchiveDotOrg.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(Files? item) { - if (item == null) + if (item is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile @@ -56,7 +56,7 @@ namespace SabreTools.Serialization.CrossModel /// private static Data.Models.Metadata.Rom? ConvertToInternalModel(File? item) { - if (item == null) + if (item is null) return null; var rom = new Data.Models.Metadata.Rom diff --git a/SabreTools.Serialization/CrossModel/AttractMode.Deserializer.cs b/SabreTools.Serialization/CrossModel/AttractMode.Deserializer.cs index c8642428..e0db00de 100644 --- a/SabreTools.Serialization/CrossModel/AttractMode.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/AttractMode.Deserializer.cs @@ -9,7 +9,7 @@ namespace SabreTools.Serialization.CrossModel /// public override MetadataFile? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var header = obj.Read(Data.Models.Metadata.MetadataFile.HeaderKey); @@ -44,7 +44,7 @@ namespace SabreTools.Serialization.CrossModel private static Row[] ConvertMachineFromInternalModel(Data.Models.Metadata.Machine item) { var roms = item.Read(Data.Models.Metadata.Machine.RomKey); - if (roms == null || roms.Length == 0) + if (roms is null || roms.Length == 0) return []; return Array.ConvertAll(roms, r => ConvertFromInternalModel(r, item)); diff --git a/SabreTools.Serialization/CrossModel/AttractMode.Serializer.cs b/SabreTools.Serialization/CrossModel/AttractMode.Serializer.cs index 72fd4f39..a874a27f 100644 --- a/SabreTools.Serialization/CrossModel/AttractMode.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/AttractMode.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile @@ -42,7 +42,7 @@ namespace SabreTools.Serialization.CrossModel /// private static Data.Models.Metadata.Machine? ConvertMachineToInternalModel(Row? item) { - if (item == null) + if (item is null) return null; var machine = new Data.Models.Metadata.Machine diff --git a/SabreTools.Serialization/CrossModel/ClrMamePro.Deserializer.cs b/SabreTools.Serialization/CrossModel/ClrMamePro.Deserializer.cs index 30511d1d..f988c53d 100644 --- a/SabreTools.Serialization/CrossModel/ClrMamePro.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/ClrMamePro.Deserializer.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.CrossModel /// public MetadataFile? Deserialize(Data.Models.Metadata.MetadataFile? obj, bool game) { - if (obj == null) + if (obj is null) return null; var metadataFile = new MetadataFile(); diff --git a/SabreTools.Serialization/CrossModel/ClrMamePro.Serializer.cs b/SabreTools.Serialization/CrossModel/ClrMamePro.Serializer.cs index 3a9fbca0..20779db2 100644 --- a/SabreTools.Serialization/CrossModel/ClrMamePro.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/ClrMamePro.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile(); @@ -59,7 +59,7 @@ namespace SabreTools.Serialization.CrossModel /// private static Data.Models.Metadata.Machine? ConvertMachineToInternalModel(GameBase? item) { - if (item == null) + if (item is null) return null; var machine = new Data.Models.Metadata.Machine diff --git a/SabreTools.Serialization/CrossModel/DosCenter.Deserializer.cs b/SabreTools.Serialization/CrossModel/DosCenter.Deserializer.cs index 26d0c9d9..876f2034 100644 --- a/SabreTools.Serialization/CrossModel/DosCenter.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/DosCenter.Deserializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override MetadataFile? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new MetadataFile(); diff --git a/SabreTools.Serialization/CrossModel/DosCenter.Serializer.cs b/SabreTools.Serialization/CrossModel/DosCenter.Serializer.cs index 8094ea70..3d64a453 100644 --- a/SabreTools.Serialization/CrossModel/DosCenter.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/DosCenter.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile(); diff --git a/SabreTools.Serialization/CrossModel/EverdriveSMDB.Deserializer.cs b/SabreTools.Serialization/CrossModel/EverdriveSMDB.Deserializer.cs index a1ad2623..44e097f9 100644 --- a/SabreTools.Serialization/CrossModel/EverdriveSMDB.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/EverdriveSMDB.Deserializer.cs @@ -9,7 +9,7 @@ namespace SabreTools.Serialization.CrossModel /// public override MetadataFile? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new MetadataFile(); @@ -32,7 +32,7 @@ namespace SabreTools.Serialization.CrossModel private static Row[] ConvertMachineFromInternalModel(Data.Models.Metadata.Machine item) { var roms = item.Read(Data.Models.Metadata.Machine.RomKey); - if (roms == null || roms.Length == 0) + if (roms is null || roms.Length == 0) return []; return Array.ConvertAll(roms, ConvertFromInternalModel); diff --git a/SabreTools.Serialization/CrossModel/EverdriveSMDB.Serializer.cs b/SabreTools.Serialization/CrossModel/EverdriveSMDB.Serializer.cs index b8f3624e..46c4dd29 100644 --- a/SabreTools.Serialization/CrossModel/EverdriveSMDB.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/EverdriveSMDB.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/CrossModel/Hashfile.Deserializer.cs b/SabreTools.Serialization/CrossModel/Hashfile.Deserializer.cs index e82b68fd..f4b30147 100644 --- a/SabreTools.Serialization/CrossModel/Hashfile.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/Hashfile.Deserializer.cs @@ -14,11 +14,11 @@ namespace SabreTools.Serialization.CrossModel /// public Data.Models.Hashfile.Hashfile? Deserialize(Data.Models.Metadata.MetadataFile? obj, HashType hash) { - if (obj == null) + if (obj is null) return null; var machines = obj.Read(Data.Models.Metadata.MetadataFile.MachineKey); - if (machines == null || machines.Length == 0) + if (machines is null || machines.Length == 0) return null; var hashfiles = Array.ConvertAll(machines, @@ -96,7 +96,7 @@ namespace SabreTools.Serialization.CrossModel private static Data.Models.Hashfile.Hashfile ConvertMachineFromInternalModel(Data.Models.Metadata.Machine item, HashType hash) { var roms = item.Read(Data.Models.Metadata.Machine.RomKey); - if (roms == null) + if (roms is null) return new Data.Models.Hashfile.Hashfile(); return new Data.Models.Hashfile.Hashfile diff --git a/SabreTools.Serialization/CrossModel/Hashfile.Serializer.cs b/SabreTools.Serialization/CrossModel/Hashfile.Serializer.cs index ec9e38bd..232bf04d 100644 --- a/SabreTools.Serialization/CrossModel/Hashfile.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/Hashfile.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(Data.Models.Hashfile.Hashfile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/CrossModel/Listrom.Deserializer.cs b/SabreTools.Serialization/CrossModel/Listrom.Deserializer.cs index aa0e14a7..1f8c4497 100644 --- a/SabreTools.Serialization/CrossModel/Listrom.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/Listrom.Deserializer.cs @@ -9,7 +9,7 @@ namespace SabreTools.Serialization.CrossModel /// public override MetadataFile? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new MetadataFile(); diff --git a/SabreTools.Serialization/CrossModel/Listrom.Serializer.cs b/SabreTools.Serialization/CrossModel/Listrom.Serializer.cs index 9ba4bed6..85bba7dc 100644 --- a/SabreTools.Serialization/CrossModel/Listrom.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/Listrom.Serializer.cs @@ -9,7 +9,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile @@ -79,7 +79,7 @@ namespace SabreTools.Serialization.CrossModel /// private static Data.Models.Metadata.DatItem ConvertToInternalModel(Row item) { - if (item.Size == null) + if (item.Size is null) { var disk = new Data.Models.Metadata.Disk { diff --git a/SabreTools.Serialization/CrossModel/Listxml.Deserializer.cs b/SabreTools.Serialization/CrossModel/Listxml.Deserializer.cs index 39aab9c3..84e0a5fe 100644 --- a/SabreTools.Serialization/CrossModel/Listxml.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/Listxml.Deserializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Mame? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var header = obj.Read(Data.Models.Metadata.MetadataFile.HeaderKey); diff --git a/SabreTools.Serialization/CrossModel/Listxml.Serializer.cs b/SabreTools.Serialization/CrossModel/Listxml.Serializer.cs index 20674245..fbbabc8a 100644 --- a/SabreTools.Serialization/CrossModel/Listxml.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/Listxml.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(Mame? item) { - if (item == null) + if (item is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/CrossModel/Logiqx.Deserializer.cs b/SabreTools.Serialization/CrossModel/Logiqx.Deserializer.cs index b4f47278..89519e0e 100644 --- a/SabreTools.Serialization/CrossModel/Logiqx.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/Logiqx.Deserializer.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.CrossModel /// public Datafile? Deserialize(Data.Models.Metadata.MetadataFile? obj, bool game) { - if (obj == null) + if (obj is null) return null; var datafile = new Datafile(); diff --git a/SabreTools.Serialization/CrossModel/Logiqx.Serializer.cs b/SabreTools.Serialization/CrossModel/Logiqx.Serializer.cs index 1d429938..76a3aa56 100644 --- a/SabreTools.Serialization/CrossModel/Logiqx.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/Logiqx.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel { public override Data.Models.Metadata.MetadataFile? Serialize(Datafile? item) { - if (item == null) + if (item is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/CrossModel/M1.Deserializer.cs b/SabreTools.Serialization/CrossModel/M1.Deserializer.cs index bf2f0ac4..28a2985c 100644 --- a/SabreTools.Serialization/CrossModel/M1.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/M1.Deserializer.cs @@ -7,7 +7,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Listxml.M1? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var header = obj.Read(Data.Models.Metadata.MetadataFile.HeaderKey); diff --git a/SabreTools.Serialization/CrossModel/M1.Serializer.cs b/SabreTools.Serialization/CrossModel/M1.Serializer.cs index 334cf48d..07ae6e0c 100644 --- a/SabreTools.Serialization/CrossModel/M1.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/M1.Serializer.cs @@ -7,7 +7,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(Data.Models.Listxml.M1? item) { - if (item == null) + if (item is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/CrossModel/Mess.Deserializer.cs b/SabreTools.Serialization/CrossModel/Mess.Deserializer.cs index df3e1f65..437501fc 100644 --- a/SabreTools.Serialization/CrossModel/Mess.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/Mess.Deserializer.cs @@ -7,7 +7,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Listxml.Mess? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var header = obj.Read(Data.Models.Metadata.MetadataFile.HeaderKey); diff --git a/SabreTools.Serialization/CrossModel/Mess.Serializer.cs b/SabreTools.Serialization/CrossModel/Mess.Serializer.cs index f62793f2..b930ddd3 100644 --- a/SabreTools.Serialization/CrossModel/Mess.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/Mess.Serializer.cs @@ -7,7 +7,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(Data.Models.Listxml.Mess? item) { - if (item == null) + if (item is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/CrossModel/OfflineList.Deserializer.cs b/SabreTools.Serialization/CrossModel/OfflineList.Deserializer.cs index 2e1133b1..4e8ab90d 100644 --- a/SabreTools.Serialization/CrossModel/OfflineList.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/OfflineList.Deserializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Dat? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var header = obj.Read(Data.Models.Metadata.MetadataFile.HeaderKey); diff --git a/SabreTools.Serialization/CrossModel/OfflineList.Serializer.cs b/SabreTools.Serialization/CrossModel/OfflineList.Serializer.cs index 60babf1a..a2067d9f 100644 --- a/SabreTools.Serialization/CrossModel/OfflineList.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/OfflineList.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(Dat? item) { - if (item == null) + if (item is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/CrossModel/OpenMSX.Deserializer.cs b/SabreTools.Serialization/CrossModel/OpenMSX.Deserializer.cs index 4e3fa337..5e8cd73e 100644 --- a/SabreTools.Serialization/CrossModel/OpenMSX.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/OpenMSX.Deserializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override SoftwareDb? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var header = obj.Read(Data.Models.Metadata.MetadataFile.HeaderKey); diff --git a/SabreTools.Serialization/CrossModel/OpenMSX.Serializer.cs b/SabreTools.Serialization/CrossModel/OpenMSX.Serializer.cs index b81856aa..02f71a1e 100644 --- a/SabreTools.Serialization/CrossModel/OpenMSX.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/OpenMSX.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(SoftwareDb? item) { - if (item == null) + if (item is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/CrossModel/RomCenter.Deserializer.cs b/SabreTools.Serialization/CrossModel/RomCenter.Deserializer.cs index 40f3a565..50b21c54 100644 --- a/SabreTools.Serialization/CrossModel/RomCenter.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/RomCenter.Deserializer.cs @@ -9,7 +9,7 @@ namespace SabreTools.Serialization.CrossModel /// public override MetadataFile? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var header = obj.Read(Data.Models.Metadata.MetadataFile.HeaderKey); @@ -85,7 +85,7 @@ namespace SabreTools.Serialization.CrossModel private static Rom[] ConvertMachineFromInternalModel(Data.Models.Metadata.Machine item) { var roms = item.Read(Data.Models.Metadata.Machine.RomKey); - if (roms == null) + if (roms is null) return []; return Array.ConvertAll(roms, r => ConvertFromInternalModel(r, item)); diff --git a/SabreTools.Serialization/CrossModel/RomCenter.Serializer.cs b/SabreTools.Serialization/CrossModel/RomCenter.Serializer.cs index 2ebd49a2..d190ee43 100644 --- a/SabreTools.Serialization/CrossModel/RomCenter.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/RomCenter.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/CrossModel/SeparatedValue.Deserializer.cs b/SabreTools.Serialization/CrossModel/SeparatedValue.Deserializer.cs index 02318123..5cfdfce6 100644 --- a/SabreTools.Serialization/CrossModel/SeparatedValue.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/SeparatedValue.Deserializer.cs @@ -9,7 +9,7 @@ namespace SabreTools.Serialization.CrossModel /// public override MetadataFile? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var header = obj.Read(Data.Models.Metadata.MetadataFile.HeaderKey); diff --git a/SabreTools.Serialization/CrossModel/SeparatedValue.Serializer.cs b/SabreTools.Serialization/CrossModel/SeparatedValue.Serializer.cs index 22820d51..d315bbb5 100644 --- a/SabreTools.Serialization/CrossModel/SeparatedValue.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/SeparatedValue.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/CrossModel/SoftwareList.Deserializer.cs b/SabreTools.Serialization/CrossModel/SoftwareList.Deserializer.cs index 0ac262d5..f6833038 100644 --- a/SabreTools.Serialization/CrossModel/SoftwareList.Deserializer.cs +++ b/SabreTools.Serialization/CrossModel/SoftwareList.Deserializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.SoftwareList.SoftwareList? Deserialize(Data.Models.Metadata.MetadataFile? obj) { - if (obj == null) + if (obj is null) return null; var header = obj.Read(Data.Models.Metadata.MetadataFile.HeaderKey); diff --git a/SabreTools.Serialization/CrossModel/SoftwareList.Serializer.cs b/SabreTools.Serialization/CrossModel/SoftwareList.Serializer.cs index aeb3d085..fe26471f 100644 --- a/SabreTools.Serialization/CrossModel/SoftwareList.Serializer.cs +++ b/SabreTools.Serialization/CrossModel/SoftwareList.Serializer.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.CrossModel /// public override Data.Models.Metadata.MetadataFile? Serialize(Data.Models.SoftwareList.SoftwareList? item) { - if (item == null) + if (item is null) return null; var metadataFile = new Data.Models.Metadata.MetadataFile diff --git a/SabreTools.Serialization/Extensions/CFB.cs b/SabreTools.Serialization/Extensions/CFB.cs index 81608ee0..5b39f3ef 100644 --- a/SabreTools.Serialization/Extensions/CFB.cs +++ b/SabreTools.Serialization/Extensions/CFB.cs @@ -13,7 +13,7 @@ namespace SabreTools.Data.Extensions public static string? DecodeStreamName(this byte[]? input) { // Ignore invalid inputs - if (input == null) + if (input is null) return null; else if (input.Length == 0) return string.Empty; @@ -69,7 +69,7 @@ namespace SabreTools.Data.Extensions public static string? DecodeStreamName(this string? input) { // Ignore invalid inputs - if (input == null) + if (input is null) return null; else if (input.Length == 0) return string.Empty; diff --git a/SabreTools.Serialization/Extensions/InstallShieldCabinet.cs b/SabreTools.Serialization/Extensions/InstallShieldCabinet.cs index 4aeb002b..89c9dcc9 100644 --- a/SabreTools.Serialization/Extensions/InstallShieldCabinet.cs +++ b/SabreTools.Serialization/Extensions/InstallShieldCabinet.cs @@ -14,7 +14,7 @@ namespace SabreTools.Data.Extensions public static bool IsCompressed(this FileDescriptor? fileDescriptor) { // Ignore invalid descriptors - if (fileDescriptor == null) + if (fileDescriptor is null) return true; #if NET20 || NET35 @@ -32,7 +32,7 @@ namespace SabreTools.Data.Extensions public static bool IsInvalid(this FileDescriptor? fileDescriptor) { // Ignore invalid descriptors - if (fileDescriptor == null) + if (fileDescriptor is null) return true; #if NET20 || NET35 @@ -50,7 +50,7 @@ namespace SabreTools.Data.Extensions public static bool IsObfuscated(this FileDescriptor? fileDescriptor) { // Ignore invalid descriptors - if (fileDescriptor == null) + if (fileDescriptor is null) return false; #if NET20 || NET35 @@ -68,7 +68,7 @@ namespace SabreTools.Data.Extensions public static bool IsSplit(this FileDescriptor? fileDescriptor) { // Ignore invalid descriptors - if (fileDescriptor == null) + if (fileDescriptor is null) return false; #if NET20 || NET35 @@ -90,7 +90,7 @@ namespace SabreTools.Data.Extensions public static int GetMajorVersion(this Cabinet? cabinet) { // Ignore invalid cabinets - if (cabinet == null) + if (cabinet is null) return -1; return cabinet.CommonHeader.GetMajorVersion(); @@ -104,7 +104,7 @@ namespace SabreTools.Data.Extensions public static int GetMajorVersion(this CommonHeader? commonHeader) { // Ignore invalid headers - if (commonHeader == null) + if (commonHeader is null) return -1; uint majorVersion = commonHeader.Version; diff --git a/SabreTools.Serialization/Extensions/PortableExecutable.cs b/SabreTools.Serialization/Extensions/PortableExecutable.cs index 81c6cac4..7bd3fe26 100644 --- a/SabreTools.Serialization/Extensions/PortableExecutable.cs +++ b/SabreTools.Serialization/Extensions/PortableExecutable.cs @@ -72,7 +72,7 @@ namespace SabreTools.Data.Extensions public static int ContainingSectionIndex(this uint rva, SectionHeader[] sections) { // If we have an invalid section table, we can't do anything - if (sections == null || sections.Length == 0) + if (sections is null || sections.Length == 0) return -1; // If the RVA is 0, we just return -1 because it's invalid @@ -159,7 +159,7 @@ namespace SabreTools.Data.Extensions public static AcceleratorTableEntry[]? AsAcceleratorTableResource(this Models.PortableExecutable.Resource.DataEntry? entry) { // If we have data that's invalid for this resource type, we can't do anything - if (entry?.Data == null || entry.Data.Length % 8 != 0) + if (entry?.Data is null || entry.Data.Length % 8 != 0) return null; // Get the number of entries @@ -188,7 +188,7 @@ namespace SabreTools.Data.Extensions public static AssemblyManifest? AsAssemblyManifest(this Models.PortableExecutable.Resource.DataEntry? entry) { // If we have an invalid entry, just skip - if (entry?.Data == null) + if (entry?.Data is null) return null; try @@ -210,7 +210,7 @@ namespace SabreTools.Data.Extensions public static DialogBoxResource? AsDialogBox(this Models.PortableExecutable.Resource.DataEntry? entry) { // If we have an invalid entry, just skip - if (entry?.Data == null) + if (entry?.Data is null) return null; // Initialize the iterator @@ -687,7 +687,7 @@ namespace SabreTools.Data.Extensions public static FontGroupHeader? AsFontGroup(this Models.PortableExecutable.Resource.DataEntry? entry) { // If we have an invalid entry, just skip - if (entry?.Data == null) + if (entry?.Data is null) return null; // Initialize the iterator @@ -756,7 +756,7 @@ namespace SabreTools.Data.Extensions public static MenuResource? AsMenu(this Models.PortableExecutable.Resource.DataEntry? entry) { // If we have an invalid entry, just skip - if (entry?.Data == null) + if (entry?.Data is null) return null; // Initialize the iterator @@ -830,7 +830,7 @@ namespace SabreTools.Data.Extensions // Align to the DWORD boundary if we're not at the end entry.Data.AlignToBoundary(ref offset, 4); - if (menuItem == null) + if (menuItem is null) return null; menuItems.Add(menuItem); @@ -852,7 +852,7 @@ namespace SabreTools.Data.Extensions public static MessageResourceData? AsMessageResourceData(this Models.PortableExecutable.Resource.DataEntry? entry) { // If we have an invalid entry, just skip - if (entry?.Data == null) + if (entry?.Data is null) return null; // Initialize the iterator @@ -884,7 +884,7 @@ namespace SabreTools.Data.Extensions for (int i = 0; i < messageResourceData.Blocks.Length; i++) { var messageResourceBlock = messageResourceData.Blocks[i]; - if (messageResourceBlock == null) + if (messageResourceBlock is null) continue; offset = (int)messageResourceBlock.OffsetToEntries; @@ -996,7 +996,7 @@ namespace SabreTools.Data.Extensions public static Dictionary? AsStringTable(this Models.PortableExecutable.Resource.DataEntry? entry) { // If we have an invalid entry, just skip - if (entry?.Data == null) + if (entry?.Data is null) return null; // Initialize the iterators @@ -1088,7 +1088,7 @@ namespace SabreTools.Data.Extensions public static VersionInfo? AsVersionInfo(this Models.PortableExecutable.Resource.DataEntry? entry) { // If we have an invalid entry, just skip - if (entry?.Data == null) + if (entry?.Data is null) return null; // Initialize the iterator @@ -1346,7 +1346,7 @@ namespace SabreTools.Data.Extensions private static bool AlignToBoundary(this byte[]? input, ref int offset, byte alignment) { // If the array is invalid - if (input == null || input.Length == 0) + if (input is null || input.Length == 0) return false; // If already at the end of the array diff --git a/SabreTools.Serialization/Extensions/StringBuilderExtensions.cs b/SabreTools.Serialization/Extensions/StringBuilderExtensions.cs index a44da52c..df7f33ea 100644 --- a/SabreTools.Serialization/Extensions/StringBuilderExtensions.cs +++ b/SabreTools.Serialization/Extensions/StringBuilderExtensions.cs @@ -21,7 +21,7 @@ namespace SabreTools.Data.Extensions /// public static StringBuilder AppendLine(this StringBuilder sb, char? value, string prefixString) { - string valueString = (value == null ? "[NULL]" : value.Value.ToString()); + string valueString = (value is null ? "[NULL]" : value.Value.ToString()); return sb.AppendLine($"{prefixString}: {valueString}"); } @@ -256,7 +256,7 @@ namespace SabreTools.Data.Extensions /// public static StringBuilder AppendLine(this StringBuilder sb, byte[]? value, string prefixString) { - string valueString = (value == null ? "[NULL]" : BitConverter.ToString(value).Replace('-', ' ')); + string valueString = (value is null ? "[NULL]" : BitConverter.ToString(value).Replace('-', ' ')); if (valueString.Length == 0) return sb.AppendLine($"{prefixString}: [EMPTY]"); @@ -268,7 +268,7 @@ namespace SabreTools.Data.Extensions /// public static StringBuilder AppendLine(this StringBuilder sb, byte[]? value, string prefixString, Encoding encoding) { - string valueString = (value == null ? "[NULL]" : encoding.GetString(value).Replace("\0", string.Empty)); + string valueString = (value is null ? "[NULL]" : encoding.GetString(value).Replace("\0", string.Empty)); if (valueString.Length == 0) return sb.AppendLine($"{prefixString}: [EMPTY]"); diff --git a/SabreTools.Serialization/Models/Metadata/DictionaryBase.cs b/SabreTools.Serialization/Models/Metadata/DictionaryBase.cs index 375462f8..233d3743 100644 --- a/SabreTools.Serialization/Models/Metadata/DictionaryBase.cs +++ b/SabreTools.Serialization/Models/Metadata/DictionaryBase.cs @@ -144,10 +144,10 @@ namespace SabreTools.Data.Models.Metadata return false; else if (!ContainsKey(key)) return false; - else if (this[key] == null) + else if (this[key] is null) return false; return true; } } -} \ No newline at end of file +} diff --git a/SabreTools.Serialization/ObjectIdentifier/Parser.ModifiedOIDIRI.cs b/SabreTools.Serialization/ObjectIdentifier/Parser.ModifiedOIDIRI.cs index 34d7d9f4..020143c7 100644 --- a/SabreTools.Serialization/ObjectIdentifier/Parser.ModifiedOIDIRI.cs +++ b/SabreTools.Serialization/ObjectIdentifier/Parser.ModifiedOIDIRI.cs @@ -25,7 +25,7 @@ namespace SabreTools.Data.ObjectIdentifier public static string? ParseOIDToModifiedOIDIRI(ulong[]? values) { // If we have an invalid set of values, we can't do anything - if (values == null || values.Length == 0) + if (values is null || values.Length == 0) return null; // Set the initial index @@ -36,7 +36,7 @@ namespace SabreTools.Data.ObjectIdentifier // Try to parse the standard value string? standard = ParseOIDToModifiedOIDIRI(values, ref index); - if (standard == null) + if (standard is null) return null; // Add the standard value to the output @@ -79,7 +79,7 @@ namespace SabreTools.Data.ObjectIdentifier private static string? ParseOIDToModifiedOIDIRI(ulong[]? values, ref int index) { // If we have an invalid set of values, we can't do anything - if (values == null || values.Length == 0) + if (values is null || values.Length == 0) return null; // If we have an invalid index, we can't do anything diff --git a/SabreTools.Serialization/ObjectIdentifier/Parser.OIDIRI.cs b/SabreTools.Serialization/ObjectIdentifier/Parser.OIDIRI.cs index e2fe8fe9..7169fee3 100644 --- a/SabreTools.Serialization/ObjectIdentifier/Parser.OIDIRI.cs +++ b/SabreTools.Serialization/ObjectIdentifier/Parser.OIDIRI.cs @@ -18,7 +18,7 @@ namespace SabreTools.Data.ObjectIdentifier public static string? ParseOIDToOIDIRINotation(ulong[]? values) { // If we have an invalid set of values, we can't do anything - if (values == null || values.Length == 0) + if (values is null || values.Length == 0) return null; // Set the initial index @@ -29,7 +29,7 @@ namespace SabreTools.Data.ObjectIdentifier // Try to parse the standard value string? standard = ParseOIDToOIDIRINotation(values, ref index); - if (standard == null) + if (standard is null) return null; // Add the standard value to the output @@ -68,7 +68,7 @@ namespace SabreTools.Data.ObjectIdentifier private static string? ParseOIDToOIDIRINotation(ulong[]? values, ref int index) { // If we have an invalid set of values, we can't do anything - if (values == null || values.Length == 0) + if (values is null || values.Length == 0) return null; // If we have an invalid index, we can't do anything diff --git a/SabreTools.Serialization/ObjectIdentifier/Parser.dot.cs b/SabreTools.Serialization/ObjectIdentifier/Parser.dot.cs index 2e21e532..89668169 100644 --- a/SabreTools.Serialization/ObjectIdentifier/Parser.dot.cs +++ b/SabreTools.Serialization/ObjectIdentifier/Parser.dot.cs @@ -15,7 +15,7 @@ namespace SabreTools.Data.ObjectIdentifier public static string? ParseOIDToDotNotation(ulong[]? values) { // If we have an invalid set of values, we can't do anything - if (values == null || values.Length == 0) + if (values is null || values.Length == 0) return null; var stringValues = Array.ConvertAll(values, v => v.ToString()); diff --git a/SabreTools.Serialization/OldDotNet.cs b/SabreTools.Serialization/OldDotNet.cs index c4ae3704..8a42b209 100644 --- a/SabreTools.Serialization/OldDotNet.cs +++ b/SabreTools.Serialization/OldDotNet.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization { public static void CopyTo(this Stream source, Stream destination) { - if (destination == null) + if (destination is null) { throw new ArgumentNullException("destination"); } diff --git a/SabreTools.Serialization/Printer.cs b/SabreTools.Serialization/Printer.cs index c664b2be..778689ae 100644 --- a/SabreTools.Serialization/Printer.cs +++ b/SabreTools.Serialization/Printer.cs @@ -16,7 +16,7 @@ namespace SabreTools.Serialization public static void PrintToConsole(this IWrapper wrapper) { var sb = ExportStringBuilder(wrapper); - if (sb == null) + if (sb is null) { Console.WriteLine("No item information could be generated"); return; diff --git a/SabreTools.Serialization/Readers/AACS.cs b/SabreTools.Serialization/Readers/AACS.cs index 461716d1..fe414bb3 100644 --- a/SabreTools.Serialization/Readers/AACS.cs +++ b/SabreTools.Serialization/Readers/AACS.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override MediaKeyBlock? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -27,7 +27,7 @@ namespace SabreTools.Serialization.Readers { // Try to parse the record var record = ParseRecord(data); - if (record == null) + if (record is null) continue; // Add the record diff --git a/SabreTools.Serialization/Readers/AbstractSyntaxNotationOne.cs b/SabreTools.Serialization/Readers/AbstractSyntaxNotationOne.cs index 5f9127df..54c47c91 100644 --- a/SabreTools.Serialization/Readers/AbstractSyntaxNotationOne.cs +++ b/SabreTools.Serialization/Readers/AbstractSyntaxNotationOne.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Readers public override TypeLengthValue[]? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -24,7 +24,7 @@ namespace SabreTools.Serialization.Readers while (data.Position < data.Length) { var topLevelValue = ParseTypeLengthValue(data); - if (topLevelValue == null) + if (topLevelValue is null) break; topLevelValues.Add(topLevelValue); @@ -62,7 +62,7 @@ namespace SabreTools.Serialization.Readers // Get the length of the value ulong? length = ReadLength(data); - if (length == null) + if (length is null) return null; // Set the length diff --git a/SabreTools.Serialization/Readers/AdvancedInstaller.cs b/SabreTools.Serialization/Readers/AdvancedInstaller.cs index 03f652b0..cdba348e 100644 --- a/SabreTools.Serialization/Readers/AdvancedInstaller.cs +++ b/SabreTools.Serialization/Readers/AdvancedInstaller.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override SFX? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -25,7 +25,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the footer from the data end var footer = ParseFooter(data, initialOffset); - if (footer == null) + if (footer is null) return null; if (footer.Signature != SignatureString) return null; diff --git a/SabreTools.Serialization/Readers/AppPkgHeader.cs b/SabreTools.Serialization/Readers/AppPkgHeader.cs index 17f913ea..d0b9449c 100644 --- a/SabreTools.Serialization/Readers/AppPkgHeader.cs +++ b/SabreTools.Serialization/Readers/AppPkgHeader.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.PlayStation4.AppPkgHeader? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/AttractMode.cs b/SabreTools.Serialization/Readers/AttractMode.cs index f534c85d..ccc183b8 100644 --- a/SabreTools.Serialization/Readers/AttractMode.cs +++ b/SabreTools.Serialization/Readers/AttractMode.cs @@ -22,7 +22,7 @@ namespace SabreTools.Serialization.Readers public override MetadataFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return default; try @@ -36,7 +36,7 @@ namespace SabreTools.Serialization.Readers var dat = new MetadataFile(); // Read the header values first - if (!reader.ReadHeader() || reader.HeaderValues == null) + if (!reader.ReadHeader() || reader.HeaderValues is null) return null; dat.Header = [.. reader.HeaderValues]; @@ -46,7 +46,7 @@ namespace SabreTools.Serialization.Readers while (!reader.EndOfStream) { // If we have no next line - if (!reader.ReadNextLine() || reader.Line == null) + if (!reader.ReadNextLine() || reader.Line is null) break; // Parse the line into a row diff --git a/SabreTools.Serialization/Readers/BDPlus.cs b/SabreTools.Serialization/Readers/BDPlus.cs index 8344347f..815ca639 100644 --- a/SabreTools.Serialization/Readers/BDPlus.cs +++ b/SabreTools.Serialization/Readers/BDPlus.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override SVM? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/BFPK.cs b/SabreTools.Serialization/Readers/BFPK.cs index bce46202..cce154ce 100644 --- a/SabreTools.Serialization/Readers/BFPK.cs +++ b/SabreTools.Serialization/Readers/BFPK.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Archive? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/BSP.cs b/SabreTools.Serialization/Readers/BSP.cs index 67c631bc..a3a15341 100644 --- a/SabreTools.Serialization/Readers/BSP.cs +++ b/SabreTools.Serialization/Readers/BSP.cs @@ -14,7 +14,7 @@ namespace SabreTools.Serialization.Readers public override BspFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -43,7 +43,7 @@ namespace SabreTools.Serialization.Readers { // Get the next lump entry var lumpEntry = header.Lumps![l]; - if (lumpEntry == null) + if (lumpEntry is null) continue; if (lumpEntry.Offset == 0 || lumpEntry.Length == 0) continue; diff --git a/SabreTools.Serialization/Readers/BaseBinaryDeserializer.cs b/SabreTools.Serialization/Readers/BaseBinaryDeserializer.cs index 64560773..c3291208 100644 --- a/SabreTools.Serialization/Readers/BaseBinaryDeserializer.cs +++ b/SabreTools.Serialization/Readers/BaseBinaryDeserializer.cs @@ -22,7 +22,7 @@ namespace SabreTools.Serialization.Readers public virtual TModel? Deserialize(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return default; // If the offset is out of bounds diff --git a/SabreTools.Serialization/Readers/CFB.cs b/SabreTools.Serialization/Readers/CFB.cs index aaffe807..5d4d9403 100644 --- a/SabreTools.Serialization/Readers/CFB.cs +++ b/SabreTools.Serialization/Readers/CFB.cs @@ -15,7 +15,7 @@ namespace SabreTools.Serialization.Readers public override Binary? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -76,7 +76,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the sectors var sectorNumbers = ParseSectorNumbers(data, fileHeader.SectorShift); - if (sectorNumbers == null) + if (sectorNumbers is null) return null; // Add all but the last sector number that was parsed @@ -124,7 +124,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the sectors var sectorNumbers = ParseSectorNumbers(data, fileHeader.SectorShift); - if (sectorNumbers == null) + if (sectorNumbers is null) return null; // Add the sector shifts @@ -160,7 +160,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the sectors var sectorNumbers = ParseSectorNumbers(data, fileHeader.SectorShift); - if (sectorNumbers == null) + if (sectorNumbers is null) return null; // Add the sector shifts @@ -215,7 +215,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the sectors var directoryEntries = ParseDirectoryEntries(data, fileHeader.SectorShift, fileHeader.MajorVersion); - if (directoryEntries == null) + if (directoryEntries is null) return null; // Add the sector shifts diff --git a/SabreTools.Serialization/Readers/CHD.cs b/SabreTools.Serialization/Readers/CHD.cs index 5edf9a8e..7489d583 100644 --- a/SabreTools.Serialization/Readers/CHD.cs +++ b/SabreTools.Serialization/Readers/CHD.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override Header? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/CIA.cs b/SabreTools.Serialization/Readers/CIA.cs index 36d72f0a..2050edeb 100644 --- a/SabreTools.Serialization/Readers/CIA.cs +++ b/SabreTools.Serialization/Readers/CIA.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.N3DS.CIA? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -52,7 +52,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < 3; i++) { var certificate = ParseCertificate(data); - if (certificate == null) + if (certificate is null) return null; cia.CertificateChain[i] = certificate; @@ -68,7 +68,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the ticket var ticket = ParseTicket(data); - if (ticket == null) + if (ticket is null) return null; // Set the ticket @@ -84,7 +84,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the title metadata var titleMetadata = ParseTitleMetadata(data); - if (titleMetadata == null) + if (titleMetadata is null) return null; // Set the title metadata @@ -352,7 +352,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < 2; i++) { var certificate = ParseCertificate(data); - if (certificate == null) + if (certificate is null) return null; obj.CertificateChain[i] = certificate; @@ -440,7 +440,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < 2; i++) { var certificate = ParseCertificate(data); - if (certificate == null) + if (certificate is null) return null; obj.CertificateChain[i] = certificate; diff --git a/SabreTools.Serialization/Readers/ClrMamePro.cs b/SabreTools.Serialization/Readers/ClrMamePro.cs index afa54a4b..9ea63df7 100644 --- a/SabreTools.Serialization/Readers/ClrMamePro.cs +++ b/SabreTools.Serialization/Readers/ClrMamePro.cs @@ -19,7 +19,7 @@ namespace SabreTools.Serialization.Readers public MetadataFile? Deserialize(byte[]? data, int offset, bool quotes) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return default; // If the offset is out of bounds @@ -71,7 +71,7 @@ namespace SabreTools.Serialization.Readers public MetadataFile? Deserialize(Stream? data, bool quotes) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -410,7 +410,7 @@ namespace SabreTools.Serialization.Readers /// Release object created from the reader context private static Release? CreateRelease(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var itemAdditional = new List(); @@ -450,7 +450,7 @@ namespace SabreTools.Serialization.Readers /// BiosSet object created from the reader context private static BiosSet? CreateBiosSet(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var biosset = new BiosSet(); @@ -480,7 +480,7 @@ namespace SabreTools.Serialization.Readers /// Rom object created from the reader context private static Rom? CreateRom(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var rom = new Rom(); @@ -582,7 +582,7 @@ namespace SabreTools.Serialization.Readers /// Disk object created from the reader context private static Disk? CreateDisk(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var disk = new Disk(); @@ -621,7 +621,7 @@ namespace SabreTools.Serialization.Readers /// Media object created from the reader context private static Media? CreateMedia(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var media = new Media(); @@ -657,7 +657,7 @@ namespace SabreTools.Serialization.Readers /// Sample object created from the reader context private static Sample? CreateSample(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var sample = new Sample(); @@ -681,7 +681,7 @@ namespace SabreTools.Serialization.Readers /// Archive object created from the reader context private static Archive? CreateArchive(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var archive = new Archive(); @@ -705,7 +705,7 @@ namespace SabreTools.Serialization.Readers /// Chip object created from the reader context private static Chip? CreateChip(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var chip = new Chip(); @@ -738,7 +738,7 @@ namespace SabreTools.Serialization.Readers /// Video object created from the reader context private static Video? CreateVideo(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var video = new Video(); @@ -780,7 +780,7 @@ namespace SabreTools.Serialization.Readers /// Sound object created from the reader context private static Sound? CreateSound(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var sound = new Sound(); @@ -804,7 +804,7 @@ namespace SabreTools.Serialization.Readers /// Input object created from the reader context private static Input? CreateInput(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var input = new Input(); @@ -843,7 +843,7 @@ namespace SabreTools.Serialization.Readers /// DipSwitch object created from the reader context private static DipSwitch? CreateDipSwitch(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var dipswitch = new DipSwitch(); @@ -875,7 +875,7 @@ namespace SabreTools.Serialization.Readers /// Driver object created from the reader context private static Driver? CreateDriver(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var driver = new Driver(); diff --git a/SabreTools.Serialization/Readers/CueSheet.cs b/SabreTools.Serialization/Readers/CueSheet.cs index e6a3e5db..bc755d6a 100644 --- a/SabreTools.Serialization/Readers/CueSheet.cs +++ b/SabreTools.Serialization/Readers/CueSheet.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.CueSheets.CueSheet? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -31,7 +31,7 @@ namespace SabreTools.Serialization.Readers lastLine = null; // If we have a null line, break from the loop - if (line == null) + if (line is null) break; // If we have an empty line, we skip @@ -123,7 +123,7 @@ namespace SabreTools.Serialization.Readers private static CueFile? CreateCueFile(string fileName, string fileType, StreamReader reader, out string? lastLine) { // Check the required parameters - if (reader == null || reader.BaseStream.Length == 0 || !reader.BaseStream.CanRead) + if (reader is null || reader.BaseStream.Length == 0 || !reader.BaseStream.CanRead) throw new ArgumentNullException(nameof(reader)); if (reader.BaseStream.Position < 0 || reader.BaseStream.Position >= reader.BaseStream.Length) throw new IndexOutOfRangeException(); @@ -138,7 +138,7 @@ namespace SabreTools.Serialization.Readers lastLine = null; // If we have a null line, break from the loop - if (line == null) + if (line is null) break; // If we have an empty line, we skip @@ -214,7 +214,7 @@ namespace SabreTools.Serialization.Readers private static CueTrack? CreateCueTrack(string number, string dataType, StreamReader reader, out string? lastLine) { // Check the required parameters - if (reader == null || reader.BaseStream.Length == 0 || !reader.BaseStream.CanRead) + if (reader is null || reader.BaseStream.Length == 0 || !reader.BaseStream.CanRead) throw new ArgumentNullException(nameof(reader)); if (reader.BaseStream.Position < 0 || reader.BaseStream.Position >= reader.BaseStream.Length) throw new IndexOutOfRangeException(); @@ -239,7 +239,7 @@ namespace SabreTools.Serialization.Readers lastLine = null; // If we have a null line, break from the loop - if (line == null) + if (line is null) break; // If we have an empty line, we skip @@ -532,7 +532,7 @@ namespace SabreTools.Serialization.Readers { // Read the next line string? line = reader.ReadLine(); - if (line == null) + if (line is null) break; // Count the number of quotes and append @@ -591,7 +591,7 @@ namespace SabreTools.Serialization.Readers private static CueTrackFlag GetFlags(string[]? flagStrings) { CueTrackFlag flag = 0; - if (flagStrings == null) + if (flagStrings is null) return flag; foreach (string? flagString in flagStrings) diff --git a/SabreTools.Serialization/Readers/DosCenter.cs b/SabreTools.Serialization/Readers/DosCenter.cs index cb2b806d..ca79fe13 100644 --- a/SabreTools.Serialization/Readers/DosCenter.cs +++ b/SabreTools.Serialization/Readers/DosCenter.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override MetadataFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -155,7 +155,7 @@ namespace SabreTools.Serialization.Readers /// File object created from the reader context private static Data.Models.DosCenter.File? CreateFile(ClrMameProReader reader) { - if (reader.Internal == null) + if (reader.Internal is null) return null; var file = new Data.Models.DosCenter.File(); diff --git a/SabreTools.Serialization/Readers/EverdriveSMDB.cs b/SabreTools.Serialization/Readers/EverdriveSMDB.cs index 6d8fcbee..43363cd9 100644 --- a/SabreTools.Serialization/Readers/EverdriveSMDB.cs +++ b/SabreTools.Serialization/Readers/EverdriveSMDB.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override MetadataFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -31,7 +31,7 @@ namespace SabreTools.Serialization.Readers while (!reader.EndOfStream) { // If we have no next line - if (!reader.ReadNextLine() || reader.Line == null) + if (!reader.ReadNextLine() || reader.Line is null) break; // If the next line has an invalid count diff --git a/SabreTools.Serialization/Readers/GCF.cs b/SabreTools.Serialization/Readers/GCF.cs index 285b8933..c386add7 100644 --- a/SabreTools.Serialization/Readers/GCF.cs +++ b/SabreTools.Serialization/Readers/GCF.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.GCF.File? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -310,7 +310,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the data block header var dataBlockHeader = ParseDataBlockHeader(data, header.MinorVersion); - if (dataBlockHeader == null) + if (dataBlockHeader is null) return null; // Set the game cache data block header diff --git a/SabreTools.Serialization/Readers/GZip.cs b/SabreTools.Serialization/Readers/GZip.cs index c6b10829..b5b0431f 100644 --- a/SabreTools.Serialization/Readers/GZip.cs +++ b/SabreTools.Serialization/Readers/GZip.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Archive? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -25,7 +25,7 @@ namespace SabreTools.Serialization.Readers #region Header var header = ParseHeader(data); - if (header == null) + if (header is null) return null; archive.Header = header; @@ -38,7 +38,7 @@ namespace SabreTools.Serialization.Readers #region Trailer var trailer = ParseTrailer(data); - if (trailer == null) + if (trailer is null) return null; archive.Trailer = trailer; @@ -93,7 +93,7 @@ namespace SabreTools.Serialization.Readers while (data.Position < currentPosition + obj.ExtraLength) { var extraField = ParseExtraFieldData(data); - if (extraField == null) + if (extraField is null) break; extraFields.Add(extraField); diff --git a/SabreTools.Serialization/Readers/Hashfile.cs b/SabreTools.Serialization/Readers/Hashfile.cs index ea20ebe0..a17acd3e 100644 --- a/SabreTools.Serialization/Readers/Hashfile.cs +++ b/SabreTools.Serialization/Readers/Hashfile.cs @@ -18,7 +18,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? Deserialize(byte[]? data, int offset, HashType hash) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -90,7 +90,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeSFV(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -105,7 +105,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; var sfv = new SFV @@ -137,7 +137,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeMD2(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -152,7 +152,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; // Parse the line into a hash @@ -181,7 +181,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeMD4(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -196,7 +196,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; // Parse the line into a hash @@ -225,7 +225,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeMD5(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; // Setup the reader and output @@ -238,7 +238,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; // Parse the line into a hash @@ -261,7 +261,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeRIPEMD128(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; // Setup the reader and output @@ -274,7 +274,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; // Parse the line into a hash @@ -297,7 +297,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeRIPEMD160(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; // Setup the reader and output @@ -310,7 +310,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; // Parse the line into a hash @@ -333,7 +333,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeSHA1(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -348,7 +348,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; // Parse the line into a hash @@ -377,7 +377,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeSHA256(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -392,7 +392,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; // Parse the line into a hash @@ -421,7 +421,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeSHA384(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -436,7 +436,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; // Parse the line into a hash @@ -465,7 +465,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeSHA512(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -480,7 +480,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; // Parse the line into a hash @@ -509,7 +509,7 @@ namespace SabreTools.Serialization.Readers public Data.Models.Hashfile.Hashfile? DeserializeSpamSum(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return default; try @@ -524,7 +524,7 @@ namespace SabreTools.Serialization.Readers // Read and split the line string? line = reader.ReadLine(); string[]? lineParts = line?.Split([' '], StringSplitOptions.RemoveEmptyEntries); - if (lineParts == null || lineParts.Length < 2) + if (lineParts is null || lineParts.Length < 2) continue; // Parse the line into a hash diff --git a/SabreTools.Serialization/Readers/IRD.cs b/SabreTools.Serialization/Readers/IRD.cs index ca792278..8da2daf5 100644 --- a/SabreTools.Serialization/Readers/IRD.cs +++ b/SabreTools.Serialization/Readers/IRD.cs @@ -10,7 +10,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.IRD.File? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/ISO9660.cs b/SabreTools.Serialization/Readers/ISO9660.cs index 72a71147..bc9e4fa5 100644 --- a/SabreTools.Serialization/Readers/ISO9660.cs +++ b/SabreTools.Serialization/Readers/ISO9660.cs @@ -17,7 +17,7 @@ namespace SabreTools.Serialization.Readers public Volume? Deserialize(Stream? data, short sectorLength) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; // Ensure the logical sector size is valid (2^n where n>=11) @@ -45,14 +45,14 @@ namespace SabreTools.Serialization.Readers // Parse the path table group(s) for each base volume descriptor var ptgs = ParsePathTableGroups(data, sectorLength, volume.VolumeDescriptorSet); - if (ptgs == null || ptgs.Length == 0) + if (ptgs is null || ptgs.Length == 0) return null; volume.PathTableGroups = ptgs; // Parse the root directory descriptor(s) for each base volume descriptor var dirs = ParseDirectoryDescriptors(data, sectorLength, volume.VolumeDescriptorSet); - if (dirs == null || dirs.Count == 0) + if (dirs is null || dirs.Count == 0) return null; volume.DirectoryDescriptors = dirs; @@ -84,7 +84,7 @@ namespace SabreTools.Serialization.Readers var volumeDescriptor = ParseVolumeDescriptor(data, sectorLength); // If no valid volume descriptor could be read, return the current set - if (volumeDescriptor == null) + if (volumeDescriptor is null) return [.. obj]; // If the set has already been terminated and the returned volume descriptor is not another terminator, @@ -601,7 +601,7 @@ namespace SabreTools.Serialization.Readers // Parse the root directory pointed to from the base volume descriptor var descriptors = ParseDirectory(data, sectorLength, blockLength, rootDirectoryRecord, false); - if (descriptors == null || descriptors.Count == 0) + if (descriptors is null || descriptors.Count == 0) continue; // Merge dictionaries @@ -703,7 +703,7 @@ namespace SabreTools.Serialization.Readers var directoryRecord = ParseDirectoryRecord(data, false); // Compare recordLength with number of bytes in directoryRecord and return null if mismatch - var readLength = 33 + directoryRecord.FileIdentifier.Length + (directoryRecord.PaddingField == null ? 0 : 1) + directoryRecord.SystemUse.Length; + var readLength = 33 + directoryRecord.FileIdentifier.Length + (directoryRecord.PaddingField is null ? 0 : 1) + directoryRecord.SystemUse.Length; if (readLength != recordLength) return null; @@ -725,7 +725,7 @@ namespace SabreTools.Serialization.Readers // Recursively parse child directory int sectorNum = record.ExtentLocation * blocksPerSector; var dir = ParseDirectory(data, sectorLength, blockLength, record, false); - if (dir == null) + if (dir is null) continue; // Add new directories to dictionary diff --git a/SabreTools.Serialization/Readers/InstallShieldArchiveV3.cs b/SabreTools.Serialization/Readers/InstallShieldArchiveV3.cs index a710e3ef..ab53c4a9 100644 --- a/SabreTools.Serialization/Readers/InstallShieldArchiveV3.cs +++ b/SabreTools.Serialization/Readers/InstallShieldArchiveV3.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Readers public override Archive? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/InstallShieldCabinet.cs b/SabreTools.Serialization/Readers/InstallShieldCabinet.cs index 96a9a6c8..71cf0b05 100644 --- a/SabreTools.Serialization/Readers/InstallShieldCabinet.cs +++ b/SabreTools.Serialization/Readers/InstallShieldCabinet.cs @@ -15,7 +15,7 @@ namespace SabreTools.Serialization.Readers public override Cabinet? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -211,7 +211,7 @@ namespace SabreTools.Serialization.Readers { // Get the offset OffsetList? list = kvp.Value; - if (list == null) + if (list is null) { fileGroupId++; continue; @@ -288,7 +288,7 @@ namespace SabreTools.Serialization.Readers { // Get the offset OffsetList? list = kvp.Value; - if (list == null) + if (list is null) { componentId++; continue; diff --git a/SabreTools.Serialization/Readers/InstallShieldExecutable.cs b/SabreTools.Serialization/Readers/InstallShieldExecutable.cs index 7b9037da..2daf9818 100644 --- a/SabreTools.Serialization/Readers/InstallShieldExecutable.cs +++ b/SabreTools.Serialization/Readers/InstallShieldExecutable.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Readers public override SFX? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -27,7 +27,7 @@ namespace SabreTools.Serialization.Readers { // Try to parse the entry var fileEntry = ParseFileEntry(data, initialOffset); - if (fileEntry == null) + if (fileEntry is null) break; // Get the length, and make sure it won't EOF @@ -60,7 +60,7 @@ namespace SabreTools.Serialization.Readers public static FileEntry? ParseFileEntry(Stream data, long initialOffset) { string? name = data.ReadNullTerminatedAnsiString(); - if (name == null) + if (name is null) return null; // Both of these strings indicate that this is a different kind of encrypted and/or compressed format of @@ -74,15 +74,15 @@ namespace SabreTools.Serialization.Readers return null; string? path = data.ReadNullTerminatedAnsiString(); - if (path == null) + if (path is null) return null; string? version = data.ReadNullTerminatedAnsiString(); - if (version == null) + if (version is null) return null; var lengthString = data.ReadNullTerminatedAnsiString(); - if (lengthString == null || !ulong.TryParse(lengthString, out var lengthValue)) + if (lengthString is null || !ulong.TryParse(lengthString, out var lengthValue)) return null; var obj = new FileEntry(); diff --git a/SabreTools.Serialization/Readers/JsonFile.cs b/SabreTools.Serialization/Readers/JsonFile.cs index be497e50..acf18b40 100644 --- a/SabreTools.Serialization/Readers/JsonFile.cs +++ b/SabreTools.Serialization/Readers/JsonFile.cs @@ -27,7 +27,7 @@ namespace SabreTools.Serialization.Readers public T? Deserialize(byte[]? data, int offset, Encoding encoding) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return default; // If the offset is out of bounds @@ -91,7 +91,7 @@ namespace SabreTools.Serialization.Readers public T? Deserialize(Stream? data, Encoding encoding) { // If the stream is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return default; try diff --git a/SabreTools.Serialization/Readers/LZKWAJ.cs b/SabreTools.Serialization/Readers/LZKWAJ.cs index 015f64f6..9c3bdaae 100644 --- a/SabreTools.Serialization/Readers/LZKWAJ.cs +++ b/SabreTools.Serialization/Readers/LZKWAJ.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override KWAJFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -27,7 +27,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the header var header = ParseHeader(data); - if (header == null) + if (header is null) return null; // Set the header diff --git a/SabreTools.Serialization/Readers/LZQBasic.cs b/SabreTools.Serialization/Readers/LZQBasic.cs index e2c8d89d..c11f829d 100644 --- a/SabreTools.Serialization/Readers/LZQBasic.cs +++ b/SabreTools.Serialization/Readers/LZQBasic.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override QBasicFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -27,7 +27,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the header var header = ParseHeader(data); - if (header == null) + if (header is null) return null; // Set the header diff --git a/SabreTools.Serialization/Readers/LZSZDD.cs b/SabreTools.Serialization/Readers/LZSZDD.cs index 81d5a606..1c70cf26 100644 --- a/SabreTools.Serialization/Readers/LZSZDD.cs +++ b/SabreTools.Serialization/Readers/LZSZDD.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override SZDDFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -27,7 +27,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the header var header = ParseHeader(data); - if (header == null) + if (header is null) return null; // Set the header diff --git a/SabreTools.Serialization/Readers/LinearExecutable.cs b/SabreTools.Serialization/Readers/LinearExecutable.cs index 0f437515..07fa4d76 100644 --- a/SabreTools.Serialization/Readers/LinearExecutable.cs +++ b/SabreTools.Serialization/Readers/LinearExecutable.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override Executable? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -28,7 +28,7 @@ namespace SabreTools.Serialization.Readers // Parse the MS-DOS stub var stub = new MSDOS().Deserialize(data); - if (stub?.Header == null || stub.Header.NewExeHeaderAddr == 0) + if (stub?.Header is null || stub.Header.NewExeHeaderAddr == 0) return null; // Set the MS-DOS stub @@ -188,7 +188,7 @@ namespace SabreTools.Serialization.Readers entryTable.Add(bundle); // If we have a 0-length entry - if (bundle == null || bundle.Entries == 0) + if (bundle is null || bundle.Entries == 0) break; } @@ -270,7 +270,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < executable.FixupRecordTable.Length; i++) { var entry = ParseFixupRecordTableEntry(data); - if (entry == null) + if (entry is null) return null; executable.FixupRecordTable[i] = entry; diff --git a/SabreTools.Serialization/Readers/Listrom.cs b/SabreTools.Serialization/Readers/Listrom.cs index dd4ee5cc..7fc45f7c 100644 --- a/SabreTools.Serialization/Readers/Listrom.cs +++ b/SabreTools.Serialization/Readers/Listrom.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override MetadataFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return default; try @@ -112,7 +112,7 @@ namespace SabreTools.Serialization.Readers // Read the name and set the rest of the line for processing string name = lineParts[0]; string trimmedLine = line.Substring(name.Length); - if (trimmedLine == null) + if (trimmedLine is null) continue; #if NETFRAMEWORK || NETCOREAPP3_1 || NETSTANDARD2_0_OR_GREATER diff --git a/SabreTools.Serialization/Readers/MSDOS.cs b/SabreTools.Serialization/Readers/MSDOS.cs index 5c5522eb..d95af8ff 100644 --- a/SabreTools.Serialization/Readers/MSDOS.cs +++ b/SabreTools.Serialization/Readers/MSDOS.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Executable? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/MicrosoftCabinet.cs b/SabreTools.Serialization/Readers/MicrosoftCabinet.cs index c1e48869..5fc20555 100644 --- a/SabreTools.Serialization/Readers/MicrosoftCabinet.cs +++ b/SabreTools.Serialization/Readers/MicrosoftCabinet.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Cabinet? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -27,7 +27,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the cabinet header var cabinetHeader = ParseCabinetHeader(data); - if (cabinetHeader == null) + if (cabinetHeader is null) return null; // Set the cabinet header @@ -44,7 +44,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < cabinetHeader.FolderCount; i++) { var folder = ParseFolder(data, cabinetHeader); - if (folder == null) + if (folder is null) return null; // Set the folder @@ -70,7 +70,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < cabinetHeader.FileCount; i++) { var file = ParseFile(data); - if (file == null) + if (file is null) return null; // Set the file diff --git a/SabreTools.Serialization/Readers/MoPaQ.cs b/SabreTools.Serialization/Readers/MoPaQ.cs index 0827485b..ae76838c 100644 --- a/SabreTools.Serialization/Readers/MoPaQ.cs +++ b/SabreTools.Serialization/Readers/MoPaQ.cs @@ -14,7 +14,7 @@ namespace SabreTools.Serialization.Readers public override Archive? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -52,7 +52,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the archive header var archiveHeader = ParseArchiveHeader(data); - if (archiveHeader == null) + if (archiveHeader is null) return null; // Set the archive header @@ -198,7 +198,7 @@ namespace SabreTools.Serialization.Readers 92, MPQ_KEY_BLOCK_TABLE, out _); - if (tableBytes == null) + if (tableBytes is null) return null; // Read in the BET table @@ -232,7 +232,7 @@ namespace SabreTools.Serialization.Readers entryCount * 16, MPQ_KEY_BLOCK_TABLE, out _); - if (tableBytes == null) + if (tableBytes is null) return null; // Read in the block table @@ -273,7 +273,7 @@ namespace SabreTools.Serialization.Readers entryCount * 16, MPQ_KEY_HASH_TABLE, out _); - if (tableBytes == null) + if (tableBytes is null) return null; // Read in the hash table @@ -311,7 +311,7 @@ namespace SabreTools.Serialization.Readers 44, MPQ_KEY_HASH_TABLE, out _); - if (tableBytes == null) + if (tableBytes is null) return null; // Read in the HET table diff --git a/SabreTools.Serialization/Readers/N3DS.cs b/SabreTools.Serialization/Readers/N3DS.cs index 46423539..e0c368ca 100644 --- a/SabreTools.Serialization/Readers/N3DS.cs +++ b/SabreTools.Serialization/Readers/N3DS.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override Cart? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -77,7 +77,7 @@ namespace SabreTools.Serialization.Readers // Handle the normal header var partition = ParseNCCHHeader(data); - if (partition == null || partition.MagicID != NCCHMagicNumber) + if (partition is null || partition.MagicID != NCCHMagicNumber) continue; // Set the normal header @@ -94,7 +94,7 @@ namespace SabreTools.Serialization.Readers data.SeekIfPossible(partitionOffset + offset, SeekOrigin.Begin); var exeFsHeader = ParseExeFSHeader(data); - if (exeFsHeader == null) + if (exeFsHeader is null) return null; cart.ExeFSHeaders[i] = exeFsHeader; diff --git a/SabreTools.Serialization/Readers/NCF.cs b/SabreTools.Serialization/Readers/NCF.cs index 0d0b031f..c31b8473 100644 --- a/SabreTools.Serialization/Readers/NCF.cs +++ b/SabreTools.Serialization/Readers/NCF.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.NCF.File? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/NewExecutable.cs b/SabreTools.Serialization/Readers/NewExecutable.cs index 5f2b9957..9b54ad0f 100644 --- a/SabreTools.Serialization/Readers/NewExecutable.cs +++ b/SabreTools.Serialization/Readers/NewExecutable.cs @@ -14,7 +14,7 @@ namespace SabreTools.Serialization.Readers public override Executable? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -29,7 +29,7 @@ namespace SabreTools.Serialization.Readers // Parse the MS-DOS stub var stub = new MSDOS().Deserialize(data); - if (stub?.Header == null || stub.Header.NewExeHeaderAddr == 0) + if (stub?.Header is null || stub.Header.NewExeHeaderAddr == 0) return null; // Set the MS-DOS stub @@ -425,7 +425,7 @@ namespace SabreTools.Serialization.Readers break; var record = ParseRelocationRecord(data); - if (record == null) + if (record is null) break; obj.RelocationRecords[i] = record; @@ -541,7 +541,7 @@ namespace SabreTools.Serialization.Readers foreach (var rtie in resourceTable.ResourceTypes) { // Skip invalid entries - if (rtie == null || rtie.TypeID == 0) + if (rtie is null || rtie.TypeID == 0) continue; // Handle offset types @@ -552,7 +552,7 @@ namespace SabreTools.Serialization.Readers foreach (var rtre in rtie.Resources) { // Skip invalid entries - if (rtre == null || rtre.IsIntegerType() || rtre.ResourceID == 0) + if (rtre is null || rtre.IsIntegerType() || rtre.ResourceID == 0) continue; // Skip already added entries diff --git a/SabreTools.Serialization/Readers/Nitro.cs b/SabreTools.Serialization/Readers/Nitro.cs index 50038fe3..6afe1c05 100644 --- a/SabreTools.Serialization/Readers/Nitro.cs +++ b/SabreTools.Serialization/Readers/Nitro.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Cart? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -329,7 +329,7 @@ namespace SabreTools.Serialization.Readers while (true) { var entry = ParseNameListEntry(data); - if (entry == null) + if (entry is null) break; nameList.Add(entry); diff --git a/SabreTools.Serialization/Readers/PAK.cs b/SabreTools.Serialization/Readers/PAK.cs index fedf986a..d3e7df7a 100644 --- a/SabreTools.Serialization/Readers/PAK.cs +++ b/SabreTools.Serialization/Readers/PAK.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.PAK.File? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/PFF.cs b/SabreTools.Serialization/Readers/PFF.cs index 9990ae57..4da598c6 100644 --- a/SabreTools.Serialization/Readers/PFF.cs +++ b/SabreTools.Serialization/Readers/PFF.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Archive? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/PIC.cs b/SabreTools.Serialization/Readers/PIC.cs index 9c5a1d44..99c24c4e 100644 --- a/SabreTools.Serialization/Readers/PIC.cs +++ b/SabreTools.Serialization/Readers/PIC.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override DiscInformation? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/PKZIP.cs b/SabreTools.Serialization/Readers/PKZIP.cs index 1ec2f679..2790e478 100644 --- a/SabreTools.Serialization/Readers/PKZIP.cs +++ b/SabreTools.Serialization/Readers/PKZIP.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override Archive? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -42,7 +42,7 @@ namespace SabreTools.Serialization.Readers // Central Directory File Header case CentralDirectoryFileHeaderSignature: var cdr = ParseCentralDirectoryFileHeader(data); - if (cdr == null) + if (cdr is null) return null; // Add the central directory record @@ -53,7 +53,7 @@ namespace SabreTools.Serialization.Readers // Local File case LocalFileHeaderSignature: var lf = ParseLocalFile(data); - if (lf == null) + if (lf is null) return null; // Add the local file @@ -68,7 +68,7 @@ namespace SabreTools.Serialization.Readers // End of Central Directory Record case EndOfCentralDirectoryRecordSignature: var eocdr = ParseEndOfCentralDirectoryRecord(data); - if (eocdr == null) + if (eocdr is null) return null; // Assign the end of central directory record @@ -79,7 +79,7 @@ namespace SabreTools.Serialization.Readers // ZIP64 End of Central Directory case EndOfCentralDirectoryRecord64Signature: var eocdr64 = ParseEndOfCentralDirectoryRecord64(data); - if (eocdr64 == null) + if (eocdr64 is null) return null; // Assign the ZIP64 end of central directory record @@ -90,7 +90,7 @@ namespace SabreTools.Serialization.Readers // ZIP64 End of Central Directory Locator case EndOfCentralDirectoryLocator64Signature: var eocdl64 = ParseEndOfCentralDirectoryLocator64(data); - if (eocdl64 == null) + if (eocdl64 is null) return null; // Assign the ZIP64 end of central directory record @@ -101,7 +101,7 @@ namespace SabreTools.Serialization.Readers // Archive Extra Data Record case ArchiveExtraDataRecordSignature: var aedr = ParseArchiveExtraDataRecord(data); - if (aedr == null) + if (aedr is null) return null; // Assign the archive extra data record @@ -411,7 +411,7 @@ namespace SabreTools.Serialization.Readers // Try to read the header var localFileHeader = ParseLocalFileHeader(data); - if (localFileHeader == null) + if (localFileHeader is null) return null; // Assign the header @@ -424,7 +424,7 @@ namespace SabreTools.Serialization.Readers { if (field is not Zip64ExtendedInformationExtraField infoField) continue; - if (infoField.CompressedSize == null) + if (infoField.CompressedSize is null) continue; compressedSize = infoField.CompressedSize.Value; @@ -505,14 +505,14 @@ namespace SabreTools.Serialization.Readers { obj.DataDescriptor = new DataDescriptor(); obj.ZIP64DataDescriptor = ParseDataDescriptor64(data); - if (obj.ZIP64DataDescriptor == null) + if (obj.ZIP64DataDescriptor is null) return null; } else { obj.DataDescriptor = ParseDataDescriptor(data); obj.ZIP64DataDescriptor = new DataDescriptor64(); - if (obj.DataDescriptor == null) + if (obj.DataDescriptor is null) return null; } @@ -583,7 +583,7 @@ namespace SabreTools.Serialization.Readers /// Array of data fields on success, null otherwise public static ExtensibleDataField[]? ParseExtraFields(CentralDirectoryFileHeader header, byte[]? data) { - if (data == null) + if (data is null) return null; List fields = []; @@ -674,7 +674,7 @@ namespace SabreTools.Serialization.Readers /// Array of data fields on success, null otherwise public static ExtensibleDataField[]? ParseExtraFields(LocalFileHeader header, byte[]? data) { - if (data == null) + if (data is null) return null; List fields = []; diff --git a/SabreTools.Serialization/Readers/PlayJAudio.cs b/SabreTools.Serialization/Readers/PlayJAudio.cs index a1aca991..b718249a 100644 --- a/SabreTools.Serialization/Readers/PlayJAudio.cs +++ b/SabreTools.Serialization/Readers/PlayJAudio.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override AudioFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -27,7 +27,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the audio header var audioHeader = ParseAudioHeader(data); - if (audioHeader == null) + if (audioHeader is null) return null; // Set the audio header @@ -55,7 +55,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the unknown block 1 var unknownBlock1 = ParseUnknownBlock1(data); - if (unknownBlock1 == null) + if (unknownBlock1 is null) return null; // Set the unknown block 1 @@ -109,7 +109,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the unknown block 3 var unknownBlock3 = ParseUnknownBlock3(data); - if (unknownBlock3 == null) + if (unknownBlock3 is null) return null; // Set the unknown block 3 @@ -141,7 +141,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < audioFile.DataFiles.Length; i++) { var dataFile = ParseDataFile(data); - if (dataFile == null) + if (dataFile is null) return null; audioFile.DataFiles[i] = dataFile; diff --git a/SabreTools.Serialization/Readers/PlayJPlaylist.cs b/SabreTools.Serialization/Readers/PlayJPlaylist.cs index 680dd50b..7b56df88 100644 --- a/SabreTools.Serialization/Readers/PlayJPlaylist.cs +++ b/SabreTools.Serialization/Readers/PlayJPlaylist.cs @@ -10,7 +10,7 @@ namespace SabreTools.Serialization.Readers public override Playlist? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -22,7 +22,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the playlist header var playlistHeader = ParsePlaylistHeader(data); - if (playlistHeader == null) + if (playlistHeader is null) return null; // Set the playlist header @@ -42,7 +42,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < playlist.AudioFiles.Length; i++) { var entryHeader = audioReader.Deserialize(data); - if (entryHeader == null) + if (entryHeader is null) continue; playlist.AudioFiles[i] = entryHeader; diff --git a/SabreTools.Serialization/Readers/PortableExecutable.cs b/SabreTools.Serialization/Readers/PortableExecutable.cs index 8afedbda..53ea882a 100644 --- a/SabreTools.Serialization/Readers/PortableExecutable.cs +++ b/SabreTools.Serialization/Readers/PortableExecutable.cs @@ -18,7 +18,7 @@ namespace SabreTools.Serialization.Readers public override Executable? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -33,7 +33,7 @@ namespace SabreTools.Serialization.Readers // Parse the MS-DOS stub var stub = new MSDOS().Deserialize(data); - if (stub?.Header == null || stub.Header.NewExeHeaderAddr == 0) + if (stub?.Header is null || stub.Header.NewExeHeaderAddr == 0) return null; // Set the MS-DOS stub @@ -61,7 +61,7 @@ namespace SabreTools.Serialization.Readers // Parse the file header var fileHeader = ParseFileHeader(data); - if (fileHeader == null) + if (fileHeader is null) return null; if (fileHeader.NumberOfSections > 96) return null; @@ -126,7 +126,7 @@ namespace SabreTools.Serialization.Readers #endregion // All tables require the optional header to exist - if (optionalHeader == null) + if (optionalHeader is null) return pex; #region Export Table @@ -231,7 +231,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < importDirectoryTable.Length; i++) { var entry = importDirectoryTable[i]; - if (entry == null) + if (entry is null) continue; long nameOffset = initialOffset + entry.NameRVA.ConvertVirtualAddress(pex.SectionTable); @@ -480,7 +480,7 @@ namespace SabreTools.Serialization.Readers /// Filled attribute certificate on success, null on error public static Data.Models.PortableExecutable.AttributeCertificate.Entry[]? ParseAttributeCertificateTable(byte[]? data) { - if (data == null) + if (data is null) return null; var obj = new List(); @@ -489,7 +489,7 @@ namespace SabreTools.Serialization.Readers while (offset < data.Length) { var entry = ParseAttributeCertificateTableEntry(data, ref offset); - if (entry == null) + if (entry is null) break; obj.Add(entry); @@ -568,7 +568,7 @@ namespace SabreTools.Serialization.Readers /// Filled base relocation table on success, null on error public static Data.Models.PortableExecutable.BaseRelocation.Block[]? ParseBaseRelocationTable(byte[]? data) { - if (data == null) + if (data is null) return null; var obj = new List(); @@ -577,7 +577,7 @@ namespace SabreTools.Serialization.Readers while (offset + 8 <= data.Length) { var block = ParseBaseRelocationBlock(data, ref offset); - if (block == null) + if (block is null) break; obj.Add(block); @@ -670,7 +670,7 @@ namespace SabreTools.Serialization.Readers /// Filled DebugTable on success, null on error public static Data.Models.PortableExecutable.DebugData.Table? ParseDebugTable(byte[]? data) { - if (data == null) + if (data is null) return null; var obj = new Data.Models.PortableExecutable.DebugData.Table(); @@ -702,7 +702,7 @@ namespace SabreTools.Serialization.Readers /// Filled DelayLoadDirectoryTable on success, null on error public static Data.Models.PortableExecutable.DelayLoad.DirectoryTable? ParseDelayLoadDirectoryTable(byte[]? data) { - if (data == null) + if (data is null) return null; var obj = new Data.Models.PortableExecutable.DelayLoad.DirectoryTable(); @@ -947,7 +947,7 @@ namespace SabreTools.Serialization.Readers var addresses = new List(); foreach (var kvp in importLookupTables) { - if (kvp.Value == null || kvp.Value.Length == 0) + if (kvp.Value is null || kvp.Value.Length == 0) continue; var vaddrs = Array.ConvertAll(kvp.Value, @@ -964,7 +964,7 @@ namespace SabreTools.Serialization.Readers var addresses = new List(); foreach (var kvp in importAddressTables) { - if (kvp.Value == null || kvp.Value.Length == 0) + if (kvp.Value is null || kvp.Value.Length == 0) continue; var vaddrs = Array.ConvertAll(kvp.Value, @@ -1443,9 +1443,9 @@ namespace SabreTools.Serialization.Readers Data.Models.PortableExecutable.Resource.DirectoryTable? table, SectionHeader[] sections) { - if (tableData == null) + if (tableData is null) return; - if (table?.Entries == null) + if (table?.Entries is null) return; foreach (var entry in table.Entries) @@ -1562,7 +1562,7 @@ namespace SabreTools.Serialization.Readers /// Filled ResourceDirectoryTable on success, null on error public static Data.Models.PortableExecutable.Resource.DirectoryTable? ParseResourceDirectoryTable(byte[]? tableData, ref int offset) { - if (tableData == null) + if (tableData is null) return null; var obj = new Data.Models.PortableExecutable.Resource.DirectoryTable(); diff --git a/SabreTools.Serialization/Readers/Quantum.cs b/SabreTools.Serialization/Readers/Quantum.cs index 80350de3..3c2c18e8 100644 --- a/SabreTools.Serialization/Readers/Quantum.cs +++ b/SabreTools.Serialization/Readers/Quantum.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Archive? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/RomCenter.cs b/SabreTools.Serialization/Readers/RomCenter.cs index db54ba3d..e93470ca 100644 --- a/SabreTools.Serialization/Readers/RomCenter.cs +++ b/SabreTools.Serialization/Readers/RomCenter.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override MetadataFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/SFB.cs b/SabreTools.Serialization/Readers/SFB.cs index 2afaccbb..c849630e 100644 --- a/SabreTools.Serialization/Readers/SFB.cs +++ b/SabreTools.Serialization/Readers/SFB.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.PlayStation3.SFB? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/SFO.cs b/SabreTools.Serialization/Readers/SFO.cs index 4ba34066..2ab6827d 100644 --- a/SabreTools.Serialization/Readers/SFO.cs +++ b/SabreTools.Serialization/Readers/SFO.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.PlayStation3.SFO? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/SGA.cs b/SabreTools.Serialization/Readers/SGA.cs index 04a8de52..9756d6fb 100644 --- a/SabreTools.Serialization/Readers/SGA.cs +++ b/SabreTools.Serialization/Readers/SGA.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override Archive? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -28,7 +28,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the header var header = ParseHeader(data); - if (header == null) + if (header is null) return null; // Set the SGA header @@ -40,7 +40,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the directory var directory = ParseDirectory(data, header.MajorVersion); - if (directory == null) + if (directory is null) return null; // Set the SGA directory @@ -150,7 +150,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the directory header var directoryHeader = ParseDirectory4Header(data); - if (directoryHeader == null) + if (directoryHeader is null) return null; // Set the directory header @@ -262,7 +262,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < directory.Folders.Length; i++) { var folder = directory.Folders[i]; - if (folder == null) + if (folder is null) continue; folder.Name = directory.StringTable[folder.NameOffset]; @@ -272,7 +272,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < directory.Files.Length; i++) { var file = directory.Files[i]; - if (file == null) + if (file is null) continue; file.Name = directory.StringTable[file.NameOffset]; @@ -299,7 +299,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the directory header var directoryHeader = ParseDirectory5Header(data); - if (directoryHeader == null) + if (directoryHeader is null) return null; // Set the directory header @@ -408,7 +408,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < directory.Folders.Length; i++) { var folder = directory.Folders[i]; - if (folder == null) + if (folder is null) continue; folder.Name = directory.StringTable[folder.NameOffset]; @@ -418,7 +418,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < directory.Files.Length; i++) { var file = directory.Files[i]; - if (file == null) + if (file is null) continue; file.Name = directory.StringTable[file.NameOffset]; @@ -445,7 +445,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the directory header var directoryHeader = ParseDirectory5Header(data); - if (directoryHeader == null) + if (directoryHeader is null) return null; // Set the directory header @@ -554,7 +554,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < directory.Folders.Length; i++) { var folder = directory.Folders[i]; - if (folder == null) + if (folder is null) continue; folder.Name = directory.StringTable[folder.NameOffset]; @@ -564,7 +564,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < directory.Files.Length; i++) { var file = directory.Files[i]; - if (file == null) + if (file is null) continue; file.Name = directory.StringTable[file.NameOffset]; @@ -591,7 +591,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the directory header var directoryHeader = ParseDirectory7Header(data); - if (directoryHeader == null) + if (directoryHeader is null) return null; // Set the directory header @@ -700,7 +700,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < directory.Folders.Length; i++) { var folder = directory.Folders[i]; - if (folder == null) + if (folder is null) continue; folder.Name = directory.StringTable[folder.NameOffset]; @@ -710,7 +710,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < directory.Files.Length; i++) { var file = directory.Files[i]; - if (file == null) + if (file is null) continue; file.Name = directory.StringTable[file.NameOffset]; diff --git a/SabreTools.Serialization/Readers/SecuROMAddD.cs b/SabreTools.Serialization/Readers/SecuROMAddD.cs index c593438a..572d8544 100644 --- a/SabreTools.Serialization/Readers/SecuROMAddD.cs +++ b/SabreTools.Serialization/Readers/SecuROMAddD.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override AddD? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/SecuROMDFA.cs b/SabreTools.Serialization/Readers/SecuROMDFA.cs index e174d711..ebd66984 100644 --- a/SabreTools.Serialization/Readers/SecuROMDFA.cs +++ b/SabreTools.Serialization/Readers/SecuROMDFA.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override DFAFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/SecuROMMatroschkaPackage.cs b/SabreTools.Serialization/Readers/SecuROMMatroschkaPackage.cs index a51f29a0..0dc05e41 100644 --- a/SabreTools.Serialization/Readers/SecuROMMatroschkaPackage.cs +++ b/SabreTools.Serialization/Readers/SecuROMMatroschkaPackage.cs @@ -14,7 +14,7 @@ namespace SabreTools.Serialization.Readers public override MatroshkaPackage? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -24,7 +24,7 @@ namespace SabreTools.Serialization.Readers // Try to parse the header var package = ParseMatroshkaPackage(data); - if (package == null) + if (package is null) return null; // Try to parse the entries @@ -113,7 +113,7 @@ namespace SabreTools.Serialization.Readers entry.Offset = data.ReadUInt32LittleEndian(); // On the first entry, determine if the unknown value exists - if (hasUnknown == null) + if (hasUnknown is null) { tempPosition = data.Position; tempValue = data.ReadUInt32LittleEndian(); diff --git a/SabreTools.Serialization/Readers/SeparatedValue.cs b/SabreTools.Serialization/Readers/SeparatedValue.cs index a7d9066f..b65e5334 100644 --- a/SabreTools.Serialization/Readers/SeparatedValue.cs +++ b/SabreTools.Serialization/Readers/SeparatedValue.cs @@ -26,7 +26,7 @@ namespace SabreTools.Serialization.Readers public MetadataFile? Deserialize(byte[]? data, int offset, char delim) { // If the data is invalid - if (data == null) + if (data is null) return null; // If the offset is out of bounds @@ -78,7 +78,7 @@ namespace SabreTools.Serialization.Readers public MetadataFile? Deserialize(Stream? data, char delim) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -93,7 +93,7 @@ namespace SabreTools.Serialization.Readers var dat = new MetadataFile(); // Read the header values first - if (!reader.ReadHeader() || reader.HeaderValues == null) + if (!reader.ReadHeader() || reader.HeaderValues is null) return null; dat.Header = [.. reader.HeaderValues]; @@ -103,7 +103,7 @@ namespace SabreTools.Serialization.Readers while (!reader.EndOfStream) { // If we have no next line - if (!reader.ReadNextLine() || reader.Line == null) + if (!reader.ReadNextLine() || reader.Line is null) break; // Parse the line into a row diff --git a/SabreTools.Serialization/Readers/SpoonInstaller.cs b/SabreTools.Serialization/Readers/SpoonInstaller.cs index 51ddcdc7..58cb8c4f 100644 --- a/SabreTools.Serialization/Readers/SpoonInstaller.cs +++ b/SabreTools.Serialization/Readers/SpoonInstaller.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Readers public override SFX? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/TapeArchive.cs b/SabreTools.Serialization/Readers/TapeArchive.cs index bd6e0486..808c0f85 100644 --- a/SabreTools.Serialization/Readers/TapeArchive.cs +++ b/SabreTools.Serialization/Readers/TapeArchive.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override Archive? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -28,7 +28,7 @@ namespace SabreTools.Serialization.Readers while (data.Position < data.Length) { var entry = ParseEntry(data); - if (entry == null) + if (entry is null) break; entries.Add(entry); @@ -62,7 +62,7 @@ namespace SabreTools.Serialization.Readers #region Header var header = ParseHeader(data); - if (header == null) + if (header is null) return null; obj.Header = header; @@ -88,7 +88,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < blocks.Length; i++) { var block = ParseBlock(data); - if (block == null) + if (block is null) break; blocks[i] = block; diff --git a/SabreTools.Serialization/Readers/VBSP.cs b/SabreTools.Serialization/Readers/VBSP.cs index 77b77fbb..41cb1a72 100644 --- a/SabreTools.Serialization/Readers/VBSP.cs +++ b/SabreTools.Serialization/Readers/VBSP.cs @@ -15,7 +15,7 @@ namespace SabreTools.Serialization.Readers public override VbspFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -34,7 +34,7 @@ namespace SabreTools.Serialization.Readers return null; if (Array.IndexOf([17, 18, 19, 20, 21, 22, 23, 25, 27, 29, 0x00040014], header.Version) > -1) return null; - if (header.Lumps == null || header.Lumps.Length != VBSP_HEADER_LUMPS) + if (header.Lumps is null || header.Lumps.Length != VBSP_HEADER_LUMPS) return null; // Set the package header @@ -48,7 +48,7 @@ namespace SabreTools.Serialization.Readers { // Get the next lump entry var lumpEntry = header.Lumps[l]; - if (lumpEntry == null) + if (lumpEntry is null) continue; if (lumpEntry.Offset == 0 || lumpEntry.Length == 0) continue; @@ -393,7 +393,7 @@ namespace SabreTools.Serialization.Readers while (data.Position < offset + length) { var vertex = data.ReadType(); - if (vertex == null) + if (vertex is null) break; vertices.Add(vertex); diff --git a/SabreTools.Serialization/Readers/VPK.cs b/SabreTools.Serialization/Readers/VPK.cs index 1995f21a..7b8bf42e 100644 --- a/SabreTools.Serialization/Readers/VPK.cs +++ b/SabreTools.Serialization/Readers/VPK.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.VPK.File? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/WAD3.cs b/SabreTools.Serialization/Readers/WAD3.cs index 63e66d38..869e7020 100644 --- a/SabreTools.Serialization/Readers/WAD3.cs +++ b/SabreTools.Serialization/Readers/WAD3.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.WAD3.File? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -61,7 +61,7 @@ namespace SabreTools.Serialization.Readers for (int i = 0; i < header.NumDirs; i++) { var dirEntry = file.DirEntries[i]; - if (dirEntry == null) + if (dirEntry is null) continue; // TODO: Handle compressed entries diff --git a/SabreTools.Serialization/Readers/WiseOverlayHeader.cs b/SabreTools.Serialization/Readers/WiseOverlayHeader.cs index 5cd0bc1c..6bc104c1 100644 --- a/SabreTools.Serialization/Readers/WiseOverlayHeader.cs +++ b/SabreTools.Serialization/Readers/WiseOverlayHeader.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override OverlayHeader? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/WiseScript.cs b/SabreTools.Serialization/Readers/WiseScript.cs index 87937a61..94338cbf 100644 --- a/SabreTools.Serialization/Readers/WiseScript.cs +++ b/SabreTools.Serialization/Readers/WiseScript.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override ScriptFile? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -33,7 +33,7 @@ namespace SabreTools.Serialization.Readers #region State Machine var states = ParseStateMachine(data, header); - if (states == null) + if (states is null) return null; script.States = states; @@ -156,7 +156,7 @@ namespace SabreTools.Serialization.Readers while (true) { string? str = data.ReadNullTerminatedAnsiString(); - if (str == null) + if (str is null) break; // Try to handle invalid string lengths @@ -270,7 +270,7 @@ namespace SabreTools.Serialization.Readers }; // If an error is detected, try parsing with flipped short DLL call values - if (stateData == null) + if (stateData is null) { // If there has already been one switch, don't try again if (switched) @@ -799,7 +799,7 @@ namespace SabreTools.Serialization.Readers if (nextByte == 0x09) { var possible = ParseCallDllFunction(data, languageCount, shortDllCall); - op0x18skip = (possible.FunctionName == null || possible.FunctionName.Length == 0) ? 6 : 0; + op0x18skip = (possible.FunctionName is null || possible.FunctionName.Length == 0) ? 6 : 0; data.SeekIfPossible(current, SeekOrigin.Begin); } } diff --git a/SabreTools.Serialization/Readers/WiseSectionHeader.cs b/SabreTools.Serialization/Readers/WiseSectionHeader.cs index 1c12f91f..f971ff13 100644 --- a/SabreTools.Serialization/Readers/WiseSectionHeader.cs +++ b/SabreTools.Serialization/Readers/WiseSectionHeader.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override SectionHeader? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -22,7 +22,7 @@ namespace SabreTools.Serialization.Readers long initialOffset = data.Position; var header = ParseSectionHeader(data, initialOffset); - if (header == null) + if (header is null) return null; // Main MSI file @@ -93,7 +93,7 @@ namespace SabreTools.Serialization.Readers obj.MsiFileEntryLength = data.ReadUInt32LittleEndian(); // If the reported header information is invalid - if (obj.Version == null) + if (obj.Version is null) return obj; if (wisOffset < 0) return obj; @@ -146,7 +146,7 @@ namespace SabreTools.Serialization.Readers // Try to read the string arrays // TODO: Count size of string section for later size verification byte[][]? stringArrays = ParseStringTable(data, obj.PreStringValues); - if (stringArrays == null) + if (stringArrays is null) return obj; // Set the string arrays @@ -173,7 +173,7 @@ namespace SabreTools.Serialization.Readers private static int GetPreStringBytesSize(Stream data, SectionHeader header, int wisOffset) { // Handle a case that shouldn't happen - if (header.Version == null) + if (header.Version is null) return 0; // TODO: better way to figure out how far it's needed to advance? @@ -248,7 +248,7 @@ namespace SabreTools.Serialization.Readers { byte[]? incrementBytes = data.ReadBytes(2); string? extraLanguageString = data.ReadNullTerminatedAnsiString(); - if (extraLanguageString == null) + if (extraLanguageString is null) return null; byte[]? extraLanguageStringArray = Encoding.ASCII.GetBytes(extraLanguageString); diff --git a/SabreTools.Serialization/Readers/XMID.cs b/SabreTools.Serialization/Readers/XMID.cs index 05628fd5..1b5013a4 100644 --- a/SabreTools.Serialization/Readers/XMID.cs +++ b/SabreTools.Serialization/Readers/XMID.cs @@ -31,7 +31,7 @@ namespace SabreTools.Serialization.Readers /// Filled XMID on success, null on error private static Data.Models.Xbox.XMID? ParseXMID(string? xmidString) { - if (xmidString == null || xmidString.Length != 8) + if (xmidString is null || xmidString.Length != 8) return null; var xmid = new Data.Models.Xbox.XMID(); diff --git a/SabreTools.Serialization/Readers/XZ.cs b/SabreTools.Serialization/Readers/XZ.cs index 05da9949..3098c027 100644 --- a/SabreTools.Serialization/Readers/XZ.cs +++ b/SabreTools.Serialization/Readers/XZ.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Readers public override Archive? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -67,7 +67,7 @@ namespace SabreTools.Serialization.Readers var index = ParseIndex(data); if (index.IndexIndicator != 0x00) return null; - if (index.Records == null) + if (index.Records is null) return null; // Set the index diff --git a/SabreTools.Serialization/Readers/XZP.cs b/SabreTools.Serialization/Readers/XZP.cs index 7bf8e7cb..57d2294d 100644 --- a/SabreTools.Serialization/Readers/XZP.cs +++ b/SabreTools.Serialization/Readers/XZP.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Readers public override Data.Models.XZP.File? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try diff --git a/SabreTools.Serialization/Readers/XeMID.cs b/SabreTools.Serialization/Readers/XeMID.cs index b3388fa8..af9e41e3 100644 --- a/SabreTools.Serialization/Readers/XeMID.cs +++ b/SabreTools.Serialization/Readers/XeMID.cs @@ -31,7 +31,7 @@ namespace SabreTools.Serialization.Readers /// Filled XeMID on success, null on error private static Data.Models.Xbox.XeMID? ParseXeMID(string? xemidString) { - if (xemidString == null) + if (xemidString is null) return null; if (!(xemidString.Length == 13 || xemidString.Length == 14 || xemidString.Length == 21 || xemidString.Length == 22)) return null; diff --git a/SabreTools.Serialization/Readers/XmlFile.cs b/SabreTools.Serialization/Readers/XmlFile.cs index 47d318cd..57b741fd 100644 --- a/SabreTools.Serialization/Readers/XmlFile.cs +++ b/SabreTools.Serialization/Readers/XmlFile.cs @@ -15,7 +15,7 @@ namespace SabreTools.Serialization.Readers public override T? Deserialize(Stream? data) { // If the stream is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return default; try diff --git a/SabreTools.Serialization/Readers/ZSTD.cs b/SabreTools.Serialization/Readers/ZSTD.cs index 18be9782..20243cce 100644 --- a/SabreTools.Serialization/Readers/ZSTD.cs +++ b/SabreTools.Serialization/Readers/ZSTD.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Readers public override Header? Deserialize(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -22,7 +22,7 @@ namespace SabreTools.Serialization.Readers #region Header var header = ParseHeader(data); - if (header == null) + if (header is null) return null; // Valid versions are 0x1E and 0x22-0x28. diff --git a/SabreTools.Serialization/WrapperFactory.cs b/SabreTools.Serialization/WrapperFactory.cs index d3e6934b..7f5eb490 100644 --- a/SabreTools.Serialization/WrapperFactory.cs +++ b/SabreTools.Serialization/WrapperFactory.cs @@ -75,7 +75,7 @@ namespace SabreTools.Serialization public static IWrapper? CreateExecutableWrapper(Stream? stream) { // If we have no stream - if (stream == null) + if (stream is null) return null; // Cache the current offset @@ -83,7 +83,7 @@ namespace SabreTools.Serialization // Try to get an MS-DOS wrapper first var wrapper = MSDOS.Create(stream); - if (wrapper == null || wrapper is not MSDOS msdos) + if (wrapper is null || wrapper is not MSDOS msdos) return null; // Check for a valid new executable address @@ -95,7 +95,7 @@ namespace SabreTools.Serialization var magic = stream.ReadBytes(4); // If we didn't get valid data at the offset - if (magic == null) + if (magic is null) { return wrapper; } @@ -133,7 +133,7 @@ namespace SabreTools.Serialization public static WrapperType GetFileType(byte[]? magic, string? extension) { // If we have an invalid magic byte array and extension - if (magic == null || magic.Length == 0 || extension == null) + if (magic is null || magic.Length == 0 || extension is null) return WrapperType.UNKNOWN; // Normalize the extension diff --git a/SabreTools.Serialization/Wrappers/AACSMediaKeyBlock.Printing.cs b/SabreTools.Serialization/Wrappers/AACSMediaKeyBlock.Printing.cs index a6d214d8..387169df 100644 --- a/SabreTools.Serialization/Wrappers/AACSMediaKeyBlock.Printing.cs +++ b/SabreTools.Serialization/Wrappers/AACSMediaKeyBlock.Printing.cs @@ -44,7 +44,7 @@ namespace SabreTools.Serialization.Wrappers private static void Print(StringBuilder builder, Record? record, int index) { builder.AppendLine($" Record Entry {index}"); - if (record == null) + if (record is null) { builder.AppendLine(" [NULL]"); return; diff --git a/SabreTools.Serialization/Wrappers/AACSMediaKeyBlock.cs b/SabreTools.Serialization/Wrappers/AACSMediaKeyBlock.cs index 6ae70ba0..d5f99a1b 100644 --- a/SabreTools.Serialization/Wrappers/AACSMediaKeyBlock.cs +++ b/SabreTools.Serialization/Wrappers/AACSMediaKeyBlock.cs @@ -78,7 +78,7 @@ namespace SabreTools.Serialization.Wrappers public static AACSMediaKeyBlock? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -98,7 +98,7 @@ namespace SabreTools.Serialization.Wrappers public static AACSMediaKeyBlock? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -107,7 +107,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.AACS().Deserialize(data); - if (model == null) + if (model is null) return null; return new AACSMediaKeyBlock(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/BDPlusSVM.cs b/SabreTools.Serialization/Wrappers/BDPlusSVM.cs index 29215926..3eb3c97f 100644 --- a/SabreTools.Serialization/Wrappers/BDPlusSVM.cs +++ b/SabreTools.Serialization/Wrappers/BDPlusSVM.cs @@ -54,7 +54,7 @@ namespace SabreTools.Serialization.Wrappers public static BDPlusSVM? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -74,7 +74,7 @@ namespace SabreTools.Serialization.Wrappers public static BDPlusSVM? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -83,7 +83,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.BDPlus().Deserialize(data); - if (model == null) + if (model is null) return null; return new BDPlusSVM(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/BFPK.Extraction.cs b/SabreTools.Serialization/Wrappers/BFPK.Extraction.cs index d4c26511..1701fa39 100644 --- a/SabreTools.Serialization/Wrappers/BFPK.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/BFPK.Extraction.cs @@ -10,7 +10,7 @@ namespace SabreTools.Serialization.Wrappers public bool Extract(string outputDirectory, bool includeDebug) { // If we have no files - if (Files == null || Files.Length == 0) + if (Files is null || Files.Length == 0) return false; // Loop through and extract all files to the output @@ -33,7 +33,7 @@ namespace SabreTools.Serialization.Wrappers public bool ExtractFile(int index, string outputDirectory, bool includeDebug) { // If we have no files - if (Files == null || Files.Length == 0) + if (Files is null || Files.Length == 0) return false; // If we have an invalid index @@ -42,7 +42,7 @@ namespace SabreTools.Serialization.Wrappers // Get the file information var file = Files[index]; - if (file == null) + if (file is null) return false; // Get the read index and length diff --git a/SabreTools.Serialization/Wrappers/BFPK.cs b/SabreTools.Serialization/Wrappers/BFPK.cs index 2bc366f7..7d4c54ce 100644 --- a/SabreTools.Serialization/Wrappers/BFPK.cs +++ b/SabreTools.Serialization/Wrappers/BFPK.cs @@ -52,7 +52,7 @@ namespace SabreTools.Serialization.Wrappers public static BFPK? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -72,7 +72,7 @@ namespace SabreTools.Serialization.Wrappers public static BFPK? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -81,7 +81,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.BFPK().Deserialize(data); - if (model == null) + if (model is null) return null; return new BFPK(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/BSP.Extraction.cs b/SabreTools.Serialization/Wrappers/BSP.Extraction.cs index 99ec1e2a..f786787c 100644 --- a/SabreTools.Serialization/Wrappers/BSP.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/BSP.Extraction.cs @@ -10,7 +10,7 @@ namespace SabreTools.Serialization.Wrappers public bool Extract(string outputDirectory, bool includeDebug) { // If we have no lumps - if (Lumps == null || Lumps.Length == 0) + if (Lumps is null || Lumps.Length == 0) return false; // Loop through and extract all lumps to the output @@ -33,7 +33,7 @@ namespace SabreTools.Serialization.Wrappers public bool ExtractLump(int index, string outputDirectory, bool includeDebug) { // If we have no lumps - if (Lumps == null || Lumps.Length == 0) + if (Lumps is null || Lumps.Length == 0) return false; // If the lumps index is invalid diff --git a/SabreTools.Serialization/Wrappers/BSP.Printing.cs b/SabreTools.Serialization/Wrappers/BSP.Printing.cs index e3a6a362..a86cbb8b 100644 --- a/SabreTools.Serialization/Wrappers/BSP.Printing.cs +++ b/SabreTools.Serialization/Wrappers/BSP.Printing.cs @@ -26,7 +26,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Header Information:"); builder.AppendLine(" -------------------------"); - if (header == null) + if (header is null) { builder.AppendLine(" No header"); builder.AppendLine(); @@ -41,7 +41,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Lumps Information:"); builder.AppendLine(" -------------------------"); - if (model?.Header?.Lumps == null || model.Header.Lumps.Length == 0) + if (model?.Header?.Lumps is null || model.Header.Lumps.Length == 0) { builder.AppendLine(" No lumps"); builder.AppendLine(); diff --git a/SabreTools.Serialization/Wrappers/BSP.cs b/SabreTools.Serialization/Wrappers/BSP.cs index 9b55f6cd..60af6e4a 100644 --- a/SabreTools.Serialization/Wrappers/BSP.cs +++ b/SabreTools.Serialization/Wrappers/BSP.cs @@ -52,7 +52,7 @@ namespace SabreTools.Serialization.Wrappers public static BSP? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -72,7 +72,7 @@ namespace SabreTools.Serialization.Wrappers public static BSP? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -81,7 +81,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.BSP().Deserialize(data); - if (model == null) + if (model is null) return null; return new BSP(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/BZip2.Extraction.cs b/SabreTools.Serialization/Wrappers/BZip2.Extraction.cs index e2e0e56b..718f5c8f 100644 --- a/SabreTools.Serialization/Wrappers/BZip2.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/BZip2.Extraction.cs @@ -14,7 +14,7 @@ namespace SabreTools.Serialization.Wrappers /// public bool Extract(string outputDirectory, bool includeDebug) { - if (_dataSource == null || !_dataSource.CanRead) + if (_dataSource is null || !_dataSource.CanRead) return false; try diff --git a/SabreTools.Serialization/Wrappers/BZip2.cs b/SabreTools.Serialization/Wrappers/BZip2.cs index a004c791..ffac0807 100644 --- a/SabreTools.Serialization/Wrappers/BZip2.cs +++ b/SabreTools.Serialization/Wrappers/BZip2.cs @@ -50,7 +50,7 @@ namespace SabreTools.Serialization.Wrappers public static BZip2? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -70,7 +70,7 @@ namespace SabreTools.Serialization.Wrappers public static BZip2? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; return new BZip2(new Archive(), data); diff --git a/SabreTools.Serialization/Wrappers/CDROM.cs b/SabreTools.Serialization/Wrappers/CDROM.cs index d9a9c2dc..63e627c4 100644 --- a/SabreTools.Serialization/Wrappers/CDROM.cs +++ b/SabreTools.Serialization/Wrappers/CDROM.cs @@ -45,7 +45,7 @@ namespace SabreTools.Serialization.Wrappers public new static CDROM? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -65,7 +65,7 @@ namespace SabreTools.Serialization.Wrappers public new static CDROM? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead || !data.CanSeek) + if (data is null || !data.CanRead || !data.CanSeek) return null; try @@ -78,7 +78,7 @@ namespace SabreTools.Serialization.Wrappers // Deserialize just the sub-stream var model = new Readers.ISO9660().Deserialize(userData); - if (model == null) + if (model is null) return null; // Reset stream diff --git a/SabreTools.Serialization/Wrappers/CFB.Extraction.cs b/SabreTools.Serialization/Wrappers/CFB.Extraction.cs index 3296e3da..f2f92639 100644 --- a/SabreTools.Serialization/Wrappers/CFB.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/CFB.Extraction.cs @@ -14,7 +14,7 @@ namespace SabreTools.Serialization.Wrappers public bool Extract(string outputDirectory, bool includeDebug) { // If we have no files - if (DirectoryEntries == null || DirectoryEntries.Length == 0) + if (DirectoryEntries is null || DirectoryEntries.Length == 0) return false; // Loop through and extract all directory entries to the output @@ -37,7 +37,7 @@ namespace SabreTools.Serialization.Wrappers public bool ExtractEntry(int index, string outputDirectory, bool includeDebug) { // If we have no entries - if (DirectoryEntries == null || DirectoryEntries.Length == 0) + if (DirectoryEntries is null || DirectoryEntries.Length == 0) return false; // If we have an invalid index @@ -46,7 +46,7 @@ namespace SabreTools.Serialization.Wrappers // Get the entry information var entry = DirectoryEntries[index]; - if (entry == null) + if (entry is null) return false; // Only try to extract stream objects @@ -55,7 +55,7 @@ namespace SabreTools.Serialization.Wrappers // Get the entry data byte[]? data = GetDirectoryEntryData(entry); - if (data == null) + if (data is null) return false; // If we have an invalid output directory @@ -110,7 +110,7 @@ namespace SabreTools.Serialization.Wrappers private byte[]? GetDirectoryEntryData(DirectoryEntry entry) { // If the CFB is invalid - if (Header == null) + if (Header is null) return null; // Only try to extract stream objects @@ -124,7 +124,7 @@ namespace SabreTools.Serialization.Wrappers var chain = miniFat ? GetMiniFATSectorChainData((SectorNumber)entry.StartingSectorLocation) : GetFATSectorChainData((SectorNumber)entry.StartingSectorLocation); - if (chain == null) + if (chain is null) return null; // Return only the proper amount of data diff --git a/SabreTools.Serialization/Wrappers/CFB.Printing.cs b/SabreTools.Serialization/Wrappers/CFB.Printing.cs index 0f095feb..a81ad28b 100644 --- a/SabreTools.Serialization/Wrappers/CFB.Printing.cs +++ b/SabreTools.Serialization/Wrappers/CFB.Printing.cs @@ -86,7 +86,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Directory Entries Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No directory entries"); builder.AppendLine(); diff --git a/SabreTools.Serialization/Wrappers/CFB.cs b/SabreTools.Serialization/Wrappers/CFB.cs index 59f36f91..c3068068 100644 --- a/SabreTools.Serialization/Wrappers/CFB.cs +++ b/SabreTools.Serialization/Wrappers/CFB.cs @@ -98,7 +98,7 @@ namespace SabreTools.Serialization.Wrappers public static CFB? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -118,7 +118,7 @@ namespace SabreTools.Serialization.Wrappers public static CFB? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -127,7 +127,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.CFB().Deserialize(data); - if (model == null) + if (model is null) return null; return new CFB(model, data, currentOffset); @@ -150,7 +150,7 @@ namespace SabreTools.Serialization.Wrappers public List? GetFATSectorChain(SectorNumber? startingSector) { // If we have an invalid sector - if (startingSector == null || startingSector < 0 || FATSectorNumbers == null || (long)startingSector >= FATSectorNumbers.Length) + if (startingSector is null || startingSector < 0 || FATSectorNumbers is null || (long)startingSector >= FATSectorNumbers.Length) return null; // Setup the returned list @@ -159,7 +159,7 @@ namespace SabreTools.Serialization.Wrappers var lastSector = startingSector; while (true) { - if (lastSector == null) + if (lastSector is null) break; // Get the next sector from the lookup table @@ -186,7 +186,7 @@ namespace SabreTools.Serialization.Wrappers { // Get the sector chain first var sectorChain = GetFATSectorChain(startingSector); - if (sectorChain == null) + if (sectorChain is null) return null; // Sequentially read the sectors @@ -218,7 +218,7 @@ namespace SabreTools.Serialization.Wrappers public long FATSectorToFileOffset(SectorNumber? sector) { // If we have an invalid sector number - if (sector == null || sector > SectorNumber.MAXREGSECT) + if (sector is null || sector > SectorNumber.MAXREGSECT) return -1; // Convert based on the sector shift value @@ -237,7 +237,7 @@ namespace SabreTools.Serialization.Wrappers public List? GetMiniFATSectorChain(SectorNumber? startingSector) { // If we have an invalid sector - if (startingSector == null || startingSector < 0 || MiniFATSectorNumbers == null || (long)startingSector >= MiniFATSectorNumbers.Length) + if (startingSector is null || startingSector < 0 || MiniFATSectorNumbers is null || (long)startingSector >= MiniFATSectorNumbers.Length) return null; // Setup the returned list @@ -246,7 +246,7 @@ namespace SabreTools.Serialization.Wrappers var lastSector = startingSector; while (true) { - if (lastSector == null) + if (lastSector is null) break; // Get the next sector from the lookup table @@ -272,12 +272,12 @@ namespace SabreTools.Serialization.Wrappers public byte[]? GetMiniFATSectorChainData(SectorNumber startingSector) { // Validate the mini stream data - if (MiniStreamData == null) + if (MiniStreamData is null) return null; // Get the sector chain var sectorChain = GetMiniFATSectorChain(startingSector); - if (sectorChain == null) + if (sectorChain is null) return null; // Sequentially read the sectors @@ -291,7 +291,7 @@ namespace SabreTools.Serialization.Wrappers // Try to read the sector data var sectorData = MiniStreamData.ReadBytes(ref streamDataOffset, (int)MiniSectorSize); - if (sectorData == null) + if (sectorData is null) return null; // Add the sector data to the output @@ -310,7 +310,7 @@ namespace SabreTools.Serialization.Wrappers public long MiniFATSectorToMiniStreamOffset(SectorNumber? sector) { // If we have an invalid sector number - if (sector == null || sector > SectorNumber.MAXREGSECT) + if (sector is null || sector > SectorNumber.MAXREGSECT) return -1; // Get the mini stream location diff --git a/SabreTools.Serialization/Wrappers/CHD.Printing.cs b/SabreTools.Serialization/Wrappers/CHD.Printing.cs index d7d15f22..6295eb4a 100644 --- a/SabreTools.Serialization/Wrappers/CHD.Printing.cs +++ b/SabreTools.Serialization/Wrappers/CHD.Printing.cs @@ -120,7 +120,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(header.Version, $"Version"); string compressorsLine = "Compressors: "; - if (header.Compressors == null) + if (header.Compressors is null) { compressorsLine += "[NULL]"; } diff --git a/SabreTools.Serialization/Wrappers/CHD.cs b/SabreTools.Serialization/Wrappers/CHD.cs index ad85edc8..e3512486 100644 --- a/SabreTools.Serialization/Wrappers/CHD.cs +++ b/SabreTools.Serialization/Wrappers/CHD.cs @@ -90,7 +90,7 @@ namespace SabreTools.Serialization.Wrappers public static CHD? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -110,7 +110,7 @@ namespace SabreTools.Serialization.Wrappers public static CHD? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -119,7 +119,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.CHD().Deserialize(data); - if (model == null) + if (model is null) return null; return new CHD(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/CIA.cs b/SabreTools.Serialization/Wrappers/CIA.cs index 395b35d1..62ae68b8 100644 --- a/SabreTools.Serialization/Wrappers/CIA.cs +++ b/SabreTools.Serialization/Wrappers/CIA.cs @@ -45,7 +45,7 @@ namespace SabreTools.Serialization.Wrappers public static CIA? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -65,7 +65,7 @@ namespace SabreTools.Serialization.Wrappers public static CIA? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -74,7 +74,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.CIA().Deserialize(data); - if (model == null) + if (model is null) return null; return new CIA(model, data, currentOffset); @@ -97,7 +97,7 @@ namespace SabreTools.Serialization.Wrappers /// public static bool IsDemo(Ticket? ticket) { - if (ticket?.Limits == null || ticket.Limits.Length == 0) + if (ticket?.Limits is null || ticket.Limits.Length == 0) return false; return ticket.Limits[0] == 0x0004; @@ -108,7 +108,7 @@ namespace SabreTools.Serialization.Wrappers /// public static uint PlayCount(Ticket ticket) { - if (ticket?.Limits == null || ticket.Limits.Length == 0) + if (ticket?.Limits is null || ticket.Limits.Length == 0) return 0; return ticket.Limits[1]; diff --git a/SabreTools.Serialization/Wrappers/GCF.Extraction.cs b/SabreTools.Serialization/Wrappers/GCF.Extraction.cs index 85fa7f27..ef6b746c 100644 --- a/SabreTools.Serialization/Wrappers/GCF.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/GCF.Extraction.cs @@ -10,7 +10,7 @@ namespace SabreTools.Serialization.Wrappers public bool Extract(string outputDirectory, bool includeDebug) { // If we have no files - if (Files == null || Files.Length == 0) + if (Files is null || Files.Length == 0) return false; // Loop through and extract all files to the output @@ -33,7 +33,7 @@ namespace SabreTools.Serialization.Wrappers public bool ExtractFile(int index, string outputDirectory, bool includeDebug) { // If we have no files - if (Files == null || Files.Length == 0 || DataBlockOffsets == null) + if (Files is null || Files.Length == 0 || DataBlockOffsets is null) return false; // If the files index is invalid @@ -42,7 +42,7 @@ namespace SabreTools.Serialization.Wrappers // Get the file var file = Files[index]; - if (file?.BlockEntries == null || file.Size == 0) + if (file?.BlockEntries is null || file.Size == 0) return false; // If the file is encrypted -- TODO: Revisit later diff --git a/SabreTools.Serialization/Wrappers/GCF.cs b/SabreTools.Serialization/Wrappers/GCF.cs index 52884904..f4a2f8c7 100644 --- a/SabreTools.Serialization/Wrappers/GCF.cs +++ b/SabreTools.Serialization/Wrappers/GCF.cs @@ -175,7 +175,7 @@ namespace SabreTools.Serialization.Wrappers public static GCF? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -195,7 +195,7 @@ namespace SabreTools.Serialization.Wrappers public static GCF? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -204,7 +204,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.GCF().Deserialize(data); - if (model == null) + if (model is null) return null; return new GCF(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/GZip.Extraction.cs b/SabreTools.Serialization/Wrappers/GZip.Extraction.cs index b93c7c2d..bab21d8d 100644 --- a/SabreTools.Serialization/Wrappers/GZip.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/GZip.Extraction.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Wrappers public bool Extract(string outputDirectory, bool includeDebug) { // Ensure there is data to extract - if (Header == null || DataOffset < 0) + if (Header is null || DataOffset < 0) { if (includeDebug) Console.Error.WriteLine("Invalid archive detected, skipping..."); return false; diff --git a/SabreTools.Serialization/Wrappers/GZip.Printing.cs b/SabreTools.Serialization/Wrappers/GZip.Printing.cs index 57ec33f0..dc63b335 100644 --- a/SabreTools.Serialization/Wrappers/GZip.Printing.cs +++ b/SabreTools.Serialization/Wrappers/GZip.Printing.cs @@ -45,7 +45,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Extra Fields:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No extra fields"); builder.AppendLine(); diff --git a/SabreTools.Serialization/Wrappers/GZip.cs b/SabreTools.Serialization/Wrappers/GZip.cs index 97e0f34b..b44d3191 100644 --- a/SabreTools.Serialization/Wrappers/GZip.cs +++ b/SabreTools.Serialization/Wrappers/GZip.cs @@ -156,7 +156,7 @@ namespace SabreTools.Serialization.Wrappers // - 0x14-0x1B - Little-endian file size of the internal file if (Header.ExtraLength != 0x1C) return false; - if (Header.ExtraFieldBytes == null || Header.ExtraFieldBytes.Length != 0x1C) + if (Header.ExtraFieldBytes is null || Header.ExtraFieldBytes.Length != 0x1C) return false; return true; @@ -201,7 +201,7 @@ namespace SabreTools.Serialization.Wrappers public static GZip? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -221,7 +221,7 @@ namespace SabreTools.Serialization.Wrappers public static GZip? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -230,7 +230,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.GZip().Deserialize(data); - if (model == null) + if (model is null) return null; return new GZip(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/IRD.cs b/SabreTools.Serialization/Wrappers/IRD.cs index 84ac88b3..e07ea20a 100644 --- a/SabreTools.Serialization/Wrappers/IRD.cs +++ b/SabreTools.Serialization/Wrappers/IRD.cs @@ -44,7 +44,7 @@ namespace SabreTools.Serialization.Wrappers public static IRD? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -64,7 +64,7 @@ namespace SabreTools.Serialization.Wrappers public static IRD? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -73,7 +73,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.IRD().Deserialize(data); - if (model == null) + if (model is null) return null; return new IRD(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/ISO9660.Printing.cs b/SabreTools.Serialization/Wrappers/ISO9660.Printing.cs index 5b30b5b8..2c2b96ed 100644 --- a/SabreTools.Serialization/Wrappers/ISO9660.Printing.cs +++ b/SabreTools.Serialization/Wrappers/ISO9660.Printing.cs @@ -319,7 +319,7 @@ namespace SabreTools.Serialization.Wrappers private static void Print(StringBuilder builder, PathTableRecord[]? records) { - if (records == null || records.Length == 0) + if (records is null || records.Length == 0) { builder.AppendLine(" No records"); builder.AppendLine(); @@ -446,7 +446,7 @@ namespace SabreTools.Serialization.Wrappers private static void Print(StringBuilder builder, ExtendedAttributeRecord? ear, Encoding encoding) { builder.AppendLine(" File Extent"); - if (ear == null) + if (ear is null) return; builder.AppendLineBothEndian(ear.OwnerIdentification, " Owner Identification"); diff --git a/SabreTools.Serialization/Wrappers/ISO9660.cs b/SabreTools.Serialization/Wrappers/ISO9660.cs index c0d153e2..81d54225 100644 --- a/SabreTools.Serialization/Wrappers/ISO9660.cs +++ b/SabreTools.Serialization/Wrappers/ISO9660.cs @@ -62,7 +62,7 @@ namespace SabreTools.Serialization.Wrappers public static ISO9660? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -82,7 +82,7 @@ namespace SabreTools.Serialization.Wrappers public static ISO9660? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -91,7 +91,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.ISO9660().Deserialize(data); - if (model == null) + if (model is null) return null; return new ISO9660(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/InstallShieldArchiveV3.Extraction.cs b/SabreTools.Serialization/Wrappers/InstallShieldArchiveV3.Extraction.cs index 64a758f6..2e04d847 100644 --- a/SabreTools.Serialization/Wrappers/InstallShieldArchiveV3.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/InstallShieldArchiveV3.Extraction.cs @@ -43,12 +43,12 @@ namespace SabreTools.Serialization.Wrappers // Get the file var file = Files[index]; - if (file == null) + if (file is null) return false; // Create the filename var filename = file.Name; - if (filename == null) + if (filename is null) return false; // Get the directory index diff --git a/SabreTools.Serialization/Wrappers/InstallShieldArchiveV3.cs b/SabreTools.Serialization/Wrappers/InstallShieldArchiveV3.cs index b421db34..4c315ff7 100644 --- a/SabreTools.Serialization/Wrappers/InstallShieldArchiveV3.cs +++ b/SabreTools.Serialization/Wrappers/InstallShieldArchiveV3.cs @@ -136,7 +136,7 @@ namespace SabreTools.Serialization.Wrappers public static InstallShieldArchiveV3? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -156,7 +156,7 @@ namespace SabreTools.Serialization.Wrappers public static InstallShieldArchiveV3? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -165,7 +165,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.InstallShieldArchiveV3().Deserialize(data); - if (model == null) + if (model is null) return null; return new InstallShieldArchiveV3(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/InstallShieldCabinet.Extraction.cs b/SabreTools.Serialization/Wrappers/InstallShieldCabinet.Extraction.cs index 03bde55d..18b6ab2d 100644 --- a/SabreTools.Serialization/Wrappers/InstallShieldCabinet.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/InstallShieldCabinet.Extraction.cs @@ -83,11 +83,11 @@ namespace SabreTools.Serialization.Wrappers else file = OpenFileForReading(pattern, i, CABINET_SUFFIX); - if (file == null) + if (file is null) break; var current = Create(file); - if (current == null) + if (current is null) break; current.VolumeID = i; @@ -122,7 +122,7 @@ namespace SabreTools.Serialization.Wrappers // Try to open the file as a stream volumeStream = OpenFileForReading(FilenamePattern, volumeId, CABINET_SUFFIX); - if (volumeStream == null) + if (volumeStream is null) { Console.Error.WriteLine($"Failed to open input cabinet file {volumeId}"); return null; @@ -130,7 +130,7 @@ namespace SabreTools.Serialization.Wrappers // Try to parse the stream into a cabinet var volume = Create(volumeStream); - if (volume == null) + if (volume is null) { Console.Error.WriteLine($"Failed to open input cabinet file {volumeId}"); return null; @@ -222,7 +222,7 @@ namespace SabreTools.Serialization.Wrappers } // If the cabinet set could not be opened - if (cabinet == null) + if (cabinet is null) return false; try @@ -271,7 +271,7 @@ namespace SabreTools.Serialization.Wrappers public bool FileSave(int index, string filename, bool includeDebug, bool useOld = false) { // Get the file descriptor - if (!TryGetFileDescriptor(index, out var fileDescriptor) || fileDescriptor == null) + if (!TryGetFileDescriptor(index, out var fileDescriptor) || fileDescriptor is null) return false; // If the file is split @@ -280,7 +280,7 @@ namespace SabreTools.Serialization.Wrappers // Get the reader at the index var reader = Reader.Create(this, index, fileDescriptor); - if (reader == null) + if (reader is null) return false; // Create the output file and hasher @@ -390,7 +390,7 @@ namespace SabreTools.Serialization.Wrappers expectedMd5 = expectedMd5.ToLowerInvariant().Replace("-", string.Empty); string? actualMd5 = md5.CurrentHashString; - if (actualMd5 == null || actualMd5 != expectedMd5) + if (actualMd5 is null || actualMd5 != expectedMd5) { Console.Error.WriteLine($"MD5 checksum failure for file {index} ({GetFileName(index)})"); return false; @@ -406,7 +406,7 @@ namespace SabreTools.Serialization.Wrappers public bool FileSaveRaw(int index, string filename) { // Get the file descriptor - if (!TryGetFileDescriptor(index, out var fileDescriptor) || fileDescriptor == null) + if (!TryGetFileDescriptor(index, out var fileDescriptor) || fileDescriptor is null) return false; // If the file is split @@ -415,7 +415,7 @@ namespace SabreTools.Serialization.Wrappers // Get the reader at the index var reader = Reader.Create(this, index, fileDescriptor); - if (reader == null) + if (reader is null) return false; // Create the output file @@ -662,7 +662,7 @@ namespace SabreTools.Serialization.Wrappers Console.Error.WriteLine($"Failed to open volume {fileDescriptor.Volume}"); return null; } - else if (reader._volumeFile == null || reader._volumeHeader == null) + else if (reader._volumeFile is null || reader._volumeHeader is null) { Console.Error.WriteLine($"Volume {fileDescriptor.Volume} is invalid"); return null; @@ -751,7 +751,7 @@ namespace SabreTools.Serialization.Wrappers { // Read the volume from the cabinet set var next = _cabinet.OpenVolume(volume, out var volumeStream); - if (next?.VolumeHeader == null || volumeStream == null) + if (next?.VolumeHeader is null || volumeStream is null) { Console.Error.WriteLine($"Failed to open input cabinet file {volume}"); return false; diff --git a/SabreTools.Serialization/Wrappers/InstallShieldCabinet.Printing.cs b/SabreTools.Serialization/Wrappers/InstallShieldCabinet.Printing.cs index b4ed8cd3..8298070e 100644 --- a/SabreTools.Serialization/Wrappers/InstallShieldCabinet.Printing.cs +++ b/SabreTools.Serialization/Wrappers/InstallShieldCabinet.Printing.cs @@ -238,7 +238,7 @@ namespace SabreTools.Serialization.Wrappers var value = kvp.Value; builder.AppendLine($" {name} Offset {offset}:"); - if (value == null) + if (value is null) { builder.AppendLine($" Unassigned {name.ToLowerInvariant()}"); continue; diff --git a/SabreTools.Serialization/Wrappers/InstallShieldCabinet.cs b/SabreTools.Serialization/Wrappers/InstallShieldCabinet.cs index 8047396c..c35286f0 100644 --- a/SabreTools.Serialization/Wrappers/InstallShieldCabinet.cs +++ b/SabreTools.Serialization/Wrappers/InstallShieldCabinet.cs @@ -99,7 +99,7 @@ namespace SabreTools.Serialization.Wrappers public static InstallShieldCabinet? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -119,7 +119,7 @@ namespace SabreTools.Serialization.Wrappers public static InstallShieldCabinet? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -128,7 +128,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.InstallShieldCabinet().Deserialize(data); - if (model == null) + if (model is null) return null; return new InstallShieldCabinet(model, data, currentOffset); @@ -148,14 +148,14 @@ namespace SabreTools.Serialization.Wrappers /// public string? GetComponentName(int index) { - if (Components == null) + if (Components is null) return null; if (index < 0 || index >= ComponentCount) return null; var component = Components[index]; - if (component?.Identifier == null) + if (component?.Identifier is null) return null; return component.Identifier.Replace('\\', '/'); @@ -202,7 +202,7 @@ namespace SabreTools.Serialization.Wrappers return false; FileDescriptor? descriptor = GetFileDescriptor(index); - if (descriptor == null) + if (descriptor is null) return false; if (descriptor.IsInvalid()) @@ -247,7 +247,7 @@ namespace SabreTools.Serialization.Wrappers public bool TryGetFileDescriptor(int index, out FileDescriptor? fileDescriptor) { fileDescriptor = GetFileDescriptor(index); - if (fileDescriptor == null) + if (fileDescriptor is null) { Console.Error.WriteLine($"Failed to get file descriptor for file {index}"); return false; @@ -268,7 +268,7 @@ namespace SabreTools.Serialization.Wrappers public string? GetFileName(int index) { var descriptor = GetFileDescriptor(index); - if (descriptor == null || descriptor.IsInvalid()) + if (descriptor is null || descriptor.IsInvalid()) return null; return descriptor.Name; @@ -279,7 +279,7 @@ namespace SabreTools.Serialization.Wrappers /// public static ulong GetReadableBytes(FileDescriptor? descriptor) { - if (descriptor == null) + if (descriptor is null) return 0; return descriptor.IsCompressed() @@ -292,7 +292,7 @@ namespace SabreTools.Serialization.Wrappers /// public static ulong GetWritableBytes(FileDescriptor? descriptor) { - if (descriptor == null) + if (descriptor is null) return 0; return descriptor.ExpandedSize; @@ -330,7 +330,7 @@ namespace SabreTools.Serialization.Wrappers for (int i = 0; i < FileGroupCount; i++) { var fileGroup = GetFileGroup(i); - if (fileGroup == null) + if (fileGroup is null) continue; if (fileGroup.FirstFile > index || fileGroup.LastFile < index) diff --git a/SabreTools.Serialization/Wrappers/InstallShieldExecutable.cs b/SabreTools.Serialization/Wrappers/InstallShieldExecutable.cs index c510c0b6..cac68723 100644 --- a/SabreTools.Serialization/Wrappers/InstallShieldExecutable.cs +++ b/SabreTools.Serialization/Wrappers/InstallShieldExecutable.cs @@ -52,7 +52,7 @@ namespace SabreTools.Serialization.Wrappers public static InstallShieldExecutable? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -72,7 +72,7 @@ namespace SabreTools.Serialization.Wrappers public static InstallShieldExecutable? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -81,7 +81,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.InstallShieldExecutable().Deserialize(data); - if (model == null) + if (model is null) return null; return new InstallShieldExecutable(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/LDSCRYPT.cs b/SabreTools.Serialization/Wrappers/LDSCRYPT.cs index 59e6533a..c35fde38 100644 --- a/SabreTools.Serialization/Wrappers/LDSCRYPT.cs +++ b/SabreTools.Serialization/Wrappers/LDSCRYPT.cs @@ -50,7 +50,7 @@ namespace SabreTools.Serialization.Wrappers public static LDSCRYPT? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -70,7 +70,7 @@ namespace SabreTools.Serialization.Wrappers public static LDSCRYPT? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; return new LDSCRYPT(new EncryptedFile(), data); diff --git a/SabreTools.Serialization/Wrappers/LZKWAJ.Extraction.cs b/SabreTools.Serialization/Wrappers/LZKWAJ.Extraction.cs index ac1165d6..f452737b 100644 --- a/SabreTools.Serialization/Wrappers/LZKWAJ.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/LZKWAJ.Extraction.cs @@ -21,7 +21,7 @@ namespace SabreTools.Serialization.Wrappers // Get the decompressor var decompressor = Decompressor.CreateKWAJ(contents, (ushort)CompressionType); - if (decompressor == null) + if (decompressor is null) return false; // If we have an invalid output directory diff --git a/SabreTools.Serialization/Wrappers/LZKWAJ.cs b/SabreTools.Serialization/Wrappers/LZKWAJ.cs index b37683fa..90e925f1 100644 --- a/SabreTools.Serialization/Wrappers/LZKWAJ.cs +++ b/SabreTools.Serialization/Wrappers/LZKWAJ.cs @@ -61,7 +61,7 @@ namespace SabreTools.Serialization.Wrappers public static LZKWAJ? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -81,7 +81,7 @@ namespace SabreTools.Serialization.Wrappers public static LZKWAJ? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -90,7 +90,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.LZKWAJ().Deserialize(data); - if (model == null) + if (model is null) return null; return new LZKWAJ(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/LZQBasic.Extraction.cs b/SabreTools.Serialization/Wrappers/LZQBasic.Extraction.cs index 3a2ba50f..f9e1c392 100644 --- a/SabreTools.Serialization/Wrappers/LZQBasic.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/LZQBasic.Extraction.cs @@ -21,7 +21,7 @@ namespace SabreTools.Serialization.Wrappers // Get the decompressor var decompressor = Decompressor.CreateQBasic(contents); - if (decompressor == null) + if (decompressor is null) return false; // If we have an invalid output directory diff --git a/SabreTools.Serialization/Wrappers/LZQBasic.cs b/SabreTools.Serialization/Wrappers/LZQBasic.cs index f76871bc..f8605e85 100644 --- a/SabreTools.Serialization/Wrappers/LZQBasic.cs +++ b/SabreTools.Serialization/Wrappers/LZQBasic.cs @@ -45,7 +45,7 @@ namespace SabreTools.Serialization.Wrappers public static LZQBasic? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -65,7 +65,7 @@ namespace SabreTools.Serialization.Wrappers public static LZQBasic? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -74,7 +74,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.LZQBasic().Deserialize(data); - if (model == null) + if (model is null) return null; return new LZQBasic(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/LZSZDD.Extraction.cs b/SabreTools.Serialization/Wrappers/LZSZDD.Extraction.cs index a1d22636..9205e6e5 100644 --- a/SabreTools.Serialization/Wrappers/LZSZDD.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/LZSZDD.Extraction.cs @@ -30,7 +30,7 @@ namespace SabreTools.Serialization.Wrappers // Get the decompressor var decompressor = Decompressor.CreateSZDD(contents); - if (decompressor == null) + if (decompressor is null) return false; // Create the output file diff --git a/SabreTools.Serialization/Wrappers/LZSZDD.cs b/SabreTools.Serialization/Wrappers/LZSZDD.cs index 12bfdc24..c0b5aca1 100644 --- a/SabreTools.Serialization/Wrappers/LZSZDD.cs +++ b/SabreTools.Serialization/Wrappers/LZSZDD.cs @@ -52,7 +52,7 @@ namespace SabreTools.Serialization.Wrappers public static LZSZDD? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -72,7 +72,7 @@ namespace SabreTools.Serialization.Wrappers public static LZSZDD? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -81,7 +81,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.LZSZDD().Deserialize(data); - if (model == null) + if (model is null) return null; return new LZSZDD(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/LinearExecutable.Printing.cs b/SabreTools.Serialization/Wrappers/LinearExecutable.Printing.cs index b26f75e4..35cf8301 100644 --- a/SabreTools.Serialization/Wrappers/LinearExecutable.Printing.cs +++ b/SabreTools.Serialization/Wrappers/LinearExecutable.Printing.cs @@ -312,7 +312,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Module Format Directives Table Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No module format directives table entries"); builder.AppendLine(); @@ -336,7 +336,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Verify Record Directive Table Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No verify record directive table entries"); builder.AppendLine(); @@ -590,7 +590,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(); builder.AppendLine(" Source Offset List:"); builder.AppendLine(" -------------------------"); - if (entry.SourceOffsetList == null || entry.SourceOffsetList.Length == 0) + if (entry.SourceOffsetList is null || entry.SourceOffsetList.Length == 0) { builder.AppendLine(" No source offset list entries"); } @@ -701,7 +701,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Debug Information:"); builder.AppendLine(" -------------------------"); - if (di == null) + if (di is null) { builder.AppendLine(" No debug information"); builder.AppendLine(); diff --git a/SabreTools.Serialization/Wrappers/LinearExecutable.cs b/SabreTools.Serialization/Wrappers/LinearExecutable.cs index c35ef588..abe8de63 100644 --- a/SabreTools.Serialization/Wrappers/LinearExecutable.cs +++ b/SabreTools.Serialization/Wrappers/LinearExecutable.cs @@ -96,7 +96,7 @@ namespace SabreTools.Serialization.Wrappers public static LinearExecutable? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -116,7 +116,7 @@ namespace SabreTools.Serialization.Wrappers public static LinearExecutable? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -125,7 +125,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.LinearExecutable().Deserialize(data); - if (model == null) + if (model is null) return null; return new LinearExecutable(model, data, currentOffset); @@ -148,7 +148,7 @@ namespace SabreTools.Serialization.Wrappers public ObjectPageMapEntry? GetObjectPageMapEntry(int index) { // If the object page map table is invalid - if (ObjectPageMap == null || ObjectPageMap.Length == 0) + if (ObjectPageMap is null || ObjectPageMap.Length == 0) return null; // If the index is invalid @@ -191,7 +191,7 @@ namespace SabreTools.Serialization.Wrappers { // Get the matching entry var entry = GetObjectPageMapEntry(index); - if (entry == null) + if (entry is null) return -1; // Return the reported length @@ -206,7 +206,7 @@ namespace SabreTools.Serialization.Wrappers public int GetObjectPageMapEntryOffset(int index) { // If the information block is invalid - if (InformationBlock == null) + if (InformationBlock is null) return -1; // Get the available source length, if possible @@ -216,7 +216,7 @@ namespace SabreTools.Serialization.Wrappers // Get the matching entry var entry = GetObjectPageMapEntry(index); - if (entry == null) + if (entry is null) return -1; // Verify the entry offset @@ -240,7 +240,7 @@ namespace SabreTools.Serialization.Wrappers public ResourceTableEntry? GetResourceTableEntry(int index) { // If the resource table table is invalid - if (ResourceTable == null || ResourceTable.Length == 0) + if (ResourceTable is null || ResourceTable.Length == 0) return null; // If the index is invalid @@ -260,7 +260,7 @@ namespace SabreTools.Serialization.Wrappers { // Get the entry var entry = GetResourceTableEntry(index); - if (entry == null) + if (entry is null) return null; // Get the entry offset @@ -277,7 +277,7 @@ namespace SabreTools.Serialization.Wrappers // Get the matching object data var objectData = GetObjectPageMapEntryData(entry.ObjectNumber); - if (objectData == null) + if (objectData is null) return null; // Read the entry data and return @@ -293,7 +293,7 @@ namespace SabreTools.Serialization.Wrappers { // Get the matching entry var entry = GetResourceTableEntry(index); - if (entry == null) + if (entry is null) return -1; // Return the reported length @@ -308,7 +308,7 @@ namespace SabreTools.Serialization.Wrappers public int GetResourceTableEntryOffset(int index) { // If the information block is invalid - if (InformationBlock == null) + if (InformationBlock is null) return -1; // Get the available source length, if possible @@ -318,7 +318,7 @@ namespace SabreTools.Serialization.Wrappers // Get the matching entry var entry = GetResourceTableEntry(index); - if (entry == null) + if (entry is null) return -1; // Get the matching object length diff --git a/SabreTools.Serialization/Wrappers/MSDOS.Printing.cs b/SabreTools.Serialization/Wrappers/MSDOS.Printing.cs index 66660f9d..25557e58 100644 --- a/SabreTools.Serialization/Wrappers/MSDOS.Printing.cs +++ b/SabreTools.Serialization/Wrappers/MSDOS.Printing.cs @@ -26,7 +26,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Header Information:"); builder.AppendLine(" -------------------------"); - if (header == null) + if (header is null) { builder.AppendLine(" No header"); builder.AppendLine(); diff --git a/SabreTools.Serialization/Wrappers/MSDOS.cs b/SabreTools.Serialization/Wrappers/MSDOS.cs index f8606cad..91ab27cf 100644 --- a/SabreTools.Serialization/Wrappers/MSDOS.cs +++ b/SabreTools.Serialization/Wrappers/MSDOS.cs @@ -45,7 +45,7 @@ namespace SabreTools.Serialization.Wrappers public static MSDOS? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -65,7 +65,7 @@ namespace SabreTools.Serialization.Wrappers public static MSDOS? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -74,7 +74,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.MSDOS().Deserialize(data); - if (model == null) + if (model is null) return null; return new MSDOS(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs b/SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs index f608da9a..48d750c4 100644 --- a/SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs @@ -47,7 +47,7 @@ namespace SabreTools.Serialization.Wrappers // Read in the current file and try to parse var stream = File.Open(filename, FileMode.Open, FileAccess.Read, FileShare.ReadWrite); var current = Create(stream); - if (current?.Header == null) + if (current?.Header is null) return null; // Seek to the first part of the cabinet set @@ -55,7 +55,7 @@ namespace SabreTools.Serialization.Wrappers { // Attempt to open the previous cabinet var prev = current.OpenPrevious(filename, includeDebug); - if (prev?.Header == null) + if (prev?.Header is null) break; // Assign previous as new current @@ -74,7 +74,7 @@ namespace SabreTools.Serialization.Wrappers // Open the next cabinet and try to parse var next = current.OpenNext(filename, includeDebug); - if (next?.Header == null) + if (next?.Header is null) break; // Add the next and previous links, resetting current @@ -176,7 +176,7 @@ namespace SabreTools.Serialization.Wrappers { // Open the full set if possible cabinet = OpenSet(Filename, includeDebug); - if (cabinet == null) + if (cabinet is null) { if (includeDebug) Console.WriteLine($"Cabinet set could not be opened!"); cabinet = this; @@ -284,7 +284,7 @@ namespace SabreTools.Serialization.Wrappers // Move to the next cabinet, if possible cabinet = cabinet.Next; - if (cabinet == null) // If the next cabinet is missing, there's no better way to handle this + if (cabinet is null) // If the next cabinet is missing, there's no better way to handle this return false; currentCabFilename = cabinet.Filename; @@ -445,7 +445,7 @@ namespace SabreTools.Serialization.Wrappers for (int j = 0; j < _folder.DataCount; j++) { var dataBlock = ReadBlock(includeDebug); - if (dataBlock == null) + if (dataBlock is null) { if (includeDebug) Console.Error.WriteLine($"Error extracting file {filename}"); return; @@ -458,7 +458,7 @@ namespace SabreTools.Serialization.Wrappers bool continuedBlock = false; if (dataBlock.UncompressedSize == 0) { - if (_cabinet.Next == null) + if (_cabinet.Next is null) break; // Next cab is missing, continue _cabinet = _cabinet.Next; @@ -467,7 +467,7 @@ namespace SabreTools.Serialization.Wrappers _folder = _cabinet.Folders[0]; _offset = _folder.CabStartOffset; var nextBlock = ReadBlock(includeDebug); - if (nextBlock == null) + if (nextBlock is null) { if (includeDebug) Console.Error.WriteLine($"Error extracting file {filename}"); return; @@ -519,7 +519,7 @@ namespace SabreTools.Serialization.Wrappers // If there are bytes left to write, and more bytes left to write than the length of the current data to be written. if (_bytesLeft > 0 && _bytesLeft >= data.Length) { - if (_fileStream == null) + if (_fileStream is null) return; _fileStream.Write(data); @@ -528,7 +528,7 @@ namespace SabreTools.Serialization.Wrappers else { long tempBytesLeft = _bytesLeft; - if (_fileStream == null) + if (_fileStream is null) return; // If there are still bytes left to write, but less bytes than the length of the current data to be written @@ -568,7 +568,7 @@ namespace SabreTools.Serialization.Wrappers /// True the end of the folder has been reached, false otherwise private bool EndFile(string outputDirectory) { - if (_fileStream == null) + if (_fileStream is null) return false; _fileStream.Close(); diff --git a/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs b/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs index c784f24b..fcad17db 100644 --- a/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs +++ b/SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs @@ -73,7 +73,7 @@ namespace SabreTools.Serialization.Wrappers public static MicrosoftCabinet? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -93,7 +93,7 @@ namespace SabreTools.Serialization.Wrappers public static MicrosoftCabinet? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -102,7 +102,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.MicrosoftCabinet().Deserialize(data); - if (model == null) + if (model is null) return null; return new MicrosoftCabinet(model, data, currentOffset); @@ -125,7 +125,7 @@ namespace SabreTools.Serialization.Wrappers public DateTime? GetDateTime(int fileIndex) { // If we have an invalid file index - if (fileIndex < 0 || Files == null || fileIndex >= Files.Length) + if (fileIndex < 0 || Files is null || fileIndex >= Files.Length) return null; // If we have an invalid DateTime @@ -274,7 +274,7 @@ namespace SabreTools.Serialization.Wrappers if (!skipPrev && spanPrev) { // Try to get Prev if it doesn't exist - if (Prev?.Header == null) + if (Prev?.Header is null) Prev = OpenPrevious(filename, includeDebug); // Get all files from Prev @@ -290,7 +290,7 @@ namespace SabreTools.Serialization.Wrappers if (!skipNext && spanNext) { // Try to get Next if it doesn't exist - if (Next?.Header == null) + if (Next?.Header is null) Next = OpenNext(filename); // Get all files from Prev @@ -314,7 +314,7 @@ namespace SabreTools.Serialization.Wrappers private CFFILE[] GetFiles(int folderIndex, bool ignorePrev = false) { // Ignore invalid archives - if (Files == null) + if (Files is null) return []; // Get all files with a name and matching index diff --git a/SabreTools.Serialization/Wrappers/MoPaQ.Extraction.cs b/SabreTools.Serialization/Wrappers/MoPaQ.Extraction.cs index 6b391126..e4d0a236 100644 --- a/SabreTools.Serialization/Wrappers/MoPaQ.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/MoPaQ.Extraction.cs @@ -19,7 +19,7 @@ namespace SabreTools.Serialization.Wrappers return false; } - if (Filename == null || !File.Exists(Filename)) + if (Filename is null || !File.Exists(Filename)) return false; // Try to open the archive and listfile diff --git a/SabreTools.Serialization/Wrappers/MoPaQ.Printing.cs b/SabreTools.Serialization/Wrappers/MoPaQ.Printing.cs index d8097f3c..e3a1c6c1 100644 --- a/SabreTools.Serialization/Wrappers/MoPaQ.Printing.cs +++ b/SabreTools.Serialization/Wrappers/MoPaQ.Printing.cs @@ -31,7 +31,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" User Data Information:"); builder.AppendLine(" -------------------------"); - if (userData == null) + if (userData is null) { builder.AppendLine(" No user data"); builder.AppendLine(); @@ -83,7 +83,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" HET Table Information:"); builder.AppendLine(" -------------------------"); - if (table == null) + if (table is null) { builder.AppendLine(" No HET table"); builder.AppendLine(); @@ -124,7 +124,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" BET Table Information:"); builder.AppendLine(" -------------------------"); - if (table == null) + if (table is null) { builder.AppendLine(" No BET table"); builder.AppendLine(); @@ -161,7 +161,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Hash Table Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No hash table items"); builder.AppendLine(); @@ -187,7 +187,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Block Table Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No block table items"); builder.AppendLine(); @@ -212,7 +212,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Hi-block Table Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No hi-block table items"); builder.AppendLine(); diff --git a/SabreTools.Serialization/Wrappers/MoPaQ.cs b/SabreTools.Serialization/Wrappers/MoPaQ.cs index 453aee86..9899e583 100644 --- a/SabreTools.Serialization/Wrappers/MoPaQ.cs +++ b/SabreTools.Serialization/Wrappers/MoPaQ.cs @@ -73,7 +73,7 @@ namespace SabreTools.Serialization.Wrappers public static MoPaQ? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -93,7 +93,7 @@ namespace SabreTools.Serialization.Wrappers public static MoPaQ? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -102,7 +102,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.MoPaQ().Deserialize(data); - if (model == null) + if (model is null) return null; return new MoPaQ(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/N3DS.Encryption.cs b/SabreTools.Serialization/Wrappers/N3DS.Encryption.cs index 09476b04..9946b7b2 100644 --- a/SabreTools.Serialization/Wrappers/N3DS.Encryption.cs +++ b/SabreTools.Serialization/Wrappers/N3DS.Encryption.cs @@ -10,13 +10,13 @@ namespace SabreTools.Serialization.Wrappers /// public byte[] ExeFSIV(int index) { - if (Partitions == null) + if (Partitions is null) return []; if (index < 0 || index >= Partitions.Length) return []; var header = Partitions[index]; - if (header == null || header.MagicID != NCCHMagicNumber) + if (header is null || header.MagicID != NCCHMagicNumber) return []; byte[] partitionIdBytes = BitConverter.GetBytes(header.PartitionId); @@ -29,13 +29,13 @@ namespace SabreTools.Serialization.Wrappers /// public byte[] PlainIV(int index) { - if (Partitions == null) + if (Partitions is null) return []; if (index < 0 || index >= Partitions.Length) return []; var header = Partitions[index]; - if (header == null || header.MagicID != NCCHMagicNumber) + if (header is null || header.MagicID != NCCHMagicNumber) return []; byte[] partitionIdBytes = BitConverter.GetBytes(header.PartitionId); @@ -48,13 +48,13 @@ namespace SabreTools.Serialization.Wrappers /// public byte[] RomFSIV(int index) { - if (Partitions == null) + if (Partitions is null) return []; if (index < 0 || index >= Partitions.Length) return []; var header = Partitions[index]; - if (header == null || header.MagicID != NCCHMagicNumber) + if (header is null || header.MagicID != NCCHMagicNumber) return []; byte[] partitionIdBytes = BitConverter.GetBytes(header.PartitionId); diff --git a/SabreTools.Serialization/Wrappers/N3DS.Printing.cs b/SabreTools.Serialization/Wrappers/N3DS.Printing.cs index 6c572566..d00724ab 100644 --- a/SabreTools.Serialization/Wrappers/N3DS.Printing.cs +++ b/SabreTools.Serialization/Wrappers/N3DS.Printing.cs @@ -71,7 +71,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(" Partition ID table:"); builder.AppendLine(" -------------------------"); - if (header.PartitionIdTable == null || header.PartitionIdTable.Length == 0) + if (header.PartitionIdTable is null || header.PartitionIdTable.Length == 0) { builder.AppendLine(" No partition ID table entries"); } @@ -262,7 +262,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(entry.ExtendedHeaderSizeInBytes, " Extended header size in bytes"); builder.AppendLine(entry.Reserved2, " Reserved 2"); builder.AppendLine(" Flags:"); - if (entry.Flags == null) + if (entry.Flags is null) { builder.AppendLine(" [NULL]"); } diff --git a/SabreTools.Serialization/Wrappers/N3DS.cs b/SabreTools.Serialization/Wrappers/N3DS.cs index fa7f8fd0..5a0b1476 100644 --- a/SabreTools.Serialization/Wrappers/N3DS.cs +++ b/SabreTools.Serialization/Wrappers/N3DS.cs @@ -231,7 +231,7 @@ namespace SabreTools.Serialization.Wrappers public static N3DS? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -251,7 +251,7 @@ namespace SabreTools.Serialization.Wrappers public static N3DS? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -260,7 +260,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.N3DS().Deserialize(data); - if (model == null) + if (model is null) return null; return new N3DS(model, data, currentOffset); @@ -280,13 +280,13 @@ namespace SabreTools.Serialization.Wrappers /// public BitMasks GetBitMasks(int index) { - if (Partitions == null) + if (Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; var partition = Partitions[index]; - if (partition?.Flags == null) + if (partition?.Flags is null) return 0; return partition.Flags.BitMasks; @@ -297,13 +297,13 @@ namespace SabreTools.Serialization.Wrappers /// public CryptoMethod GetCryptoMethod(int index) { - if (Partitions == null) + if (Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; var partition = Partitions[index]; - if (partition?.Flags == null) + if (partition?.Flags is null) return 0; return partition.Flags.CryptoMethod; @@ -314,20 +314,20 @@ namespace SabreTools.Serialization.Wrappers /// public bool IsCodeBinary(int fsIndex, int headerIndex) { - if (ExeFSHeaders == null) + if (ExeFSHeaders is null) return false; if (fsIndex < 0 || fsIndex >= ExeFSHeaders.Length) return false; var fsHeader = ExeFSHeaders[fsIndex]; - if (fsHeader?.FileHeaders == null) + if (fsHeader?.FileHeaders is null) return false; if (headerIndex < 0 || headerIndex >= fsHeader.FileHeaders.Length) return false; var fileHeader = fsHeader.FileHeaders[headerIndex]; - if (fileHeader == null) + if (fileHeader is null) return false; return fileHeader.FileName == ".code"; @@ -357,7 +357,7 @@ namespace SabreTools.Serialization.Wrappers public uint GetExeFSOffset(int index) { // No partitions means no size is available - if (PartitionsTable == null || Partitions == null) + if (PartitionsTable is null || Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; @@ -365,7 +365,7 @@ namespace SabreTools.Serialization.Wrappers // Invalid partition means no size is available var entry = PartitionsTable[index]; var header = Partitions[index]; - if (header == null || header.MagicID != NCCHMagicNumber) + if (header is null || header.MagicID != NCCHMagicNumber) return 0; // If the offset is 0, return 0 @@ -385,7 +385,7 @@ namespace SabreTools.Serialization.Wrappers public uint GetLogoRegionOffset(int index) { // No partitions means no size is available - if (PartitionsTable == null || Partitions == null) + if (PartitionsTable is null || Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; @@ -393,7 +393,7 @@ namespace SabreTools.Serialization.Wrappers // Invalid partition means no size is available var entry = PartitionsTable[index]; var header = Partitions[index]; - if (header == null || header.MagicID != NCCHMagicNumber) + if (header is null || header.MagicID != NCCHMagicNumber) return 0; // If the offset is 0, return 0 @@ -413,7 +413,7 @@ namespace SabreTools.Serialization.Wrappers public uint GetPartitionOffset(int index) { // No partitions means no size is available - if (PartitionsTable == null) + if (PartitionsTable is null) return 0; if (index < 0 || index >= PartitionsTable.Length) return 0; @@ -435,7 +435,7 @@ namespace SabreTools.Serialization.Wrappers public uint GetPlainRegionOffset(int index) { // No partitions means no size is available - if (PartitionsTable == null || Partitions == null) + if (PartitionsTable is null || Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; @@ -443,7 +443,7 @@ namespace SabreTools.Serialization.Wrappers // Invalid partition means no size is available var entry = PartitionsTable[index]; var header = Partitions[index]; - if (header == null || header.MagicID != NCCHMagicNumber) + if (header is null || header.MagicID != NCCHMagicNumber) return 0; // If the offset is 0, return 0 @@ -463,7 +463,7 @@ namespace SabreTools.Serialization.Wrappers public uint GetRomFSOffset(int index) { // No partitions means no size is available - if (PartitionsTable == null || Partitions == null) + if (PartitionsTable is null || Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; @@ -471,7 +471,7 @@ namespace SabreTools.Serialization.Wrappers // Invalid partition means no size is available var entry = PartitionsTable[index]; var header = Partitions[index]; - if (header == null || header.MagicID != NCCHMagicNumber) + if (header is null || header.MagicID != NCCHMagicNumber) return 0; // If the offset is 0, return 0 @@ -495,14 +495,14 @@ namespace SabreTools.Serialization.Wrappers public uint GetExeFSSize(int index) { // Empty partitions array means no size is available - if (Partitions == null) + if (Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; // Invalid partition header means no size is available var header = Partitions[index]; - if (header == null) + if (header is null) return 0; // Return the adjusted size @@ -516,14 +516,14 @@ namespace SabreTools.Serialization.Wrappers public uint GetExtendedHeaderSize(int index) { // Empty partitions array means no size is available - if (Partitions == null) + if (Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; // Invalid partition header means no size is available var header = Partitions[index]; - if (header == null) + if (header is null) return 0; // Return the adjusted size @@ -537,14 +537,14 @@ namespace SabreTools.Serialization.Wrappers public uint GetLogoRegionSize(int index) { // Empty partitions array means no size is available - if (Partitions == null) + if (Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; // Invalid partition header means no size is available var header = Partitions[index]; - if (header == null) + if (header is null) return 0; // Return the adjusted size @@ -558,14 +558,14 @@ namespace SabreTools.Serialization.Wrappers public uint GetPlainRegionSize(int index) { // Empty partitions array means no size is available - if (Partitions == null) + if (Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; // Invalid partition header means no size is available var header = Partitions[index]; - if (header == null) + if (header is null) return 0; // Return the adjusted size @@ -579,14 +579,14 @@ namespace SabreTools.Serialization.Wrappers public uint GetRomFSSize(int index) { // Empty partitions array means no size is available - if (Partitions == null) + if (Partitions is null) return 0; if (index < 0 || index >= Partitions.Length) return 0; // Invalid partition header means no size is available var header = Partitions[index]; - if (header == null) + if (header is null) return 0; // Return the adjusted size diff --git a/SabreTools.Serialization/Wrappers/NCF.cs b/SabreTools.Serialization/Wrappers/NCF.cs index e0ba1e7a..de9f28e0 100644 --- a/SabreTools.Serialization/Wrappers/NCF.cs +++ b/SabreTools.Serialization/Wrappers/NCF.cs @@ -44,7 +44,7 @@ namespace SabreTools.Serialization.Wrappers public static NCF? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -64,7 +64,7 @@ namespace SabreTools.Serialization.Wrappers public static NCF? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -73,7 +73,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.NCF().Deserialize(data); - if (model == null) + if (model is null) return null; return new NCF(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/NewExecutable.Extraction.cs b/SabreTools.Serialization/Wrappers/NewExecutable.Extraction.cs index a363bbc7..70c9a71f 100644 --- a/SabreTools.Serialization/Wrappers/NewExecutable.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/NewExecutable.Extraction.cs @@ -237,7 +237,7 @@ namespace SabreTools.Serialization.Wrappers // Seek to the overlay and parse source.SeekIfPossible(offset, SeekOrigin.Begin); var header = WiseOverlayHeader.Create(source); - if (header == null) + if (header is null) { if (includeDebug) Console.Error.WriteLine("Could not parse the overlay header"); return false; @@ -254,7 +254,7 @@ namespace SabreTools.Serialization.Wrappers // Open the script file from the output directory var scriptStream = File.OpenRead(Path.Combine(outputDirectory, "WiseScript.bin")); var script = WiseScript.Create(scriptStream); - if (script == null) + if (script is null) { if (includeDebug) Console.Error.WriteLine("Could not parse WiseScript.bin"); return false; diff --git a/SabreTools.Serialization/Wrappers/NewExecutable.Printing.cs b/SabreTools.Serialization/Wrappers/NewExecutable.Printing.cs index 01a8bd28..f722f214 100644 --- a/SabreTools.Serialization/Wrappers/NewExecutable.Printing.cs +++ b/SabreTools.Serialization/Wrappers/NewExecutable.Printing.cs @@ -160,7 +160,7 @@ namespace SabreTools.Serialization.Wrappers // TODO: If not integer type, print out name var resource = entry.Resources[j]; builder.AppendLine($" Resource Entry {j}"); - if (resource == null) + if (resource is null) { builder.AppendLine(" [NULL]"); continue; @@ -185,7 +185,7 @@ namespace SabreTools.Serialization.Wrappers foreach (var typeAndNameString in table.TypeAndNameStrings) { builder.AppendLine($" Resource Type/Name Offset {typeAndNameString.Key}"); - if (typeAndNameString.Value == null) + if (typeAndNameString.Value is null) { builder.AppendLine(" [NULL]"); continue; diff --git a/SabreTools.Serialization/Wrappers/NewExecutable.cs b/SabreTools.Serialization/Wrappers/NewExecutable.cs index a8f29f02..b7fc97ed 100644 --- a/SabreTools.Serialization/Wrappers/NewExecutable.cs +++ b/SabreTools.Serialization/Wrappers/NewExecutable.cs @@ -337,7 +337,7 @@ namespace SabreTools.Serialization.Wrappers public static NewExecutable? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -357,7 +357,7 @@ namespace SabreTools.Serialization.Wrappers public static NewExecutable? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -366,7 +366,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.NewExecutable().Deserialize(data); - if (model == null) + if (model is null) return null; return new NewExecutable(model, data, currentOffset); @@ -491,7 +491,7 @@ namespace SabreTools.Serialization.Wrappers { // Get the matching resource var resource = GetSegment(id); - if (resource == null) + if (resource is null) return -1; // Return the reported length @@ -512,7 +512,7 @@ namespace SabreTools.Serialization.Wrappers // Get the matching resource var resource = GetSegment(id); - if (resource == null) + if (resource is null) return -1; // Verify the resource offset @@ -579,7 +579,7 @@ namespace SabreTools.Serialization.Wrappers { // Get the matching segment var segment = GetSegment(index); - if (segment == null) + if (segment is null) return -1; // Return the reported length @@ -600,7 +600,7 @@ namespace SabreTools.Serialization.Wrappers // Get the matching segment var segment = GetSegment(index); - if (segment == null) + if (segment is null) return -1; // Verify the segment offset diff --git a/SabreTools.Serialization/Wrappers/Nitro.Encryption.cs b/SabreTools.Serialization/Wrappers/Nitro.Encryption.cs index 9493ccd6..bec0458c 100644 --- a/SabreTools.Serialization/Wrappers/Nitro.Encryption.cs +++ b/SabreTools.Serialization/Wrappers/Nitro.Encryption.cs @@ -34,7 +34,7 @@ namespace SabreTools.Serialization.Wrappers if (message != null) Console.WriteLine(message); - if (isDecrypted == null) + if (isDecrypted is null) { Console.WriteLine("File has an empty secure area, cannot proceed"); return; @@ -152,7 +152,7 @@ namespace SabreTools.Serialization.Wrappers if (message != null) Console.WriteLine(message); - if (isDecrypted == null) + if (isDecrypted is null) { Console.WriteLine("File has an empty secure area, cannot proceed"); return; diff --git a/SabreTools.Serialization/Wrappers/Nitro.cs b/SabreTools.Serialization/Wrappers/Nitro.cs index f99276a6..6cb0f62c 100644 --- a/SabreTools.Serialization/Wrappers/Nitro.cs +++ b/SabreTools.Serialization/Wrappers/Nitro.cs @@ -58,7 +58,7 @@ namespace SabreTools.Serialization.Wrappers public static Nitro? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -78,7 +78,7 @@ namespace SabreTools.Serialization.Wrappers public static Nitro? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -87,7 +87,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.Nitro().Deserialize(data); - if (model == null) + if (model is null) return null; return new Nitro(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/PAK.cs b/SabreTools.Serialization/Wrappers/PAK.cs index 971dcdf9..d5668e5a 100644 --- a/SabreTools.Serialization/Wrappers/PAK.cs +++ b/SabreTools.Serialization/Wrappers/PAK.cs @@ -52,7 +52,7 @@ namespace SabreTools.Serialization.Wrappers public static PAK? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -72,7 +72,7 @@ namespace SabreTools.Serialization.Wrappers public static PAK? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -81,7 +81,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.PAK().Deserialize(data); - if (model == null) + if (model is null) return null; return new PAK(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/PFF.Extraction.cs b/SabreTools.Serialization/Wrappers/PFF.Extraction.cs index e287fad3..cca581d4 100644 --- a/SabreTools.Serialization/Wrappers/PFF.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/PFF.Extraction.cs @@ -9,7 +9,7 @@ namespace SabreTools.Serialization.Wrappers public bool Extract(string outputDirectory, bool includeDebug) { // If we have no segments - if (Segments == null || Segments.Length == 0) + if (Segments is null || Segments.Length == 0) return false; // Loop through and extract all files to the output @@ -36,7 +36,7 @@ namespace SabreTools.Serialization.Wrappers return false; // If we have no segments - if (Segments == null || Segments.Length == 0) + if (Segments is null || Segments.Length == 0) return false; // If we have an invalid index diff --git a/SabreTools.Serialization/Wrappers/PFF.cs b/SabreTools.Serialization/Wrappers/PFF.cs index 65361de2..796702e5 100644 --- a/SabreTools.Serialization/Wrappers/PFF.cs +++ b/SabreTools.Serialization/Wrappers/PFF.cs @@ -57,7 +57,7 @@ namespace SabreTools.Serialization.Wrappers public static PFF? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -77,7 +77,7 @@ namespace SabreTools.Serialization.Wrappers public static PFF? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -86,7 +86,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.PFF().Deserialize(data); - if (model == null) + if (model is null) return null; return new PFF(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/PIC.Printing.cs b/SabreTools.Serialization/Wrappers/PIC.Printing.cs index d8b31cdd..d7aa2263 100644 --- a/SabreTools.Serialization/Wrappers/PIC.Printing.cs +++ b/SabreTools.Serialization/Wrappers/PIC.Printing.cs @@ -54,7 +54,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(body.DiscSizeClassVersion, " Disc size class version"); builder.AppendLine(body.FormatDependentContents, " Format-dependent contents"); - if (entry.Trailer == null) + if (entry.Trailer is null) { builder.AppendLine(" No trailer"); } diff --git a/SabreTools.Serialization/Wrappers/PIC.cs b/SabreTools.Serialization/Wrappers/PIC.cs index e53695f0..ca6acb1b 100644 --- a/SabreTools.Serialization/Wrappers/PIC.cs +++ b/SabreTools.Serialization/Wrappers/PIC.cs @@ -52,7 +52,7 @@ namespace SabreTools.Serialization.Wrappers public static PIC? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -72,7 +72,7 @@ namespace SabreTools.Serialization.Wrappers public static PIC? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -82,7 +82,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.PIC().Deserialize(data); - if (model == null) + if (model is null) return null; return new PIC(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/PKZIP.Extraction.cs b/SabreTools.Serialization/Wrappers/PKZIP.Extraction.cs index d2c57ebe..281486f6 100644 --- a/SabreTools.Serialization/Wrappers/PKZIP.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/PKZIP.Extraction.cs @@ -19,7 +19,7 @@ namespace SabreTools.Serialization.Wrappers /// public bool Extract(string outputDirectory, bool lookForHeader, bool includeDebug) { - if (_dataSource == null || !_dataSource.CanRead) + if (_dataSource is null || !_dataSource.CanRead) return false; #if NET462_OR_GREATER || NETCOREAPP || NETSTANDARD2_0_OR_GREATER @@ -52,18 +52,18 @@ namespace SabreTools.Serialization.Wrappers continue; // If the entry has an invalid key - if (entry.Key == null) + if (entry.Key is null) continue; // If the entry is partial due to an incomplete multi-part archive, skip it if (!entry.IsComplete) continue; - + // If the entry is password-protected, skip it if (entry.IsEncrypted) { if (includeDebug) Console.WriteLine($"File {entry.Key} in zip is password-protected!"); - + continue; } diff --git a/SabreTools.Serialization/Wrappers/PKZIP.Printing.cs b/SabreTools.Serialization/Wrappers/PKZIP.Printing.cs index f42df79b..491b38c6 100644 --- a/SabreTools.Serialization/Wrappers/PKZIP.Printing.cs +++ b/SabreTools.Serialization/Wrappers/PKZIP.Printing.cs @@ -30,7 +30,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Local File Information:"); builder.AppendLine(" -------------------------"); - if (localFiles == null || localFiles.Length == 0) + if (localFiles is null || localFiles.Length == 0) { builder.AppendLine(" No local files"); builder.AppendLine(); @@ -72,7 +72,7 @@ namespace SabreTools.Serialization.Wrappers #region Encryption Headers var encryptionHeaders = localFile.EncryptionHeaders; - if (encryptionHeaders == null) + if (encryptionHeaders is null) { builder.AppendLine(" [Encryption Headers]: [NULL]"); } @@ -87,7 +87,7 @@ namespace SabreTools.Serialization.Wrappers #region File Data var fileData = localFile.FileData; - if (fileData == null) + if (fileData is null) { builder.AppendLine(" [File Data]: [NULL]"); } @@ -102,7 +102,7 @@ namespace SabreTools.Serialization.Wrappers #region Data Descriptor var dataDescriptor = localFile.DataDescriptor; - if (dataDescriptor == null) + if (dataDescriptor is null) { builder.AppendLine(" [Data Descriptor]: [NULL]"); } @@ -115,7 +115,7 @@ namespace SabreTools.Serialization.Wrappers } var zip64DataDescriptor = localFile.ZIP64DataDescriptor; - if (zip64DataDescriptor == null) + if (zip64DataDescriptor is null) { builder.AppendLine(" [ZIP64 Data Descriptor]: [NULL]"); } @@ -134,7 +134,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" End of Central Directory Record Information:"); builder.AppendLine(" -------------------------"); - if (record == null) + if (record is null) { builder.AppendLine(" No end of central directory record"); builder.AppendLine(); @@ -157,7 +157,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" ZIP64 End of Central Directory Locator Information:"); builder.AppendLine(" -------------------------"); - if (locator == null) + if (locator is null) { builder.AppendLine(" No ZIP64 end of central directory locator"); builder.AppendLine(); @@ -175,7 +175,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" ZIP64 End of Central Directory Record Information:"); builder.AppendLine(" -------------------------"); - if (record == null) + if (record is null) { builder.AppendLine(" No ZIP64 end of central directory record"); builder.AppendLine(); @@ -201,7 +201,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Central Directory File Headers Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No central directory file headers"); builder.AppendLine(); @@ -243,7 +243,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Archive Extra Data Record Information:"); builder.AppendLine(" -------------------------"); - if (record == null) + if (record is null) { builder.AppendLine(" No archive extra data record"); builder.AppendLine(); @@ -263,7 +263,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(title); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No extra fields"); builder.AppendLine(); diff --git a/SabreTools.Serialization/Wrappers/PKZIP.cs b/SabreTools.Serialization/Wrappers/PKZIP.cs index d08ae897..de90f5e9 100644 --- a/SabreTools.Serialization/Wrappers/PKZIP.cs +++ b/SabreTools.Serialization/Wrappers/PKZIP.cs @@ -64,7 +64,7 @@ namespace SabreTools.Serialization.Wrappers public static PKZIP? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -84,7 +84,7 @@ namespace SabreTools.Serialization.Wrappers public static PKZIP? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -93,7 +93,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.PKZIP().Deserialize(data); - if (model == null) + if (model is null) return null; return new PKZIP(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/PlayJAudioFile.Printing.cs b/SabreTools.Serialization/Wrappers/PlayJAudioFile.Printing.cs index 1e93a7a5..7f82887c 100644 --- a/SabreTools.Serialization/Wrappers/PlayJAudioFile.Printing.cs +++ b/SabreTools.Serialization/Wrappers/PlayJAudioFile.Printing.cs @@ -120,7 +120,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Unknown Block 3 Information:"); builder.AppendLine(" -------------------------"); - if (block == null) + if (block is null) { builder.AppendLine(" No unknown block 1r"); builder.AppendLine(); @@ -136,7 +136,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(" Data Files Information:"); builder.AppendLine(" -------------------------"); builder.AppendLine(count, " Data files count"); - if (count == 0 || entries == null || entries.Length == 0) + if (count == 0 || entries is null || entries.Length == 0) { builder.AppendLine(" No data files"); builder.AppendLine(); diff --git a/SabreTools.Serialization/Wrappers/PlayJAudioFile.cs b/SabreTools.Serialization/Wrappers/PlayJAudioFile.cs index 3eed12ac..8e0241c0 100644 --- a/SabreTools.Serialization/Wrappers/PlayJAudioFile.cs +++ b/SabreTools.Serialization/Wrappers/PlayJAudioFile.cs @@ -44,7 +44,7 @@ namespace SabreTools.Serialization.Wrappers public static PlayJAudioFile? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -64,7 +64,7 @@ namespace SabreTools.Serialization.Wrappers public static PlayJAudioFile? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -73,7 +73,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.PlayJAudio().Deserialize(data); - if (model == null) + if (model is null) return null; return new PlayJAudioFile(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/PlayJPlaylist.Printing.cs b/SabreTools.Serialization/Wrappers/PlayJPlaylist.Printing.cs index 3ddf8636..f15cdd6b 100644 --- a/SabreTools.Serialization/Wrappers/PlayJPlaylist.Printing.cs +++ b/SabreTools.Serialization/Wrappers/PlayJPlaylist.Printing.cs @@ -152,7 +152,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Unknown Block 3 Information:"); builder.AppendLine(" -------------------------"); - if (block == null) + if (block is null) { builder.AppendLine(" No unknown block 1r"); builder.AppendLine(); @@ -168,7 +168,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(" Data Files Information:"); builder.AppendLine(" -------------------------"); builder.AppendLine(count, " Data files count"); - if (count == 0 || entries == null || entries.Length == 0) + if (count == 0 || entries is null || entries.Length == 0) { builder.AppendLine(" No data files"); builder.AppendLine(); diff --git a/SabreTools.Serialization/Wrappers/PlayJPlaylist.cs b/SabreTools.Serialization/Wrappers/PlayJPlaylist.cs index beacc6e6..190c83e5 100644 --- a/SabreTools.Serialization/Wrappers/PlayJPlaylist.cs +++ b/SabreTools.Serialization/Wrappers/PlayJPlaylist.cs @@ -44,7 +44,7 @@ namespace SabreTools.Serialization.Wrappers public static PlayJPlaylist? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -64,7 +64,7 @@ namespace SabreTools.Serialization.Wrappers public static PlayJPlaylist? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -73,7 +73,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.PlayJPlaylist().Deserialize(data); - if (model == null) + if (model is null) return null; return new PlayJPlaylist(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs b/SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs index 5a8900ad..38872369 100644 --- a/SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs @@ -62,7 +62,7 @@ namespace SabreTools.Serialization.Wrappers // Try to deserialize the source data var deserializer = new Readers.AdvancedInstaller(); var sfx = deserializer.Deserialize(_dataSource); - if (sfx == null || sfx.Entries.Length == 0) + if (sfx is null || sfx.Entries.Length == 0) return false; // Loop through the entries and extract @@ -119,12 +119,12 @@ namespace SabreTools.Serialization.Wrappers { // Get all resources of type 99 with index 2 var resources = FindResourceByNamedType("99, 2"); - if (resources == null || resources.Count == 0) + if (resources is null || resources.Count == 0) return false; // Get the first resource of type 99 with index 2 var resource = resources[0]; - if (resource == null || resource.Length == 0) + if (resource is null || resource.Length == 0) return false; // Create the output data buffer @@ -137,7 +137,7 @@ namespace SabreTools.Serialization.Wrappers data = DecompressCExeLZ(resource); // If we have no data - if (data == null) + if (data is null) return false; // Create the temp filename @@ -362,7 +362,7 @@ namespace SabreTools.Serialization.Wrappers string resourceKey = kvp.Key; var value = kvp.Value; - if (value == null || value is not byte[] ba || ba.Length == 0) + if (value is null || value is not byte[] ba || ba.Length == 0) continue; // Set the output variables @@ -533,7 +533,7 @@ namespace SabreTools.Serialization.Wrappers public bool ExtractMatroschka(string outputDirectory, bool includeDebug) { // Check if executable contains Matroschka package or not - if (MatroschkaPackage == null) + if (MatroschkaPackage is null) return false; // Attempt to extract package @@ -549,7 +549,7 @@ namespace SabreTools.Serialization.Wrappers public bool ExtractInstallShieldExecutable(string outputDirectory, bool includeDebug) { // Check if executable contains an InstallShield Executable or not - if (ISEXE == null) + if (ISEXE is null) return false; // Attempt to extract package @@ -572,7 +572,7 @@ namespace SabreTools.Serialization.Wrappers // Try to deserialize the source data var deserializer = new Readers.SpoonInstaller(); var sfx = deserializer.Deserialize(_dataSource); - if (sfx?.Entries == null) + if (sfx?.Entries is null) return false; // Loop through the entries and extract @@ -650,7 +650,7 @@ namespace SabreTools.Serialization.Wrappers // Seek to the overlay and parse source.SeekIfPossible(offset, SeekOrigin.Begin); var header = WiseOverlayHeader.Create(source); - if (header == null) + if (header is null) { if (includeDebug) Console.Error.WriteLine("Could not parse a Wise overlay header"); return false; @@ -667,7 +667,7 @@ namespace SabreTools.Serialization.Wrappers // Open the script file from the output directory var scriptStream = File.OpenRead(Path.Combine(outputDirectory, "WiseScript.bin")); var script = WiseScript.Create(scriptStream); - if (script == null) + if (script is null) { if (includeDebug) Console.Error.WriteLine("Could not parse WiseScript.bin"); return false; @@ -692,7 +692,7 @@ namespace SabreTools.Serialization.Wrappers { // Get the section header var header = WiseSection; - if (header == null) + if (header is null) { if (includeDebug) Console.Error.WriteLine("Could not parse a Wise section header"); return false; diff --git a/SabreTools.Serialization/Wrappers/PortableExecutable.Printing.cs b/SabreTools.Serialization/Wrappers/PortableExecutable.Printing.cs index 19c6a455..49fdb9f2 100644 --- a/SabreTools.Serialization/Wrappers/PortableExecutable.Printing.cs +++ b/SabreTools.Serialization/Wrappers/PortableExecutable.Printing.cs @@ -263,7 +263,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Section Table Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No section table items"); builder.AppendLine(); @@ -297,7 +297,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Symbol Table Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No symbol table items"); builder.AppendLine(); @@ -401,7 +401,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" String Table Information:"); builder.AppendLine(" -------------------------"); - if (stringTable?.Strings == null || stringTable.Strings.Length == 0) + if (stringTable?.Strings is null || stringTable.Strings.Length == 0) { builder.AppendLine(" No string table items"); builder.AppendLine(); @@ -423,7 +423,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Attribute Certificate Table Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No attribute certificate table items"); builder.AppendLine(); @@ -446,14 +446,14 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Certificate Data [Formatted]"); builder.AppendLine(" -------------------------"); - if (entry.Certificate == null) + if (entry.Certificate is null) { builder.AppendLine(" INVALID DATA FOUND"); } else { var topLevelValues = deserializer.Deserialize(entry.Certificate, 0); - if (topLevelValues == null) + if (topLevelValues is null) { builder.AppendLine(" INVALID DATA FOUND"); builder.AppendLine(entry.Certificate, " Raw data"); @@ -490,7 +490,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Delay-Load Directory Table Information:"); builder.AppendLine(" -------------------------"); - if (table == null) + if (table is null) { builder.AppendLine(" No delay-load directory table items"); builder.AppendLine(); @@ -517,7 +517,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Base Relocation Table Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No base relocation table items"); builder.AppendLine(); @@ -560,7 +560,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Debug Table Information:"); builder.AppendLine(" -------------------------"); - if (table?.DebugDirectoryTable == null || table.DebugDirectoryTable.Length == 0) + if (table?.DebugDirectoryTable is null || table.DebugDirectoryTable.Length == 0) { builder.AppendLine(" No debug table items"); builder.AppendLine(); @@ -589,7 +589,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(value: " Export Directory Table Information:"); builder.AppendLine(" -------------------------"); - if (table == null) + if (table is null) { builder.AppendLine(" No export directory table"); } @@ -619,7 +619,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Export Address Table Information:"); builder.AppendLine(" -------------------------"); - if (table == null || table.Length == 0) + if (table is null || table.Length == 0) { builder.AppendLine(" No export address table items"); } @@ -642,7 +642,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Export Name Pointer Table Information:"); builder.AppendLine(" -------------------------"); - if (table?.Pointers == null || table.Pointers.Length == 0) + if (table?.Pointers is null || table.Pointers.Length == 0) { builder.AppendLine(" No export name pointer table items"); } @@ -664,7 +664,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Export Ordinal Table Information:"); builder.AppendLine(" -------------------------"); - if (table?.Indexes == null || table.Indexes.Length == 0) + if (table?.Indexes is null || table.Indexes.Length == 0) { builder.AppendLine(" No export ordinal table items"); } @@ -686,7 +686,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Export Name Table Information:"); builder.AppendLine(" -------------------------"); - if (table?.Strings == null || table.Strings.Length == 0) + if (table?.Strings is null || table.Strings.Length == 0) { builder.AppendLine(" No export name table items"); } @@ -708,7 +708,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Import Directory Table Information:"); builder.AppendLine(" -------------------------"); - if (table == null || table.Length == 0) + if (table is null || table.Length == 0) { builder.AppendLine(" No import directory table items"); } @@ -738,7 +738,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Import Lookup Tables Information:"); builder.AppendLine(" -------------------------"); - if (tables == null || tables.Count == 0) + if (tables is null || tables.Count == 0) { builder.AppendLine(" No import lookup tables"); } @@ -752,7 +752,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(); builder.AppendLine($" Import Lookup Table {index} Information:"); builder.AppendLine(" -------------------------"); - if (importLookupTable == null || importLookupTable.Length == 0) + if (importLookupTable is null || importLookupTable.Length == 0) { builder.AppendLine(" No import lookup table items"); continue; @@ -784,7 +784,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Import Address Tables Information:"); builder.AppendLine(" -------------------------"); - if (tables == null || tables.Count == 0) + if (tables is null || tables.Count == 0) { builder.AppendLine(" No import address tables"); } @@ -798,7 +798,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(); builder.AppendLine($" Import Address Table {index} Information:"); builder.AppendLine(" -------------------------"); - if (importAddressTable == null || importAddressTable.Length == 0) + if (importAddressTable is null || importAddressTable.Length == 0) { builder.AppendLine(" No import address table items"); continue; @@ -830,7 +830,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Import Hint/Name Table Information:"); builder.AppendLine(" -------------------------"); - if (table == null || table.Length == 0) + if (table is null || table.Length == 0) { builder.AppendLine(" No import hint/name table items"); } @@ -853,7 +853,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Resource Directory Table Information:"); builder.AppendLine(" -------------------------"); - if (table == null) + if (table is null) { builder.AppendLine(" No resource directory table items"); builder.AppendLine(); @@ -1042,7 +1042,7 @@ namespace SabreTools.Serialization.Wrappers MenuResource? menu = null; try { menu = entry.AsMenu(); } catch { } - if (menu == null) + if (menu is null) { builder.AppendLine($"{padding}Menu resource found, but malformed"); return; @@ -1077,7 +1077,7 @@ namespace SabreTools.Serialization.Wrappers { var menuItem = menu.MenuItems[i]; builder.AppendLine($"{padding}Menu item {i}"); - if (menuItem == null) + if (menuItem is null) { builder.AppendLine($"{padding} [NULL]"); continue; @@ -1117,7 +1117,7 @@ namespace SabreTools.Serialization.Wrappers DialogBoxResource? dialogBox = null; try { dialogBox = entry.AsDialogBox(); } catch { } - if (dialogBox == null) + if (dialogBox is null) { builder.AppendLine($"{padding}Dialog box resource found, but malformed"); return; @@ -1143,7 +1143,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine($"{padding}Dialog item templates"); builder.AppendLine($"{padding}-------------------------"); if (dialogBox.DialogTemplate.ItemCount == 0 - || dialogBox.DialogItemTemplates == null + || dialogBox.DialogItemTemplates is null || dialogBox.DialogItemTemplates.Length == 0) { builder.AppendLine($"{padding}No dialog item templates"); @@ -1154,7 +1154,7 @@ namespace SabreTools.Serialization.Wrappers { var dialogItemTemplate = dialogBox.DialogItemTemplates[i]; builder.AppendLine($"{padding}Dialog item template {i}"); - if (dialogItemTemplate == null) + if (dialogItemTemplate is null) { builder.AppendLine($"{padding} [NULL]"); continue; @@ -1204,7 +1204,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine($"{padding}Dialog item templates"); builder.AppendLine($"{padding}-------------------------"); if (dialogBox.ExtendedDialogTemplate.DialogItems == 0 - || dialogBox.ExtendedDialogItemTemplates == null + || dialogBox.ExtendedDialogItemTemplates is null || dialogBox.ExtendedDialogItemTemplates.Length == 0) { builder.AppendLine($"{padding}No dialog item templates"); @@ -1215,7 +1215,7 @@ namespace SabreTools.Serialization.Wrappers { var dialogItemTemplate = dialogBox.ExtendedDialogItemTemplates[i]; builder.AppendLine($"{padding}Dialog item template {i}"); - if (dialogItemTemplate == null) + if (dialogItemTemplate is null) { builder.AppendLine($"{padding} [NULL]"); continue; @@ -1252,7 +1252,7 @@ namespace SabreTools.Serialization.Wrappers Dictionary? stringTable = null; try { stringTable = entry.AsStringTable(); } catch { } - if (stringTable == null) + if (stringTable is null) { builder.AppendLine($"{padding}String table resource found, but malformed"); return; @@ -1284,7 +1284,7 @@ namespace SabreTools.Serialization.Wrappers AcceleratorTableEntry[]? acceleratorTable = null; try { acceleratorTable = entry.AsAcceleratorTableResource(); } catch { } - if (acceleratorTable == null) + if (acceleratorTable is null) { builder.AppendLine($"{padding}Accelerator table resource found, but malformed"); return; @@ -1307,7 +1307,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine($"{padding}Application-defined resource found, not parsed yet"); // Then print the data, if needed - if (entry.Data == null) + if (entry.Data is null) { builder.AppendLine($"{padding}Data: [NULL] (This may indicate a very large resource)"); } @@ -1366,7 +1366,7 @@ namespace SabreTools.Serialization.Wrappers MessageResourceData? messageTable = null; try { messageTable = entry.AsMessageResourceData(); } catch { } - if (messageTable == null) + if (messageTable is null) { builder.AppendLine($"{padding}Message resource data found, but malformed"); return; @@ -1386,7 +1386,7 @@ namespace SabreTools.Serialization.Wrappers { var messageResourceBlock = messageTable.Blocks[i]; builder.AppendLine($"{padding}Message resource block {i}"); - if (messageResourceBlock == null) + if (messageResourceBlock is null) { builder.AppendLine($"{padding} [NULL]"); continue; @@ -1412,7 +1412,7 @@ namespace SabreTools.Serialization.Wrappers uint index = kvp.Key; var messageResourceEntry = kvp.Value; builder.AppendLine($"{padding}Message resource entry {index}"); - if (messageResourceEntry == null) + if (messageResourceEntry is null) { builder.AppendLine($"{padding} [NULL]"); continue; @@ -1443,7 +1443,7 @@ namespace SabreTools.Serialization.Wrappers VersionInfo? versionInfo = null; try { versionInfo = entry.AsVersionInfo(); } catch { } - if (versionInfo == null) + if (versionInfo is null) { builder.AppendLine($"{padding}Version info resource found, but malformed"); return; @@ -1487,7 +1487,7 @@ namespace SabreTools.Serialization.Wrappers for (int i = 0; i < versionInfo.StringFileInfo.Children.Length; i++) { var stringFileInfoChildEntry = versionInfo.StringFileInfo.Children[i]; - if (stringFileInfoChildEntry == null) + if (stringFileInfoChildEntry is null) { builder.AppendLine($"{padding} [String Table {i}] [NULL]"); continue; @@ -1508,7 +1508,7 @@ namespace SabreTools.Serialization.Wrappers for (int j = 0; j < stringFileInfoChildEntry.Children.Length; j++) { var stringDataEntry = stringFileInfoChildEntry.Children[j]; - if (stringDataEntry == null) + if (stringDataEntry is null) { builder.AppendLine($"{padding} [String Data {j}] [NULL]"); continue; @@ -1542,7 +1542,7 @@ namespace SabreTools.Serialization.Wrappers for (int i = 0; i < versionInfo.VarFileInfo.Children.Length; i++) { var varFileInfoChildEntry = versionInfo.VarFileInfo.Children[i]; - if (varFileInfoChildEntry == null) + if (varFileInfoChildEntry is null) { builder.AppendLine($"{padding} [String Table {i}] [NULL]"); continue; @@ -1607,7 +1607,7 @@ namespace SabreTools.Serialization.Wrappers AssemblyManifest? assemblyManifest = null; try { assemblyManifest = entry.AsAssemblyManifest(); } catch { } - if (assemblyManifest == null) + if (assemblyManifest is null) { builder.AppendLine($"{padding}Assembly manifest found, but malformed"); return; @@ -1685,7 +1685,7 @@ namespace SabreTools.Serialization.Wrappers for (int i = 0; i < assemblyManifest.File.Length; i++) { var file = assemblyManifest.File[i]; - if (file == null) + if (file is null) { builder.AppendLine($"{padding}[File {i}] [NULL]"); continue; @@ -1791,7 +1791,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine($"{padding}Unknown type {resourceType} found, not parsed yet"); // Then print the data, if needed - if (entry.Data == null) + if (entry.Data is null) { builder.AppendLine($"{padding}Data: [NULL] (This may indicate a very large resource)"); } diff --git a/SabreTools.Serialization/Wrappers/PortableExecutable.cs b/SabreTools.Serialization/Wrappers/PortableExecutable.cs index b3762c7e..6a289d98 100644 --- a/SabreTools.Serialization/Wrappers/PortableExecutable.cs +++ b/SabreTools.Serialization/Wrappers/PortableExecutable.cs @@ -38,7 +38,7 @@ namespace SabreTools.Serialization.Wrappers return field; // If we have no resource table, just return - if (DebugDirectoryTable == null || DebugDirectoryTable.Length == 0) + if (DebugDirectoryTable is null || DebugDirectoryTable.Length == 0) return field; // Otherwise, build and return the cached dictionary @@ -225,7 +225,7 @@ namespace SabreTools.Serialization.Wrappers } // Otherwise, it could not be found - if (section == null) + if (section is null) { _matroschkaPackageFailed = true; return null; @@ -250,7 +250,7 @@ namespace SabreTools.Serialization.Wrappers // Parse the package field = SecuROMMatroschkaPackage.Create(sectionData, 0); - if (field?.Entries == null) + if (field?.Entries is null) _matroschkaPackageFailed = true; return field; @@ -605,9 +605,9 @@ namespace SabreTools.Serialization.Wrappers return _resourceData; // If we have no resource table, just return - if (OptionalHeader.ResourceTable == null + if (OptionalHeader.ResourceTable is null || OptionalHeader.ResourceTable.VirtualAddress == 0 - || ResourceDirectoryTable == null) + || ResourceDirectoryTable is null) { return _resourceData; } @@ -649,7 +649,7 @@ namespace SabreTools.Serialization.Wrappers } // If the section cannot be found - if (wiseSection == null) + if (wiseSection is null) { _wiseSectionHeaderMissing = true; return null; @@ -674,7 +674,7 @@ namespace SabreTools.Serialization.Wrappers // Parse the section header field = WiseSectionHeader.Create(sectionData, 0); - if (field == null) + if (field is null) _wiseSectionHeaderMissing = true; return field; @@ -1231,7 +1231,7 @@ namespace SabreTools.Serialization.Wrappers public static PortableExecutable? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -1251,7 +1251,7 @@ namespace SabreTools.Serialization.Wrappers public static PortableExecutable? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -1260,7 +1260,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.PortableExecutable().Deserialize(data); - if (model == null) + if (model is null) return null; return new PortableExecutable(model, data, currentOffset); @@ -1294,12 +1294,12 @@ namespace SabreTools.Serialization.Wrappers return null; // Ensure the resource table has been parsed - if (ResourceData == null) + if (ResourceData is null) return null; // If we don't have string version info in this executable var stringTable = _versionInfo?.StringFileInfo?.Children; - if (stringTable == null || stringTable.Length == 0) + if (stringTable is null || stringTable.Length == 0) return null; // Try to find a key that matches @@ -1356,19 +1356,19 @@ namespace SabreTools.Serialization.Wrappers var debugFound = new List(); foreach (var data in debugData.Values) { - if (data == null) + if (data is null) continue; if (data is Data.Models.PortableExecutable.DebugData.NB10ProgramDatabase n) { - if (n.PdbFileName == null || !n.PdbFileName.Contains(path)) + if (n.PdbFileName is null || !n.PdbFileName.Contains(path)) continue; debugFound.Add(n); } else if (data is Data.Models.PortableExecutable.DebugData.RSDSProgramDatabase r) { - if (r.PathAndFileName == null || !r.PathAndFileName.Contains(path)) + if (r.PathAndFileName is null || !r.PathAndFileName.Contains(path)) continue; debugFound.Add(r); @@ -1393,9 +1393,9 @@ namespace SabreTools.Serialization.Wrappers var table = new List(); foreach (var data in debugData.Values) { - if (data == null) + if (data is null) continue; - if (data is not byte[] b || b == null) + if (data is not byte[] b || b is null) continue; try @@ -1445,7 +1445,7 @@ namespace SabreTools.Serialization.Wrappers private Dictionary ParseDebugTable() { // If there is no debug table - if (DebugDirectoryTable == null || DebugDirectoryTable.Length == 0) + if (DebugDirectoryTable is null || DebugDirectoryTable.Length == 0) return []; // Create a new debug table @@ -1531,9 +1531,9 @@ namespace SabreTools.Serialization.Wrappers var resources = new List(); foreach (var resource in resourceData.Values) { - if (resource == null) + if (resource is null) continue; - if (resource is not DialogBoxResource dbr || dbr == null) + if (resource is not DialogBoxResource dbr || dbr is null) continue; if (dbr.DialogTemplate?.TitleResource?.Contains(title) ?? false) @@ -1560,9 +1560,9 @@ namespace SabreTools.Serialization.Wrappers var resources = new List(); foreach (var resource in resourceData.Values) { - if (resource == null) + if (resource is null) continue; - if (resource is not DialogBoxResource dbr || dbr == null) + if (resource is not DialogBoxResource dbr || dbr is null) continue; if (dbr.DialogItemTemplates != null) @@ -1597,17 +1597,17 @@ namespace SabreTools.Serialization.Wrappers var stringTables = new List?>(); foreach (var resource in resourceData.Values) { - if (resource == null) + if (resource is null) continue; - if (resource is not Dictionary st || st == null) + if (resource is not Dictionary st || st is null) continue; foreach (string? s in st.Values) { #if NETFRAMEWORK || NETSTANDARD - if (s == null || !s.Contains(entry)) + if (s is null || !s.Contains(entry)) #else - if (s == null || !s.Contains(entry, StringComparison.OrdinalIgnoreCase)) + if (s is null || !s.Contains(entry, StringComparison.OrdinalIgnoreCase)) #endif continue; @@ -1636,7 +1636,7 @@ namespace SabreTools.Serialization.Wrappers { if (!kvp.Key.Contains(typeName)) continue; - if (kvp.Value == null || kvp.Value is not byte[] b || b == null) + if (kvp.Value is null || kvp.Value is not byte[] b || b is null) continue; resources.Add(b); @@ -1660,9 +1660,9 @@ namespace SabreTools.Serialization.Wrappers var resources = new List(); foreach (var resource in resourceData.Values) { - if (resource == null) + if (resource is null) continue; - if (resource is not byte[] b || b == null) + if (resource is not byte[] b || b is null) continue; try @@ -1757,7 +1757,7 @@ namespace SabreTools.Serialization.Wrappers } // If there are no resources - if (OptionalHeader.ResourceTable == null) + if (OptionalHeader.ResourceTable is null) return -1; // Cache the resource data for easier reading @@ -1769,7 +1769,7 @@ namespace SabreTools.Serialization.Wrappers bool exeResources = false; foreach (var kvp in resourceData) { - if (kvp.Value == null || kvp.Value is not byte[] ba) + if (kvp.Value is null || kvp.Value is not byte[] ba) continue; if (!ba.StartsWith(Data.Models.MSDOS.Constants.SignatureBytes)) continue; @@ -1863,7 +1863,7 @@ namespace SabreTools.Serialization.Wrappers private void ParseResourceDataEntry(Data.Models.PortableExecutable.Resource.DataEntry entry, List types) { // Create the key and value objects - string key = types == null + string key = types is null ? $"UNKNOWN_{Guid.NewGuid()}" : string.Join(", ", Array.ConvertAll([.. types], t => t.ToString())); @@ -1976,7 +1976,7 @@ namespace SabreTools.Serialization.Wrappers public bool ContainsSection(string? sectionName, bool exact = false) { // If no section name is provided - if (sectionName == null) + if (sectionName is null) return false; // Get all section names first @@ -2224,7 +2224,7 @@ namespace SabreTools.Serialization.Wrappers // Get the section data, if possible byte[]? sectionData = GetSectionData(index); - if (sectionData == null || sectionData.Length == 0) + if (sectionData is null || sectionData.Length == 0) { _sectionStringData[index] = []; return _sectionStringData[index]; @@ -2327,7 +2327,7 @@ namespace SabreTools.Serialization.Wrappers // Get the table data, if possible byte[]? tableData = GetTableData(index); - if (tableData == null || tableData.Length == 0) + if (tableData is null || tableData.Length == 0) { _tableStringData[index] = []; return _tableStringData[index]; diff --git a/SabreTools.Serialization/Wrappers/Quantum.Extraction.cs b/SabreTools.Serialization/Wrappers/Quantum.Extraction.cs index 3e0963a2..2f0b729d 100644 --- a/SabreTools.Serialization/Wrappers/Quantum.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/Quantum.Extraction.cs @@ -8,7 +8,7 @@ namespace SabreTools.Serialization.Wrappers public bool Extract(string outputDirectory, bool includeDebug) { // If we have no files - if (FileList == null || FileList.Length == 0) + if (FileList is null || FileList.Length == 0) return false; // Loop through and extract all files to the output @@ -31,7 +31,7 @@ namespace SabreTools.Serialization.Wrappers public bool ExtractFile(int index, string outputDirectory, bool includeDebug) { // If we have no files - if (Header == null || FileCount == 0 || FileList == null || FileList.Length == 0) + if (Header is null || FileCount == 0 || FileList is null || FileList.Length == 0) return false; // If we have an invalid index diff --git a/SabreTools.Serialization/Wrappers/Quantum.cs b/SabreTools.Serialization/Wrappers/Quantum.cs index 03c96d85..ea93293a 100644 --- a/SabreTools.Serialization/Wrappers/Quantum.cs +++ b/SabreTools.Serialization/Wrappers/Quantum.cs @@ -61,7 +61,7 @@ namespace SabreTools.Serialization.Wrappers public static Quantum? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -81,7 +81,7 @@ namespace SabreTools.Serialization.Wrappers public static Quantum? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -90,7 +90,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.Quantum().Deserialize(data); - if (model == null) + if (model is null) return null; return new Quantum(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/RAR.Extraction.cs b/SabreTools.Serialization/Wrappers/RAR.Extraction.cs index c257954f..7d295aa0 100644 --- a/SabreTools.Serialization/Wrappers/RAR.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/RAR.Extraction.cs @@ -25,7 +25,7 @@ namespace SabreTools.Serialization.Wrappers /// public bool Extract(string outputDirectory, bool lookForHeader, bool includeDebug) { - if (_dataSource == null || !_dataSource.CanRead) + if (_dataSource is null || !_dataSource.CanRead) return false; #if NET462_OR_GREATER || NETCOREAPP || NETSTANDARD2_0_OR_GREATER @@ -66,7 +66,7 @@ namespace SabreTools.Serialization.Wrappers continue; // If the entry has an invalid key - if (entry.Key == null) + if (entry.Key is null) continue; // If we have a partial entry due to an incomplete multi-part archive, skip it @@ -78,7 +78,7 @@ namespace SabreTools.Serialization.Wrappers firstFile = false; continue; } - + if (entry.IsSolid) { // If the RAR is solid and the first entry is password-protected, you won't be able to @@ -88,10 +88,10 @@ namespace SabreTools.Serialization.Wrappers if (includeDebug) Console.WriteLine("RAR is password-protected!"); return false; } - + isSolid = true; } - + break; } catch (Exception ex) @@ -222,18 +222,18 @@ namespace SabreTools.Serialization.Wrappers continue; // If the entry has an invalid key - if (entry.Key == null) + if (entry.Key is null) continue; // If we have a partial entry due to an incomplete multi-part archive, skip it if (!entry.IsComplete) continue; - + // If the entry is password-protected, skip it if (entry.IsEncrypted) { if (includeDebug) Console.WriteLine($"File {entry.Key} in RAR is password-protected!"); - + continue; } diff --git a/SabreTools.Serialization/Wrappers/RAR.cs b/SabreTools.Serialization/Wrappers/RAR.cs index e083c6cf..d611b08c 100644 --- a/SabreTools.Serialization/Wrappers/RAR.cs +++ b/SabreTools.Serialization/Wrappers/RAR.cs @@ -50,7 +50,7 @@ namespace SabreTools.Serialization.Wrappers public static RAR? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -70,7 +70,7 @@ namespace SabreTools.Serialization.Wrappers public static RAR? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; return new RAR(new Archive(), data); diff --git a/SabreTools.Serialization/Wrappers/RealArcadeInstaller.cs b/SabreTools.Serialization/Wrappers/RealArcadeInstaller.cs index d2346e9f..a69bb7c9 100644 --- a/SabreTools.Serialization/Wrappers/RealArcadeInstaller.cs +++ b/SabreTools.Serialization/Wrappers/RealArcadeInstaller.cs @@ -50,7 +50,7 @@ namespace SabreTools.Serialization.Wrappers public static RealArcadeInstaller? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -70,7 +70,7 @@ namespace SabreTools.Serialization.Wrappers public static RealArcadeInstaller? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; return new RealArcadeInstaller(new RgsFile(), data); diff --git a/SabreTools.Serialization/Wrappers/RealArcadeMezzanine.cs b/SabreTools.Serialization/Wrappers/RealArcadeMezzanine.cs index bc916228..d7a52b4d 100644 --- a/SabreTools.Serialization/Wrappers/RealArcadeMezzanine.cs +++ b/SabreTools.Serialization/Wrappers/RealArcadeMezzanine.cs @@ -50,7 +50,7 @@ namespace SabreTools.Serialization.Wrappers public static RealArcadeMezzanine? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -70,7 +70,7 @@ namespace SabreTools.Serialization.Wrappers public static RealArcadeMezzanine? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; return new RealArcadeMezzanine(new Mezzanine(), data); diff --git a/SabreTools.Serialization/Wrappers/SFFS.cs b/SabreTools.Serialization/Wrappers/SFFS.cs index c02e9385..5b482733 100644 --- a/SabreTools.Serialization/Wrappers/SFFS.cs +++ b/SabreTools.Serialization/Wrappers/SFFS.cs @@ -51,7 +51,7 @@ namespace SabreTools.Serialization.Wrappers public static SFFS? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -71,7 +71,7 @@ namespace SabreTools.Serialization.Wrappers public static SFFS? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; return new SFFS(new FileSystem(), data); diff --git a/SabreTools.Serialization/Wrappers/SGA.Extraction.cs b/SabreTools.Serialization/Wrappers/SGA.Extraction.cs index e04d118c..741df1ad 100644 --- a/SabreTools.Serialization/Wrappers/SGA.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/SGA.Extraction.cs @@ -45,7 +45,7 @@ namespace SabreTools.Serialization.Wrappers // Create the filename var filename = GetFileName(index); - if (filename == null) + if (filename is null) return false; // Loop through and get all parent directories diff --git a/SabreTools.Serialization/Wrappers/SGA.cs b/SabreTools.Serialization/Wrappers/SGA.cs index 4fc26be5..cb4ffdaa 100644 --- a/SabreTools.Serialization/Wrappers/SGA.cs +++ b/SabreTools.Serialization/Wrappers/SGA.cs @@ -89,7 +89,7 @@ namespace SabreTools.Serialization.Wrappers public static SGA? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -109,7 +109,7 @@ namespace SabreTools.Serialization.Wrappers public static SGA? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -118,7 +118,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.SGA().Deserialize(data); - if (model == null) + if (model is null) return null; return new SGA(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/SecuROMDFA.cs b/SabreTools.Serialization/Wrappers/SecuROMDFA.cs index 2f4b415c..a5bf4f01 100644 --- a/SabreTools.Serialization/Wrappers/SecuROMDFA.cs +++ b/SabreTools.Serialization/Wrappers/SecuROMDFA.cs @@ -45,7 +45,7 @@ namespace SabreTools.Serialization.Wrappers public static SecuROMDFA? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -65,7 +65,7 @@ namespace SabreTools.Serialization.Wrappers public static SecuROMDFA? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -74,7 +74,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.SecuROMDFA().Deserialize(data); - if (model == null) + if (model is null) return null; return new SecuROMDFA(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.Extraction.cs b/SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.Extraction.cs index b5bbbf58..9e44ab2d 100644 --- a/SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.Extraction.cs @@ -43,7 +43,7 @@ namespace SabreTools.Serialization.Wrappers // Get the entry var entry = Entries[index]; - if (entry.Path == null) + if (entry.Path is null) return false; // Ensure directory separators are consistent @@ -57,7 +57,7 @@ namespace SabreTools.Serialization.Wrappers // Read the file var data = ReadFileData(entry, includeDebug); - if (data == null) + if (data is null) return false; // Ensure the full output directory exists @@ -93,7 +93,7 @@ namespace SabreTools.Serialization.Wrappers public byte[]? ReadFileData(MatroshkaEntry entry, bool includeDebug) { // Skip if the entry is incomplete - if (entry.Path == null || entry.MD5 == null) + if (entry.Path is null || entry.MD5 is null) return null; // Cache the expected MD5 diff --git a/SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.cs b/SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.cs index 0de8391d..f84a1b46 100644 --- a/SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.cs +++ b/SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.cs @@ -73,7 +73,7 @@ namespace SabreTools.Serialization.Wrappers public static SecuROMMatroschkaPackage? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -93,7 +93,7 @@ namespace SabreTools.Serialization.Wrappers public static SecuROMMatroschkaPackage? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -102,7 +102,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.SecuROMMatroschkaPackage().Deserialize(data); - if (model == null) + if (model is null) return null; return new SecuROMMatroschkaPackage(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs b/SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs index fb6df68e..fdb129c0 100644 --- a/SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs @@ -24,7 +24,7 @@ namespace SabreTools.Serialization.Wrappers /// public bool Extract(string outputDirectory, bool lookForHeader, bool includeDebug) { - if (_dataSource == null || !_dataSource.CanRead) + if (_dataSource is null || !_dataSource.CanRead) return false; #if NET462_OR_GREATER || NETCOREAPP || NETSTANDARD2_0_OR_GREATER @@ -65,7 +65,7 @@ namespace SabreTools.Serialization.Wrappers continue; // If the entry has an invalid key - if (entry.Key == null) + if (entry.Key is null) continue; // If we have a partial entry due to an incomplete multi-part archive, skip it @@ -77,7 +77,7 @@ namespace SabreTools.Serialization.Wrappers firstFile = false; continue; } - + if (entry.IsSolid) { // If the 7z is solid and the first entry is password-protected, you won't be able to @@ -87,10 +87,10 @@ namespace SabreTools.Serialization.Wrappers if (includeDebug) Console.WriteLine("7z is password-protected!"); return false; } - + isSolid = true; } - + break; } catch (Exception ex) @@ -190,18 +190,18 @@ namespace SabreTools.Serialization.Wrappers continue; // If the entry has an invalid key - if (entry.Key == null) + if (entry.Key is null) continue; // If we have a partial entry due to an incomplete multi-part archive, skip it if (!entry.IsComplete) continue; - + // If the entry is password-protected, skip it if (entry.IsEncrypted) { if (includeDebug) Console.WriteLine($"File {entry.Key} in 7z is password-protected!"); - + continue; } diff --git a/SabreTools.Serialization/Wrappers/SevenZip.cs b/SabreTools.Serialization/Wrappers/SevenZip.cs index 1284a801..d44342bc 100644 --- a/SabreTools.Serialization/Wrappers/SevenZip.cs +++ b/SabreTools.Serialization/Wrappers/SevenZip.cs @@ -50,7 +50,7 @@ namespace SabreTools.Serialization.Wrappers public static SevenZip? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -70,7 +70,7 @@ namespace SabreTools.Serialization.Wrappers public static SevenZip? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; return new SevenZip(new Archive(), data); diff --git a/SabreTools.Serialization/Wrappers/Skeleton.Printing.cs b/SabreTools.Serialization/Wrappers/Skeleton.Printing.cs index 2cb850ea..b0669b82 100644 --- a/SabreTools.Serialization/Wrappers/Skeleton.Printing.cs +++ b/SabreTools.Serialization/Wrappers/Skeleton.Printing.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine("-------------------------"); builder.AppendLine(); - if (Model.SystemArea == null || Model.SystemArea.Length == 0) + if (Model.SystemArea is null || Model.SystemArea.Length == 0) builder.AppendLine(Model.SystemArea, "System Area"); else if (Array.TrueForAll(Model.SystemArea, b => b == 0)) builder.AppendLine("Zeroed", "System Area"); diff --git a/SabreTools.Serialization/Wrappers/Skeleton.cs b/SabreTools.Serialization/Wrappers/Skeleton.cs index 5ee1d611..e5af95a1 100644 --- a/SabreTools.Serialization/Wrappers/Skeleton.cs +++ b/SabreTools.Serialization/Wrappers/Skeleton.cs @@ -45,7 +45,7 @@ namespace SabreTools.Serialization.Wrappers public new static Skeleton? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -65,7 +65,7 @@ namespace SabreTools.Serialization.Wrappers public new static Skeleton? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -74,7 +74,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.ISO9660().Deserialize(data); - if (model == null) + if (model is null) return null; return new Skeleton(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/TapeArchive.Extraction.cs b/SabreTools.Serialization/Wrappers/TapeArchive.Extraction.cs index 0edf3597..3ee1af07 100644 --- a/SabreTools.Serialization/Wrappers/TapeArchive.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/TapeArchive.Extraction.cs @@ -68,7 +68,7 @@ namespace SabreTools.Serialization.Wrappers // Directories case TypeFlag.DIRTYPE: string? entryDirectory = header.FileName?.TrimEnd('\0'); - if (entryDirectory == null) + if (entryDirectory is null) { if (includeDebug) Console.Error.WriteLine($"Entry {i} reported as directory, but no path found! Skipping..."); continue; @@ -113,7 +113,7 @@ namespace SabreTools.Serialization.Wrappers // Exit early if the block has no data var block = entry.Blocks[blockNumber++]; - if (block.Data == null || block.Data.Length != 512) + if (block.Data is null || block.Data.Length != 512) { if (includeDebug) Console.Error.WriteLine($"Invalid data for block number {i + 1}, file may be incomplete!"); break; diff --git a/SabreTools.Serialization/Wrappers/TapeArchive.Printing.cs b/SabreTools.Serialization/Wrappers/TapeArchive.Printing.cs index 6c70031c..c5add49c 100644 --- a/SabreTools.Serialization/Wrappers/TapeArchive.Printing.cs +++ b/SabreTools.Serialization/Wrappers/TapeArchive.Printing.cs @@ -80,7 +80,7 @@ namespace SabreTools.Serialization.Wrappers for (int i = 0; i < entries.Length; i++) { var block = entries[i]; - if (block.Data == null) + if (block.Data is null) builder.AppendLine($" Block {i} Length: 0"); else builder.AppendLine(block.Data.Length, $" Block {i} Length"); diff --git a/SabreTools.Serialization/Wrappers/TapeArchive.cs b/SabreTools.Serialization/Wrappers/TapeArchive.cs index 02d7d398..98318b74 100644 --- a/SabreTools.Serialization/Wrappers/TapeArchive.cs +++ b/SabreTools.Serialization/Wrappers/TapeArchive.cs @@ -52,7 +52,7 @@ namespace SabreTools.Serialization.Wrappers public static TapeArchive? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -72,7 +72,7 @@ namespace SabreTools.Serialization.Wrappers public static TapeArchive? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -81,7 +81,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.TapeArchive().Deserialize(data); - if (model == null) + if (model is null) return null; return new TapeArchive(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/VBSP.Extraction.cs b/SabreTools.Serialization/Wrappers/VBSP.Extraction.cs index 31ea4fe3..f401459d 100644 --- a/SabreTools.Serialization/Wrappers/VBSP.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/VBSP.Extraction.cs @@ -10,7 +10,7 @@ namespace SabreTools.Serialization.Wrappers public bool Extract(string outputDirectory, bool includeDebug) { // If we have no lumps - if (Lumps == null || Lumps.Length == 0) + if (Lumps is null || Lumps.Length == 0) return false; // Loop through and extract all lumps to the output @@ -33,7 +33,7 @@ namespace SabreTools.Serialization.Wrappers public bool ExtractLump(int index, string outputDirectory, bool includeDebug) { // If we have no lumps - if (Lumps == null || Lumps.Length == 0) + if (Lumps is null || Lumps.Length == 0) return false; // If the lumps index is invalid diff --git a/SabreTools.Serialization/Wrappers/VBSP.cs b/SabreTools.Serialization/Wrappers/VBSP.cs index 85f9cd6e..a8543717 100644 --- a/SabreTools.Serialization/Wrappers/VBSP.cs +++ b/SabreTools.Serialization/Wrappers/VBSP.cs @@ -52,7 +52,7 @@ namespace SabreTools.Serialization.Wrappers public static VBSP? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -72,7 +72,7 @@ namespace SabreTools.Serialization.Wrappers public static VBSP? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -81,7 +81,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.VBSP().Deserialize(data); - if (model == null) + if (model is null) return null; return new VBSP(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/VPK.Extraction.cs b/SabreTools.Serialization/Wrappers/VPK.Extraction.cs index 223fc531..1262862e 100644 --- a/SabreTools.Serialization/Wrappers/VPK.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/VPK.Extraction.cs @@ -48,7 +48,7 @@ namespace SabreTools.Serialization.Wrappers byte[] data = []; if (directoryItem.DirectoryEntry.ArchiveIndex == HL_VPK_NO_ARCHIVE) { - if (directoryItem.PreloadData == null) + if (directoryItem.PreloadData is null) return false; data = directoryItem.PreloadData; @@ -56,7 +56,7 @@ namespace SabreTools.Serialization.Wrappers else { // If we have invalid archives - if (ArchiveFilenames == null || ArchiveFilenames.Length == 0) + if (ArchiveFilenames is null || ArchiveFilenames.Length == 0) return false; // If we have an invalid index @@ -101,7 +101,7 @@ namespace SabreTools.Serialization.Wrappers } // If there is nothing to write out - if (data == null) + if (data is null) return false; // If we have an invalid output directory diff --git a/SabreTools.Serialization/Wrappers/VPK.Printing.cs b/SabreTools.Serialization/Wrappers/VPK.Printing.cs index a923400b..6b495dbd 100644 --- a/SabreTools.Serialization/Wrappers/VPK.Printing.cs +++ b/SabreTools.Serialization/Wrappers/VPK.Printing.cs @@ -38,7 +38,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Extended Header Information:"); builder.AppendLine(" -------------------------"); - if (header == null) + if (header is null) { builder.AppendLine(" No extended header"); builder.AppendLine(); @@ -56,7 +56,7 @@ namespace SabreTools.Serialization.Wrappers { builder.AppendLine(" Archive Hashes Information:"); builder.AppendLine(" -------------------------"); - if (entries == null || entries.Length == 0) + if (entries is null || entries.Length == 0) { builder.AppendLine(" No archive hashes"); builder.AppendLine(); diff --git a/SabreTools.Serialization/Wrappers/VPK.cs b/SabreTools.Serialization/Wrappers/VPK.cs index f95372b5..40b2f427 100644 --- a/SabreTools.Serialization/Wrappers/VPK.cs +++ b/SabreTools.Serialization/Wrappers/VPK.cs @@ -36,7 +36,7 @@ namespace SabreTools.Serialization.Wrappers // If the filename is not the right format string extension = Path.GetExtension(Filename).TrimStart('.'); string? directoryName = Path.GetDirectoryName(Filename); - string fileName = directoryName == null + string fileName = directoryName is null ? Path.GetFileNameWithoutExtension(Filename) : Path.Combine(directoryName, Path.GetFileNameWithoutExtension(Filename)); @@ -123,7 +123,7 @@ namespace SabreTools.Serialization.Wrappers public static VPK? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -143,7 +143,7 @@ namespace SabreTools.Serialization.Wrappers public static VPK? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -152,7 +152,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.VPK().Deserialize(data); - if (model == null) + if (model is null) return null; return new VPK(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/WAD3.cs b/SabreTools.Serialization/Wrappers/WAD3.cs index 2a74856d..e7b5fcd1 100644 --- a/SabreTools.Serialization/Wrappers/WAD3.cs +++ b/SabreTools.Serialization/Wrappers/WAD3.cs @@ -51,7 +51,7 @@ namespace SabreTools.Serialization.Wrappers public static WAD3? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -71,7 +71,7 @@ namespace SabreTools.Serialization.Wrappers public static WAD3? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -80,7 +80,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.WAD3().Deserialize(data); - if (model == null) + if (model is null) return null; return new WAD3(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/WiseOverlayHeader.Extraction.cs b/SabreTools.Serialization/Wrappers/WiseOverlayHeader.Extraction.cs index 8eb0feb8..527534e2 100644 --- a/SabreTools.Serialization/Wrappers/WiseOverlayHeader.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/WiseOverlayHeader.Extraction.cs @@ -144,7 +144,7 @@ namespace SabreTools.Serialization.Wrappers string baseName = $"CustomBillboardSet_{obj.Flags:X4}-{obj.Operand_2}-{obj.Operand_3}"; // If there are no deflate objects - if (obj.DeflateInfo == null) + if (obj.DeflateInfo is null) { if (includeDebug) Console.WriteLine($"Skipping {baseName} because the deflate object array is null!"); return ExtractionStatus.FAIL; diff --git a/SabreTools.Serialization/Wrappers/WiseOverlayHeader.cs b/SabreTools.Serialization/Wrappers/WiseOverlayHeader.cs index 89e98ba4..551fd346 100644 --- a/SabreTools.Serialization/Wrappers/WiseOverlayHeader.cs +++ b/SabreTools.Serialization/Wrappers/WiseOverlayHeader.cs @@ -186,7 +186,7 @@ namespace SabreTools.Serialization.Wrappers public static WiseOverlayHeader? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -206,7 +206,7 @@ namespace SabreTools.Serialization.Wrappers public static WiseOverlayHeader? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -215,7 +215,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.WiseOverlayHeader().Deserialize(data); - if (model == null) + if (model is null) return null; return new WiseOverlayHeader(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/WiseScript.Printing.cs b/SabreTools.Serialization/Wrappers/WiseScript.Printing.cs index 374b447a..b9bcaf49 100644 --- a/SabreTools.Serialization/Wrappers/WiseScript.Printing.cs +++ b/SabreTools.Serialization/Wrappers/WiseScript.Printing.cs @@ -44,7 +44,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(); builder.AppendLine(" Header strings"); builder.AppendLine(" -------------------------"); - if (header.HeaderStrings == null || header.HeaderStrings.Length == 0) + if (header.HeaderStrings is null || header.HeaderStrings.Length == 0) { builder.AppendLine(" No header strings"); } @@ -132,7 +132,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(data.DestinationPathname, $" Destination pathname"); builder.AppendLine($" File texts"); builder.AppendLine(" -------------------------"); - if (data.Description == null || data.Description.Length == 0) + if (data.Description is null || data.Description.Length == 0) { builder.AppendLine(" No file texts"); } @@ -160,7 +160,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(data.Flags, $" Flags"); builder.AppendLine($" Title/Text strings"); builder.AppendLine(" -------------------------"); - if (data.TitleText == null || data.TitleText.Length == 0) + if (data.TitleText is null || data.TitleText.Length == 0) { builder.AppendLine(" No title/text strings"); } @@ -181,7 +181,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(data.Flags, $" Count"); builder.AppendLine($" Script lines"); builder.AppendLine(" -------------------------"); - if (data.ScriptLines == null || data.ScriptLines.Length == 0) + if (data.ScriptLines is null || data.ScriptLines.Length == 0) { builder.AppendLine(" No script lines"); } @@ -212,7 +212,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine($" Deflate info:"); builder.AppendLine($" -------------------------"); - if (data.DeflateInfo == null || data.DeflateInfo.Length == 0) + if (data.DeflateInfo is null || data.DeflateInfo.Length == 0) { builder.AppendLine(" No deflate info items"); } @@ -257,7 +257,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(data.ReturnVariable, $" Return variable"); builder.AppendLine($" Entries"); builder.AppendLine(" -------------------------"); - if (data.Entries == null || data.Entries.Length == 0) + if (data.Entries is null || data.Entries.Length == 0) { builder.AppendLine(" No entry data"); } @@ -369,7 +369,7 @@ namespace SabreTools.Serialization.Wrappers builder.AppendLine(data.Destination, $" Destination"); builder.AppendLine($" Descriptions"); builder.AppendLine(" -------------------------"); - if (data.Description == null || data.Description.Length == 0) + if (data.Description is null || data.Description.Length == 0) { builder.AppendLine(" No descriptions"); } @@ -802,7 +802,7 @@ namespace SabreTools.Serialization.Wrappers private static void Print(StringBuilder builder, ExternalDllCall data, int i) { builder.AppendLine($" Entry {i}: ExternalDllCall"); - if (data.Args == null) + if (data.Args is null) builder.AppendLine((string?)null, $" Args"); else builder.AppendLine(string.Join(", ", data.Args), $" Args"); diff --git a/SabreTools.Serialization/Wrappers/WiseScript.cs b/SabreTools.Serialization/Wrappers/WiseScript.cs index 3eceb180..7cd1bef8 100644 --- a/SabreTools.Serialization/Wrappers/WiseScript.cs +++ b/SabreTools.Serialization/Wrappers/WiseScript.cs @@ -92,7 +92,7 @@ namespace SabreTools.Serialization.Wrappers public static WiseScript? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -112,7 +112,7 @@ namespace SabreTools.Serialization.Wrappers public static WiseScript? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -121,7 +121,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.WiseScript().Deserialize(data); - if (model == null) + if (model is null) return null; return new WiseScript(model, data, currentOffset); @@ -198,7 +198,7 @@ namespace SabreTools.Serialization.Wrappers case OperationCode.CreateDirectory: if (state.Data is not CreateDirectory createDirectory) return false; - if (createDirectory.Pathname == null) + if (createDirectory.Pathname is null) return false; try @@ -239,9 +239,9 @@ namespace SabreTools.Serialization.Wrappers case OperationCode.CopyLocalFile: if (state.Data is not CopyLocalFile copyLocalFile) return false; - if (copyLocalFile.Source == null) + if (copyLocalFile.Source is null) return false; - if (copyLocalFile.Destination == null) + if (copyLocalFile.Destination is null) return false; try diff --git a/SabreTools.Serialization/Wrappers/WiseSectionHeader.Extraction.cs b/SabreTools.Serialization/Wrappers/WiseSectionHeader.Extraction.cs index a9d04a5a..253f2b8a 100644 --- a/SabreTools.Serialization/Wrappers/WiseSectionHeader.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/WiseSectionHeader.Extraction.cs @@ -94,7 +94,7 @@ namespace SabreTools.Serialization.Wrappers status = ExtractStreamWithoutChecksum(destination, entrySize, includeDebug); // If the extracted data is invalid - if (status != ExtractionStatus.GOOD || destination == null) + if (status != ExtractionStatus.GOOD || destination is null) return status; // Ensure the full output directory exists diff --git a/SabreTools.Serialization/Wrappers/WiseSectionHeader.cs b/SabreTools.Serialization/Wrappers/WiseSectionHeader.cs index 66b01f04..441539e6 100644 --- a/SabreTools.Serialization/Wrappers/WiseSectionHeader.cs +++ b/SabreTools.Serialization/Wrappers/WiseSectionHeader.cs @@ -126,7 +126,7 @@ namespace SabreTools.Serialization.Wrappers public static WiseSectionHeader? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -146,7 +146,7 @@ namespace SabreTools.Serialization.Wrappers public static WiseSectionHeader? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -155,7 +155,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.WiseSectionHeader().Deserialize(data); - if (model == null) + if (model is null) return null; // HACK: Cache the end-of-header offset diff --git a/SabreTools.Serialization/Wrappers/XMID.cs b/SabreTools.Serialization/Wrappers/XMID.cs index 4cc4bf75..7d56ae01 100644 --- a/SabreTools.Serialization/Wrappers/XMID.cs +++ b/SabreTools.Serialization/Wrappers/XMID.cs @@ -103,13 +103,13 @@ namespace SabreTools.Serialization.Wrappers public static XMID? Create(string? data) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; try { var model = new Readers.XMID().Deserialize(data); - if (model == null) + if (model is null) return null; var ms = new MemoryStream(Encoding.ASCII.GetBytes(data)); diff --git a/SabreTools.Serialization/Wrappers/XZ.Extraction.cs b/SabreTools.Serialization/Wrappers/XZ.Extraction.cs index bb983df3..eb7ee937 100644 --- a/SabreTools.Serialization/Wrappers/XZ.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/XZ.Extraction.cs @@ -16,7 +16,7 @@ namespace SabreTools.Serialization.Wrappers /// public bool Extract(string outputDirectory, bool includeDebug) { - if (_dataSource == null || !_dataSource.CanRead) + if (_dataSource is null || !_dataSource.CanRead) return false; #if NET462_OR_GREATER || NETCOREAPP || NETSTANDARD2_0_OR_GREATER diff --git a/SabreTools.Serialization/Wrappers/XZ.Printing.cs b/SabreTools.Serialization/Wrappers/XZ.Printing.cs index 2276f2a7..80ed7e98 100644 --- a/SabreTools.Serialization/Wrappers/XZ.Printing.cs +++ b/SabreTools.Serialization/Wrappers/XZ.Printing.cs @@ -57,7 +57,7 @@ namespace SabreTools.Serialization.Wrappers // TODO: Print filter flags builder.AppendLine(block.HeaderPadding, " Header padding"); builder.AppendLine(block.Crc32, " CRC-32"); - if (block.CompressedData == null) + if (block.CompressedData is null) builder.AppendLine(" Compressed data length: [NULL]"); else builder.AppendLine(block.CompressedData.Length, " Compressed data length"); diff --git a/SabreTools.Serialization/Wrappers/XZ.cs b/SabreTools.Serialization/Wrappers/XZ.cs index 69ebe0c7..bbae9019 100644 --- a/SabreTools.Serialization/Wrappers/XZ.cs +++ b/SabreTools.Serialization/Wrappers/XZ.cs @@ -50,7 +50,7 @@ namespace SabreTools.Serialization.Wrappers public static XZ? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -70,7 +70,7 @@ namespace SabreTools.Serialization.Wrappers public static XZ? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -79,7 +79,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.XZ().Deserialize(data); - if (model == null) + if (model is null) return null; return new XZ(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/XZP.Extraction.cs b/SabreTools.Serialization/Wrappers/XZP.Extraction.cs index 50570f02..de01b0b8 100644 --- a/SabreTools.Serialization/Wrappers/XZP.Extraction.cs +++ b/SabreTools.Serialization/Wrappers/XZP.Extraction.cs @@ -46,7 +46,7 @@ namespace SabreTools.Serialization.Wrappers // Get the associated directory item var directoryEntry = DirectoryEntries[index]; var directoryItem = Array.Find(DirectoryItems, di => di?.FileNameCRC == directoryEntry.FileNameCRC); - if (directoryItem == null) + if (directoryItem is null) return false; // Load the item data diff --git a/SabreTools.Serialization/Wrappers/XZP.cs b/SabreTools.Serialization/Wrappers/XZP.cs index 13f7a766..a98da8ae 100644 --- a/SabreTools.Serialization/Wrappers/XZP.cs +++ b/SabreTools.Serialization/Wrappers/XZP.cs @@ -54,7 +54,7 @@ namespace SabreTools.Serialization.Wrappers public static XZP? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -74,7 +74,7 @@ namespace SabreTools.Serialization.Wrappers public static XZP? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -83,7 +83,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.XZP().Deserialize(data); - if (model == null) + if (model is null) return null; return new XZP(model, data, currentOffset); diff --git a/SabreTools.Serialization/Wrappers/XeMID.cs b/SabreTools.Serialization/Wrappers/XeMID.cs index 840bbddc..68fcc570 100644 --- a/SabreTools.Serialization/Wrappers/XeMID.cs +++ b/SabreTools.Serialization/Wrappers/XeMID.cs @@ -125,13 +125,13 @@ namespace SabreTools.Serialization.Wrappers public static XeMID? Create(string? data) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; try { var model = new Readers.XeMID().Deserialize(data); - if (model == null) + if (model is null) return null; var ms = new MemoryStream(Encoding.ASCII.GetBytes(data)); diff --git a/SabreTools.Serialization/Wrappers/ZSTD.cs b/SabreTools.Serialization/Wrappers/ZSTD.cs index d9cb6d00..fb427e75 100644 --- a/SabreTools.Serialization/Wrappers/ZSTD.cs +++ b/SabreTools.Serialization/Wrappers/ZSTD.cs @@ -55,7 +55,7 @@ namespace SabreTools.Serialization.Wrappers public static ZSTD? Create(byte[]? data, int offset) { // If the data is invalid - if (data == null || data.Length == 0) + if (data is null || data.Length == 0) return null; // If the offset is out of bounds @@ -75,7 +75,7 @@ namespace SabreTools.Serialization.Wrappers public static ZSTD? Create(Stream? data) { // If the data is invalid - if (data == null || !data.CanRead) + if (data is null || !data.CanRead) return null; try @@ -84,7 +84,7 @@ namespace SabreTools.Serialization.Wrappers long currentOffset = data.Position; var model = new Readers.ZSTD().Deserialize(data); - if (model == null) + if (model is null) return null; return new ZSTD(model, data, currentOffset); diff --git a/SabreTools.Serialization/Writers/AttractMode.cs b/SabreTools.Serialization/Writers/AttractMode.cs index 9887b1dc..db2d8b8c 100644 --- a/SabreTools.Serialization/Writers/AttractMode.cs +++ b/SabreTools.Serialization/Writers/AttractMode.cs @@ -73,7 +73,7 @@ namespace SabreTools.Serialization.Writers public byte[]? SerializeArray(MetadataFile? obj, bool longHeader) { using var stream = SerializeStream(obj, longHeader); - if (stream == null) + if (stream is null) return null; byte[] bytes = new byte[stream.Length]; @@ -96,7 +96,7 @@ namespace SabreTools.Serialization.Writers return false; using var stream = SerializeStream(obj, longHeader); - if (stream == null) + if (stream is null) return false; using var fs = File.Open(path, FileMode.Create, FileAccess.Write, FileShare.None); @@ -118,7 +118,7 @@ namespace SabreTools.Serialization.Writers public Stream? SerializeStream(MetadataFile? obj, bool longHeader) { // If the metadata file is null - if (obj == null) + if (obj is null) return null; // Setup the writer and output @@ -150,13 +150,13 @@ namespace SabreTools.Serialization.Writers private static void WriteRows(Row[]? rows, SeparatedValueWriter writer, bool longHeader) { // If the games information is missing, we can't do anything - if (rows == null || rows.Length == 0) + if (rows is null || rows.Length == 0) return; // Loop through and write out the rows foreach (var row in rows) { - if (row == null) + if (row is null) continue; string?[] rowArray; diff --git a/SabreTools.Serialization/Writers/BaseBinarySerializer.cs b/SabreTools.Serialization/Writers/BaseBinarySerializer.cs index 70a0871b..986875fd 100644 --- a/SabreTools.Serialization/Writers/BaseBinarySerializer.cs +++ b/SabreTools.Serialization/Writers/BaseBinarySerializer.cs @@ -22,7 +22,7 @@ namespace SabreTools.Serialization.Writers public virtual byte[]? SerializeArray(TModel? obj) { using var stream = SerializeStream(obj); - if (stream == null) + if (stream is null) return null; byte[] bytes = new byte[stream.Length]; @@ -41,7 +41,7 @@ namespace SabreTools.Serialization.Writers return false; using var stream = SerializeStream(obj); - if (stream == null) + if (stream is null) return false; using var fs = File.Open(path, FileMode.Create, FileAccess.Write, FileShare.None); diff --git a/SabreTools.Serialization/Writers/ClrMamePro.cs b/SabreTools.Serialization/Writers/ClrMamePro.cs index 86e5d002..62b93881 100644 --- a/SabreTools.Serialization/Writers/ClrMamePro.cs +++ b/SabreTools.Serialization/Writers/ClrMamePro.cs @@ -18,7 +18,7 @@ namespace SabreTools.Serialization.Writers public byte[]? SerializeArray(MetadataFile? obj, bool quotes) { using var stream = SerializeStream(obj, quotes); - if (stream == null) + if (stream is null) return null; byte[] bytes = new byte[stream.Length]; @@ -41,7 +41,7 @@ namespace SabreTools.Serialization.Writers return false; using var stream = SerializeStream(obj, quotes); - if (stream == null) + if (stream is null) return false; using var fs = File.Open(path, FileMode.Create, FileAccess.Write, FileShare.None); @@ -63,7 +63,7 @@ namespace SabreTools.Serialization.Writers public Stream? SerializeStream(MetadataFile? obj, bool quotes) { // If the metadata file is null - if (obj == null) + if (obj is null) return null; // Setup the writer and output @@ -92,7 +92,7 @@ namespace SabreTools.Serialization.Writers private static void WriteHeader(Data.Models.ClrMamePro.ClrMamePro? header, ClrMameProWriter writer) { // If the header information is missing, we can't do anything - if (header == null) + if (header is null) return; writer.WriteStartElement("clrmamepro"); @@ -125,13 +125,13 @@ namespace SabreTools.Serialization.Writers private static void WriteGames(GameBase[]? games, ClrMameProWriter writer) { // If the games information is missing, we can't do anything - if (games == null || games.Length == 0) + if (games is null || games.Length == 0) return; // Loop through and write out the games foreach (var game in games) { - if (game == null) + if (game is null) continue; WriteGame(game, writer); @@ -147,7 +147,7 @@ namespace SabreTools.Serialization.Writers private static void WriteGame(GameBase game, ClrMameProWriter writer) { // If the game information is missing, we can't do anything - if (game == null) + if (game is null) return; switch (game) @@ -202,7 +202,7 @@ namespace SabreTools.Serialization.Writers private static void WriteReleases(Release[]? releases, ClrMameProWriter writer) { // If the array is missing, we can't do anything - if (releases == null) + if (releases is null) return; foreach (var release in releases) @@ -225,7 +225,7 @@ namespace SabreTools.Serialization.Writers private static void WriteBiosSets(BiosSet[]? biossets, ClrMameProWriter writer) { // If the array is missing, we can't do anything - if (biossets == null) + if (biossets is null) return; foreach (var biosset in biossets) @@ -246,7 +246,7 @@ namespace SabreTools.Serialization.Writers private static void WriteRoms(Rom[]? roms, ClrMameProWriter writer) { // If the array is missing, we can't do anything - if (roms == null) + if (roms is null) return; foreach (var rom in roms) @@ -291,7 +291,7 @@ namespace SabreTools.Serialization.Writers private static void WriteDisks(Disk[]? disks, ClrMameProWriter writer) { // If the array is missing, we can't do anything - if (disks == null) + if (disks is null) return; foreach (var disk in disks) @@ -315,7 +315,7 @@ namespace SabreTools.Serialization.Writers private static void WriteMedia(Media[]? medias, ClrMameProWriter writer) { // If the array is missing, we can't do anything - if (medias == null) + if (medias is null) return; foreach (var media in medias) @@ -338,7 +338,7 @@ namespace SabreTools.Serialization.Writers private static void WriteSamples(Sample[]? samples, ClrMameProWriter writer) { // If the array is missing, we can't do anything - if (samples == null) + if (samples is null) return; foreach (var sample in samples) @@ -357,7 +357,7 @@ namespace SabreTools.Serialization.Writers private static void WriteArchives(Archive[]? archives, ClrMameProWriter writer) { // If the array is missing, we can't do anything - if (archives == null) + if (archives is null) return; foreach (var archive in archives) @@ -376,7 +376,7 @@ namespace SabreTools.Serialization.Writers private static void WriteChips(Chip[]? chips, ClrMameProWriter writer) { // If the array is missing, we can't do anything - if (chips == null) + if (chips is null) return; foreach (var chip in chips) @@ -398,7 +398,7 @@ namespace SabreTools.Serialization.Writers private static void WriteVideos(Video[]? videos, ClrMameProWriter writer) { // If the item is missing, we can't do anything - if (videos == null) + if (videos is null) return; foreach (var video in videos) @@ -423,7 +423,7 @@ namespace SabreTools.Serialization.Writers private static void WriteSound(Sound? sound, ClrMameProWriter writer) { // If the item is missing, we can't do anything - if (sound == null) + if (sound is null) return; writer.WriteStartElement("sound"); @@ -439,7 +439,7 @@ namespace SabreTools.Serialization.Writers private static void WriteInput(Input? input, ClrMameProWriter writer) { // If the item is missing, we can't do anything - if (input == null) + if (input is null) return; writer.WriteStartElement("input"); @@ -460,7 +460,7 @@ namespace SabreTools.Serialization.Writers private static void WriteDipSwitches(DipSwitch[]? dipswitches, ClrMameProWriter writer) { // If the array is missing, we can't do anything - if (dipswitches == null) + if (dipswitches is null) return; foreach (var dipswitch in dipswitches) @@ -484,7 +484,7 @@ namespace SabreTools.Serialization.Writers private static void WriteDriver(Driver? driver, ClrMameProWriter writer) { // If the item is missing, we can't do anything - if (driver == null) + if (driver is null) return; writer.WriteStartElement("driver"); @@ -504,7 +504,7 @@ namespace SabreTools.Serialization.Writers private static void WriteInfo(Info? info, ClrMameProWriter writer) { // If the info information is missing, we can't do anything - if (info?.Source == null) + if (info?.Source is null) return; writer.WriteStartElement("info"); diff --git a/SabreTools.Serialization/Writers/CueSheet.cs b/SabreTools.Serialization/Writers/CueSheet.cs index 9a4c39a7..21edd4dd 100644 --- a/SabreTools.Serialization/Writers/CueSheet.cs +++ b/SabreTools.Serialization/Writers/CueSheet.cs @@ -12,11 +12,11 @@ namespace SabreTools.Serialization.Writers public override Stream? SerializeStream(Data.Models.CueSheets.CueSheet? obj) { // If the cuesheet is null - if (obj == null) + if (obj is null) return null; // If we don't have any files, it's invalid - if (obj?.Files == null) + if (obj?.Files is null) throw new InvalidDataException(nameof(obj.Files)); else if (obj.Files.Length == 0) throw new ArgumentException("No files provided to write"); @@ -45,7 +45,7 @@ namespace SabreTools.Serialization.Writers private static void WriteCueSheet(Data.Models.CueSheets.CueSheet cueSheet, StreamWriter sw) { // If we don't have any files, it's invalid - if (cueSheet.Files == null) + if (cueSheet.Files is null) throw new InvalidDataException(nameof(cueSheet.Files)); else if (cueSheet.Files.Length == 0) throw new ArgumentException("No files provided to write"); @@ -79,7 +79,7 @@ namespace SabreTools.Serialization.Writers private static void WriteCueFile(CueFile? cueFile, StreamWriter sw) { // If we don't have any tracks, it's invalid - if (cueFile?.Tracks == null) + if (cueFile?.Tracks is null) throw new InvalidDataException(nameof(cueFile.Tracks)); else if (cueFile.Tracks.Length == 0) throw new ArgumentException("No tracks provided to write"); @@ -100,7 +100,7 @@ namespace SabreTools.Serialization.Writers private static void WriteCueTrack(CueTrack? cueTrack, StreamWriter sw) { // If we don't have any indices, it's invalid - if (cueTrack?.Indices == null) + if (cueTrack?.Indices is null) throw new InvalidDataException(nameof(cueTrack.Indices)); else if (cueTrack.Indices.Length == 0) throw new ArgumentException("No indices provided to write"); @@ -151,7 +151,7 @@ namespace SabreTools.Serialization.Writers /// StreamWriter to write to private static void WriteCueIndex(CueIndex? cueIndex, StreamWriter sw) { - if (cueIndex == null) + if (cueIndex is null) throw new ArgumentNullException(nameof(cueIndex)); sw.WriteLine($" INDEX {cueIndex.Index:D2} {cueIndex.Minutes:D2}:{cueIndex.Seconds:D2}:{cueIndex.Frames:D2}"); diff --git a/SabreTools.Serialization/Writers/DosCenter.cs b/SabreTools.Serialization/Writers/DosCenter.cs index 41370c86..98f36982 100644 --- a/SabreTools.Serialization/Writers/DosCenter.cs +++ b/SabreTools.Serialization/Writers/DosCenter.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Writers public override Stream? SerializeStream(MetadataFile? obj) { // If the metadata file is null - if (obj == null) + if (obj is null) return null; // Setup the writer and output @@ -41,7 +41,7 @@ namespace SabreTools.Serialization.Writers private static void WriteHeader(Data.Models.DosCenter.DosCenter? header, ClrMameProWriter writer) { // If the header information is missing, we can't do anything - if (header == null) + if (header is null) return; writer.WriteStartElement("DOSCenter"); @@ -66,7 +66,7 @@ namespace SabreTools.Serialization.Writers private static void WriteGames(Game[]? games, ClrMameProWriter writer) { // If the games information is missing, we can't do anything - if (games == null || games.Length == 0) + if (games is null || games.Length == 0) return; // Loop through and write out the games @@ -85,7 +85,7 @@ namespace SabreTools.Serialization.Writers private static void WriteGame(Game game, ClrMameProWriter writer) { // If the game information is missing, we can't do anything - if (game == null) + if (game is null) return; writer.WriteStartElement("game"); @@ -107,7 +107,7 @@ namespace SabreTools.Serialization.Writers private static void WriteFiles(Data.Models.DosCenter.File[]? files, ClrMameProWriter writer) { // If the array is missing, we can't do anything - if (files == null) + if (files is null) return; foreach (var file in files) diff --git a/SabreTools.Serialization/Writers/EverdriveSMDB.cs b/SabreTools.Serialization/Writers/EverdriveSMDB.cs index 6a82e977..76f3b371 100644 --- a/SabreTools.Serialization/Writers/EverdriveSMDB.cs +++ b/SabreTools.Serialization/Writers/EverdriveSMDB.cs @@ -13,7 +13,7 @@ namespace SabreTools.Serialization.Writers public override Stream? SerializeStream(MetadataFile? obj) { // If the metadata file is null - if (obj == null) + if (obj is null) return null; // Setup the writer and output @@ -36,13 +36,13 @@ namespace SabreTools.Serialization.Writers private static void WriteRows(Row[]? rows, SeparatedValueWriter writer) { // If the games information is missing, we can't do anything - if (rows == null || rows.Length == 0) + if (rows is null || rows.Length == 0) return; // Loop through and write out the rows foreach (var row in rows) { - if (row == null) + if (row is null) continue; var rowArray = new List diff --git a/SabreTools.Serialization/Writers/Hashfile.cs b/SabreTools.Serialization/Writers/Hashfile.cs index ce5c7f9d..1863b59a 100644 --- a/SabreTools.Serialization/Writers/Hashfile.cs +++ b/SabreTools.Serialization/Writers/Hashfile.cs @@ -20,7 +20,7 @@ namespace SabreTools.Serialization.Writers public byte[]? SerializeArray(Data.Models.Hashfile.Hashfile? obj, HashType hash) { using var stream = SerializeStream(obj, hash); - if (stream == null) + if (stream is null) return null; byte[] bytes = new byte[stream.Length]; @@ -43,7 +43,7 @@ namespace SabreTools.Serialization.Writers return false; using var stream = SerializeStream(obj, hash); - if (stream == null) + if (stream is null) return false; using var fs = File.Open(path, FileMode.Create, FileAccess.Write, FileShare.None); @@ -65,7 +65,7 @@ namespace SabreTools.Serialization.Writers public Stream? SerializeStream(Data.Models.Hashfile.Hashfile? obj, HashType hash) { // If the metadata file is null - if (obj == null) + if (obj is null) return null; // Setup the writer and output @@ -130,7 +130,7 @@ namespace SabreTools.Serialization.Writers private static void WriteSFV(SFV[]? sfvs, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (sfvs == null || sfvs.Length == 0) + if (sfvs is null || sfvs.Length == 0) return; // Loop through and write out the items @@ -152,7 +152,7 @@ namespace SabreTools.Serialization.Writers private static void WriteMD2(MD2[]? md2s, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (md2s == null || md2s.Length == 0) + if (md2s is null || md2s.Length == 0) return; // Loop through and write out the items @@ -174,7 +174,7 @@ namespace SabreTools.Serialization.Writers private static void WriteMD4(MD4[]? md4s, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (md4s == null || md4s.Length == 0) + if (md4s is null || md4s.Length == 0) return; // Loop through and write out the items @@ -196,7 +196,7 @@ namespace SabreTools.Serialization.Writers private static void WriteMD5(MD5[]? md5s, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (md5s == null || md5s.Length == 0) + if (md5s is null || md5s.Length == 0) return; // Loop through and write out the items @@ -218,7 +218,7 @@ namespace SabreTools.Serialization.Writers private static void WriteRIPEMD128(RIPEMD128[]? ripemd128s, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (ripemd128s == null || ripemd128s.Length == 0) + if (ripemd128s is null || ripemd128s.Length == 0) return; // Loop through and write out the items @@ -240,7 +240,7 @@ namespace SabreTools.Serialization.Writers private static void WriteRIPEMD160(RIPEMD160[]? ripemd160s, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (ripemd160s == null || ripemd160s.Length == 0) + if (ripemd160s is null || ripemd160s.Length == 0) return; // Loop through and write out the items @@ -262,7 +262,7 @@ namespace SabreTools.Serialization.Writers private static void WriteSHA1(SHA1[]? sha1s, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (sha1s == null || sha1s.Length == 0) + if (sha1s is null || sha1s.Length == 0) return; // Loop through and write out the items @@ -284,7 +284,7 @@ namespace SabreTools.Serialization.Writers private static void WriteSHA256(SHA256[]? sha256s, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (sha256s == null || sha256s.Length == 0) + if (sha256s is null || sha256s.Length == 0) return; // Loop through and write out the items @@ -306,7 +306,7 @@ namespace SabreTools.Serialization.Writers private static void WriteSHA384(SHA384[]? sha384s, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (sha384s == null || sha384s.Length == 0) + if (sha384s is null || sha384s.Length == 0) return; // Loop through and write out the items @@ -328,7 +328,7 @@ namespace SabreTools.Serialization.Writers private static void WriteSHA512(SHA512[]? sha512s, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (sha512s == null || sha512s.Length == 0) + if (sha512s is null || sha512s.Length == 0) return; // Loop through and write out the items @@ -350,7 +350,7 @@ namespace SabreTools.Serialization.Writers private static void WriteSpamSum(SpamSum[]? spamsums, SeparatedValueWriter writer) { // If the item information is missing, we can't do anything - if (spamsums == null || spamsums.Length == 0) + if (spamsums is null || spamsums.Length == 0) return; // Loop through and write out the items diff --git a/SabreTools.Serialization/Writers/IRD.cs b/SabreTools.Serialization/Writers/IRD.cs index 79e4233a..46a50f30 100644 --- a/SabreTools.Serialization/Writers/IRD.cs +++ b/SabreTools.Serialization/Writers/IRD.cs @@ -10,7 +10,7 @@ namespace SabreTools.Serialization.Writers public override Stream? SerializeStream(Data.Models.IRD.File? obj) { // If the data is invalid - if (obj?.Magic == null) + if (obj?.Magic is null) return null; // If the magic doesn't match @@ -37,11 +37,11 @@ namespace SabreTools.Serialization.Writers return null; if (obj.Footer.Length != obj.FooterLength) return null; - if (obj.RegionHashes.Length != obj.RegionCount || !Array.TrueForAll(obj.RegionHashes, h => h == null || h.Length != 16)) + if (obj.RegionHashes.Length != obj.RegionCount || !Array.TrueForAll(obj.RegionHashes, h => h is null || h.Length != 16)) return null; if (obj.FileKeys.Length != obj.FileCount) return null; - if (obj.FileHashes.Length != obj.FileCount || !Array.TrueForAll(obj.FileHashes, h => h == null || h.Length != 16)) + if (obj.FileHashes.Length != obj.FileCount || !Array.TrueForAll(obj.FileHashes, h => h is null || h.Length != 16)) return null; if (obj.PIC.Length != 115) return null; diff --git a/SabreTools.Serialization/Writers/JsonFile.cs b/SabreTools.Serialization/Writers/JsonFile.cs index 20508648..7b8b2ac3 100644 --- a/SabreTools.Serialization/Writers/JsonFile.cs +++ b/SabreTools.Serialization/Writers/JsonFile.cs @@ -27,7 +27,7 @@ namespace SabreTools.Serialization.Writers public byte[]? SerializeArray(T? obj, Encoding encoding) { using var stream = Serialize(obj, encoding); - if (stream == null) + if (stream is null) return null; byte[] bytes = new byte[stream.Length]; @@ -57,7 +57,7 @@ namespace SabreTools.Serialization.Writers return false; using var stream = Serialize(obj, encoding); - if (stream == null) + if (stream is null) return false; using var fs = File.Open(path, FileMode.Create, FileAccess.Write, FileShare.None); @@ -85,7 +85,7 @@ namespace SabreTools.Serialization.Writers public Stream? Serialize(T? obj, Encoding encoding) { // If the object is null - if (obj == null) + if (obj is null) return null; // Setup the serializer and the writer diff --git a/SabreTools.Serialization/Writers/Listrom.cs b/SabreTools.Serialization/Writers/Listrom.cs index 7767ee79..1e3fa2b3 100644 --- a/SabreTools.Serialization/Writers/Listrom.cs +++ b/SabreTools.Serialization/Writers/Listrom.cs @@ -11,7 +11,7 @@ namespace SabreTools.Serialization.Writers public override Stream? SerializeStream(MetadataFile? obj) { // If the metadata file is null - if (obj == null) + if (obj is null) return null; // Setup the writer and output @@ -34,7 +34,7 @@ namespace SabreTools.Serialization.Writers private static void WriteSets(Set[]? sets, StreamWriter writer) { // If the games information is missing, we can't do anything - if (sets == null || sets.Length == 0) + if (sets is null || sets.Length == 0) return; // Loop through and write out the games @@ -53,7 +53,7 @@ namespace SabreTools.Serialization.Writers private static void WriteSet(Set set, StreamWriter writer) { // If the set information is missing, we can't do anything - if (set == null) + if (set is null) return; if (!string.IsNullOrEmpty(set.Driver)) @@ -106,7 +106,7 @@ namespace SabreTools.Serialization.Writers private static void WriteRows(Row[]? rows, StreamWriter writer) { // If the array is missing, we can't do anything - if (rows == null) + if (rows is null) return; foreach (var row in rows) diff --git a/SabreTools.Serialization/Writers/RomCenter.cs b/SabreTools.Serialization/Writers/RomCenter.cs index f8d2668c..c40985c4 100644 --- a/SabreTools.Serialization/Writers/RomCenter.cs +++ b/SabreTools.Serialization/Writers/RomCenter.cs @@ -12,7 +12,7 @@ namespace SabreTools.Serialization.Writers public override Stream? SerializeStream(MetadataFile? obj) { // If the metadata file is null - if (obj == null) + if (obj is null) return null; // Setup the writer and output @@ -44,7 +44,7 @@ namespace SabreTools.Serialization.Writers private static void WriteCredits(Credits? credits, IniWriter writer) { // If the credits information is missing, we can't do anything - if (credits == null) + if (credits is null) return; writer.WriteSection("CREDITS"); @@ -76,7 +76,7 @@ namespace SabreTools.Serialization.Writers private static void WriteDat(Dat? dat, IniWriter writer) { // If the dat information is missing, we can't do anything - if (dat == null) + if (dat is null) return; writer.WriteSection("DAT"); @@ -102,7 +102,7 @@ namespace SabreTools.Serialization.Writers private static void WriteEmulator(Emulator? emulator, IniWriter writer) { // If the emulator information is missing, we can't do anything - if (emulator == null) + if (emulator is null) return; writer.WriteSection("EMULATOR"); @@ -124,7 +124,7 @@ namespace SabreTools.Serialization.Writers private static void WriteGames(Games? games, IniWriter writer) { // If the games information is missing, we can't do anything - if (games?.Rom == null || games.Rom.Length == 0) + if (games?.Rom is null || games.Rom.Length == 0) return; writer.WriteSection("GAMES"); diff --git a/SabreTools.Serialization/Writers/SeparatedValue.cs b/SabreTools.Serialization/Writers/SeparatedValue.cs index 47587f62..5461ae2a 100644 --- a/SabreTools.Serialization/Writers/SeparatedValue.cs +++ b/SabreTools.Serialization/Writers/SeparatedValue.cs @@ -61,7 +61,7 @@ namespace SabreTools.Serialization.Writers public byte[]? SerializeArray(MetadataFile? obj, char delim, bool longHeader) { using var stream = SerializeStream(obj, delim, longHeader); - if (stream == null) + if (stream is null) return null; byte[] bytes = new byte[stream.Length]; @@ -84,7 +84,7 @@ namespace SabreTools.Serialization.Writers return false; using var stream = SerializeStream(obj, delim, longHeader); - if (stream == null) + if (stream is null) return false; using var fs = File.Open(path, FileMode.Create, FileAccess.Write, FileShare.None); @@ -106,7 +106,7 @@ namespace SabreTools.Serialization.Writers public Stream? SerializeStream(MetadataFile? obj, char delim, bool longHeader) { // If the metadata file is null - if (obj == null) + if (obj is null) return null; // Setup the writer and output @@ -149,7 +149,7 @@ namespace SabreTools.Serialization.Writers private static void WriteRows(Row[]? rows, SeparatedValueWriter writer, bool longHeader) { // If the games information is missing, we can't do anything - if (rows == null || rows.Length == 0) + if (rows is null || rows.Length == 0) return; // Loop through and write out the rows diff --git a/SabreTools.Serialization/Writers/XMID.cs b/SabreTools.Serialization/Writers/XMID.cs index ccbfe125..df4c9004 100644 --- a/SabreTools.Serialization/Writers/XMID.cs +++ b/SabreTools.Serialization/Writers/XMID.cs @@ -15,7 +15,7 @@ namespace SabreTools.Serialization.Writers /// public string? Serialize(Data.Models.Xbox.XMID? obj) { - if (obj == null) + if (obj is null) return null; var sb = new StringBuilder(); diff --git a/SabreTools.Serialization/Writers/XeMID.cs b/SabreTools.Serialization/Writers/XeMID.cs index 868214ec..478f1d06 100644 --- a/SabreTools.Serialization/Writers/XeMID.cs +++ b/SabreTools.Serialization/Writers/XeMID.cs @@ -15,7 +15,7 @@ namespace SabreTools.Serialization.Writers /// public string? Serialize(Data.Models.Xbox.XeMID? obj) { - if (obj == null) + if (obj is null) return null; var sb = new StringBuilder(); diff --git a/SabreTools.Serialization/Writers/XmlFile.cs b/SabreTools.Serialization/Writers/XmlFile.cs index abbe4464..051b0560 100644 --- a/SabreTools.Serialization/Writers/XmlFile.cs +++ b/SabreTools.Serialization/Writers/XmlFile.cs @@ -30,7 +30,7 @@ namespace SabreTools.Serialization.Writers public byte[]? SerializeArray(T? obj, string? name = null, string? pubid = null, string? sysid = null, string? subset = null) { using var stream = Serialize(obj, name, pubid, sysid, subset); - if (stream == null) + if (stream is null) return null; byte[] bytes = new byte[stream.Length]; @@ -62,7 +62,7 @@ namespace SabreTools.Serialization.Writers return false; using var stream = Serialize(obj, name, pubid, sysid, subset); - if (stream == null) + if (stream is null) return false; using var fs = File.Open(path, FileMode.Create, FileAccess.Write, FileShare.None); @@ -92,7 +92,7 @@ namespace SabreTools.Serialization.Writers public Stream? Serialize(T? obj, string? name = null, string? pubid = null, string? sysid = null, string? subset = null) { // If the object is null - if (obj == null) + if (obj is null) return null; // Setup the serializer and the writer diff --git a/SabreTools.Serialization/_EXTERNAL/StormLibSharp/MpqArchive.cs b/SabreTools.Serialization/_EXTERNAL/StormLibSharp/MpqArchive.cs index 9817fef9..13144ff5 100644 --- a/SabreTools.Serialization/_EXTERNAL/StormLibSharp/MpqArchive.cs +++ b/SabreTools.Serialization/_EXTERNAL/StormLibSharp/MpqArchive.cs @@ -106,7 +106,7 @@ namespace StormLibSharp private void VerifyHandle() { - if (_handle == null || _handle.IsInvalid) + if (_handle is null || _handle.IsInvalid) throw new ObjectDisposedException("MpqArchive"); } @@ -202,7 +202,7 @@ namespace StormLibSharp public void AddPatchArchives(IEnumerable patchPaths) { - if (patchPaths == null) + if (patchPaths is null) throw new ArgumentNullException("patchPaths"); VerifyHandle(); diff --git a/SabreTools.Serialization/_EXTERNAL/StormLibSharp/MpqFileStream.cs b/SabreTools.Serialization/_EXTERNAL/StormLibSharp/MpqFileStream.cs index 26e5c0b0..77feb504 100644 --- a/SabreTools.Serialization/_EXTERNAL/StormLibSharp/MpqFileStream.cs +++ b/SabreTools.Serialization/_EXTERNAL/StormLibSharp/MpqFileStream.cs @@ -21,7 +21,7 @@ namespace StormLibSharp private void VerifyHandle() { - if (_handle == null || _handle.IsInvalid || _handle.IsClosed) + if (_handle is null || _handle.IsInvalid || _handle.IsClosed) throw new ObjectDisposedException("MpqFileStream"); } @@ -77,7 +77,7 @@ namespace StormLibSharp public override unsafe int Read(byte[] buffer, int offset, int count) { - if (buffer == null) + if (buffer is null) throw new ArgumentNullException(nameof(buffer)); if (offset > buffer.Length || (offset + count) > buffer.Length) throw new ArgumentException(); @@ -122,7 +122,7 @@ namespace StormLibSharp { VerifyHandle(); - if (buffer == null) + if (buffer is null) throw new ArgumentNullException(nameof(buffer)); if (offset > buffer.Length || (offset + count) > buffer.Length) throw new ArgumentException(); diff --git a/SabreTools.Serialization/_EXTERNAL/StormLibSharp/Native/NativeMethods.cs b/SabreTools.Serialization/_EXTERNAL/StormLibSharp/Native/NativeMethods.cs index 85d76c4a..b71a3d2a 100644 --- a/SabreTools.Serialization/_EXTERNAL/StormLibSharp/Native/NativeMethods.cs +++ b/SabreTools.Serialization/_EXTERNAL/StormLibSharp/Native/NativeMethods.cs @@ -153,7 +153,7 @@ namespace StormLibSharp.Native MpqFileSafeHandle? hFile ) { - if (hFile == null || hFile.IsInvalid || hFile.IsClosed) + if (hFile is null || hFile.IsInvalid || hFile.IsClosed) throw new InvalidOperationException(); IntPtr handle = hFile.DangerousGetHandle();