[PR #2] [MERGED] Update CueSheet.Deserializer.cs #25

New Issue

Open

opened 2026-01-29 21:16:41 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:41 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/2
Author: @Deterous
Created: 12/29/2023
Status: ✅ Merged
Merged: 1/3/2024
Merged by: @mnadareski

Base: main ← Head: Deterous-patch-1

---

📝 Commits (2)

• e047c76 Update CueSheet.Deserializer.cs
• b6b0dcc Explicitly deal with new track/file cases

📊 Changes

1 file changed (+14 additions, -1 deletions)

View changed files

📝 Files/CueSheet.Deserializer.cs (+14 -1)

📄 Description

Don't return null when cuesheet is not ended, instead return the current CUE file/track
This prevents Cuesheet deserializer from returning malformed tracks and files for multi-file CUEs.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/2 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 12/29/2023 **Status:** ✅ Merged **Merged:** 1/3/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `Deterous-patch-1` --- ### 📝 Commits (2) - [`e047c76`](https://github.com/SabreTools/SabreTools.Serialization/commit/e047c76059ea1c78375986dcf10e757e4638deda) Update CueSheet.Deserializer.cs - [`b6b0dcc`](https://github.com/SabreTools/SabreTools.Serialization/commit/b6b0dccc3d88679629e9c081edb633a5b3ed8a6c) Explicitly deal with new track/file cases ### 📊 Changes **1 file changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Files/CueSheet.Deserializer.cs` (+14 -1) </details> ### 📄 Description Don't return null when cuesheet is not ended, instead return the current CUE file/track This prevents Cuesheet deserializer from returning malformed tracks and files for multi-file CUEs. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:16:41 +00:00

claunia referenced this issue 2026-01-29 21:16:46 +00:00

[PR #25] [MERGED] Small fix to temp solid code just in case #49

claunia referenced this issue 2026-01-29 21:16:47 +00:00

[PR #25] Small fix to temp solid code just in case #54

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#25