[PR #17] [MERGED] Add extra validity checks for GCF #41

New Issue

Open

opened 2026-01-29 21:16:45 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:45 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/17
Author: @HeroponRikiBestest
Created: 7/12/2025
Status: ✅ Merged
Merged: 7/12/2025
Merged by: @mnadareski

Base: main ← Head: quakeET-falsepositive-GCF-md5b

---

📝 Commits (2)

• 8bb25d7 Add extra validity checks for GCF
• 1cb0fbf Remove "for validity"

📊 Changes

1 file changed (+9 additions, -2 deletions)

View changed files

📝 SabreTools.Serialization/Deserializers/GCF.cs (+9 -2)

📄 Description

Fixes false GCF detection on idtech 5 md5 binary model format https://github.com/SabreTools/BinaryObjectScanner/issues/376 . Adds a few extra validity checks mentioned in HLLib, specifically

47de5d5fed/HLLib/GCFFile.h (L104)
47de5d5fed/HLLib/GCFFile.h (L109)

which should avoid any other false positives from Enemy Territory's md5b files.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/17 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 7/12/2025 **Status:** ✅ Merged **Merged:** 7/12/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `quakeET-falsepositive-GCF-md5b` --- ### 📝 Commits (2) - [`8bb25d7`](https://github.com/SabreTools/SabreTools.Serialization/commit/8bb25d76038a7c4d4f08611446fac8be3cdef511) Add extra validity checks for GCF - [`1cb0fbf`](https://github.com/SabreTools/SabreTools.Serialization/commit/1cb0fbff3427f15d7bd234e7d99c79c156aa6ce3) Remove "for validity" ### 📊 Changes **1 file changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `SabreTools.Serialization/Deserializers/GCF.cs` (+9 -2) </details> ### 📄 Description Fixes false GCF detection on idtech 5 md5 binary model format https://github.com/SabreTools/BinaryObjectScanner/issues/376 . Adds a few extra validity checks mentioned in HLLib, specifically https://github.com/Rupan/HLLib/blob/47de5d5fed1b4d8e160c20f50d0bf61999996161/HLLib/GCFFile.h#L104 https://github.com/Rupan/HLLib/blob/47de5d5fed1b4d8e160c20f50d0bf61999996161/HLLib/GCFFile.h#L109 which should avoid any other false positives from Enemy Territory's md5b files. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:16:45 +00:00

claunia referenced this issue 2026-01-29 21:16:54 +00:00

[PR #41] [MERGED] Final ISO9660 fix #74

claunia referenced this issue 2026-01-29 21:16:55 +00:00

[PR #41] Final ISO9660 fix #79

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#41