SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-02-03 21:30:35 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

[PR #17] Add extra validity checks for GCF #44

New Issue
Open
opened 2026-01-29 21:16:45 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 21:16:45 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/SabreTools/SabreTools.Serialization/pull/17

State: closed
Merged: Yes

Fixes false GCF detection on idtech 5 md5 binary model format https://github.com/SabreTools/BinaryObjectScanner/issues/376 . Adds a few extra validity checks mentioned in HLLib, specifically

47de5d5fed/HLLib/GCFFile.h (L104)
47de5d5fed/HLLib/GCFFile.h (L109)

which should avoid any other false positives from Enemy Territory's md5b files.

**Original Pull Request:** https://github.com/SabreTools/SabreTools.Serialization/pull/17 **State:** closed **Merged:** Yes --- Fixes false GCF detection on idtech 5 md5 binary model format https://github.com/SabreTools/BinaryObjectScanner/issues/376 . Adds a few extra validity checks mentioned in HLLib, specifically https://github.com/Rupan/HLLib/blob/47de5d5fed1b4d8e160c20f50d0bf61999996161/HLLib/GCFFile.h#L104 https://github.com/Rupan/HLLib/blob/47de5d5fed1b4d8e160c20f50d0bf61999996161/HLLib/GCFFile.h#L109 which should avoid any other false positives from Enemy Territory's md5b files.
claunia added the pull-request label 2026-01-29 21:16:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#44
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?