[PR #28] [MERGED] increase buffer size for isexe reading / writing based on deterous's … #51

New Issue

Open

opened 2026-01-29 21:16:47 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:47 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/28
Author: @HeroponRikiBestest
Created: 10/26/2025
Status: ✅ Merged
Merged: 10/26/2025
Merged by: @mnadareski

Base: main ← Head: quick-isexe-blocksize-bump

---

📝 Commits (2)

• 5a9386e increase buffer size for isexe reading / writing based on deterous's input
• da9583b remove comment

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs (+1 -1)

📄 Description

The buffer size is fully arbitrary, and I had only chosen what it currently is just based on a whim. According to deterous, this buffer size has worked best for him and others in various environments, and overall I trust it much more than my previous tiny buffer size.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/28 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 10/26/2025 **Status:** ✅ Merged **Merged:** 10/26/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `quick-isexe-blocksize-bump` --- ### 📝 Commits (2) - [`5a9386e`](https://github.com/SabreTools/SabreTools.Serialization/commit/5a9386ec5e3be032d3cd050d8a84bbc4dcfa7e2b) increase buffer size for isexe reading / writing based on deterous's input - [`da9583b`](https://github.com/SabreTools/SabreTools.Serialization/commit/da9583b3f4a6ad65be22942860478f6911b2cb9e) remove comment ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs` (+1 -1) </details> ### 📄 Description The buffer size is fully arbitrary, and I had only chosen what it currently is just based on a whim. According to deterous, this buffer size has worked best for him and others in various environments, and overall I trust it much more than my previous tiny buffer size. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:16:47 +00:00

claunia referenced this issue 2026-01-29 21:16:56 +00:00

[PR #51] [CLOSED] Fix mszip relying on exceptions - PR Option 2 - some changes, not quite ideal but better solution #84

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#51