[PR #37] [MERGED] CD-ROM (Volume Descriptor Set) support #69

New Issue

Closed

opened 2026-01-29 21:16:52 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:52 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/37
Author: @Deterous
Created: 11/2/2025
Status: ✅ Merged
Merged: 11/3/2025
Merged by: @mnadareski

Base: main ← Head: main

---

📝 Commits (3)

• f27e07b CD-ROM Wrapper
• 515c2d3 Fix CDROMVolume Reader
• 0b248ae Fix SectorMode enum

📊 Changes

14 files changed (+513 additions, -0 deletions)

View changed files

📝 ExtractionTool/Features/MainFeature.cs (+5 -0)
➕ SabreTools.Serialization/Models/CDROM/CDROM.cs (+17 -0)
➕ SabreTools.Serialization/Models/CDROM/DataTrack.cs (+22 -0)
➕ SabreTools.Serialization/Models/CDROM/Enums.cs (+42 -0)
➕ SabreTools.Serialization/Models/CDROM/Mode1.cs (+31 -0)
➕ SabreTools.Serialization/Models/CDROM/Mode2Form1.cs (+31 -0)
➕ SabreTools.Serialization/Models/CDROM/Mode2Form2.cs (+27 -0)
➕ SabreTools.Serialization/Models/CDROM/Sector.cs (+26 -0)
➕ SabreTools.Serialization/Readers/CDROMVolume.cs (+171 -0)
📝 SabreTools.Serialization/WrapperFactory.cs (+10 -0)
➕ SabreTools.Serialization/Wrappers/CDROM.Extraction.cs (+9 -0)
➕ SabreTools.Serialization/Wrappers/CDROM.Printing.cs (+27 -0)
➕ SabreTools.Serialization/Wrappers/CDROM.cs (+90 -0)
📝 SabreTools.Serialization/Wrappers/WrapperType.cs (+5 -0)

📄 Description

• CDROM Models
• CDROMVolume Reader (Only supports reading the Volume Descriptor Set)
• CDROM Wrapper (CDROMVolume only)
• CDROM Printer (uses ISO9660 printer)
• Detected with magic AND bin/skeleton extension
• Does not support extraction due to Volume Descriptor Set only (no Directories/File Extents)

For support of CD-ROM models and directories/file extents, a custom Stream would need to be made that extracts the CDROM header/EDC/ECC, and pass the user data to the ISO9660 Reader.
This would mean CDROMVolume would become deprecated with a proper CDROM reader parsing a CDROM.DataTrack model.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/37 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 11/2/2025 **Status:** ✅ Merged **Merged:** 11/3/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`f27e07b`](https://github.com/SabreTools/SabreTools.Serialization/commit/f27e07b9ceb3b1b340269ce65848c0922cf11f71) CD-ROM Wrapper - [`515c2d3`](https://github.com/SabreTools/SabreTools.Serialization/commit/515c2d35b889e1d8e04e2874b5bb64b74d53023d) Fix CDROMVolume Reader - [`0b248ae`](https://github.com/SabreTools/SabreTools.Serialization/commit/0b248ae07b1425568a38dc2397774504bd7f7384) Fix SectorMode enum ### 📊 Changes **14 files changed** (+513 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `ExtractionTool/Features/MainFeature.cs` (+5 -0) ➕ `SabreTools.Serialization/Models/CDROM/CDROM.cs` (+17 -0) ➕ `SabreTools.Serialization/Models/CDROM/DataTrack.cs` (+22 -0) ➕ `SabreTools.Serialization/Models/CDROM/Enums.cs` (+42 -0) ➕ `SabreTools.Serialization/Models/CDROM/Mode1.cs` (+31 -0) ➕ `SabreTools.Serialization/Models/CDROM/Mode2Form1.cs` (+31 -0) ➕ `SabreTools.Serialization/Models/CDROM/Mode2Form2.cs` (+27 -0) ➕ `SabreTools.Serialization/Models/CDROM/Sector.cs` (+26 -0) ➕ `SabreTools.Serialization/Readers/CDROMVolume.cs` (+171 -0) 📝 `SabreTools.Serialization/WrapperFactory.cs` (+10 -0) ➕ `SabreTools.Serialization/Wrappers/CDROM.Extraction.cs` (+9 -0) ➕ `SabreTools.Serialization/Wrappers/CDROM.Printing.cs` (+27 -0) ➕ `SabreTools.Serialization/Wrappers/CDROM.cs` (+90 -0) 📝 `SabreTools.Serialization/Wrappers/WrapperType.cs` (+5 -0) </details> ### 📄 Description - CDROM Models - CDROMVolume Reader (Only supports reading the Volume Descriptor Set) - CDROM Wrapper (CDROMVolume only) - CDROM Printer (uses ISO9660 printer) - Detected with magic AND bin/skeleton extension - Does not support extraction due to Volume Descriptor Set only (no Directories/File Extents) For support of CD-ROM models and directories/file extents, a custom Stream would need to be made that extracts the CDROM header/EDC/ECC, and pass the user data to the ISO9660 Reader. This would mean CDROMVolume would become deprecated with a proper CDROM reader parsing a CDROM.DataTrack model. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:16:52 +00:00

claunia closed this issue 2026-01-29 21:16:52 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#69