SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-02-07 13:54:37 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

[PR #40] [MERGED] Custom ISO Stream for full CDROM support #70

New Issue
Open
opened 2026-01-29 21:16:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 21:16:52 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/40
Author: @Deterous
Created: 11/4/2025
Status: ✅ Merged
Merged: 11/5/2025
Merged by: @mnadareski

Base: main ← Head: main

📝 Commits (10+)

📊 Changes

16 files changed (+350 additions, -328 deletions)

View changed files

➖ SabreTools.Serialization.Test/Readers/CDROMVolumeTests.cs (+0 -73)
➕ SabreTools.Serialization/Extensions/CDROM.cs (+275 -0)
📝 SabreTools.Serialization/Models/CDROM/CDROM.cs (+5 -4)
➕ SabreTools.Serialization/Models/CDROM/Constants.cs (+34 -0)
📝 SabreTools.Serialization/Models/CDROM/DataSector.cs (+2 -2)
➖ SabreTools.Serialization/Models/CDROM/DataTrack.cs (+0 -21)
📝 SabreTools.Serialization/Models/CDROM/Mode1.cs (+1 -1)
📝 SabreTools.Serialization/Models/CDROM/Mode2Form1.cs (+1 -1)
📝 SabreTools.Serialization/Models/CDROM/Mode2Form2.cs (+1 -1)
📝 SabreTools.Serialization/Models/ISO9660/Constants.cs (+1 -1)
➖ SabreTools.Serialization/Readers/CDROMVolume.cs (+0 -170)
➖ SabreTools.Serialization/Wrappers/CDROM.Extraction.cs (+0 -9)
➖ SabreTools.Serialization/Wrappers/CDROM.Printing.cs (+0 -27)
📝 SabreTools.Serialization/Wrappers/CDROM.cs (+16 -9)
📝 SabreTools.Serialization/Wrappers/ISO9660.Printing.cs (+12 -7)
📝 SabreTools.Serialization/Wrappers/ISO9660.cs (+2 -2)

📄 Description

  • CDROM Wrapper that inherits the ISO9660 wrapper, and calls IOS9660.Create() with a custom stream
  • Deletes the VolumeDescriptor-only CDROMVolume Reader

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/40 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 11/4/2025 **Status:** ✅ Merged **Merged:** 11/5/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`39ff75a`](https://github.com/SabreTools/SabreTools.Serialization/commit/39ff75ad4f0a05cb0d5a4313fee332606ce75118) Implement custom ISO stream for CDROM support - [`c8c2f69`](https://github.com/SabreTools/SabreTools.Serialization/commit/c8c2f697c761099b0d4f407eb137aeb1c252ecc0) Delete old files - [`af55176`](https://github.com/SabreTools/SabreTools.Serialization/commit/af55176a77b64e566270ede3c0a12cc98ab7a1bd) Delete old test - [`da46ee3`](https://github.com/SabreTools/SabreTools.Serialization/commit/da46ee35dc7bdea5850c570b73a1dcb9e7bee1fe) Leaner CDROM wrapper - [`7fac120`](https://github.com/SabreTools/SabreTools.Serialization/commit/7fac120cf9f027266c1f21c41decb89b5c2c6098) Fix custom stream - [`8d3b42f`](https://github.com/SabreTools/SabreTools.Serialization/commit/8d3b42fbdfaced56a11b7ed10dbd3ed2ed83899e) Merge branch 'main' into main - [`950a138`](https://github.com/SabreTools/SabreTools.Serialization/commit/950a138694c03a21cec2ed76bffe6ed2ff50ebdd) Merge branch 'SabreTools:main' into main - [`09f6c2c`](https://github.com/SabreTools/SabreTools.Serialization/commit/09f6c2c32bda642ab146841a5d0658a995f0bb23) WrapperBase using ISO stream - [`2b854ba`](https://github.com/SabreTools/SabreTools.Serialization/commit/2b854ba36c26f9ebf35e65f50c752b6029f5ad03) Reset stream after deserializing - [`3d2ab64`](https://github.com/SabreTools/SabreTools.Serialization/commit/3d2ab643cd303faec3d549db64559181ab750ac0) Fix SeekOrigin ### 📊 Changes **16 files changed** (+350 additions, -328 deletions) <details> <summary>View changed files</summary> ➖ `SabreTools.Serialization.Test/Readers/CDROMVolumeTests.cs` (+0 -73) ➕ `SabreTools.Serialization/Extensions/CDROM.cs` (+275 -0) 📝 `SabreTools.Serialization/Models/CDROM/CDROM.cs` (+5 -4) ➕ `SabreTools.Serialization/Models/CDROM/Constants.cs` (+34 -0) 📝 `SabreTools.Serialization/Models/CDROM/DataSector.cs` (+2 -2) ➖ `SabreTools.Serialization/Models/CDROM/DataTrack.cs` (+0 -21) 📝 `SabreTools.Serialization/Models/CDROM/Mode1.cs` (+1 -1) 📝 `SabreTools.Serialization/Models/CDROM/Mode2Form1.cs` (+1 -1) 📝 `SabreTools.Serialization/Models/CDROM/Mode2Form2.cs` (+1 -1) 📝 `SabreTools.Serialization/Models/ISO9660/Constants.cs` (+1 -1) ➖ `SabreTools.Serialization/Readers/CDROMVolume.cs` (+0 -170) ➖ `SabreTools.Serialization/Wrappers/CDROM.Extraction.cs` (+0 -9) ➖ `SabreTools.Serialization/Wrappers/CDROM.Printing.cs` (+0 -27) 📝 `SabreTools.Serialization/Wrappers/CDROM.cs` (+16 -9) 📝 `SabreTools.Serialization/Wrappers/ISO9660.Printing.cs` (+12 -7) 📝 `SabreTools.Serialization/Wrappers/ISO9660.cs` (+2 -2) </details> ### 📄 Description - CDROM Wrapper that inherits the ISO9660 wrapper, and calls IOS9660.Create() with a custom stream - Deletes the VolumeDescriptor-only CDROMVolume Reader --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 21:16:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#70
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?