[PR #49] [CLOSED] Fix mszip errors - PR Option 1 - Least changes, least ideal solution #78

New Issue

Open

opened 2026-01-29 21:16:54 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:54 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/49
Author: @HeroponRikiBestest
Created: 12/4/2025
Status: ❌ Closed

Base: main ← Head: bestest-mszip

---

📝 Commits (3)

• f51cfeb Better fix
• 4d2700a initial
• 809aaca Fixed

📊 Changes

3 files changed (+37 additions, -4 deletions)

View changed files

📝 SabreTools.Serialization/Readers/MicrosoftCabinet.cs (+4 -4)
📝 SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs (+31 -0)
📝 SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs (+2 -0)

📄 Description

Fixes https://github.com/SabreTools/SabreTools.Serialization/issues/44 with the simplest possible changes.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/49 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 12/4/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bestest-mszip` --- ### 📝 Commits (3) - [`f51cfeb`](https://github.com/SabreTools/SabreTools.Serialization/commit/f51cfeb451b35a1c8dc2226090ed1681573dfae8) Better fix - [`4d2700a`](https://github.com/SabreTools/SabreTools.Serialization/commit/4d2700a137ac37ceba2f99c2fbc2d95a3334367d) initial - [`809aaca`](https://github.com/SabreTools/SabreTools.Serialization/commit/809aacacc71c996f91489d93f2067a0afb4deeca) Fixed ### 📊 Changes **3 files changed** (+37 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `SabreTools.Serialization/Readers/MicrosoftCabinet.cs` (+4 -4) 📝 `SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs` (+31 -0) 📝 `SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs` (+2 -0) </details> ### 📄 Description Fixes https://github.com/SabreTools/SabreTools.Serialization/issues/44 with the simplest possible changes. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:16:54 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#78