[PR #53] [MERGED] Fix GCF naming convention to avoid future code breakage #86

New Issue

Open

opened 2026-01-29 21:16:56 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:56 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/53
Author: @HeroponRikiBestest
Created: 12/4/2025
Status: ✅ Merged
Merged: 12/4/2025
Merged by: @mnadareski

Base: main ← Head: gcf-naming

---

📝 Commits (1)

• ab88084 fix naming

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 SabreTools.Serialization/Readers/GCF.cs (+2 -2)

📄 Description

Incorrect/unclear variable naming was the cause of the existing breakage, so this should help avoid future issues

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/53 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 12/4/2025 **Status:** ✅ Merged **Merged:** 12/4/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `gcf-naming` --- ### 📝 Commits (1) - [`ab88084`](https://github.com/SabreTools/SabreTools.Serialization/commit/ab8808476f6ebe7345bb31776a442647166bcd29) fix naming ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `SabreTools.Serialization/Readers/GCF.cs` (+2 -2) </details> ### 📄 Description Incorrect/unclear variable naming was the cause of the existing breakage, so this should help avoid future issues --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:16:56 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#86