[PR #54] [CLOSED] Implement model, reader, wrapper for valve SKU sis files. #87

New Issue

Open

opened 2026-01-29 21:16:57 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:57 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/54
Author: @HeroponRikiBestest
Created: 1/5/2026
Status: ❌ Closed

Base: main ← Head: skusis-addition

---

📝 Commits (10+)

• ca115c0 Initial implementation
• 1499c84 Commit to the right branch this time
• be8519a Use newtonsoft instead of System.Text.Json
• 9481dd5 Don't parse constant strings
• e20ed73 Add comments for documentation
• 2e7f9e1 Add reader and wrapper tests
• 9f98ef3 Fix Naming
• 2e5c5b3 Extract Ms-cabs while reading instead of loading all datablocks into memory (#56)
• 6bfe68b Formatting and comment cleanup
• f16ed97 Support WoD info CMP block type

📊 Changes

527 files changed (+8158 additions, -6603 deletions)

View changed files

➕ .editorconfig (+167 -0)
📝 ExtractionTool/Program.cs (+1 -1)
📝 InfoPrint/Features/MainFeature.cs (+16 -16)
📝 InfoPrint/Program.cs (+1 -1)
📝 SabreTools.Serialization.Test/CrossModel/ArchiveDotOrgTests.cs (+1 -1)
📝 SabreTools.Serialization.Test/CrossModel/ClrMameProTests.cs (+19 -0)
📝 SabreTools.Serialization.Test/CrossModel/HashfileTests.cs (+3 -1)
📝 SabreTools.Serialization.Test/Extensions/TypeLengthValueTests.cs (+3 -2)
📝 SabreTools.Serialization.Test/Readers/AppPkgHeaderTests.cs (+73 -73)
📝 SabreTools.Serialization.Test/Readers/ArchiveDotOrgTests.cs (+1 -1)
📝 SabreTools.Serialization.Test/Readers/AttractModeTests.cs (+4 -4)
📝 SabreTools.Serialization.Test/Readers/ClrMameProTests.cs (+23 -4)
📝 SabreTools.Serialization.Test/Readers/DosCenterTests.cs (+1 -1)
📝 SabreTools.Serialization.Test/Readers/EverdriveSMDBTests.cs (+1 -1)
📝 SabreTools.Serialization.Test/Readers/HashfileTests.cs (+12 -10)
📝 SabreTools.Serialization.Test/Readers/InstallShieldExecutableTests.cs (+7 -7)
📝 SabreTools.Serialization.Test/Readers/ListromTests.cs (+1 -1)
📝 SabreTools.Serialization.Test/Readers/ListxmlTests.cs (+2 -2)
📝 SabreTools.Serialization.Test/Readers/LogiqxTests.cs (+2 -2)
📝 SabreTools.Serialization.Test/Readers/M1Tests.cs (+2 -2)

...and 80 more files

📄 Description

This PR is a draft until I do another pass for proper formatting and commenting, as well as more testing, and other requirements that need to be fulfilled.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/54 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 1/5/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `skusis-addition` --- ### 📝 Commits (10+) - [`ca115c0`](https://github.com/SabreTools/SabreTools.Serialization/commit/ca115c01b30ad20f4dfd75bb708fe55e640a45f7) Initial implementation - [`1499c84`](https://github.com/SabreTools/SabreTools.Serialization/commit/1499c84f2efda6374ec76f4bc9e5006d4a5e0d8d) Commit to the right branch this time - [`be8519a`](https://github.com/SabreTools/SabreTools.Serialization/commit/be8519a11d9b09de6237901231ff18bbf8550cf5) Use newtonsoft instead of System.Text.Json - [`9481dd5`](https://github.com/SabreTools/SabreTools.Serialization/commit/9481dd505a044461e06834eb60f3c23b11868b69) Don't parse constant strings - [`e20ed73`](https://github.com/SabreTools/SabreTools.Serialization/commit/e20ed7345b4202214e47423fbd20f1662b9e4677) Add comments for documentation - [`2e7f9e1`](https://github.com/SabreTools/SabreTools.Serialization/commit/2e7f9e198fd7f3100459d99e96173b36fd00ff21) Add reader and wrapper tests - [`9f98ef3`](https://github.com/SabreTools/SabreTools.Serialization/commit/9f98ef310c4752dfd4caa25eb1659426f834d439) Fix Naming - [`2e5c5b3`](https://github.com/SabreTools/SabreTools.Serialization/commit/2e5c5b3c79bc56b449a563d1caf356a5c47b98ea) Extract Ms-cabs while reading instead of loading all datablocks into memory (#56) - [`6bfe68b`](https://github.com/SabreTools/SabreTools.Serialization/commit/6bfe68b8cfcf3f3e89c031fdece78c92fe2782a3) Formatting and comment cleanup - [`f16ed97`](https://github.com/SabreTools/SabreTools.Serialization/commit/f16ed9742fe378f59c2a0b77f3e9e2b61dceb746) Support WoD info CMP block type ### 📊 Changes **527 files changed** (+8158 additions, -6603 deletions) <details> <summary>View changed files</summary> ➕ `.editorconfig` (+167 -0) 📝 `ExtractionTool/Program.cs` (+1 -1) 📝 `InfoPrint/Features/MainFeature.cs` (+16 -16) 📝 `InfoPrint/Program.cs` (+1 -1) 📝 `SabreTools.Serialization.Test/CrossModel/ArchiveDotOrgTests.cs` (+1 -1) 📝 `SabreTools.Serialization.Test/CrossModel/ClrMameProTests.cs` (+19 -0) 📝 `SabreTools.Serialization.Test/CrossModel/HashfileTests.cs` (+3 -1) 📝 `SabreTools.Serialization.Test/Extensions/TypeLengthValueTests.cs` (+3 -2) 📝 `SabreTools.Serialization.Test/Readers/AppPkgHeaderTests.cs` (+73 -73) 📝 `SabreTools.Serialization.Test/Readers/ArchiveDotOrgTests.cs` (+1 -1) 📝 `SabreTools.Serialization.Test/Readers/AttractModeTests.cs` (+4 -4) 📝 `SabreTools.Serialization.Test/Readers/ClrMameProTests.cs` (+23 -4) 📝 `SabreTools.Serialization.Test/Readers/DosCenterTests.cs` (+1 -1) 📝 `SabreTools.Serialization.Test/Readers/EverdriveSMDBTests.cs` (+1 -1) 📝 `SabreTools.Serialization.Test/Readers/HashfileTests.cs` (+12 -10) 📝 `SabreTools.Serialization.Test/Readers/InstallShieldExecutableTests.cs` (+7 -7) 📝 `SabreTools.Serialization.Test/Readers/ListromTests.cs` (+1 -1) 📝 `SabreTools.Serialization.Test/Readers/ListxmlTests.cs` (+2 -2) 📝 `SabreTools.Serialization.Test/Readers/LogiqxTests.cs` (+2 -2) 📝 `SabreTools.Serialization.Test/Readers/M1Tests.cs` (+2 -2) _...and 80 more files_ </details> ### 📄 Description This PR is a draft until I do another pass for proper formatting and commenting, as well as more testing, and other requirements that need to be fulfilled. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:16:57 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#87