SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-02-06 21:29:44 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

[PR #57] [MERGED] Change mscab extraction to use state handling, break into more helper methods #90

New Issue
Closed
opened 2026-01-29 21:16:58 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 21:16:58 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/57
Author: @HeroponRikiBestest
Created: 1/25/2026
Status: ✅ Merged
Merged: 1/25/2026
Merged by: @mnadareski

Base: main ← Head: mscab-state

📝 Commits (10+)

📊 Changes

1 file changed (+299 additions, -241 deletions)

View changed files

📝 SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs (+299 -241)

📄 Description

Attempt to fulfill the request to use proper state handling. Feedback needed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/57 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 1/25/2026 **Status:** ✅ Merged **Merged:** 1/25/2026 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `mscab-state` --- ### 📝 Commits (10+) - [`cc04e90`](https://github.com/SabreTools/SabreTools.Serialization/commit/cc04e90a15cb50c7d9da6b4a94b6d545ee851b6d) Attempt 1 - [`a2670b3`](https://github.com/SabreTools/SabreTools.Serialization/commit/a2670b35f9b64a03c5302d9b161cd71063de729a) Use private helper class - [`9938901`](https://github.com/SabreTools/SabreTools.Serialization/commit/9938901e6d61f3ffb42dc3e25219807abd46a4b8) Remove comment - [`d6ff072`](https://github.com/SabreTools/SabreTools.Serialization/commit/d6ff0721917c162c4c5d82112cd7e49b764f3aad) Add missing summaries - [`af766ce`](https://github.com/SabreTools/SabreTools.Serialization/commit/af766ce87706ddfd18a071fb283494c1636ee767) Don't use create pattern - [`d1d7c91`](https://github.com/SabreTools/SabreTools.Serialization/commit/d1d7c9166e4099059967da6ea058abda7adaf33b) Remove removed variable summary - [`cf8d793`](https://github.com/SabreTools/SabreTools.Serialization/commit/cf8d7935fec401686f05f4b830c6c691542170e8) Reduce what needs to be passed in - [`845198f`](https://github.com/SabreTools/SabreTools.Serialization/commit/845198fb4cb50654396e1a3d0e2f08e900b44ff5) Further reduce what needs to be passed in - [`84732e0`](https://github.com/SabreTools/SabreTools.Serialization/commit/84732e0dd5d4745645fbdb7cae6b33af7cdcc2ab) These didn't get tabbed for some reason - [`fa42b67`](https://github.com/SabreTools/SabreTools.Serialization/commit/fa42b67f96b5dac1f19cbef357901af6f6191278) First round of fixes. ### 📊 Changes **1 file changed** (+299 additions, -241 deletions) <details> <summary>View changed files</summary> 📝 `SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs` (+299 -241) </details> ### 📄 Description Attempt to fulfill the request to use proper state handling. Feedback needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 21:16:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#90
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?