TencentARC/GFPGAN
1
0
Fork 0
mirror of https://github.com/TencentARC/GFPGAN.git synced 2026-04-26 15:52:04 +00:00
Code Issues 476 Packages Projects Releases 8 Wiki Activity

tanh activation #211

New Issue
Open
opened 2026-01-29 21:45:45 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 21:45:45 +00:00
Owner
Copy Link

Originally created by @g-luo on GitHub (Jul 22, 2022).

Hi, I was curious why in the implementation of GFPGAN there is no final tanh activation to keep generator outputs constrained between [-1, 1]; is there a reason why / could GFPGAN possibly benefit from such an activation?

Originally created by @g-luo on GitHub (Jul 22, 2022). Hi, I was curious why in the implementation of GFPGAN there is no final tanh activation to keep generator outputs constrained between [-1, 1]; is there a reason why / could GFPGAN possibly benefit from such an activation?
claunia commented 2026-01-29 21:45:46 +00:00
Author
Owner
Copy Link

@g-luo commented on GitHub (Jul 22, 2022):

Additionally, what is the intuition for detaching the fake output when training the discriminator (see code)?

@g-luo commented on GitHub (Jul 22, 2022): Additionally, what is the intuition for detaching the fake output when training the discriminator ([see code](https://github.com/TencentARC/GFPGAN/blob/9c3f2d62cb4e63a7ba7ce68648dd1667b2b2ef44/gfpgan/models/gfpgan_model.py#L420))?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TencentARC/GFPGAN#211
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?