mirror of
https://github.com/TencentARC/GFPGAN.git
synced 2026-04-22 05:41:37 +00:00
Project dependencies may have API risk issues #324
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @PyDR-Tool on GitHub (Mar 12, 2023).
Hi, In GFPGAN, inappropriate dependency versioning constraints can cause risks.
Below are the dependencies and version constraints that the project is using
The version constraint == will introduce the risk of dependency conflicts because the scope of dependencies is too strict.
The version constraint No Upper Bound and * will introduce the risk of the missing API Error because the latest version of the dependencies may remove some APIs.
After further analysis, in this project,
The version constraint of dependency tqdm can be changed to >=3.4.0,<=4.64.0.
The above modification suggestions can reduce the dependency conflicts as much as possible,
and introduce the latest version as much as possible without calling Error in the projects.
The invocation of the current project includes all the following methods.
In version tqdm-3.1.4, the API tqdm.tqdm.set_description whch is used by the current project in gfpgan/models/gfpgan_model.py is missing.
The calling methods from the tqdm
The calling methods from the all methods
@developer
Could please help me check this issue?
May I pull a request to fix it?
Thank you very much.