[PR #85] [MERGED] Fix unsigned vs. signed problem #1045

New Issue

claunia · 2026-01-29T15:39:54Z

claunia commented

2026-01-29 15:39:54 +00:00

📋 Pull Request Information

Original PR: https://github.com/aaru-dps/Aaru/pull/85
Author: @darkstar
Created: 12/20/2017
Status: ✅ Merged
Merged: 12/20/2017
Merged by: @claunia

Base: master ← Head: fixes

📝 Commits (1)

b030712 Fix unsigned vs. signed problem

📊 Changes

3 files changed (+12 additions, -12 deletions)

View changed files

📝 DiscImageChef.Devices/Device/Constructor.cs (+4 -4)
📝 DiscImageChef.Devices/Windows/ListDevices.cs (+4 -4)
📝 DiscImageChef.Devices/Windows/Structs.cs (+4 -4)

📄 Description

Fix crash on Windows when using list-devices.

Problem is that the fields in the StorageDeviceDescriptor are uint, then checked against > 0, then cast to int, which crashes the string indexing in CToString(...)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aaru-dps/Aaru/pull/85 **Author:** [@darkstar](https://github.com/darkstar) **Created:** 12/20/2017 **Status:** ✅ Merged **Merged:** 12/20/2017 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `master` ← **Head:** `fixes` --- ### 📝 Commits (1) - [`b030712`](https://github.com/aaru-dps/Aaru/commit/b030712b3833551cd6f13d0cca1f530d5478e2fd) Fix unsigned vs. signed problem ### 📊 Changes **3 files changed** (+12 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `DiscImageChef.Devices/Device/Constructor.cs` (+4 -4) 📝 `DiscImageChef.Devices/Windows/ListDevices.cs` (+4 -4) 📝 `DiscImageChef.Devices/Windows/Structs.cs` (+4 -4) </details> ### 📄 Description Fix [crash](https://pastebin.com/TZNVX3dw) on Windows when using `list-devices`. Problem is that the fields in the `StorageDeviceDescriptor` are uint, then checked against `> 0`, then cast to int, which crashes the string indexing in `CToString(...)` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 15:39:54 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: aaru-dps/Aaru-aaru-dps#1045