aaru-dps/Aaru-aaru-dps
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2026-07-08 17:56:18 +00:00
Code Issues 657 Packages Projects Releases 19 Wiki Activity

[PR #86] [MERGED] Add workaround to correctly display device serials #1047

New Issue
Open
opened 2026-01-29 15:39:56 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 15:39:56 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/aaru-dps/Aaru/pull/86
Author: @darkstar
Created: 12/20/2017
Status: ✅ Merged
Merged: 12/20/2017
Merged by: @claunia

Base: master ← Head: fixes

📝 Commits (2)

  • cfd0b26 Add workaround to correctly display device serials
  • 7cc1b1e Formatting fixes

📊 Changes

1 file changed (+22 additions, -0 deletions)

View changed files

📝 DiscImageChef.Devices/Windows/ListDevices.cs (+22 -0)

📄 Description

Some devices on windows (especially, apparently, SATA devices behind a bridge chip) report their serial number as a string of hex bytes instead of ASCII.

This patch tries to detect that and transparently work around it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aaru-dps/Aaru/pull/86 **Author:** [@darkstar](https://github.com/darkstar) **Created:** 12/20/2017 **Status:** ✅ Merged **Merged:** 12/20/2017 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `master` ← **Head:** `fixes` --- ### 📝 Commits (2) - [`cfd0b26`](https://github.com/aaru-dps/Aaru/commit/cfd0b2655f2b488f45fa72fca1688fbb5d3d0992) Add workaround to correctly display device serials - [`7cc1b1e`](https://github.com/aaru-dps/Aaru/commit/7cc1b1e0a2eff41c7bba0498c20a096ef2686b8a) Formatting fixes ### 📊 Changes **1 file changed** (+22 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `DiscImageChef.Devices/Windows/ListDevices.cs` (+22 -0) </details> ### 📄 Description Some devices on windows (especially, apparently, SATA devices behind a bridge chip) report their serial number as a string of hex bytes instead of ASCII. This patch tries to detect that and transparently work around it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 15:39:56 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
archive
beginner
bug
bug
dependencies
device
device
dump image format
duplicate
Epic
feature request
filesystem
filter
gui
gui
gui
help wanted
invalid
invalid
media
needs triage
partitioning scheme
pull-request
Mirrored from GitHub Pull Request
 upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/Aaru-aaru-dps#1047
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?