aaru-dps/Aaru-aaru-dps
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2026-02-04 00:54:33 +00:00
Code Issues 657 Packages Projects Releases 19 Wiki Activity

[PR #85] Fix unsigned vs. signed problem #1050

New Issue
Open
opened 2026-01-29 15:39:58 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 15:39:58 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/aaru-dps/Aaru/pull/85

State: closed
Merged: Yes

Fix crash on Windows when using list-devices.

Problem is that the fields in the StorageDeviceDescriptor are uint, then checked against > 0, then cast to int, which crashes the string indexing in CToString(...)

**Original Pull Request:** https://github.com/aaru-dps/Aaru/pull/85 **State:** closed **Merged:** Yes --- Fix [crash](https://pastebin.com/TZNVX3dw) on Windows when using `list-devices`. Problem is that the fields in the `StorageDeviceDescriptor` are uint, then checked against `> 0`, then cast to int, which crashes the string indexing in `CToString(...)`
claunia added the pull-request label 2026-01-29 15:39:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
archive
beginner
bug
bug
dependencies
device
device
dump image format
duplicate
Epic
feature request
filesystem
filter
gui
gui
gui
help wanted
invalid
invalid
media
needs triage
partitioning scheme
pull-request
Mirrored from GitHub Pull Request
 upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/Aaru-aaru-dps#1050
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?