aaru-dps/Aaru-aaru-dps
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2026-02-04 00:54:33 +00:00
Code Issues 657 Packages Projects Releases 19 Wiki Activity

[PR #403] [MERGED] Don't write ISRC to CDRDAO or CDRWin images if it's null or white space #1099

New Issue
Open
opened 2026-01-29 15:41:18 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 15:41:18 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/aaru-dps/Aaru/pull/403
Author: @TheRogueArchivist
Created: 8/4/2020
Status: ✅ Merged
Merged: 10/31/2020
Merged by: @claunia

Base: master ← Head: master

📝 Commits (2)

  • 80ad486 Prevent empty ISRC from being added to CDRWin and CDRDAO images
  • 3b3c3de Fix previous commit

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 Aaru.Images/CDRDAO/Write.cs (+1 -1)
📝 Aaru.Images/CDRWin/Write.cs (+1 -1)

📄 Description

Don't write ISRC to CDRDAO or CDRWin images if they're null or white space.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New filesystem, test images in [url]
  • New disc image, test images in [url]
  • New partition scheme, test images in [url]
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aaru-dps/Aaru/pull/403 **Author:** [@TheRogueArchivist](https://github.com/TheRogueArchivist) **Created:** 8/4/2020 **Status:** ✅ Merged **Merged:** 10/31/2020 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`80ad486`](https://github.com/aaru-dps/Aaru/commit/80ad48618946eecd6784ee860070d5fc79caeaf5) Prevent empty ISRC from being added to CDRWin and CDRDAO images - [`3b3c3de`](https://github.com/aaru-dps/Aaru/commit/3b3c3de0b0a857493f833f5d3120910479cf8454) Fix previous commit ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Aaru.Images/CDRDAO/Write.cs` (+1 -1) 📝 `Aaru.Images/CDRWin/Write.cs` (+1 -1) </details> ### 📄 Description Don't write ISRC to CDRDAO or CDRWin images if they're null or white space. ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] New filesystem, test images in [url] - [ ] New disc image, test images in [url] - [ ] New partition scheme, test images in [url] - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [X] I have read the **CONTRIBUTING** document. - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 15:41:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
archive
beginner
bug
bug
dependencies
device
device
dump image format
duplicate
Epic
feature request
filesystem
filter
gui
gui
gui
help wanted
invalid
invalid
media
needs triage
partitioning scheme
pull-request
Mirrored from GitHub Pull Request
 upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/Aaru-aaru-dps#1099
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?