aaru-dps/Aaru-aaru-dps
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2026-02-04 00:54:33 +00:00
Code Issues 657 Packages Projects Releases 19 Wiki Activity

[PR #825] [MERGED] [Dump] Fix wrongly removed title keys #1160

New Issue
Open
opened 2026-01-29 15:42:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 15:42:52 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/aaru-dps/Aaru/pull/825
Author: @FakeShemp
Created: 11/11/2023
Status: ✅ Merged
Merged: 11/11/2023
Merged by: @claunia

Base: devel ← Head: fakeshemp/title-key-fix-2

📝 Commits (1)

  • 783f5ee [Dump] Fix wrongly removed title keys

📊 Changes

1 file changed (+0 additions, -19 deletions)

View changed files

📝 Aaru.Core/Devices/Dumping/Sbc/Data.cs (+0 -19)

📄 Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

This should only have been added in the decryption step, not in the dumping step. Resulted in lost data.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aaru-dps/Aaru/pull/825 **Author:** [@FakeShemp](https://github.com/FakeShemp) **Created:** 11/11/2023 **Status:** ✅ Merged **Merged:** 11/11/2023 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `devel` ← **Head:** `fakeshemp/title-key-fix-2` --- ### 📝 Commits (1) - [`783f5ee`](https://github.com/aaru-dps/Aaru/commit/783f5eee6124658da751d5ad35663f11d9f6236b) [Dump] Fix wrongly removed title keys ### 📊 Changes **1 file changed** (+0 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `Aaru.Core/Devices/Dumping/Sbc/Data.cs` (+0 -19) </details> ### 📄 Description ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [X] Bug fix (non-breaking change which fixes an issue) This should only have been added in the decryption step, not in the dumping step. Resulted in lost data. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 15:42:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
archive
beginner
bug
bug
dependencies
device
device
dump image format
duplicate
Epic
feature request
filesystem
filter
gui
gui
gui
help wanted
invalid
invalid
media
needs triage
partitioning scheme
pull-request
Mirrored from GitHub Pull Request
 upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/Aaru-aaru-dps#1160
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?