mirror of
https://github.com/aaru-dps/Aaru.git
synced 2026-02-04 00:54:33 +00:00
Add command-line switch to control whether subchannel data should be read #227
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TheRogueArchivist on GitHub (Jun 24, 2018).
Prerequisites
Check and fill as appropiate:
Description
A command-line switch that determines if subchannel data should be read while dumping media would be useful. By default, DIC attempts to read subchannel data if the drive and the output format support it. A command-line switch for the function dump-media would be, in my opinion, the best way to deal with this. There are multiple image formats that support subchannel data, so adding a specific option to each of them would be, as far as I can tell, more difficult to implement.
It would be useful to disable reading subchannel data because it cannot be read consistently, making comparing image files by simply hashing them impossible. This is more useful for testing purposes than archival purposes, but making the testing process easier by removing a few steps would be nice. This can be done in Alcohol 120% by unchecking the "Read Sub-Channel data from current disc" option.
An idea for the command-line switch and description: --subchannel (Default: true) Try to read subchannel data. Only applicable to CD/DDCD/GD.
*Copied from the --lead-in description, I don't know if it only applies to CD/DDCD/GD.
If --subchannel is set to true, DIC should act as it did before. If it is set to false, DIC should not attempt to check for or read subchannel data, and the image dumping process should not be stopped solely because the output format does not support subchannel data. As far as I can tell, no default behavior should have to change for dumping images.
@claunia commented on GitHub (Jun 24, 2018):
Will be added in the future, depends on changing the command line library (current library doesn't handle setting false something that is by default true.
@TheRogueArchivist commented on GitHub (Jun 24, 2018):
That's odd, --resume is listed as being true by default. Should that switch be removed or marked as not working, or is it handled differently?
@claunia commented on GitHub (Jun 25, 2018):
And does "--resume false" work for you?
@TheRogueArchivist commented on GitHub (Jun 25, 2018):
Not that I can tell, no. Shouldn't it be at least temporarily removed or give a warning if used? Having a switch that currently does nothing can be confusing.
@TheRogueArchivist commented on GitHub (Nov 4, 2019):
Is this possible to do now? The command line library has been changed AFAIK, does it support this kind of thing?
@claunia commented on GitHub (Dec 7, 2019):
@claunia commented on GitHub (Dec 26, 2019):
Fixed in 470f66ed47aef5d8b99678f5a6efd1eebd416599