aaru-dps/Aaru-aaru-dps
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2026-02-04 00:54:33 +00:00
Code Issues 657 Packages Projects Releases 19 Wiki Activity

ISRC seem to be incorrectly set with TS-H353A #331

New Issue
Closed
opened 2026-01-29 15:16:13 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 15:16:13 +00:00
Owner
Copy Link

Originally created by @FakeShemp on GitHub (Mar 3, 2020).

Prerequisites

  • Are you running the latest version?
  • Can you reproduce the problem in the debug version?

Check and fill as appropriate:

  • I was running Aaru under Linux Ubuntu 19.10...
  • ...using .NET Core 3.1...
  • ...in 64-bit

Description

When dumping with a TS-H353A, the ISRC seem to not be read correctly for all tracks.

Exact command line used:

./Aaru m dump --first-pregap --persistent /dev/sr0 ComeAlong.aaruf

Expected behavior:

The ISRC to be set to:

Setting ISRC for track 1 to SELEE0107010                                                           
Setting ISRC for track 2 to SELEE0107020                                                           
Setting ISRC for track 3 to SELEE0107030                                                           
Setting ISRC for track 4 to SELEE0107040                                                           
Setting ISRC for track 5 to SELEE0107050                                                           
Setting ISRC for track 6 to SELEE0107060                                                           
Setting ISRC for track 7 to SELEE0107070                                                           
Setting ISRC for track 8 to SELEE0107080                                                           
Setting ISRC for track 9 to SELEE0107090                                                           
Setting ISRC for track 10 to SELEE0107100                                                          
Setting ISRC for track 11 to SELEE0107110

Actual behavior:

It was set to:

Setting ISRC for track 1 to SELEE0107010                                                           
Setting ISRC for track 2 to +?q????]                                                               
Setting ISRC for track 3 to SELEE0107030                                                           
Setting ISRC for track 4 to $S;?$?:h%4<l                                                           
Setting ISRC for track 5 to SELEE0107050                                                           
Setting ISRC for track 6 to SELEE0107060                                                           
Setting ISRC for track 7 to SELEE0107070                                                           
Setting ISRC for track 8 to SELEE0107080                                                           
Setting ISRC for track 9 to SELEE0107090                                                           
Setting ISRC for track 10 to SELEE0107100

If command was expected to work with a device fill this out:

  • Manufacturer: Toshiba-Samsung
  • Model: TS-H353A
  • Bus:
    • USB

Output of command execution with debug output enabled

ISRC relevant part of debug

[...]
DEBUG (Aaru Format plugin): Got a shift of 12 for 4096 sectors per block
DEBUG (Aaru Format plugin): In memory DDT?: True
DEBUG (SCSI Device): READ CD (LBA: 0, Block Size: 2448, Transfer Length: 1, Expected Sector Type: AllTypes, DAP: False, Relative Address: False, Sync: True, Headers: AllHeaders, User Data: True, ECC/EDC: True, C2: None, Subchannel: Raw, Sense: False, Last Error: 0) took 40 ms.
Setting flags for track 1...                                                                       
Setting flags for track 2...                                                                       
Setting flags for track 3...                                                                       
Setting flags for track 4...                                                                       
Setting flags for track 5...                                                                       
Setting flags for track 6...                                                                       
Setting flags for track 7...                                                                       
Setting flags for track 8...                                                                       
Setting flags for track 9...                                                                       
Setting flags for track 10...                                                                      
Setting flags for track 11...                                                                      
DEBUG (SCSI Device): READ READ SUB-CHANNEL (MCN, Sense False, Last Error 0) took 176 ms.
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 1, Sense: False, Last Error: 0) took 116 ms.
Setting ISRC for track 1 to SELEE0107010                                                           
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 2, Sense: False, Last Error: 0) took 144 ms.
Setting ISRC for track 2 to SELEE0107020                                                           
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 3, Sense: False, Last Error: 0) took 68 ms.
Setting ISRC for track 3 to ???????????                                                            
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 4, Sense: False, Last Error: 0) took 96 ms.
Setting ISRC for track 4 to SELEE0107040                                                           
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 5, Sense: False, Last Error: 0) took 204 ms.
Setting ISRC for track 5 to SELEE0107050                                                           
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 6, Sense: False, Last Error: 0) took 160 ms.
Setting ISRC for track 6 to SELEE0107060                                                           
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 7, Sense: False, Last Error: 0) took 84 ms.
Setting ISRC for track 7 to SELEE0107070                                                           
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 8, Sense: False, Last Error: 0) took 140 ms.
Setting ISRC for track 8 to SELEE0107080                                                           
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 9, Sense: False, Last Error: 0) took 148 ms.
Setting ISRC for track 9 to SELEE0107090                                                           
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 10, Sense: False, Last Error: 0) took 72 ms.
Setting ISRC for track 10 to SELEE0107100                                                          
DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 11, Sense: False, Last Error: 0) took 132 ms.
Setting ISRC for track 11 to SELEE0107110                                                          
Track 1 starts at LBA 0 and ends at LBA 16717                                                      
Track 2 starts at LBA 16718 and ends at LBA 35307                
[...]
Originally created by @FakeShemp on GitHub (Mar 3, 2020). ### Prerequisites * [X] Are you running the latest version? * [X] Can you reproduce the problem in the debug version? ### Check and fill as appropriate: * [X] I was running Aaru under Linux Ubuntu 19.10... * [X] ...using .NET Core 3.1... * [X] ...in 64-bit ### Description When dumping with a TS-H353A, the ISRC seem to not be read correctly for all tracks. ### Exact command line used: `./Aaru m dump --first-pregap --persistent /dev/sr0 ComeAlong.aaruf` ### Expected behavior: The ISRC to be set to: ``` Setting ISRC for track 1 to SELEE0107010 Setting ISRC for track 2 to SELEE0107020 Setting ISRC for track 3 to SELEE0107030 Setting ISRC for track 4 to SELEE0107040 Setting ISRC for track 5 to SELEE0107050 Setting ISRC for track 6 to SELEE0107060 Setting ISRC for track 7 to SELEE0107070 Setting ISRC for track 8 to SELEE0107080 Setting ISRC for track 9 to SELEE0107090 Setting ISRC for track 10 to SELEE0107100 Setting ISRC for track 11 to SELEE0107110 ``` ### Actual behavior: It was set to: ``` Setting ISRC for track 1 to SELEE0107010 Setting ISRC for track 2 to +?q????] Setting ISRC for track 3 to SELEE0107030 Setting ISRC for track 4 to $S;?$?:h%4<l Setting ISRC for track 5 to SELEE0107050 Setting ISRC for track 6 to SELEE0107060 Setting ISRC for track 7 to SELEE0107070 Setting ISRC for track 8 to SELEE0107080 Setting ISRC for track 9 to SELEE0107090 Setting ISRC for track 10 to SELEE0107100 ``` ### If command was expected to work with a device fill this out: * **Manufacturer**: Toshiba-Samsung * **Model**: TS-H353A * **Bus**: * [X] USB ### Output of command execution with debug output enabled ISRC relevant part of debug ``` [...] DEBUG (Aaru Format plugin): Got a shift of 12 for 4096 sectors per block DEBUG (Aaru Format plugin): In memory DDT?: True DEBUG (SCSI Device): READ CD (LBA: 0, Block Size: 2448, Transfer Length: 1, Expected Sector Type: AllTypes, DAP: False, Relative Address: False, Sync: True, Headers: AllHeaders, User Data: True, ECC/EDC: True, C2: None, Subchannel: Raw, Sense: False, Last Error: 0) took 40 ms. Setting flags for track 1... Setting flags for track 2... Setting flags for track 3... Setting flags for track 4... Setting flags for track 5... Setting flags for track 6... Setting flags for track 7... Setting flags for track 8... Setting flags for track 9... Setting flags for track 10... Setting flags for track 11... DEBUG (SCSI Device): READ READ SUB-CHANNEL (MCN, Sense False, Last Error 0) took 176 ms. DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 1, Sense: False, Last Error: 0) took 116 ms. Setting ISRC for track 1 to SELEE0107010 DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 2, Sense: False, Last Error: 0) took 144 ms. Setting ISRC for track 2 to SELEE0107020 DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 3, Sense: False, Last Error: 0) took 68 ms. Setting ISRC for track 3 to ??????????? DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 4, Sense: False, Last Error: 0) took 96 ms. Setting ISRC for track 4 to SELEE0107040 DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 5, Sense: False, Last Error: 0) took 204 ms. Setting ISRC for track 5 to SELEE0107050 DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 6, Sense: False, Last Error: 0) took 160 ms. Setting ISRC for track 6 to SELEE0107060 DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 7, Sense: False, Last Error: 0) took 84 ms. Setting ISRC for track 7 to SELEE0107070 DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 8, Sense: False, Last Error: 0) took 140 ms. Setting ISRC for track 8 to SELEE0107080 DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 9, Sense: False, Last Error: 0) took 148 ms. Setting ISRC for track 9 to SELEE0107090 DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 10, Sense: False, Last Error: 0) took 72 ms. Setting ISRC for track 10 to SELEE0107100 DEBUG (SCSI Device): READ READ SUB-CHANNEL (ISRC, Track Number: 11, Sense: False, Last Error: 0) took 132 ms. Setting ISRC for track 11 to SELEE0107110 Track 1 starts at LBA 0 and ends at LBA 16717 Track 2 starts at LBA 16718 and ends at LBA 35307 [...] ```
claunia commented 2026-01-29 15:16:14 +00:00
Author
Owner
Copy Link

@claunia commented on GitHub (May 5, 2020):

Fixed in fb947e3d5c.

@claunia commented on GitHub (May 5, 2020): Fixed in fb947e3d5ca4ba9a49a6bca6c9c6e7f671ef1985.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
archive
beginner
bug
bug
dependencies
device
device
dump image format
duplicate
Epic
feature request
filesystem
filter
gui
gui
gui
help wanted
invalid
invalid
media
needs triage
partitioning scheme
pull-request
Mirrored from GitHub Pull Request
 upstream
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/Aaru-aaru-dps#331
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?