aaru-dps/Aaru-aaru-dps
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2026-02-04 00:54:33 +00:00
Code Issues 657 Packages Projects Releases 19 Wiki Activity

Extract TOC generation from CloneCd into Aaru.Decoders #774

New Issue
Closed
opened 2026-01-29 15:29:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 15:29:26 +00:00
Owner
Copy Link

Originally created by @mnadareski on GitHub (Jun 28, 2021).

Check and fill as appropriate:

  • Support for a new media image format...
  • Support for identifying a new filesystem...
  • Support for extracting files from a new filesystem...
  • New command...
  • Improvement to output...
  • Improvement to enable code reuse

Detailed Description

Currently, the code to generate a TOC is a private method within CloneCd. With this suggested change, that code would be moved a more common location that would be accessible by both other image formats and any programs that use the Aaru libraries.

Context

This was requested due to a pull request on RedBookPlayer, where that functionality had to be copied out from CloneCd: https://github.com/aaru-dps/RedBookPlayer/pull/12
This change would allow for less code duplication for these cases.

Known documentation

https://github.com/aaru-dps/Aaru/blob/master/Aaru.Images/CloneCD/Write.cs#L285

Originally created by @mnadareski on GitHub (Jun 28, 2021). <!--- Provide a general summary of the issue in the Title above --> ### Check and fill as appropriate: * [ ] Support for a new media image format... * [ ] Support for identifying a new filesystem... * [ ] Support for extracting files from a new filesystem... * [ ] New command... * [ ] Improvement to output... * [X] Improvement to enable code reuse ## Detailed Description Currently, the code to generate a TOC is a private method within CloneCd. With this suggested change, that code would be moved a more common location that would be accessible by both other image formats and any programs that use the Aaru libraries. ## Context This was requested due to a pull request on RedBookPlayer, where that functionality had to be copied out from CloneCd: https://github.com/aaru-dps/RedBookPlayer/pull/12 This change would allow for less code duplication for these cases. ## Known documentation https://github.com/aaru-dps/Aaru/blob/master/Aaru.Images/CloneCD/Write.cs#L285
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
archive
beginner
bug
bug
dependencies
device
device
dump image format
duplicate
Epic
feature request
filesystem
filter
gui
gui
gui
help wanted
invalid
invalid
media
needs triage
partitioning scheme
pull-request
Mirrored from GitHub Pull Request
 upstream
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/Aaru-aaru-dps#774
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?