From 4ce965e6cfa46d073b59438e428657baf9aefe85 Mon Sep 17 00:00:00 2001
From: Natalia Portillo <claunia@claunia.com>
Date: Thu, 21 Dec 2017 06:06:19 +0000
Subject: [PATCH] REFACTOR: Invert 'if' statement to reduce nesting.

---
 Extents/ExtentsByte.cs   | 30 ++++++++++++++----------------
 Extents/ExtentsInt.cs    | 30 ++++++++++++++----------------
 Extents/ExtentsLong.cs   | 30 ++++++++++++++----------------
 Extents/ExtentsSByte.cs  | 30 ++++++++++++++----------------
 Extents/ExtentsShort.cs  | 30 ++++++++++++++----------------
 Extents/ExtentsUInt.cs   | 30 ++++++++++++++----------------
 Extents/ExtentsULong.cs  | 30 ++++++++++++++----------------
 Extents/ExtentsUShort.cs | 30 ++++++++++++++----------------
 StringHandlers.cs        |  9 ++++-----
 9 files changed, 116 insertions(+), 133 deletions(-)

diff --git a/Extents/ExtentsByte.cs b/Extents/ExtentsByte.cs
index b7efb0f..ad6e549 100644
--- a/Extents/ExtentsByte.cs
+++ b/Extents/ExtentsByte.cs
@@ -82,19 +82,18 @@ namespace Extents
                 }
 
                 // Expands existing extent end
-                if(item == backend[i].Item2 + 1)
+                if(item != backend[i].Item2 + 1) continue;
+
+                removeOne = backend[i];
+
+                if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
                 {
-                    removeOne = backend[i];
-
-                    if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
-                    {
-                        removeTwo = backend[i + 1];
-                        itemToAdd = new Tuple<byte, byte>(backend[i].Item1, backend[i + 1].Item2);
-                    }
-                    else itemToAdd = new Tuple<byte, byte>(backend[i].Item1, item);
-
-                    break;
+                    removeTwo = backend[i + 1];
+                    itemToAdd = new Tuple<byte, byte>(backend[i].Item1, backend[i + 1].Item2);
                 }
+                else itemToAdd = new Tuple<byte, byte>(backend[i].Item1, item);
+
+                break;
             }
 
             if(itemToAdd != null)
@@ -170,11 +169,10 @@ namespace Extents
                 }
 
                 // Extent is only element
-                if(item == extent.Item1 && item == extent.Item2)
-                {
-                    toRemove = extent;
-                    break;
-                }
+                if(item != extent.Item1 || item != extent.Item2) continue;
+
+                toRemove = extent;
+                break;
             }
 
             // Item not found
diff --git a/Extents/ExtentsInt.cs b/Extents/ExtentsInt.cs
index ee6b2d3..ad651ff 100644
--- a/Extents/ExtentsInt.cs
+++ b/Extents/ExtentsInt.cs
@@ -82,19 +82,18 @@ namespace Extents
                 }
 
                 // Expands existing extent end
-                if(item == backend[i].Item2 + 1)
+                if(item != backend[i].Item2 + 1) continue;
+
+                removeOne = backend[i];
+
+                if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
                 {
-                    removeOne = backend[i];
-
-                    if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
-                    {
-                        removeTwo = backend[i + 1];
-                        itemToAdd = new Tuple<int, int>(backend[i].Item1, backend[i + 1].Item2);
-                    }
-                    else itemToAdd = new Tuple<int, int>(backend[i].Item1, item);
-
-                    break;
+                    removeTwo = backend[i + 1];
+                    itemToAdd = new Tuple<int, int>(backend[i].Item1, backend[i + 1].Item2);
                 }
+                else itemToAdd = new Tuple<int, int>(backend[i].Item1, item);
+
+                break;
             }
 
             if(itemToAdd != null)
@@ -170,11 +169,10 @@ namespace Extents
                 }
 
                 // Extent is only element
-                if(item == extent.Item1 && item == extent.Item2)
-                {
-                    toRemove = extent;
-                    break;
-                }
+                if(item != extent.Item1 || item != extent.Item2) continue;
+
+                toRemove = extent;
+                break;
             }
 
             // Item not found
diff --git a/Extents/ExtentsLong.cs b/Extents/ExtentsLong.cs
index 1e2979c..85fdf56 100644
--- a/Extents/ExtentsLong.cs
+++ b/Extents/ExtentsLong.cs
@@ -82,19 +82,18 @@ namespace Extents
                 }
 
                 // Expands existing extent end
-                if(item == backend[i].Item2 + 1)
+                if(item != backend[i].Item2 + 1) continue;
+
+                removeOne = backend[i];
+
+                if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
                 {
-                    removeOne = backend[i];
-
-                    if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
-                    {
-                        removeTwo = backend[i + 1];
-                        itemToAdd = new Tuple<long, long>(backend[i].Item1, backend[i + 1].Item2);
-                    }
-                    else itemToAdd = new Tuple<long, long>(backend[i].Item1, item);
-
-                    break;
+                    removeTwo = backend[i + 1];
+                    itemToAdd = new Tuple<long, long>(backend[i].Item1, backend[i + 1].Item2);
                 }
+                else itemToAdd = new Tuple<long, long>(backend[i].Item1, item);
+
+                break;
             }
 
             if(itemToAdd != null)
@@ -170,11 +169,10 @@ namespace Extents
                 }
 
                 // Extent is only element
-                if(item == extent.Item1 && item == extent.Item2)
-                {
-                    toRemove = extent;
-                    break;
-                }
+                if(item != extent.Item1 || item != extent.Item2) continue;
+
+                toRemove = extent;
+                break;
             }
 
             // Item not found
diff --git a/Extents/ExtentsSByte.cs b/Extents/ExtentsSByte.cs
index 8ecd609..2444eb2 100644
--- a/Extents/ExtentsSByte.cs
+++ b/Extents/ExtentsSByte.cs
@@ -82,19 +82,18 @@ namespace Extents
                 }
 
                 // Expands existing extent end
-                if(item == backend[i].Item2 + 1)
+                if(item != backend[i].Item2 + 1) continue;
+
+                removeOne = backend[i];
+
+                if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
                 {
-                    removeOne = backend[i];
-
-                    if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
-                    {
-                        removeTwo = backend[i + 1];
-                        itemToAdd = new Tuple<sbyte, sbyte>(backend[i].Item1, backend[i + 1].Item2);
-                    }
-                    else itemToAdd = new Tuple<sbyte, sbyte>(backend[i].Item1, item);
-
-                    break;
+                    removeTwo = backend[i + 1];
+                    itemToAdd = new Tuple<sbyte, sbyte>(backend[i].Item1, backend[i + 1].Item2);
                 }
+                else itemToAdd = new Tuple<sbyte, sbyte>(backend[i].Item1, item);
+
+                break;
             }
 
             if(itemToAdd != null)
@@ -170,11 +169,10 @@ namespace Extents
                 }
 
                 // Extent is only element
-                if(item == extent.Item1 && item == extent.Item2)
-                {
-                    toRemove = extent;
-                    break;
-                }
+                if(item != extent.Item1 || item != extent.Item2) continue;
+
+                toRemove = extent;
+                break;
             }
 
             // Item not found
diff --git a/Extents/ExtentsShort.cs b/Extents/ExtentsShort.cs
index 2e5f401..ac32f34 100644
--- a/Extents/ExtentsShort.cs
+++ b/Extents/ExtentsShort.cs
@@ -82,19 +82,18 @@ namespace Extents
                 }
 
                 // Expands existing extent end
-                if(item == backend[i].Item2 + 1)
+                if(item != backend[i].Item2 + 1) continue;
+
+                removeOne = backend[i];
+
+                if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
                 {
-                    removeOne = backend[i];
-
-                    if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
-                    {
-                        removeTwo = backend[i + 1];
-                        itemToAdd = new Tuple<short, short>(backend[i].Item1, backend[i + 1].Item2);
-                    }
-                    else itemToAdd = new Tuple<short, short>(backend[i].Item1, item);
-
-                    break;
+                    removeTwo = backend[i + 1];
+                    itemToAdd = new Tuple<short, short>(backend[i].Item1, backend[i + 1].Item2);
                 }
+                else itemToAdd = new Tuple<short, short>(backend[i].Item1, item);
+
+                break;
             }
 
             if(itemToAdd != null)
@@ -170,11 +169,10 @@ namespace Extents
                 }
 
                 // Extent is only element
-                if(item == extent.Item1 && item == extent.Item2)
-                {
-                    toRemove = extent;
-                    break;
-                }
+                if(item != extent.Item1 || item != extent.Item2) continue;
+
+                toRemove = extent;
+                break;
             }
 
             // Item not found
diff --git a/Extents/ExtentsUInt.cs b/Extents/ExtentsUInt.cs
index 8fb27ff..27a0e8b 100644
--- a/Extents/ExtentsUInt.cs
+++ b/Extents/ExtentsUInt.cs
@@ -82,19 +82,18 @@ namespace Extents
                 }
 
                 // Expands existing extent end
-                if(item == backend[i].Item2 + 1)
+                if(item != backend[i].Item2 + 1) continue;
+
+                removeOne = backend[i];
+
+                if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
                 {
-                    removeOne = backend[i];
-
-                    if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
-                    {
-                        removeTwo = backend[i + 1];
-                        itemToAdd = new Tuple<uint, uint>(backend[i].Item1, backend[i + 1].Item2);
-                    }
-                    else itemToAdd = new Tuple<uint, uint>(backend[i].Item1, item);
-
-                    break;
+                    removeTwo = backend[i + 1];
+                    itemToAdd = new Tuple<uint, uint>(backend[i].Item1, backend[i + 1].Item2);
                 }
+                else itemToAdd = new Tuple<uint, uint>(backend[i].Item1, item);
+
+                break;
             }
 
             if(itemToAdd != null)
@@ -170,11 +169,10 @@ namespace Extents
                 }
 
                 // Extent is only element
-                if(item == extent.Item1 && item == extent.Item2)
-                {
-                    toRemove = extent;
-                    break;
-                }
+                if(item != extent.Item1 || item != extent.Item2) continue;
+
+                toRemove = extent;
+                break;
             }
 
             // Item not found
diff --git a/Extents/ExtentsULong.cs b/Extents/ExtentsULong.cs
index 68d5a3b..7fcea95 100644
--- a/Extents/ExtentsULong.cs
+++ b/Extents/ExtentsULong.cs
@@ -82,19 +82,18 @@ namespace Extents
                 }
 
                 // Expands existing extent end
-                if(item == backend[i].Item2 + 1)
+                if(item != backend[i].Item2 + 1) continue;
+
+                removeOne = backend[i];
+
+                if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
                 {
-                    removeOne = backend[i];
-
-                    if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
-                    {
-                        removeTwo = backend[i + 1];
-                        itemToAdd = new Tuple<ulong, ulong>(backend[i].Item1, backend[i + 1].Item2);
-                    }
-                    else itemToAdd = new Tuple<ulong, ulong>(backend[i].Item1, item);
-
-                    break;
+                    removeTwo = backend[i + 1];
+                    itemToAdd = new Tuple<ulong, ulong>(backend[i].Item1, backend[i + 1].Item2);
                 }
+                else itemToAdd = new Tuple<ulong, ulong>(backend[i].Item1, item);
+
+                break;
             }
 
             if(itemToAdd != null)
@@ -170,11 +169,10 @@ namespace Extents
                 }
 
                 // Extent is only element
-                if(item == extent.Item1 && item == extent.Item2)
-                {
-                    toRemove = extent;
-                    break;
-                }
+                if(item != extent.Item1 || item != extent.Item2) continue;
+
+                toRemove = extent;
+                break;
             }
 
             // Item not found
diff --git a/Extents/ExtentsUShort.cs b/Extents/ExtentsUShort.cs
index e74f028..e9e11d4 100644
--- a/Extents/ExtentsUShort.cs
+++ b/Extents/ExtentsUShort.cs
@@ -82,19 +82,18 @@ namespace Extents
                 }
 
                 // Expands existing extent end
-                if(item == backend[i].Item2 + 1)
+                if(item != backend[i].Item2 + 1) continue;
+
+                removeOne = backend[i];
+
+                if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
                 {
-                    removeOne = backend[i];
-
-                    if(i < backend.Count - 1 && item == backend[i + 1].Item1 - 1)
-                    {
-                        removeTwo = backend[i + 1];
-                        itemToAdd = new Tuple<ushort, ushort>(backend[i].Item1, backend[i + 1].Item2);
-                    }
-                    else itemToAdd = new Tuple<ushort, ushort>(backend[i].Item1, item);
-
-                    break;
+                    removeTwo = backend[i + 1];
+                    itemToAdd = new Tuple<ushort, ushort>(backend[i].Item1, backend[i + 1].Item2);
                 }
+                else itemToAdd = new Tuple<ushort, ushort>(backend[i].Item1, item);
+
+                break;
             }
 
             if(itemToAdd != null)
@@ -171,11 +170,10 @@ namespace Extents
                 }
 
                 // Extent is only element
-                if(item == extent.Item1 && item == extent.Item2)
-                {
-                    toRemove = extent;
-                    break;
-                }
+                if(item != extent.Item1 || item != extent.Item2) continue;
+
+                toRemove = extent;
+                break;
             }
 
             // Item not found
diff --git a/StringHandlers.cs b/StringHandlers.cs
index 839cfea..728715e 100644
--- a/StringHandlers.cs
+++ b/StringHandlers.cs
@@ -145,11 +145,10 @@ namespace DiscImageChef
             {
                 if(i == start) return "";
 
-                if(SpacePaddedString[i - 1] != 0x20)
-                {
-                    len = i;
-                    break;
-                }
+                if(SpacePaddedString[i - 1] == 0x20) continue;
+
+                len = i;
+                break;
             }
 
             return len == 0 ? "" : encoding.GetString(SpacePaddedString, start, len);