diff --git a/DiscImageChef.Core/Devices/Dumping/ATA.cs b/DiscImageChef.Core/Devices/Dumping/ATA.cs index d8ae8c0d..d22905dc 100644 --- a/DiscImageChef.Core/Devices/Dumping/ATA.cs +++ b/DiscImageChef.Core/Devices/Dumping/ATA.cs @@ -277,9 +277,7 @@ namespace DiscImageChef.Core.Devices.Dumping dumpLog.WriteLine("Error reading {0} blocks from block {1}.", blocksToRead, i); } -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created currentSpeed = (double)blockSize * blocksToRead / 1048576 / (duration / 1000); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created GC.Collect(); resume.NextBlock = i + blocksToRead; } @@ -287,11 +285,9 @@ namespace DiscImageChef.Core.Devices.Dumping end = DateTime.Now; DicConsole.WriteLine(); mhddLog.Close(); -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created ibgLog.Close(dev, blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000), devicePath); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created dumpLog.WriteLine("Dump finished in {0} seconds.", (end - start).TotalSeconds); dumpLog.WriteLine("Average dump speed {0:F3} KiB/sec.", (double)blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000)); @@ -399,9 +395,7 @@ namespace DiscImageChef.Core.Devices.Dumping dumpFile.Write(new byte[blockSize]); } -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created currentSpeed = blockSize / (double)1048576 / (duration / 1000); -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created GC.Collect(); currentBlock++; @@ -412,11 +406,9 @@ namespace DiscImageChef.Core.Devices.Dumping end = DateTime.Now; DicConsole.WriteLine(); mhddLog.Close(); -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created ibgLog.Close(dev, blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000), devicePath); -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created dumpLog.WriteLine("Dump finished in {0} seconds.", (end - start).TotalSeconds); dumpLog.WriteLine("Average dump speed {0:F3} KiB/sec.", (double)blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000)); diff --git a/DiscImageChef.Core/Devices/Dumping/CompactDisc.cs b/DiscImageChef.Core/Devices/Dumping/CompactDisc.cs index 663b9bba..9d555afd 100644 --- a/DiscImageChef.Core/Devices/Dumping/CompactDisc.cs +++ b/DiscImageChef.Core/Devices/Dumping/CompactDisc.cs @@ -437,9 +437,7 @@ namespace DiscImageChef.Core.Devices.Dumping } } -#pragma warning disable IDE0004 // Remove Unnecessary Cast currentSpeed = blockSize / (double)1048576 / (cmdDuration / 1000); -#pragma warning restore IDE0004 // Remove Unnecessary Cast } dumpFile.Close(); @@ -629,9 +627,7 @@ namespace DiscImageChef.Core.Devices.Dumping } } -#pragma warning disable IDE0004 // Remove Unnecessary Cast currentSpeed = (double)blockSize * blocksToRead / 1048576 / (cmdDuration / 1000); -#pragma warning restore IDE0004 // Remove Unnecessary Cast resume.NextBlock = i + blocksToRead; } @@ -672,10 +668,8 @@ namespace DiscImageChef.Core.Devices.Dumping DicConsole.WriteLine(); end = DateTime.UtcNow; mhddLog.Close(); -#pragma warning disable IDE0004 // Remove Unnecessary Cast ibgLog.Close(dev, blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000), devicePath); -#pragma warning restore IDE0004 // Remove Unnecessary Cast dumpLog.WriteLine("Dump finished in {0} seconds.", (end - start).TotalSeconds); dumpLog.WriteLine("Average dump speed {0:F3} KiB/sec.", (double)blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000)); @@ -860,9 +854,7 @@ namespace DiscImageChef.Core.Devices.Dumping double chkDuration = (chkEnd - chkStart).TotalMilliseconds; totalChkDuration += chkDuration; -#pragma warning disable IDE0004 // Remove Unnecessary Cast currentSpeed = (double)blockSize * blocksToRead / 1048576 / (chkDuration / 1000); -#pragma warning restore IDE0004 // Remove Unnecessary Cast } tracks[t].Checksums = trkChk.End().ToArray(); diff --git a/DiscImageChef.Core/Devices/Dumping/SBC.cs b/DiscImageChef.Core/Devices/Dumping/SBC.cs index c1f62323..3ac0c436 100644 --- a/DiscImageChef.Core/Devices/Dumping/SBC.cs +++ b/DiscImageChef.Core/Devices/Dumping/SBC.cs @@ -396,19 +396,15 @@ namespace DiscImageChef.Core.Devices.Dumping dumpLog.WriteLine("Error reading {0} blocks from block {1}.", blocksToRead, i); } -#pragma warning disable IDE0004 // Remove Unnecessary Cast currentSpeed = (double)blockSize * blocksToRead / 1048576 / (cmdDuration / 1000); -#pragma warning restore IDE0004 // Remove Unnecessary Cast resume.NextBlock = i + blocksToRead; } end = DateTime.UtcNow; DicConsole.WriteLine(); mhddLog.Close(); -#pragma warning disable IDE0004 // Remove Unnecessary Cast ibgLog.Close(dev, blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000), devicePath); -#pragma warning restore IDE0004 // Remove Unnecessary Cast dumpLog.WriteLine("Dump finished in {0} seconds.", (end - start).TotalSeconds); dumpLog.WriteLine("Average dump speed {0:F3} KiB/sec.", (double)blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000)); @@ -592,9 +588,7 @@ namespace DiscImageChef.Core.Devices.Dumping double chkDuration = (chkEnd - chkStart).TotalMilliseconds; totalChkDuration += chkDuration; -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created currentSpeed = (double)blockSize * blocksToRead / 1048576 / (chkDuration / 1000); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created } DicConsole.WriteLine(); @@ -831,10 +825,8 @@ namespace DiscImageChef.Core.Devices.Dumping DicConsole.WriteLine("Took a total of {0:F3} seconds ({1:F3} processing commands, {2:F3} checksumming).", (end - start).TotalSeconds, totalDuration / 1000, totalChkDuration / 1000); -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created DicConsole.WriteLine("Avegare speed: {0:F3} MiB/sec.", (double)blockSize * (double)(blocks + 1) / 1048576 / (totalDuration / 1000)); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created DicConsole.WriteLine("Fastest speed burst: {0:F3} MiB/sec.", maxSpeed); DicConsole.WriteLine("Slowest speed burst: {0:F3} MiB/sec.", minSpeed); DicConsole.WriteLine("{0} sectors could not be read.", resume.BadBlocks.Count); diff --git a/DiscImageChef.Core/Devices/Dumping/SSC.cs b/DiscImageChef.Core/Devices/Dumping/SSC.cs index f3c73bc8..108168c3 100644 --- a/DiscImageChef.Core/Devices/Dumping/SSC.cs +++ b/DiscImageChef.Core/Devices/Dumping/SSC.cs @@ -632,10 +632,8 @@ namespace DiscImageChef.Core.Devices.Dumping DicConsole.WriteLine("Took a total of {0:F3} seconds ({1:F3} processing commands, {2:F3} checksumming).", (end - start).TotalSeconds, totalDuration / 1000, totalChkDuration / 1000); -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created DicConsole.WriteLine("Avegare speed: {0:F3} MiB/sec.", (double)blockSize * (double)(blocks + 1) / 1048576 / (totalDuration / 1000)); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created DicConsole.WriteLine("Fastest speed burst: {0:F3} MiB/sec.", maxSpeed); DicConsole.WriteLine("Slowest speed burst: {0:F3} MiB/sec.", minSpeed); diff --git a/DiscImageChef.Core/Devices/Dumping/SecureDigital.cs b/DiscImageChef.Core/Devices/Dumping/SecureDigital.cs index 1f653330..89f2b82c 100644 --- a/DiscImageChef.Core/Devices/Dumping/SecureDigital.cs +++ b/DiscImageChef.Core/Devices/Dumping/SecureDigital.cs @@ -344,9 +344,7 @@ namespace DiscImageChef.Core.Devices.Dumping dumpLog.WriteLine("Error reading {0} blocks from block {1}.", blocksToRead, i); } -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created currentSpeed = (double)blockSize * blocksToRead / 1048576 / (duration / 1000); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created GC.Collect(); resume.NextBlock = i + blocksToRead; } @@ -354,10 +352,8 @@ namespace DiscImageChef.Core.Devices.Dumping end = DateTime.Now; DicConsole.WriteLine(); mhddLog.Close(); -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created ibgLog.Close(dev, blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000), devicePath); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created dumpLog.WriteLine("Dump finished in {0} seconds.", (end - start).TotalSeconds); dumpLog.WriteLine("Average dump speed {0:F3} KiB/sec.", (double)blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000)); diff --git a/DiscImageChef.Core/Devices/Dumping/XGD.cs b/DiscImageChef.Core/Devices/Dumping/XGD.cs index 8ffd3e0c..0731d824 100644 --- a/DiscImageChef.Core/Devices/Dumping/XGD.cs +++ b/DiscImageChef.Core/Devices/Dumping/XGD.cs @@ -437,9 +437,7 @@ namespace DiscImageChef.Core.Devices.Dumping foreach(string senseLine in senseLines) dumpLog.WriteLine(senseLine); } -#pragma warning disable IDE0004 // Remove Unnecessary Cast currentSpeed = (double)blockSize * blocksToRead / 1048576 / (cmdDuration / 1000); -#pragma warning restore IDE0004 // Remove Unnecessary Cast blocksToRead = saveBlocksToRead; currentSector = i + 1; resume.NextBlock = currentSector; @@ -568,9 +566,7 @@ namespace DiscImageChef.Core.Devices.Dumping foreach(string senseLine in senseLines) dumpLog.WriteLine(senseLine); } -#pragma warning disable IDE0004 // Remove Unnecessary Cast currentSpeed = (double)blockSize * blocksToRead / 1048576 / (cmdDuration / 1000); -#pragma warning restore IDE0004 // Remove Unnecessary Cast currentSector += blocksToRead; resume.NextBlock = currentSector; } @@ -594,10 +590,8 @@ namespace DiscImageChef.Core.Devices.Dumping end = DateTime.UtcNow; DicConsole.WriteLine(); mhddLog.Close(); -#pragma warning disable IDE0004 // Remove Unnecessary Cast ibgLog.Close(dev, blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000), devicePath); -#pragma warning restore IDE0004 // Remove Unnecessary Cast dumpLog.WriteLine("Dump finished in {0} seconds.", (end - start).TotalSeconds); dumpLog.WriteLine("Average dump speed {0:F3} KiB/sec.", (double)blockSize * (double)(blocks + 1) / 1024 / (totalDuration / 1000)); @@ -792,9 +786,7 @@ namespace DiscImageChef.Core.Devices.Dumping double chkDuration = (chkEnd - chkStart).TotalMilliseconds; totalChkDuration += chkDuration; -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created currentSpeed = (double)blockSize * blocksToRead / 1048576 / (chkDuration / 1000); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created } DicConsole.WriteLine(); diff --git a/DiscImageChef.Core/Devices/ReaderATA.cs b/DiscImageChef.Core/Devices/ReaderATA.cs index c538d82f..cafee9dd 100644 --- a/DiscImageChef.Core/Devices/ReaderATA.cs +++ b/DiscImageChef.Core/Devices/ReaderATA.cs @@ -191,9 +191,7 @@ namespace DiscImageChef.Core.Devices if((ataId.PhysLogSectorSize & 0x2000) == 0x2000) { -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created PhysicalBlockSize = LogicalBlockSize * (uint)Math.Pow(2, ataId.PhysLogSectorSize & 0xF); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created } else PhysicalBlockSize = LogicalBlockSize; } diff --git a/DiscImageChef.Core/Devices/ReaderSCSI.cs b/DiscImageChef.Core/Devices/ReaderSCSI.cs index 53ce5521..a2ec772d 100644 --- a/DiscImageChef.Core/Devices/ReaderSCSI.cs +++ b/DiscImageChef.Core/Devices/ReaderSCSI.cs @@ -93,15 +93,11 @@ namespace DiscImageChef.Core.Devices return true; } -#pragma warning disable IDE0004 // Remove Unnecessary Cast if(!read16 && Blocks > 0xFFFFFFFF + (long)1) -#pragma warning restore IDE0004 // Remove Unnecessary Cast { -#pragma warning disable IDE0004 // Remove Unnecessary Cast ErrorMessage = string.Format("Device only supports SCSI READ (10) but has more than {0} blocks ({1} blocks total)", 0xFFFFFFFF + (long)1, Blocks); -#pragma warning restore IDE0004 // Remove Unnecessary Cast return true; } diff --git a/DiscImageChef.Core/Devices/Report/ATA.cs b/DiscImageChef.Core/Devices/Report/ATA.cs index 338cf426..4030368f 100644 --- a/DiscImageChef.Core/Devices/Report/ATA.cs +++ b/DiscImageChef.Core/Devices/Report/ATA.cs @@ -603,10 +603,8 @@ namespace DiscImageChef.Core.Devices.Report if((ataId.PhysLogSectorSize & 0x2000) == 0x2000) { -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created physicalsectorsize = (uint)(logicalsectorsize * ((1 << ataId.PhysLogSectorSize) & 0xF)); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created } else physicalsectorsize = logicalsectorsize; } @@ -973,10 +971,8 @@ namespace DiscImageChef.Core.Devices.Report if((ataId.PhysLogSectorSize & 0x2000) == 0x2000) { -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created physicalsectorsize = logicalsectorsize * (uint)Math.Pow(2, ataId.PhysLogSectorSize & 0xF); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created } else physicalsectorsize = logicalsectorsize; } diff --git a/DiscImageChef.Core/Devices/Scanning/ATA.cs b/DiscImageChef.Core/Devices/Scanning/ATA.cs index c1aa243a..f9841c6d 100644 --- a/DiscImageChef.Core/Devices/Scanning/ATA.cs +++ b/DiscImageChef.Core/Devices/Scanning/ATA.cs @@ -167,20 +167,16 @@ namespace DiscImageChef.Core.Devices.Scanning ibgLog.Write(i, 0); } -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values currentSpeed = (double)blockSize * blocksToRead / 1048576 / (duration / 1000); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values GC.Collect(); } end = DateTime.UtcNow; DicConsole.WriteLine(); mhddLog.Close(); -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values ibgLog.Close(dev, results.Blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(results.Blocks + 1) / 1024 / (results.ProcessingTime / 1000), devicePath); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values if(ataReader.CanSeekLba) for(int i = 0; i < SEEK_TIMES; i++) @@ -252,9 +248,7 @@ namespace DiscImageChef.Core.Devices.Scanning ibgLog.Write(currentBlock, 0); } -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values currentSpeed = blockSize / (double)1048576 / (duration / 1000); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values GC.Collect(); currentBlock++; @@ -265,11 +259,9 @@ namespace DiscImageChef.Core.Devices.Scanning end = DateTime.UtcNow; DicConsole.WriteLine(); mhddLog.Close(); -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values ibgLog.Close(dev, results.Blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(results.Blocks + 1) / 1024 / (results.ProcessingTime / 1000), devicePath); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values if(ataReader.CanSeek) for(int i = 0; i < SEEK_TIMES; i++) @@ -299,10 +291,8 @@ namespace DiscImageChef.Core.Devices.Scanning results.ProcessingTime /= 1000; results.TotalTime = (end - start).TotalSeconds; -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values results.AvgSpeed = blockSize * (double)(results.Blocks + 1) / 1048576 / results.ProcessingTime; -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values results.SeekTimes = SEEK_TIMES; return results; diff --git a/DiscImageChef.Core/Devices/Scanning/SCSI.cs b/DiscImageChef.Core/Devices/Scanning/SCSI.cs index 9ed3ebe5..20d94143 100644 --- a/DiscImageChef.Core/Devices/Scanning/SCSI.cs +++ b/DiscImageChef.Core/Devices/Scanning/SCSI.cs @@ -161,10 +161,8 @@ namespace DiscImageChef.Core.Devices.Scanning if(results.Blocks != 0 && blockSize != 0) { results.Blocks++; -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values DicConsole.WriteLine("Media has {0} blocks of {1} bytes/each. (for a total of {2} bytes)", results.Blocks, blockSize, results.Blocks * (ulong)blockSize); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values } break; case PeripheralDeviceTypes.SequentialAccess: @@ -353,20 +351,16 @@ namespace DiscImageChef.Core.Devices.Scanning } } -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values currentSpeed = (double)blockSize * blocksToRead / 1048576 / (cmdDuration / 1000); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values GC.Collect(); } end = DateTime.UtcNow; DicConsole.WriteLine(); mhddLog.Close(); -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values ibgLog.Close(dev, results.Blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(results.Blocks + 1) / 1024 / (results.ProcessingTime / 1000), devicePath); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values } else { @@ -418,19 +412,15 @@ namespace DiscImageChef.Core.Devices.Scanning ibgLog.Write(i, 0); } -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values currentSpeed = (double)blockSize * blocksToRead / 1048576 / (cmdDuration / 1000); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values } end = DateTime.UtcNow; DicConsole.WriteLine(); mhddLog.Close(); -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values ibgLog.Close(dev, results.Blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(results.Blocks + 1) / 1024 / (results.ProcessingTime / 1000), devicePath); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values } results.SeekMax = double.MinValue; @@ -468,9 +458,7 @@ namespace DiscImageChef.Core.Devices.Scanning results.ProcessingTime /= 1000; results.TotalTime = (end - start).TotalSeconds; -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values results.AvgSpeed = blockSize * (double)(results.Blocks + 1) / 1048576 / results.ProcessingTime; -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values results.SeekTimes = SEEK_TIMES; return results; diff --git a/DiscImageChef.Core/Devices/Scanning/SecureDigital.cs b/DiscImageChef.Core/Devices/Scanning/SecureDigital.cs index d3af5e3d..c6985341 100644 --- a/DiscImageChef.Core/Devices/Scanning/SecureDigital.cs +++ b/DiscImageChef.Core/Devices/Scanning/SecureDigital.cs @@ -204,20 +204,16 @@ namespace DiscImageChef.Core.Devices.Scanning ibgLog.Write(i, 0); } -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values currentSpeed = (double)blockSize * blocksToRead / 1048576 / (duration / 1000); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values GC.Collect(); } end = DateTime.UtcNow; DicConsole.WriteLine(); mhddLog.Close(); -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values ibgLog.Close(dev, results.Blocks, blockSize, (end - start).TotalSeconds, currentSpeed * 1024, blockSize * (double)(results.Blocks + 1) / 1024 / (results.ProcessingTime / 1000), devicePath); -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values for(int i = 0; i < SEEK_TIMES; i++) { @@ -243,9 +239,7 @@ namespace DiscImageChef.Core.Devices.Scanning results.ProcessingTime /= 1000; results.TotalTime = (end - start).TotalSeconds; -#pragma warning disable IDE0004 // Without this specific cast, it gives incorrect values results.AvgSpeed = blockSize * (double)(results.Blocks + 1) / 1048576 / results.ProcessingTime; -#pragma warning restore IDE0004 // Without this specific cast, it gives incorrect values results.SeekTimes = SEEK_TIMES; return results; diff --git a/DiscImageChef.Decoders/ATA/Identify.cs b/DiscImageChef.Decoders/ATA/Identify.cs index ae9a194e..8943b860 100644 --- a/DiscImageChef.Decoders/ATA/Identify.cs +++ b/DiscImageChef.Decoders/ATA/Identify.cs @@ -2378,10 +2378,8 @@ namespace DiscImageChef.Decoders.ATA if((ATAID.PhysLogSectorSize & 0x2000) == 0x2000) { -#pragma warning disable IDE0004 // Remove Unnecessary Cast physicalsectorsize = logicalsectorsize * (uint)Math.Pow(2, ATAID.PhysLogSectorSize & 0xF); -#pragma warning restore IDE0004 // Remove Unnecessary Cast } else physicalsectorsize = logicalsectorsize; } diff --git a/DiscImageChef.Decoders/SCSI/SSC/BlockLimits.cs b/DiscImageChef.Decoders/SCSI/SSC/BlockLimits.cs index b8d273ac..2f391d71 100644 --- a/DiscImageChef.Decoders/SCSI/SSC/BlockLimits.cs +++ b/DiscImageChef.Decoders/SCSI/SSC/BlockLimits.cs @@ -84,11 +84,9 @@ namespace DiscImageChef.Decoders.SCSI.SSC sb.AppendFormat("Device's minimum block size is {0} bytes", decoded.Value.minBlockLen).AppendLine(); if(decoded.Value.granularity > 0) -#pragma warning disable IDE0004 // Remove Unnecessary Cast sb.AppendFormat("Device's needs a block size granularity of 2^{0} ({1}) bytes", decoded.Value.granularity, Math.Pow(2, decoded.Value.granularity)) .AppendLine(); -#pragma warning restore IDE0004 // Remove Unnecessary Cast } return sb.ToString(); diff --git a/DiscImageChef.Decoders/SCSI/SSC/DensitySupport.cs b/DiscImageChef.Decoders/SCSI/SSC/DensitySupport.cs index 994a8185..09b69167 100644 --- a/DiscImageChef.Decoders/SCSI/SSC/DensitySupport.cs +++ b/DiscImageChef.Decoders/SCSI/SSC/DensitySupport.cs @@ -160,10 +160,8 @@ namespace DiscImageChef.Decoders.SCSI.SSC if(descriptor.duplicate) sb.AppendLine("\tThis descriptor is duplicated"); if(descriptor.defaultDensity) sb.AppendLine("\tThis is the default density on the drive"); sb.AppendFormat("\tDensity has {0} bits per mm, with {1} tracks in a {2} mm width tape", -#pragma warning disable IDE0004 // Remove Unnecessary Cast descriptor.bpmm, descriptor.tracks, descriptor.width / (double)10) .AppendLine(); -#pragma warning restore IDE0004 // Remove Unnecessary Cast sb.AppendFormat("\tDensity maximum capacity is {0} megabytes", descriptor.capacity).AppendLine(); sb.AppendFormat("\tDensity description: {0}", descriptor.description).AppendLine(); sb.AppendLine(); @@ -251,9 +249,7 @@ namespace DiscImageChef.Decoders.SCSI.SSC } sb.AppendFormat("\tMedium has a nominal length of {0} m in a {1} mm width tape", -#pragma warning disable IDE0004 // Remove Unnecessary Cast descriptor.length, descriptor.width / (double)10).AppendLine(); -#pragma warning restore IDE0004 // Remove Unnecessary Cast sb.AppendFormat("\tMedium description: {0}", descriptor.description).AppendLine(); sb.AppendLine(); } diff --git a/DiscImageChef.Devices/Device/ScsiCommands/MMC.cs b/DiscImageChef.Devices/Device/ScsiCommands/MMC.cs index e7c9e1f1..a38936bc 100644 --- a/DiscImageChef.Devices/Device/ScsiCommands/MMC.cs +++ b/DiscImageChef.Devices/Device/ScsiCommands/MMC.cs @@ -99,9 +99,7 @@ namespace DiscImageChef.Devices if(sense) return true; -#pragma warning disable IDE0004 // Cast is necessary or an invalid bitshift happens ushort confLength = (ushort)((buffer[2] << 8) + buffer[3] + 4); -#pragma warning restore IDE0004 // Cast is necessary or an invalid bitshift happens buffer = new byte[confLength]; cdb[7] = (byte)((buffer.Length & 0xFF00) >> 8); cdb[8] = (byte)(buffer.Length & 0xFF); @@ -156,9 +154,7 @@ namespace DiscImageChef.Devices if(sense) return true; -#pragma warning disable IDE0004 // Cast is necessary or an invalid bitshift happens ushort strctLength = (ushort)((buffer[0] << 8) + buffer[1] + 2); -#pragma warning restore IDE0004 // Cast is necessary or an invalid bitshift happens buffer = new byte[strctLength]; cdb[8] = (byte)((buffer.Length & 0xFF00) >> 8); cdb[9] = (byte)(buffer.Length & 0xFF); @@ -318,9 +314,7 @@ namespace DiscImageChef.Devices out sense); Error = LastError != 0; -#pragma warning disable IDE0004 // Cast is necessary or an invalid bitshift happens uint strctLength = (uint)((tmpBuffer[0] << 8) + tmpBuffer[1] + 2); -#pragma warning restore IDE0004 // Cast is necessary or an invalid bitshift happens buffer = new byte[strctLength]; if(buffer.Length <= tmpBuffer.Length) @@ -381,9 +375,7 @@ namespace DiscImageChef.Devices out sense); Error = LastError != 0; -#pragma warning disable IDE0004 // Cast is necessary or an invalid bitshift happens uint strctLength = (uint)((tmpBuffer[0] << 8) + tmpBuffer[1] + 2); -#pragma warning restore IDE0004 // Cast is necessary or an invalid bitshift happens buffer = new byte[strctLength]; Array.Copy(tmpBuffer, 0, buffer, 0, buffer.Length); diff --git a/DiscImageChef.Devices/Device/ScsiCommands/SMC.cs b/DiscImageChef.Devices/Device/ScsiCommands/SMC.cs index c980e5d2..fa22d7bd 100644 --- a/DiscImageChef.Devices/Device/ScsiCommands/SMC.cs +++ b/DiscImageChef.Devices/Device/ScsiCommands/SMC.cs @@ -80,10 +80,8 @@ namespace DiscImageChef.Devices if(sense) return true; -#pragma warning disable IDE0004 // Cast is necessary or an invalid bitshift happens uint attrLen = (uint)((buffer[0] << 24) + (buffer[1] << 16) + (buffer[2] << 8) + buffer[3] + 4); -#pragma warning restore IDE0004 // Cast is necessary or an invalid bitshift happens buffer = new byte[attrLen]; cdb[10] = (byte)((buffer.Length & 0xFF000000) >> 24); cdb[11] = (byte)((buffer.Length & 0xFF0000) >> 16); diff --git a/DiscImageChef.Devices/Device/ScsiCommands/SPC.cs b/DiscImageChef.Devices/Device/ScsiCommands/SPC.cs index d7fd528f..6834ae6f 100644 --- a/DiscImageChef.Devices/Device/ScsiCommands/SPC.cs +++ b/DiscImageChef.Devices/Device/ScsiCommands/SPC.cs @@ -367,9 +367,7 @@ namespace DiscImageChef.Devices if(sense) return true; -#pragma warning disable IDE0004 // Cast is necessary or an invalid bitshift happens ushort modeLength = (ushort)((buffer[0] << 8) + buffer[1] + 2); -#pragma warning restore IDE0004 // Cast is necessary or an invalid bitshift happens buffer = new byte[modeLength]; cdb[7] = (byte)((buffer.Length & 0xFF00) >> 8); cdb[8] = (byte)(buffer.Length & 0xFF); @@ -598,10 +596,8 @@ namespace DiscImageChef.Devices if(sense) return true; -#pragma warning disable IDE0004 // Cast is necessary or an invalid bitshift happens uint strctLength = (uint)((buffer[0] << 24) + (buffer[1] << 16) + (buffer[2] << 8) + buffer[3] + 4); -#pragma warning restore IDE0004 // Cast is necessary or an invalid bitshift happens buffer = new byte[strctLength]; cdb[6] = (byte)((buffer.Length & 0xFF000000) >> 24); cdb[7] = (byte)((buffer.Length & 0xFF0000) >> 16); diff --git a/DiscImageChef.Devices/Device/ScsiCommands/SSC.cs b/DiscImageChef.Devices/Device/ScsiCommands/SSC.cs index e2122ab6..832db00f 100644 --- a/DiscImageChef.Devices/Device/ScsiCommands/SSC.cs +++ b/DiscImageChef.Devices/Device/ScsiCommands/SSC.cs @@ -917,9 +917,7 @@ namespace DiscImageChef.Devices if(sense) return true; -#pragma warning disable IDE0004 // Cast is necessary or an invalid bitshift happens ushort availableLength = (ushort)((buffer[0] << 8) + buffer[1] + 2); -#pragma warning restore IDE0004 // Cast is necessary or an invalid bitshift happens buffer = new byte[availableLength]; cdb[7] = (byte)((buffer.Length & 0xFF00) >> 8); cdb[8] = (byte)(buffer.Length & 0xFF); diff --git a/DiscImageChef/Commands/Entropy.cs b/DiscImageChef/Commands/Entropy.cs index 93236c53..019877d1 100644 --- a/DiscImageChef/Commands/Entropy.cs +++ b/DiscImageChef/Commands/Entropy.cs @@ -113,12 +113,10 @@ namespace DiscImageChef.Commands DicConsole.WriteLine("Entropy for track {0} is {1:F4}.", currentTrack.TrackSequence, entropy); -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created if(options.DuplicatedSectors) DicConsole.WriteLine("Track {0} has {1} unique sectors ({1:P3})", currentTrack.TrackSequence, uniqueSectorsPerTrack.Count, (double)uniqueSectorsPerTrack.Count / (double)sectors); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created DicConsole.WriteLine(); } @@ -165,10 +163,8 @@ namespace DiscImageChef.Commands DicConsole.WriteLine("Entropy for disk is {0:F4}.", entropy); if(options.DuplicatedSectors) -#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created DicConsole.WriteLine("Disk has {0} unique sectors ({1:P3})", uniqueSectors.Count, (double)uniqueSectors.Count / (double)sectors); -#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created Core.Statistics.AddCommand("entropy"); }