From 8c6d05eed34a0a0e6a4c28df67ca7681750182d6 Mon Sep 17 00:00:00 2001
From: Natalia Portillo <claunia@claunia.com>
Date: Tue, 19 Dec 2017 01:13:31 +0000
Subject: [PATCH] FEATURE FREEZE: Removed TODO lines already implemented.

---
 DiscImageChef.Core/Devices/Dumping/CompactDisc.cs | 1 -
 DiscImageChef.Core/Devices/Reader.cs              | 3 ---
 DiscImageChef.Core/Devices/Report/ATA.cs          | 3 +--
 DiscImageChef.Devices/Device/Constructor.cs       | 2 --
 DiscImageChef.Filesystems/AppleHFS.cs             | 1 -
 DiscImageChef.Filesystems/SysV.cs                 | 1 -
 DiscImageChef.Settings/Settings.cs                | 1 -
 DiscImageChef/Commands/Verify.cs                  | 1 -
 8 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/DiscImageChef.Core/Devices/Dumping/CompactDisc.cs b/DiscImageChef.Core/Devices/Dumping/CompactDisc.cs
index b425cf06..ac389109 100644
--- a/DiscImageChef.Core/Devices/Dumping/CompactDisc.cs
+++ b/DiscImageChef.Core/Devices/Dumping/CompactDisc.cs
@@ -56,7 +56,6 @@ namespace DiscImageChef.Core.Devices.Dumping
 
     internal class CompactDisc
     {
-        // TODO: Add support for resume file
         internal static void Dump(Device dev, string devicePath, string outputPrefix, ushort retryPasses, bool force, bool dumpRaw, bool persistent, bool stopOnError, ref CICMMetadataType sidecar, ref MediaType dskType, bool separateSubchannel, ref Resume resume, ref DumpLog dumpLog, Alcohol120 alcohol, bool dumpLeadIn)
         {
             MHDDLog mhddLog;
diff --git a/DiscImageChef.Core/Devices/Reader.cs b/DiscImageChef.Core/Devices/Reader.cs
index d02b46dd..f53205f9 100644
--- a/DiscImageChef.Core/Devices/Reader.cs
+++ b/DiscImageChef.Core/Devices/Reader.cs
@@ -79,9 +79,6 @@ namespace DiscImageChef.Core.Devices
                     break;
                 case DeviceType.NVMe:
                     throw new NotImplementedException("NVMe devices not yet supported.");
-                case DeviceType.MMC:
-                case DeviceType.SecureDigital:
-                    throw new NotImplementedException("MMC/SD devices not yet supported.");
             }
         }
 
diff --git a/DiscImageChef.Core/Devices/Report/ATA.cs b/DiscImageChef.Core/Devices/Report/ATA.cs
index efcd339f..dbd04df8 100644
--- a/DiscImageChef.Core/Devices/Report/ATA.cs
+++ b/DiscImageChef.Core/Devices/Report/ATA.cs
@@ -615,9 +615,8 @@ namespace DiscImageChef.Core.Devices.Report
 
                                     if((ataId.PhysLogSectorSize & 0x2000) == 0x2000)
                                     {
-                                        // TODO: Bit shift 1 << value&F
 #pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created
-                                        physicalsectorsize = logicalsectorsize * (uint)Math.Pow(2, (double)(ataId.PhysLogSectorSize & 0xF));
+                                        physicalsectorsize = (uint)(logicalsectorsize * (1 << ataId.PhysLogSectorSize & 0xF));
 #pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created
                                     }
                                     else
diff --git a/DiscImageChef.Devices/Device/Constructor.cs b/DiscImageChef.Devices/Device/Constructor.cs
index 6fbb3e6f..dbf29fdb 100644
--- a/DiscImageChef.Devices/Device/Constructor.cs
+++ b/DiscImageChef.Devices/Device/Constructor.cs
@@ -213,8 +213,6 @@ namespace DiscImageChef.Devices
                         else
                             manufacturer = "ATA";
                     }
-
-                    // TODO: Get cached CID, CSD and SCR from kernel space
                 }
                 
                 ntDevicePath = Windows.Command.GetDevicePath((SafeFileHandle)fd);
diff --git a/DiscImageChef.Filesystems/AppleHFS.cs b/DiscImageChef.Filesystems/AppleHFS.cs
index 8893783b..101d6203 100644
--- a/DiscImageChef.Filesystems/AppleHFS.cs
+++ b/DiscImageChef.Filesystems/AppleHFS.cs
@@ -136,7 +136,6 @@ namespace DiscImageChef.Filesystems
 
             bool APMFromHDDOnCD = false;
 
-            // TODO: I don't like this, I can do better
             if(imagePlugin.GetSectorSize() == 2352 || imagePlugin.GetSectorSize() == 2448 || imagePlugin.GetSectorSize() == 2048)
             {
                 byte[] tmp_sector = imagePlugin.ReadSectors(partition.Start, 2);
diff --git a/DiscImageChef.Filesystems/SysV.cs b/DiscImageChef.Filesystems/SysV.cs
index 8a8c9738..c576ee19 100644
--- a/DiscImageChef.Filesystems/SysV.cs
+++ b/DiscImageChef.Filesystems/SysV.cs
@@ -38,7 +38,6 @@ using DiscImageChef.CommonTypes;
 namespace DiscImageChef.Filesystems
 {
     // Information from the Linux kernel
-    // TODO: Get documentation, test files, and rewrite this mess
     public class SysVfs : Filesystem
     {
         const uint XENIX_MAGIC = 0x002B5544;
diff --git a/DiscImageChef.Settings/Settings.cs b/DiscImageChef.Settings/Settings.cs
index 7416da77..9fe7f183 100644
--- a/DiscImageChef.Settings/Settings.cs
+++ b/DiscImageChef.Settings/Settings.cs
@@ -353,7 +353,6 @@ namespace DiscImageChef.Settings
                             }
                         }
                         break;
-                    // TODO: Use the Registry
                     default:
                         {
                             string configPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".config");
diff --git a/DiscImageChef/Commands/Verify.cs b/DiscImageChef/Commands/Verify.cs
index 9109e93b..1df2fb14 100644
--- a/DiscImageChef/Commands/Verify.cs
+++ b/DiscImageChef/Commands/Verify.cs
@@ -157,7 +157,6 @@ namespace DiscImageChef.Commands
                             else
                                 checkStatus = null;
 
-                            // TODO: Refactor
                             foreach(ulong failLBA in tempFailingLBAs)
                                 FailingLBAs.Add(failLBA);