From e953155bd369b5a16be37c48ddf5cbac3745ea62 Mon Sep 17 00:00:00 2001 From: Natalia Portillo Date: Wed, 4 Oct 2023 00:09:19 +0100 Subject: [PATCH] Code refactor and cleanup. --- .idea/.idea.Aaru.Server/.idea/discord.xml | 7 + .../.idea/riderMarkupCache.xml | 6 + .../.idea/runConfigurations/Server_task.xml | 8 +- Aaru.Server.Task/Program.cs | 55 +- Aaru.Server.Task/appsettings.json | 2 +- Aaru.Server/Aaru.Server.csproj | 134 ++--- .../Areas/Admin/Controllers/AtasController.cs | 122 ++-- .../Controllers/BlockDescriptorsController.cs | 3 +- .../Areas/Admin/Controllers/ChsController.cs | 13 +- .../Admin/Controllers/CommandsController.cs | 3 +- .../CompactDiscOffsetsController.cs | 18 +- .../Controllers/DeviceStatsController.cs | 18 +- .../Admin/Controllers/DevicesController.cs | 27 +- .../Controllers/FilesystemsController.cs | 3 +- .../Admin/Controllers/FiltersController.cs | 3 +- .../Admin/Controllers/FireWiresController.cs | 28 +- .../GdRomSwapDiscCapabilitiesController.cs | 46 +- .../Areas/Admin/Controllers/HomeController.cs | 3 +- .../Controllers/MediaFormatsController.cs | 11 +- .../Admin/Controllers/MediasController.cs | 11 +- .../Areas/Admin/Controllers/MmcController.cs | 15 +- .../Controllers/MmcFeaturesController.cs | 7 +- .../Admin/Controllers/MmcSdsController.cs | 15 +- .../Controllers/OperatingSystemsController.cs | 3 +- .../Admin/Controllers/PartitionsController.cs | 3 +- .../Admin/Controllers/PcmciasController.cs | 11 +- .../Admin/Controllers/ReportsController.cs | 26 +- .../Admin/Controllers/ScsiModesController.cs | 11 +- .../Admin/Controllers/ScsiPagesController.cs | 11 +- .../Admin/Controllers/ScsisController.cs | 60 +- .../Areas/Admin/Controllers/SscsController.cs | 19 +- .../SupportedDensitiesController.cs | 11 +- .../Controllers/TestedMediasController.cs | 59 +- .../TestedSequentialMediasController.cs | 18 +- .../Controllers/UsbProductsController.cs | 3 +- .../Admin/Controllers/UsbVendorsController.cs | 7 +- .../Areas/Admin/Controllers/UsbsController.cs | 25 +- .../Admin/Controllers/VersionsController.cs | 3 +- .../Admin/Views/Atas/CheckPrivate.cshtml | 3 +- .../Areas/Admin/Views/Atas/Consolidate.cshtml | 6 +- .../Areas/Admin/Views/Atas/Delete.cshtml | 6 +- .../Areas/Admin/Views/Atas/Details.cshtml | 8 +- .../Areas/Admin/Views/Atas/Index.cshtml | 3 +- .../Admin/Views/BlockDescriptors/Index.cshtml | 3 +- .../Areas/Admin/Views/Chs/Consolidate.cshtml | 6 +- .../Areas/Admin/Views/Chs/Index.cshtml | 3 +- .../Areas/Admin/Views/Commands/Index.cshtml | 2 +- .../Views/CompactDiscOffsets/Delete.cshtml | 6 +- .../Views/CompactDiscOffsets/Edit.cshtml | 16 +- .../Views/CompactDiscOffsets/Index.cshtml | 2 +- .../Admin/Views/DeviceStats/Delete.cshtml | 6 +- .../Areas/Admin/Views/DeviceStats/Edit.cshtml | 14 +- .../Admin/Views/DeviceStats/Index.cshtml | 2 +- .../Areas/Admin/Views/Devices/Delete.cshtml | 6 +- .../Areas/Admin/Views/Devices/Details.cshtml | 19 +- .../Areas/Admin/Views/Devices/Edit.cshtml | 18 +- .../Areas/Admin/Views/Devices/Find.cshtml | 4 +- .../Areas/Admin/Views/Devices/Index.cshtml | 2 +- .../Admin/Views/Filesystems/Index.cshtml | 2 +- .../Areas/Admin/Views/Filters/Index.cshtml | 2 +- .../Admin/Views/FireWires/Consolidate.cshtml | 6 +- .../Areas/Admin/Views/FireWires/Delete.cshtml | 6 +- .../Areas/Admin/Views/FireWires/Edit.cshtml | 16 +- .../Areas/Admin/Views/FireWires/Index.cshtml | 3 +- .../GdRomSwapDiscCapabilities/Delete.cshtml | 8 +- .../GdRomSwapDiscCapabilities/Details.cshtml | 4 +- .../Areas/Admin/Views/Home/Index.cshtml | 62 +- .../Admin/Views/MediaFormats/Delete.cshtml | 6 +- .../Admin/Views/MediaFormats/Index.cshtml | 2 +- .../Areas/Admin/Views/Medias/Delete.cshtml | 6 +- .../Areas/Admin/Views/Medias/Index.cshtml | 2 +- .../Areas/Admin/Views/Mmc/Delete.cshtml | 6 +- .../Areas/Admin/Views/Mmc/Details.cshtml | 2 +- .../Areas/Admin/Views/Mmc/Index.cshtml | 2 +- .../Admin/Views/MmcFeatures/Details.cshtml | 2 +- .../Admin/Views/MmcFeatures/Index.cshtml | 3 +- .../Areas/Admin/Views/MmcSds/Delete.cshtml | 6 +- .../Areas/Admin/Views/MmcSds/Details.cshtml | 2 +- .../Areas/Admin/Views/MmcSds/Index.cshtml | 3 +- .../Admin/Views/OperatingSystems/Index.cshtml | 3 +- .../Areas/Admin/Views/Partitions/Index.cshtml | 2 +- .../Areas/Admin/Views/Pcmcias/Delete.cshtml | 6 +- .../Areas/Admin/Views/Pcmcias/Index.cshtml | 3 +- .../Areas/Admin/Views/Reports/Delete.cshtml | 6 +- .../Areas/Admin/Views/Reports/Details.cshtml | 15 +- .../Areas/Admin/Views/Reports/Edit.cshtml | 14 +- .../Areas/Admin/Views/Reports/Index.cshtml | 2 +- .../Areas/Admin/Views/ScsiModes/Delete.cshtml | 6 +- .../Areas/Admin/Views/ScsiModes/Index.cshtml | 3 +- .../Areas/Admin/Views/ScsiPages/Delete.cshtml | 6 +- .../Areas/Admin/Views/ScsiPages/Index.cshtml | 3 +- .../Admin/Views/Scsis/Consolidate.cshtml | 6 +- .../Areas/Admin/Views/Scsis/Delete.cshtml | 6 +- .../Areas/Admin/Views/Scsis/Details.cshtml | 8 +- .../Areas/Admin/Views/Scsis/Index.cshtml | 3 +- .../Areas/Admin/Views/Shared/_Layout.cshtml | 12 +- .../Areas/Admin/Views/Sscs/Consolidate.cshtml | 6 +- .../Areas/Admin/Views/Sscs/Delete.cshtml | 6 +- .../Areas/Admin/Views/Sscs/Index.cshtml | 3 +- .../Views/SupportedDensities/Delete.cshtml | 6 +- .../Views/SupportedDensities/Index.cshtml | 3 +- .../Admin/Views/TestedMedias/Delete.cshtml | 6 +- .../Admin/Views/TestedMedias/Details.cshtml | 2 +- .../Admin/Views/TestedMedias/Edit.cshtml | 18 +- .../Admin/Views/TestedMedias/Index.cshtml | 3 +- .../TestedSequentialMedias/Delete.cshtml | 6 +- .../Views/TestedSequentialMedias/Edit.cshtml | 12 +- .../Views/TestedSequentialMedias/Index.cshtml | 3 +- .../Admin/Views/UsbProducts/Index.cshtml | 2 +- .../Admin/Views/UsbVendors/Details.cshtml | 4 +- .../Areas/Admin/Views/UsbVendors/Index.cshtml | 2 +- .../Areas/Admin/Views/Usbs/Consolidate.cshtml | 6 +- .../Areas/Admin/Views/Usbs/Delete.cshtml | 6 +- .../Areas/Admin/Views/Usbs/Details.cshtml | 2 +- .../Areas/Admin/Views/Usbs/Index.cshtml | 3 +- .../Areas/Admin/Views/Versions/Index.cshtml | 3 +- Aaru.Server/BasicAuthMiddleware.cs | 2 - Aaru.Server/Controllers/ReportController.cs | 52 +- Aaru.Server/Controllers/StatsController.cs | 40 +- Aaru.Server/Controllers/UpdateController.cs | 21 +- .../Controllers/UploadReportController.cs | 20 +- .../Controllers/UploadStatsController.cs | 58 +- Aaru.Server/Core/Ata.cs | 309 ++++++++-- Aaru.Server/Core/Hash.cs | 4 +- Aaru.Server/Core/HtmlHelpers.cs | 12 +- Aaru.Server/Core/ScsiInquiry.cs | 7 +- Aaru.Server/Core/ScsiMmcFeatures.cs | 6 + Aaru.Server/Core/ScsiMmcMode.cs | 19 +- Aaru.Server/Core/ScsiModeSense.cs | 45 +- Aaru.Server/Core/SscTestedMedia.cs | 4 - Aaru.Server/Core/StatsConverter.cs | 78 ++- Aaru.Server/Core/TestedMedia.cs | 79 ++- Aaru.Server/Models/CdOffset.cs | 5 +- Aaru.Server/Models/Context.cs | 2 +- Aaru.Server/Models/Device.cs | 11 +- Aaru.Server/Models/FireWireModel.cs | 10 +- Aaru.Server/Models/Media.cs | 9 +- Aaru.Server/Models/MmcModelForView.cs | 4 +- Aaru.Server/Models/NesHeaderInfo.cs | 16 +- Aaru.Server/Models/UsbProductModel.cs | 8 +- Aaru.Server/Models/UsbVendor.cs | 7 +- Aaru.Server/Models/UsbVendorModel.cs | 7 +- Aaru.Server/Program.cs | 110 ++-- Aaru.Server/Properties/launchSettings.json | 18 +- Aaru.Server/Seeder.cs | 10 +- Aaru.Server/Views/Report/View.cshtml | 536 +++++++++--------- .../Views/Shared/_CookieConsentPartial.cshtml | 6 +- Aaru.Server/Views/Shared/_Layout.cshtml | 4 +- Aaru.Server/Views/Stats/Index.cshtml | 6 +- Aaru.Server/appsettings.Development.json | 10 +- Aaru.Server/appsettings.json | 6 +- Aaru.Server/docs/CONTRIBUTING.md | 3 +- Aaru.Server/docs/ISSUE_TEMPLATE.md | 18 +- Aaru.Server/docs/NEEDED.md | 112 ++-- Aaru.Server/package.json | 16 +- Aaru.Server/wwwroot | 2 +- 156 files changed, 1730 insertions(+), 1282 deletions(-) create mode 100644 .idea/.idea.Aaru.Server/.idea/discord.xml create mode 100644 .idea/.idea.Aaru.Server/.idea/riderMarkupCache.xml diff --git a/.idea/.idea.Aaru.Server/.idea/discord.xml b/.idea/.idea.Aaru.Server/.idea/discord.xml new file mode 100644 index 00000000..d8e95616 --- /dev/null +++ b/.idea/.idea.Aaru.Server/.idea/discord.xml @@ -0,0 +1,7 @@ + + + + + \ No newline at end of file diff --git a/.idea/.idea.Aaru.Server/.idea/riderMarkupCache.xml b/.idea/.idea.Aaru.Server/.idea/riderMarkupCache.xml new file mode 100644 index 00000000..3a174183 --- /dev/null +++ b/.idea/.idea.Aaru.Server/.idea/riderMarkupCache.xml @@ -0,0 +1,6 @@ + + + + + \ No newline at end of file diff --git a/.idea/.idea.Aaru.Server/.idea/runConfigurations/Server_task.xml b/.idea/.idea.Aaru.Server/.idea/runConfigurations/Server_task.xml index cd8c4146..131ca4fb 100644 --- a/.idea/.idea.Aaru.Server/.idea/runConfigurations/Server_task.xml +++ b/.idea/.idea.Aaru.Server/.idea/runConfigurations/Server_task.xml @@ -1,8 +1,8 @@ -