aaru-dps/Aaru
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2025-12-16 19:24:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Refactor] Use static lambdas in LINQ queries for improved performance

Browse Source
This commit is contained in:
Natalia Portillo
2025-11-24 03:00:06 +00:00
parent 5fe7f574d6
commit 04c45e69fa
126 changed files with 971 additions and 929 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Aaru.Decoders/CD/FullTOC.cs
View File

@@ -86,7 +86,7 @@ public static class FullTOC
return null;
}
for(int i = 0; i < (decoded.DataLength - 2) / 11; i++)
for(var i = 0; i < (decoded.DataLength - 2) / 11; i++)
{
decoded.TrackDescriptors[i].SessionNumber = CDFullTOCResponse[0 + i * 11 + 4];
decoded.TrackDescriptors[i].ADR = (byte)((CDFullTOCResponse[1 + i * 11 + 4] & 0xF0) >> 4);
@@ -115,7 +115,7 @@ public static class FullTOC
var sb = new StringBuilder();
int lastSession = 0;
var lastSession = 0;
sb.AppendFormat(Localization.First_complete_session_number_0, response.FirstCompleteSession).AppendLine();
sb.AppendFormat(Localization.Last_complete_session_number_0, response.LastCompleteSession).AppendLine();
@@ -641,7 +641,7 @@ public static class FullTOC
case 6:
{
uint id = (uint)((descriptor.Min << 16) + (descriptor.Sec << 8) + descriptor.Frame);
var id = (uint)((descriptor.Min << 16) + (descriptor.Sec << 8) + descriptor.Frame);
sb.AppendFormat(Localization.Disc_ID_0_X6, id & 0x00FFFFFF).AppendLine();
break;
@@ -669,7 +669,7 @@ public static class FullTOC
List<TrackDataDescriptor> trackDescriptors = [];
byte currentTrack = 0;
foreach(Track track in tracks.OrderBy(t => t.Session).ThenBy(t => t.Sequence))
foreach(Track track in tracks.OrderBy(static t => t.Session).ThenBy(static t => t.Sequence))
{
if(track.Session < toc.FirstCompleteSession) toc.FirstCompleteSession = (byte)track.Session;
@@ -686,11 +686,12 @@ public static class FullTOC
}
sessionEndingTrack.TryAdd(toc.LastCompleteSession,
(byte)tracks.Where(t => t.Session == toc.LastCompleteSession).Max(t => t.Sequence));
(byte)tracks.Where(t => t.Session == toc.LastCompleteSession)
.Max(static t => t.Sequence));
byte currentSession = 0;
foreach(Track track in tracks.OrderBy(t => t.Session).ThenBy(t => t.Sequence))
foreach(Track track in tracks.OrderBy(static t => t.Session).ThenBy(static t => t.Sequence))
{
trackFlags.TryGetValue((byte)track.Sequence, out byte trackControl);
@@ -702,7 +703,7 @@ public static class FullTOC
(byte minute, byte second, byte frame) leadoutAmsf = LbaToMsf(track.StartSector - 150);
(byte minute, byte second, byte frame) leadoutPmsf =
LbaToMsf(tracks.OrderBy(t => t.Session).ThenBy(t => t.Sequence).Last().StartSector);
LbaToMsf(tracks.OrderBy(static t => t.Session).ThenBy(static t => t.Sequence).Last().StartSector);
// Lead-out
trackDescriptors.Add(new TrackDataDescriptor

2
Aaru.Decoders/PCMCIA/CIS.cs
View File

@@ -290,7 +290,7 @@ public static class CIS
{
sb.AppendLine("\t" + Localization.Additional_information);
foreach(string info in tuple.AdditionalInformation.Where(info => !string.IsNullOrEmpty(info)))
foreach(string info in tuple.AdditionalInformation.Where(static info => !string.IsNullOrEmpty(info)))
sb.Append($"\t\t{info}").AppendLine();
}

4
Aaru.Decoders/SCSI/Modes/2A.cs
View File

@@ -149,9 +149,11 @@ public static partial class Modes
}
if(modePage.BufferSize > 0)
{
sb.AppendFormat($"\t[slateblue1]{Localization.Drive_has_0_Kbyte_of_buffer}[/]",
$"[aqua]{modePage.BufferSize}[/]")
.AppendLine();
}
if(modePage.MaximumSpeed > 0)
{
@@ -251,7 +253,7 @@ public static partial class Modes
if(modePage.WriteSpeedPerformanceDescriptors != null)
{
foreach(ModePage_2A_WriteDescriptor descriptor in
modePage.WriteSpeedPerformanceDescriptors.Where(descriptor => descriptor.WriteSpeed > 0))
modePage.WriteSpeedPerformanceDescriptors.Where(static descriptor => descriptor.WriteSpeed > 0))
{
switch(descriptor.RotationControl)
{

2
Aaru.Decoders/SCSI/Modes/Mode10.cs
View File

@@ -336,7 +336,7 @@ public static partial class Modes
{
var modeSize = 0;
if(mode.Pages != null) modeSize += mode.Pages.Sum(page => page.PageResponse.Length);
if(mode.Pages != null) modeSize += mode.Pages.Sum(static page => page.PageResponse.Length);
byte[] hdr = EncodeModeHeader10(mode.Header, deviceType);
modeSize += hdr.Length;

2
Aaru.Decoders/SCSI/Modes/Mode6.cs
View File

@@ -238,7 +238,7 @@ public static partial class Modes
{
var modeSize = 0;
if(mode.Pages != null) modeSize += mode.Pages.Sum(page => page.PageResponse.Length);
if(mode.Pages != null) modeSize += mode.Pages.Sum(static page => page.PageResponse.Length);
byte[] hdr = EncodeModeHeader6(mode.Header, deviceType);
modeSize += hdr.Length;