diff --git a/BitEndian.cs b/BitEndian.cs index 73c3869ce..96a35d563 100644 --- a/BitEndian.cs +++ b/BitEndian.cs @@ -42,7 +42,8 @@ namespace Aaru.Helpers public enum BitEndian { /// Little-endian, or least significant bit - Little, /// Big-endian, or most significant bit + Little, + /// Big-endian, or most significant bit Big, /// PDP-11 endian, little endian except for 32-bit integers where the 16 halves are swapped between them Pdp diff --git a/CHS.cs b/CHS.cs index a7e411159..f02554873 100644 --- a/CHS.cs +++ b/CHS.cs @@ -42,7 +42,7 @@ namespace Aaru.Helpers /// Number of sectors per track /// public static uint ToLBA(uint cyl, uint head, uint sector, uint maxHead, uint maxSector) => - maxHead == 0 || maxSector == 0 ? (cyl * 16 + head) * 63 + sector - 1 - : (cyl * maxHead + head) * maxSector + sector - 1; + maxHead == 0 || maxSector == 0 ? ((((cyl * 16) + head) * 63) + sector) - 1 + : ((((cyl * maxHead) + head) * maxSector) + sector) - 1; } } \ No newline at end of file diff --git a/CountBits.cs b/CountBits.cs index 80f64b560..60704df73 100644 --- a/CountBits.cs +++ b/CountBits.cs @@ -42,7 +42,7 @@ namespace Aaru.Helpers number = number - ((number >> 1) & 0x55555555); number = (number & 0x33333333) + ((number >> 2) & 0x33333333); - return(int)((((number + (number >> 4)) & 0x0F0F0F0F) * 0x01010101) >> 24); + return (int)((((number + (number >> 4)) & 0x0F0F0F0F) * 0x01010101) >> 24); } } } \ No newline at end of file diff --git a/DateHandlers.cs b/DateHandlers.cs index afed05c88..0b227c8a1 100644 --- a/DateHandlers.cs +++ b/DateHandlers.cs @@ -108,7 +108,7 @@ namespace Aaru fourcharvalue[3] = vdDateTime[3]; AaruConsole.DebugWriteLine("ISO9600ToDateTime handler", "year = \"{0}\"", - StringHandlers.CToString(fourcharvalue, Encoding.ASCII)); + StringHandlers.CToString(fourcharvalue, Encoding.ASCII)); if(!int.TryParse(StringHandlers.CToString(fourcharvalue, Encoding.ASCII), out int year)) year = 0; @@ -117,7 +117,7 @@ namespace Aaru twocharvalue[1] = vdDateTime[5]; AaruConsole.DebugWriteLine("ISO9600ToDateTime handler", "month = \"{0}\"", - StringHandlers.CToString(twocharvalue, Encoding.ASCII)); + StringHandlers.CToString(twocharvalue, Encoding.ASCII)); if(!int.TryParse(StringHandlers.CToString(twocharvalue, Encoding.ASCII), out int month)) month = 0; @@ -126,7 +126,7 @@ namespace Aaru twocharvalue[1] = vdDateTime[7]; AaruConsole.DebugWriteLine("ISO9600ToDateTime handler", "day = \"{0}\"", - StringHandlers.CToString(twocharvalue, Encoding.ASCII)); + StringHandlers.CToString(twocharvalue, Encoding.ASCII)); if(!int.TryParse(StringHandlers.CToString(twocharvalue, Encoding.ASCII), out int day)) day = 0; @@ -135,7 +135,7 @@ namespace Aaru twocharvalue[1] = vdDateTime[9]; AaruConsole.DebugWriteLine("ISO9600ToDateTime handler", "hour = \"{0}\"", - StringHandlers.CToString(twocharvalue, Encoding.ASCII)); + StringHandlers.CToString(twocharvalue, Encoding.ASCII)); if(!int.TryParse(StringHandlers.CToString(twocharvalue, Encoding.ASCII), out int hour)) hour = 0; @@ -144,7 +144,7 @@ namespace Aaru twocharvalue[1] = vdDateTime[11]; AaruConsole.DebugWriteLine("ISO9600ToDateTime handler", "minute = \"{0}\"", - StringHandlers.CToString(twocharvalue, Encoding.ASCII)); + StringHandlers.CToString(twocharvalue, Encoding.ASCII)); if(!int.TryParse(StringHandlers.CToString(twocharvalue, Encoding.ASCII), out int minute)) minute = 0; @@ -153,7 +153,7 @@ namespace Aaru twocharvalue[1] = vdDateTime[13]; AaruConsole.DebugWriteLine("ISO9600ToDateTime handler", "second = \"{0}\"", - StringHandlers.CToString(twocharvalue, Encoding.ASCII)); + StringHandlers.CToString(twocharvalue, Encoding.ASCII)); if(!int.TryParse(StringHandlers.CToString(twocharvalue, Encoding.ASCII), out int second)) second = 0; @@ -162,14 +162,14 @@ namespace Aaru twocharvalue[1] = vdDateTime[15]; AaruConsole.DebugWriteLine("ISO9600ToDateTime handler", "hundredths = \"{0}\"", - StringHandlers.CToString(twocharvalue, Encoding.ASCII)); + StringHandlers.CToString(twocharvalue, Encoding.ASCII)); if(!int.TryParse(StringHandlers.CToString(twocharvalue, Encoding.ASCII), out int hundredths)) hundredths = 0; AaruConsole.DebugWriteLine("ISO9600ToDateTime handler", - "decodedDT = new DateTime({0}, {1}, {2}, {3}, {4}, {5}, {6}, DateTimeKind.Unspecified);", - year, month, day, hour, minute, second, hundredths * 10); + "decodedDT = new DateTime({0}, {1}, {2}, {3}, {4}, {5}, {6}, DateTimeKind.Unspecified);", + year, month, day, hour, minute, second, hundredths * 10); var decodedDt = new DateTime(year, month, day, hour, minute, second, hundredths * 10, DateTimeKind.Unspecified); @@ -211,8 +211,8 @@ namespace Aaru int month = dateRecord & 0x000F; AaruConsole.DebugWriteLine("UCSDPascalToDateTime handler", - "dateRecord = 0x{0:X4}, year = {1}, month = {2}, day = {3}", dateRecord, year, - month, day); + "dateRecord = 0x{0:X4}, year = {1}, month = {2}, day = {3}", dateRecord, year, + month, day); return new DateTime(year, month, day); } @@ -231,11 +231,11 @@ namespace Aaru int second = (time & 0x1F) * 2; AaruConsole.DebugWriteLine("DOSToDateTime handler", "date = 0x{0:X4}, year = {1}, month = {2}, day = {3}", - date, year, month, day); + date, year, month, day); AaruConsole.DebugWriteLine("DOSToDateTime handler", - "time = 0x{0:X4}, hour = {1}, minute = {2}, second = {3}", time, hour, minute, - second); + "time = 0x{0:X4}, hour = {1}, minute = {2}, second = {3}", time, hour, minute, + second); DateTime dosdate; @@ -285,8 +285,8 @@ namespace Aaru { byte specification = (byte)((typeAndTimeZone & 0xF000) >> 12); - long ticks = (long)centiseconds * 100000 + (long)hundredsOfMicroseconds * 1000 + - (long)microseconds * 10; + long ticks = ((long)centiseconds * 100000) + ((long)hundredsOfMicroseconds * 1000) + + ((long)microseconds * 10); if(specification == 0) return new DateTime(year, month, day, hour, minute, second, DateTimeKind.Utc).AddTicks(ticks); @@ -321,7 +321,7 @@ namespace Aaru public static DateTime Os9ToDateTime(byte[] date) { if(date == null || - date.Length != 3 && date.Length != 5) + (date.Length != 3 && date.Length != 5)) return DateTime.MinValue; DateTime os9Date; @@ -363,12 +363,12 @@ namespace Aaru { try { - int iyear = (year >> 4) * 10 + (year & 0xF); - int imonth = (month >> 4) * 10 + (month & 0xF); - int iday = (day >> 4) * 10 + (day & 0xF); - int iminute = (minute >> 4) * 10 + (minute & 0xF); - int ihour = (hour >> 4) * 10 + (hour & 0xF); - int isecond = (second >> 4) * 10 + (second & 0xF); + int iyear = ((year >> 4) * 10) + (year & 0xF); + int imonth = ((month >> 4) * 10) + (month & 0xF); + int iday = ((day >> 4) * 10) + (day & 0xF); + int iminute = ((minute >> 4) * 10) + (minute & 0xF); + int ihour = ((hour >> 4) * 10) + (hour & 0xF); + int isecond = ((second >> 4) * 10) + (second & 0xF); if(iyear >= 70) iyear += 1900; diff --git a/Marshal.cs b/Marshal.cs index 9da983d82..58b449779 100644 --- a/Marshal.cs +++ b/Marshal.cs @@ -89,7 +89,7 @@ namespace Aaru.Helpers ptr.Free(); - return(T)SwapStructureMembersEndian(str); + return (T)SwapStructureMembersEndian(str); } /// Marshal big-endian binary data to a structure @@ -121,7 +121,7 @@ namespace Aaru.Helpers ptr.Free(); - return(T)SwapStructureMembersEndianPdp(str); + return (T)SwapStructureMembersEndianPdp(str); } } @@ -175,7 +175,7 @@ namespace Aaru.Helpers { T str = SpanToStructureLittleEndian(bytes); - return(T)SwapStructureMembersEndian(str); + return (T)SwapStructureMembersEndian(str); } /// @@ -192,7 +192,7 @@ namespace Aaru.Helpers { T str = SpanToStructureLittleEndian(bytes.Slice(start, length)); - return(T)SwapStructureMembersEndian(str); + return (T)SwapStructureMembersEndian(str); } /// @@ -207,7 +207,7 @@ namespace Aaru.Helpers { object str = SpanToStructureLittleEndian(bytes); - return(T)SwapStructureMembersEndianPdp(str); + return (T)SwapStructureMembersEndianPdp(str); } /// @@ -222,7 +222,7 @@ namespace Aaru.Helpers { object str = SpanToStructureLittleEndian(bytes.Slice(start, length)); - return(T)SwapStructureMembersEndianPdp(str); + return (T)SwapStructureMembersEndianPdp(str); } /// diff --git a/StringHandlers.cs b/StringHandlers.cs index 6f7bc75a1..59e0a2567 100644 --- a/StringHandlers.cs +++ b/StringHandlers.cs @@ -136,7 +136,7 @@ namespace Aaru for(int i = SpacePaddedString.Length; i >= start; i--) { if(i == start) - return""; + return ""; if(SpacePaddedString[i - 1] == 0x20) continue; diff --git a/Swapping.cs b/Swapping.cs index 8ba7cf6b9..d59117667 100644 --- a/Swapping.cs +++ b/Swapping.cs @@ -53,7 +53,7 @@ namespace Aaru { x = ((x << 8) & 0xFF00FF00) | ((x >> 8) & 0xFF00FF); - return(x << 16) | (x >> 16); + return (x << 16) | (x >> 16); } [MethodImpl(MethodImplOptions.AggressiveInlining)] @@ -61,7 +61,7 @@ namespace Aaru { x = (int)(((x << 8) & 0xFF00FF00) | (((uint)x >> 8) & 0xFF00FF)); - return(int)(((uint)x << 16) | (((uint)x >> 16) & 0xFFFF)); + return (int)(((uint)x << 16) | (((uint)x >> 16) & 0xFFFF)); } [MethodImpl(MethodImplOptions.AggressiveInlining)]