From 238062c7b04cd060d787c945d3a5ebc7c273af18 Mon Sep 17 00:00:00 2001 From: Natalia Portillo Date: Sat, 25 Oct 2025 13:00:36 +0100 Subject: [PATCH] [GUI] Some private fields should not be observable properties. --- Aaru.Gui/ViewModels/Windows/ImageChecksumViewModel.cs | 1 - Aaru.Gui/ViewModels/Windows/ImageConvertViewModel.cs | 5 +---- Aaru.Gui/ViewModels/Windows/ImageEntropyViewModel.cs | 2 -- Aaru.Gui/ViewModels/Windows/ImageSidecarViewModel.cs | 1 - Aaru.Gui/ViewModels/Windows/ImageVerifyViewModel.cs | 3 +-- Aaru.Gui/ViewModels/Windows/MediaDumpViewModel.cs | 5 +---- Aaru.Gui/ViewModels/Windows/MediaScanViewModel.cs | 4 ---- 7 files changed, 3 insertions(+), 18 deletions(-) diff --git a/Aaru.Gui/ViewModels/Windows/ImageChecksumViewModel.cs b/Aaru.Gui/ViewModels/Windows/ImageChecksumViewModel.cs index b36133e4d..d66332b85 100644 --- a/Aaru.Gui/ViewModels/Windows/ImageChecksumViewModel.cs +++ b/Aaru.Gui/ViewModels/Windows/ImageChecksumViewModel.cs @@ -59,7 +59,6 @@ public sealed partial class ImageChecksumViewModel : ViewModelBase readonly Window _view; [ObservableProperty] bool _adler32Checked; - [ObservableProperty] bool _cancel; [ObservableProperty] bool _checksumMediaChecked; diff --git a/Aaru.Gui/ViewModels/Windows/ImageConvertViewModel.cs b/Aaru.Gui/ViewModels/Windows/ImageConvertViewModel.cs index 2347a679e..0f64fc40a 100644 --- a/Aaru.Gui/ViewModels/Windows/ImageConvertViewModel.cs +++ b/Aaru.Gui/ViewModels/Windows/ImageConvertViewModel.cs @@ -71,11 +71,9 @@ public sealed partial class ImageConvertViewModel : ViewModelBase { readonly IMediaImage _inputFormat; readonly Window _view; - [ObservableProperty] - Metadata _aaruMetadata; + Metadata _aaruMetadata; [ObservableProperty] bool _aaruMetadataFromImageVisible; - [ObservableProperty] bool _cancel; [ObservableProperty] bool _closeVisible; @@ -109,7 +107,6 @@ public sealed partial class ImageConvertViewModel : ViewModelBase string _driveSerialNumberText; [ObservableProperty] bool _driveSerialNumberVisible; - [ObservableProperty] List _dumpHardware; [ObservableProperty] bool _forceChecked; diff --git a/Aaru.Gui/ViewModels/Windows/ImageEntropyViewModel.cs b/Aaru.Gui/ViewModels/Windows/ImageEntropyViewModel.cs index ab4b7dfb7..0069e564b 100644 --- a/Aaru.Gui/ViewModels/Windows/ImageEntropyViewModel.cs +++ b/Aaru.Gui/ViewModels/Windows/ImageEntropyViewModel.cs @@ -58,7 +58,6 @@ public sealed partial class ImageEntropyViewModel : ViewModelBase bool _duplicatedSectorsChecked; [ObservableProperty] bool _duplicatedSectorsEnabled; - [ObservableProperty] EntropyResults _entropy; [ObservableProperty] string _mediaEntropyText; @@ -104,7 +103,6 @@ public sealed partial class ImageEntropyViewModel : ViewModelBase bool _startVisible; [ObservableProperty] bool _stopVisible; - [ObservableProperty] EntropyResults[] _tracksEntropy; [ObservableProperty] bool _wholeDiscChecked; diff --git a/Aaru.Gui/ViewModels/Windows/ImageSidecarViewModel.cs b/Aaru.Gui/ViewModels/Windows/ImageSidecarViewModel.cs index 4e75e8474..00015b65b 100644 --- a/Aaru.Gui/ViewModels/Windows/ImageSidecarViewModel.cs +++ b/Aaru.Gui/ViewModels/Windows/ImageSidecarViewModel.cs @@ -87,7 +87,6 @@ public sealed partial class ImageSidecarViewModel : ViewModelBase double _progressValue; [ObservableProperty] bool _progressVisible; - [ObservableProperty] Sidecar _sidecarClass; [ObservableProperty] bool _startVisible; diff --git a/Aaru.Gui/ViewModels/Windows/ImageVerifyViewModel.cs b/Aaru.Gui/ViewModels/Windows/ImageVerifyViewModel.cs index b987f6c01..a05b33bd4 100644 --- a/Aaru.Gui/ViewModels/Windows/ImageVerifyViewModel.cs +++ b/Aaru.Gui/ViewModels/Windows/ImageVerifyViewModel.cs @@ -57,8 +57,7 @@ public sealed partial class ImageVerifyViewModel : ViewModelBase { readonly IMediaImage _inputFormat; readonly Window _view; - [ObservableProperty] - bool _cancel; + bool _cancel; [ObservableProperty] bool _closeVisible; [ObservableProperty] diff --git a/Aaru.Gui/ViewModels/Windows/MediaDumpViewModel.cs b/Aaru.Gui/ViewModels/Windows/MediaDumpViewModel.cs index d452ac9f9..e9330cdb2 100644 --- a/Aaru.Gui/ViewModels/Windows/MediaDumpViewModel.cs +++ b/Aaru.Gui/ViewModels/Windows/MediaDumpViewModel.cs @@ -81,10 +81,8 @@ public sealed partial class MediaDumpViewModel : ViewModelBase string _destination; [ObservableProperty] bool _destinationEnabled; - [ObservableProperty] Device _dev; - [ObservableProperty] - Dump _dumper; + Dump _dumper; [ObservableProperty] string _encodingEnabled; [ObservableProperty] @@ -98,7 +96,6 @@ public sealed partial class MediaDumpViewModel : ViewModelBase string _log; [ObservableProperty] bool _optionsVisible; - [ObservableProperty] string _outputPrefix; [ObservableProperty] bool _persistent; diff --git a/Aaru.Gui/ViewModels/Windows/MediaScanViewModel.cs b/Aaru.Gui/ViewModels/Windows/MediaScanViewModel.cs index 1161da62e..402702600 100644 --- a/Aaru.Gui/ViewModels/Windows/MediaScanViewModel.cs +++ b/Aaru.Gui/ViewModels/Windows/MediaScanViewModel.cs @@ -68,7 +68,6 @@ public sealed partial class MediaScanViewModel : ViewModelBase string _b; [ObservableProperty] ulong _blocks; - [ObservableProperty] ulong _blocksToRead; [ObservableProperty] string _c; @@ -76,7 +75,6 @@ public sealed partial class MediaScanViewModel : ViewModelBase bool _closeVisible; [ObservableProperty] string _d; - [ObservableProperty] string _devicePath; [ObservableProperty] string _e; @@ -84,7 +82,6 @@ public sealed partial class MediaScanViewModel : ViewModelBase string _f; [ObservableProperty] Color _lineColor; - [ObservableProperty] ScanResults _localResults; [ObservableProperty] string _maxSpeed; @@ -122,7 +119,6 @@ public sealed partial class MediaScanViewModel : ViewModelBase bool _progressVisible; [ObservableProperty] bool _resultsVisible; - [ObservableProperty] MediaScan _scanner; [ObservableProperty] bool _startVisible;