Move image and sector verification methods to new interfaces.

DiscImageChef.CommonTypes.csproj

@@ -74,6 +74,8 @@
     <Compile Include="Interfaces\IPartitionableMediaImage.cs" />
     <Compile Include="Interfaces\IPluginRegister.cs" />
     <Compile Include="Interfaces\IReadOnlyFilesystem.cs" />
+    <Compile Include="Interfaces\IVerifiableImage.cs" />
+    <Compile Include="Interfaces\IVerifiableSectorsImage.cs" />
     <Compile Include="Interfaces\IWritableFloppyImage.cs" />
     <Compile Include="Interfaces\IWritableImage.cs" />
     <Compile Include="Interfaces\IWritableOpticalImage.cs" />

Interfaces/IMediaImage.cs

@@ -135,28 +135,5 @@ namespace DiscImageChef.CommonTypes.Interfaces
         /// <param name="sectorAddress">Starting sector address (LBA).</param>
         /// <param name="length">How many sectors to read.</param>
         byte[] ReadSectorsLong(ulong sectorAddress, uint length);
-
-        /// <summary>
-        ///     Verifies a sector.
-        /// </summary>
-        /// <returns>True if correct, false if incorrect, null if uncheckable.</returns>
-        /// <param name="sectorAddress">Sector address (LBA).</param>
-        bool? VerifySector(ulong sectorAddress);
-
-        /// <summary>
-        ///     Verifies several sectors.
-        /// </summary>
-        /// <returns>True if all are correct, false if any is incorrect, null if any is uncheckable.</returns>
-        /// <param name="sectorAddress">Starting sector address (LBA).</param>
-        /// <param name="length">How many sectors to read.</param>
-        /// <param name="failingLbas">List of incorrect sectors</param>
-        /// <param name="unknownLbas">List of uncheckable sectors</param>
-        bool? VerifySectors(ulong sectorAddress, uint length, out List<ulong> failingLbas, out List<ulong> unknownLbas);
-
-        /// <summary>
-        ///     Verifies media image internal checksum.
-        /// </summary>
-        /// <returns>True if correct, false if incorrect, null if there is no internal checksum available</returns>
-        bool? VerifyMediaImage();
     }
 }

Interfaces/IOpticalMediaImage.cs

@@ -45,7 +45,7 @@ namespace DiscImageChef.CommonTypes.Interfaces
     /// <summary>
     ///     Abstract class to implement disk image reading plugins.
     /// </summary>
-    public interface IOpticalMediaImage : IMediaImage, IPartitionableMediaImage
+    public interface IOpticalMediaImage : IMediaImage, IPartitionableMediaImage, IVerifiableSectorsImage
     {
         /// <summary>
         ///     Gets the disc track extents (start, length).

Interfaces/IVerifiableImage.cs

@@ -0,0 +1,50 @@
+// /***************************************************************************
+// The Disc Image Chef
+// ----------------------------------------------------------------------------
+//
+// Filename       : IVerifiableImage.cs
+// Author(s)      : Natalia Portillo <claunia@claunia.com>
+//
+// Component      : Disc image plugins.
+//
+// --[ Description ] ----------------------------------------------------------
+//
+//     Defines interface to be implemented by image plugins that can verify the
+//     image itself.
+//
+// --[ License ] --------------------------------------------------------------
+//
+//     Permission is hereby granted, free of charge, to any person obtaining a
+//     copy of this software and associated documentation files (the
+//     "Software"), to deal in the Software without restriction, including
+//     without limitation the rights to use, copy, modify, merge, publish,
+//     distribute, sublicense, and/or sell copies of the Software, and to
+//     permit persons to whom the Software is furnished to do so, subject to
+//     the following conditions:
+//
+//     The above copyright notice and this permission notice shall be included
+//     in all copies or substantial portions of the Software.
+//
+//     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+//     OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+//     MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+//     IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+//     CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+//     TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+//     SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+//
+// ----------------------------------------------------------------------------
+// Copyright © 2011-2019 Natalia Portillo
+// ****************************************************************************/
+
+namespace DiscImageChef.CommonTypes.Interfaces
+{
+    public interface IVerifiableImage
+    {
+        /// <summary>
+        ///     Verifies media image internal checksum.
+        /// </summary>
+        /// <returns>True if correct, false if incorrect, null if there is no internal checksum available</returns>
+        bool? VerifyMediaImage();
+    }
+}

Interfaces/IVerifiableSectorsImage.cs

@@ -0,0 +1,63 @@
+// /***************************************************************************
+// The Disc Image Chef
+// ----------------------------------------------------------------------------
+//
+// Filename       : IVerifiableSectorsImage.cs
+// Author(s)      : Natalia Portillo <claunia@claunia.com>
+//
+// Component      : Disc image plugins.
+//
+// --[ Description ] ----------------------------------------------------------
+//
+//     Defines interface to be implemented by image plugins that can verify the
+//     sectors contained in the image.
+//
+// --[ License ] --------------------------------------------------------------
+//
+//     Permission is hereby granted, free of charge, to any person obtaining a
+//     copy of this software and associated documentation files (the
+//     "Software"), to deal in the Software without restriction, including
+//     without limitation the rights to use, copy, modify, merge, publish,
+//     distribute, sublicense, and/or sell copies of the Software, and to
+//     permit persons to whom the Software is furnished to do so, subject to
+//     the following conditions:
+//
+//     The above copyright notice and this permission notice shall be included
+//     in all copies or substantial portions of the Software.
+//
+//     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+//     OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+//     MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+//     IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+//     CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+//     TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+//     SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+//
+// ----------------------------------------------------------------------------
+// Copyright © 2011-2019 Natalia Portillo
+// ****************************************************************************/
+
+using System.Collections.Generic;
+
+namespace DiscImageChef.CommonTypes.Interfaces
+{
+    public interface IVerifiableSectorsImage
+    {
+        /// <summary>
+        ///     Verifies a sector.
+        /// </summary>
+        /// <returns>True if correct, false if incorrect, null if uncheckable.</returns>
+        /// <param name="sectorAddress">Sector address (LBA).</param>
+        bool? VerifySector(ulong sectorAddress);
+
+        /// <summary>
+        ///     Verifies several sectors.
+        /// </summary>
+        /// <returns>True if all are correct, false if any is incorrect, null if any is uncheckable.</returns>
+        /// <param name="sectorAddress">Starting sector address (LBA).</param>
+        /// <param name="length">How many sectors to read.</param>
+        /// <param name="failingLbas">List of incorrect sectors</param>
+        /// <param name="unknownLbas">List of uncheckable sectors</param>
+        bool? VerifySectors(ulong sectorAddress, uint length, out List<ulong> failingLbas, out List<ulong> unknownLbas);
+    }
+}