aaru-dps/Aaru
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2025-12-16 19:24:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unused variables.

Browse Source
This commit is contained in:
Natalia Portillo
2022-03-16 00:31:33 +00:00
parent d4b1e63e96
commit 5f14f0e79c
15 changed files with 45 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Aaru.Checksums

Submodule Aaru.Checksums updated: 19c7f3d4ff...4b209cb4c7

2
Aaru.Core/Devices/Report/GdRomSwapTrick.cs
View File

@@ -1563,7 +1563,7 @@ public sealed partial class DeviceReport
subchannel = MmcSubchannel.Q16;
}
Console.CancelKeyPress += (sender, e) =>
Console.CancelKeyPress += (_, e) =>
{
e.Cancel = true;
aborted = true;

1
Aaru.Filesystems/FAT/BPB.cs
View File

@@ -52,7 +52,6 @@ public sealed partial class FAT
minBootNearJump = 0;
andosOemCorrect = false;
bootable = false;
ErrorNumber errno;
humanBpb = Marshal.ByteArrayToStructureBigEndian<HumanParameterBlock>(bpbSector);
atariBpb = Marshal.ByteArrayToStructureLittleEndian<AtariParameterBlock>(bpbSector);

16
Aaru.Filesystems/ISO9660/Dir.cs
View File

@@ -842,6 +842,13 @@ public sealed partial class ISO9660
ErrorNumber errno = ReadSector(cl.child_dir_lba, out byte[] childSector);
if(errno != ErrorNumber.NoError)
{
systemAreaOff = end;
break;
}
DirectoryRecord childRecord =
Marshal.ByteArrayToStructureLittleEndian<DirectoryRecord>(childSector);
@@ -1053,6 +1060,9 @@ public sealed partial class ISO9660
{
ErrorNumber errno = ReadSector(tEntry.Extent, out byte[] sector);
if(errno != ErrorNumber.NoError)
continue;
CdiDirectoryRecord record =
Marshal.ByteArrayToStructureBigEndian<CdiDirectoryRecord>(sector, tEntry.XattrLength,
_cdiDirectoryRecordSize);
@@ -1103,6 +1113,9 @@ public sealed partial class ISO9660
{
ErrorNumber errno = ReadSector(tEntry.Extent, out byte[] sector);
if(errno != ErrorNumber.NoError)
continue;
DirectoryRecord record =
Marshal.ByteArrayToStructureLittleEndian<DirectoryRecord>(sector, tEntry.XattrLength,
_directoryRecordSize);
@@ -1153,6 +1166,9 @@ public sealed partial class ISO9660
{
ErrorNumber errno = ReadSector(tEntry.Extent, out byte[] sector);
if(errno != ErrorNumber.NoError)
continue;
HighSierraDirectoryRecord record =
Marshal.ByteArrayToStructureLittleEndian<HighSierraDirectoryRecord>(sector, tEntry.XattrLength,
_highSierraDirectoryRecordSize);

14
Aaru.Gui/ViewModels/Panels/ImageInfoViewModel.cs
View File

@@ -735,7 +735,7 @@ public sealed class ImageInfoViewModel : ViewModelBase
_imageEntropy = new ImageEntropy();
_imageEntropy.DataContext = new ImageEntropyViewModel(_imageFormat, _imageEntropy);
_imageEntropy.Closed += (sender, args) => _imageEntropy = null;
_imageEntropy.Closed += (_, _) => _imageEntropy = null;
_imageEntropy.Show();
}
@@ -752,7 +752,7 @@ public sealed class ImageInfoViewModel : ViewModelBase
_imageVerify = new ImageVerify();
_imageVerify.DataContext = new ImageVerifyViewModel(_imageFormat, _imageVerify);
_imageVerify.Closed += (sender, args) => _imageVerify = null;
_imageVerify.Closed += (_, _) => _imageVerify = null;
_imageVerify.Show();
}
@@ -769,7 +769,7 @@ public sealed class ImageInfoViewModel : ViewModelBase
_imageChecksum = new ImageChecksum();
_imageChecksum.DataContext = new ImageChecksumViewModel(_imageFormat, _imageChecksum);
_imageChecksum.Closed += (sender, args) => _imageChecksum = null;
_imageChecksum.Closed += (_, _) => _imageChecksum = null;
_imageChecksum.Show();
}
@@ -786,7 +786,7 @@ public sealed class ImageInfoViewModel : ViewModelBase
_imageConvert = new ImageConvert();
_imageConvert.DataContext = new ImageConvertViewModel(_imageFormat, _imagePath, _imageConvert);
_imageConvert.Closed += (sender, args) => _imageConvert = null;
_imageConvert.Closed += (_, _) => _imageConvert = null;
_imageConvert.Show();
}
@@ -806,7 +806,7 @@ public sealed class ImageInfoViewModel : ViewModelBase
_imageSidecar.DataContext =
new ImageSidecarViewModel(_imageFormat, _imagePath, _filter.Id, null, _imageSidecar);
_imageSidecar.Closed += (sender, args) => _imageSidecar = null;
_imageSidecar.Closed += (_, _) => _imageSidecar = null;
_imageSidecar.Show();
}
@@ -825,7 +825,7 @@ public sealed class ImageInfoViewModel : ViewModelBase
DataContext = new ViewSectorViewModel(_imageFormat)
};
_viewSector.Closed += (sender, args) => _viewSector = null;
_viewSector.Closed += (_, _) => _viewSector = null;
_viewSector.Show();
}
@@ -844,7 +844,7 @@ public sealed class ImageInfoViewModel : ViewModelBase
DataContext = new DecodeMediaTagsViewModel(_imageFormat)
};
_decodeMediaTags.Closed += (sender, args) => _decodeMediaTags = null;
_decodeMediaTags.Closed += (_, _) => _decodeMediaTags = null;
_decodeMediaTags.Show();
}

10
Aaru.Gui/ViewModels/Windows/ImageConvertViewModel.cs
View File

@@ -844,7 +844,7 @@ public sealed class ImageConvertViewModel : ViewModelBase
ErrorNumber errno;
foreach(MediaTagType mediaTag in _inputFormat.Info.ReadableMediaTags.TakeWhile(mediaTag => !_cancel))
foreach(MediaTagType mediaTag in _inputFormat.Info.ReadableMediaTags.TakeWhile(_ => !_cancel))
{
await Dispatcher.UIThread.InvokeAsync(() =>
{
@@ -1100,7 +1100,7 @@ public sealed class ImageConvertViewModel : ViewModelBase
subchannelExtents.Add((int)s);
}
foreach(SectorTagType tag in _inputFormat.Info.ReadableSectorTags.TakeWhile(tag => useLong && !_cancel))
foreach(SectorTagType tag in _inputFormat.Info.ReadableSectorTags.TakeWhile(_ => useLong && !_cancel))
{
switch(tag)
{
@@ -1310,7 +1310,7 @@ public sealed class ImageConvertViewModel : ViewModelBase
}
else
{
foreach(Track track in tracks.TakeWhile(track => !_cancel))
foreach(Track track in tracks.TakeWhile(_ => !_cancel))
{
doneSectors = 0;
ulong trackSectors = track.EndSector - track.StartSector + 1;
@@ -1451,7 +1451,7 @@ public sealed class ImageConvertViewModel : ViewModelBase
});
foreach(SectorTagType tag in _inputFormat.Info.ReadableSectorTags.OrderBy(t => t).
TakeWhile(tag => useLong && !_cancel))
TakeWhile(_ => useLong && !_cancel))
{
switch(tag)
{
@@ -1470,7 +1470,7 @@ public sealed class ImageConvertViewModel : ViewModelBase
if(ForceChecked && !outputFormat.SupportedSectorTags.Contains(tag))
continue;
foreach(Track track in tracks.TakeWhile(track => !_cancel))
foreach(Track track in tracks.TakeWhile(_ => !_cancel))
{
doneSectors = 0;
ulong trackSectors = track.EndSector - track.StartSector + 1;

8
Aaru.Gui/ViewModels/Windows/MainWindowViewModel.cs
View File

@@ -346,7 +346,7 @@ public sealed class MainWindowViewModel : ViewModelBase
var imageEntropyWindow = new ImageEntropy();
imageEntropyWindow.DataContext = new ImageEntropyViewModel(imageModel.Image, imageEntropyWindow);
imageEntropyWindow.Closed += (sender, args) => imageEntropyWindow = null;
imageEntropyWindow.Closed += (_, _) => imageEntropyWindow = null;
imageEntropyWindow.Show();
}
@@ -359,7 +359,7 @@ public sealed class MainWindowViewModel : ViewModelBase
var imageVerifyWindow = new ImageVerify();
imageVerifyWindow.DataContext = new ImageVerifyViewModel(imageModel.Image, imageVerifyWindow);
imageVerifyWindow.Closed += (sender, args) => imageVerifyWindow = null;
imageVerifyWindow.Closed += (_, _) => imageVerifyWindow = null;
imageVerifyWindow.Show();
}
@@ -372,7 +372,7 @@ public sealed class MainWindowViewModel : ViewModelBase
var imageChecksumWindow = new ImageChecksum();
imageChecksumWindow.DataContext = new ImageChecksumViewModel(imageModel.Image, imageChecksumWindow);
imageChecksumWindow.Closed += (sender, args) => imageChecksumWindow = null;
imageChecksumWindow.Closed += (_, _) => imageChecksumWindow = null;
imageChecksumWindow.Show();
}
@@ -387,7 +387,7 @@ public sealed class MainWindowViewModel : ViewModelBase
imageConvertWindow.DataContext =
new ImageConvertViewModel(imageModel.Image, imageModel.Path, imageConvertWindow);
imageConvertWindow.Closed += (sender, args) => imageConvertWindow = null;
imageConvertWindow.Closed += (_, _) => imageConvertWindow = null;
imageConvertWindow.Show();
}

2
Aaru.Images/CloneCD/Read.cs
View File

@@ -953,7 +953,7 @@ public sealed partial class CloneCd
buffer = null;
foreach(KeyValuePair<uint, ulong> kvp in _offsetMap.Where(kvp => sectorAddress >= kvp.Value).
SelectMany(kvp => Tracks, (kvp, track) => new
SelectMany(_ => Tracks, (kvp, track) => new
{
kvp,
track

3
Aaru.Images/IMD/Enums.cs
View File

@@ -32,8 +32,11 @@
namespace Aaru.DiscImages;
using System.Diagnostics.CodeAnalysis;
public sealed partial class Imd
{
[SuppressMessage("ReSharper", "UnusedMember.Local")]
enum TransferRate : byte
{
/// <summary>500 kbps in FM mode</summary>

3
Aaru.Images/NDIF/Read.cs
View File

@@ -84,7 +84,7 @@ public sealed partial class Ndif
_imageInfo.Sectors = 0;
foreach(byte[] bcem in bcems.Select(id => rsrc.GetResource(NDIF_RESOURCEID)))
foreach(byte[] bcem in bcems.Select(_ => rsrc.GetResource(NDIF_RESOURCEID)))
{
if(bcem.Length < 128)
return ErrorNumber.InvalidArgument;
@@ -362,7 +362,6 @@ public sealed partial class Ndif
var cmpBuffer = new byte[currentChunk.length];
_imageStream.Seek(currentChunk.offset, SeekOrigin.Begin);
_imageStream.Read(cmpBuffer, 0, cmpBuffer.Length);
var cmpMs = new MemoryStream(cmpBuffer);
int realSize;
switch(currentChunk.type)

2
Aaru.Tests/Images/OpticalMediaImageTest.cs
View File

@@ -288,7 +288,7 @@ public abstract class OpticalMediaImageTest : BaseMediaImageTest
Assert.Multiple(() =>
{
Parallel.For(0L, Tests.Length, (i, state) =>
Parallel.For(0L, Tests.Length, (i, _) =>
{
string testFile = Tests[i].TestFile;

2
Aaru.Tests/Issues/OpticalImageConvertIssueTest.cs
View File

@@ -237,7 +237,7 @@ public abstract class OpticalImageConvertIssueTest
subchannelExtents.Add((int)s);
}
foreach(SectorTagType tag in inputFormat.Info.ReadableSectorTags.OrderBy(t => t).TakeWhile(tag => UseLong))
foreach(SectorTagType tag in inputFormat.Info.ReadableSectorTags.OrderBy(t => t).TakeWhile(_ => UseLong))
{
switch(tag)
{

2
Aaru.Tests/WritableImages/WritableOpticalMediaImageTest.cs
View File

@@ -305,7 +305,7 @@ public abstract class WritableOpticalMediaImageTest : BaseWritableMediaImageTest
}
foreach(SectorTagType tag in inputFormat.Info.ReadableSectorTags.OrderBy(t => t).
TakeWhile(tag => useLong))
TakeWhile(_ => useLong))
{
switch(tag)
{

4
Aaru/Commands/Image/Convert.cs
View File

@@ -1013,7 +1013,7 @@ sealed class ConvertImageCommand : Command
subchannelExtents.Add((int)s);
}
foreach(SectorTagType tag in inputOptical.Info.ReadableSectorTags.OrderBy(t => t).TakeWhile(tag => useLong))
foreach(SectorTagType tag in inputOptical.Info.ReadableSectorTags.OrderBy(t => t).TakeWhile(_ => useLong))
{
switch(tag)
{
@@ -1411,7 +1411,7 @@ sealed class ConvertImageCommand : Command
mediaTask.StopTask();
foreach(SectorTagType tag in inputFormat.Info.ReadableSectorTags.TakeWhile(tag => useLong))
foreach(SectorTagType tag in inputFormat.Info.ReadableSectorTags.TakeWhile(_ => useLong))
{
switch(tag)
{

2
Aaru/Commands/Media/Dump.cs
View File

@@ -750,7 +750,7 @@ sealed class DumpMediaCommand : Command
_progressTask2.MaxValue = maximum;
};
Console.CancelKeyPress += (sender, e) =>
Console.CancelKeyPress += (_, e) =>
{
e.Cancel = true;
dumper.Abort();