From 60f957b5399cdfe6aec988a266505ce3ac61e66b Mon Sep 17 00:00:00 2001
From: Natalia Portillo <claunia@claunia.com>
Date: Tue, 28 Dec 2021 03:36:13 +0000
Subject: [PATCH] Add support for dumping Master System / Sega Mark III
 cartridges using a Retrode.

---
 .../.idea/runConfigurations/Aaru.xml          |  2 +-
 .../Devices/Dumping/LinearMemory/Retrode.cs   | 37 ++++++++++++++-----
 2 files changed, 29 insertions(+), 10 deletions(-)

diff --git a/.idea/.idea.Aaru/.idea/runConfigurations/Aaru.xml b/.idea/.idea.Aaru/.idea/runConfigurations/Aaru.xml
index e3733c56b..b18fe86bc 100644
--- a/.idea/.idea.Aaru/.idea/runConfigurations/Aaru.xml
+++ b/.idea/.idea.Aaru/.idea/runConfigurations/Aaru.xml
@@ -1,7 +1,7 @@
 <component name="ProjectRunConfigurationManager">
   <configuration default="false" name="Aaru" type="DotNetProject" factoryName=".NET Project">
     <option name="EXE_PATH" value="$PROJECT_DIR$/Aaru/bin/Debug/net6/aaru" />
-    <option name="PROGRAM_PARAMETERS" value="m dump /dev/sdb foo2.md" />
+    <option name="PROGRAM_PARAMETERS" value="m dump /dev/sda foo3.sms" />
     <option name="WORKING_DIRECTORY" value="$USER_HOME$/Desktop" />
     <option name="PASS_PARENT_ENVS" value="1" />
     <option name="USE_EXTERNAL_CONSOLE" value="0" />
diff --git a/Aaru.Core/Devices/Dumping/LinearMemory/Retrode.cs b/Aaru.Core/Devices/Dumping/LinearMemory/Retrode.cs
index fa4f19ae1..0564875d7 100644
--- a/Aaru.Core/Devices/Dumping/LinearMemory/Retrode.cs
+++ b/Aaru.Core/Devices/Dumping/LinearMemory/Retrode.cs
@@ -51,6 +51,11 @@ public partial class Dump
         0x42, 0x49, 0x4E
     };
 
+    static readonly byte[] _smsExtension =
+    {
+        0x53, 0x4D, 0x53
+    };
+
     /// <summary>Dumps a game cartridge using a Retrode adapter</summary>
     void Retrode()
     {
@@ -100,6 +105,7 @@ public partial class Dump
         int  romPos;
         bool sfcFound     = false;
         bool genesisFound = false;
+        bool smsFound     = false;
         tmp = new byte[3];
 
         for(romPos = 0; romPos < buffer.Length; romPos += 0x20)
@@ -119,10 +125,18 @@ public partial class Dump
 
                 break;
             }
+
+            if(tmp.SequenceEqual(_smsExtension))
+            {
+                smsFound = true;
+
+                break;
+            }
         }
 
-        if(!sfcFound &&
-           !genesisFound)
+        if(!sfcFound     &&
+           !genesisFound &&
+           !smsFound)
         {
             StoppingErrorMessage?.Invoke("No cartridge found, not dumping...");
             _dumpLog.WriteLine("No cartridge found, not dumping...");
@@ -133,13 +147,18 @@ public partial class Dump
         ushort cluster = BitConverter.ToUInt16(buffer, romPos + 0x1A);
         uint   romSize = BitConverter.ToUInt32(buffer, romPos + 0x1C);
 
-        MediaType mediaType     = genesisFound ? MediaType.MegaDriveCartridge : MediaType.SNESGamePak;
-        uint      blocksToRead  = 64;
-        double    totalDuration = 0;
-        double    currentSpeed  = 0;
-        double    maxSpeed      = double.MinValue;
-        double    minSpeed      = double.MaxValue;
-        byte[]    senseBuf;
+        MediaType mediaType = smsFound
+                                  ? MediaType.MasterSystemCartridge
+                                  : genesisFound
+                                      ? MediaType.MegaDriveCartridge
+                                      : MediaType.SNESGamePak;
+
+        uint   blocksToRead  = 64;
+        double totalDuration = 0;
+        double currentSpeed  = 0;
+        double maxSpeed      = double.MinValue;
+        double minSpeed      = double.MaxValue;
+        byte[] senseBuf;
 
         if(_outputPlugin is not IByteAddressableImage outputBai ||
            !outputBai.SupportedMediaTypes.Contains(mediaType))