aaru-dps/Aaru
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2025-12-16 19:24:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

General cleanup and refactor.

Browse Source
This commit is contained in:
Natalia Portillo
2022-03-07 07:36:44 +00:00
parent bc6e432565
commit 762e3eb6d2
1321 changed files with 44657 additions and 45479 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
Aaru.Images/ByteAddressable/Nintendo64.cs
View File

@@ -30,6 +30,8 @@
// Copyright © 2011-2022 Natalia Portillo
// ****************************************************************************/
namespace Aaru.DiscImages.ByteAddressable;
using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
@@ -44,8 +46,6 @@ using Aaru.Helpers;
using Schemas;
using Marshal = Aaru.Helpers.Marshal;
namespace Aaru.DiscImages.ByteAddressable;
/// <inheritdoc />
/// <summary>Implements support for Nintendo 64 cartridge dumps</summary>
public class Nintendo64 : IByteAddressableImage
@@ -88,9 +88,9 @@ public class Nintendo64 : IByteAddressableImage
return false;
stream.Position = 0;
byte[] magicBytes = new byte[4];
var magicBytes = new byte[4];
stream.Read(magicBytes, 0, 4);
uint magic = BitConverter.ToUInt32(magicBytes, 0);
var magic = BitConverter.ToUInt32(magicBytes, 0);
switch(magic)
{
@@ -119,9 +119,9 @@ public class Nintendo64 : IByteAddressableImage
return ErrorNumber.InvalidArgument;
stream.Position = 0;
byte[] magicBytes = new byte[4];
var magicBytes = new byte[4];
stream.Read(magicBytes, 0, 4);
uint magic = BitConverter.ToUInt32(magicBytes, 0);
var magic = BitConverter.ToUInt32(magicBytes, 0);
switch(magic)
{
@@ -169,9 +169,9 @@ public class Nintendo64 : IByteAddressableImage
if(_littleEndian)
{
byte[] tmp = new byte[_data.Length];
var tmp = new byte[_data.Length];
for(int i = 0; i < _data.Length; i += 4)
for(var i = 0; i < _data.Length; i += 4)
{
tmp[i] = _data[i + 3];
tmp[i + 1] = _data[i + 2];
@@ -184,9 +184,9 @@ public class Nintendo64 : IByteAddressableImage
if(_interleaved)
{
byte[] tmp = new byte[_data.Length];
var tmp = new byte[_data.Length];
for(int i = 0; i < _data.Length; i += 2)
for(var i = 0; i < _data.Length; i += 2)
{
tmp[i] = _data[i + 1];
tmp[i + 1] = _data[i];
@@ -216,7 +216,7 @@ public class Nintendo64 : IByteAddressableImage
sb.AppendFormat("Region: {0}", DecodeCountryCode(header.CountryCode)).AppendLine();
sb.AppendFormat("Cartridge ID: {0}", _imageInfo.MediaPartNumber).AppendLine();
sb.AppendFormat("Cartridge type: {0}", (char)header.CartridgeType).AppendLine();
sb.AppendFormat("Version: {0}.{1}", (header.Version / 10) + 1, header.Version % 10).AppendLine();
sb.AppendFormat("Version: {0}.{1}", header.Version / 10 + 1, header.Version % 10).AppendLine();
sb.AppendFormat("CRC1: 0x{0:X8}", header.Crc1).AppendLine();
sb.AppendFormat("CRC2: 0x{0:X8}", header.Crc2).AppendLine();
@@ -669,12 +669,11 @@ public class Nintendo64 : IByteAddressableImage
return ErrorNumber.ReadOnly;
}
bool foundRom = false;
bool foundSaveRam = false;
var foundRom = false;
var foundSaveRam = false;
// Sanitize
foreach(LinearMemoryDevice map in mappings.Devices)
{
switch(map.Type)
{
case LinearMemoryType.ROM when !foundRom:
@@ -689,7 +688,6 @@ public class Nintendo64 : IByteAddressableImage
break;
default: return ErrorNumber.InvalidArgument;
}
}
// Cannot save in this image format anyway
return foundRom ? ErrorNumber.NoError : ErrorNumber.InvalidArgument;
@@ -830,9 +828,9 @@ public class Nintendo64 : IByteAddressableImage
if(_interleaved)
{
byte[] tmp = new byte[_data.Length];
var tmp = new byte[_data.Length];
for(int i = 0; i < _data.Length; i += 2)
for(var i = 0; i < _data.Length; i += 2)
{
tmp[i] = _data[i + 1];
tmp[i + 1] = _data[i];
@@ -861,29 +859,29 @@ public class Nintendo64 : IByteAddressableImage
public bool SetMetadata(ImageInfo metadata) => true;
static string DecodeCountryCode(byte countryCode) => countryCode switch
{
0x37 => "Beta",
0x41 => "Asia (NTSC)",
0x42 => "Brazil",
0x43 => "China",
0x44 => "Germany",
0x45 => "North America",
0x46 => "France",
0x47 => "Gateway 64 (NTSC)",
0x48 => "Netherlands",
0x49 => "Italy",
0x4A => "Japan",
0x4B => "Korea",
0x4C => "Gateway 64 (PAL)",
0x4E => "Canada",
0x50 => "Europe",
0x53 => "Spain",
0x55 => "Australia",
0x57 => "Scandinavia",
0x58 => "Europe",
0x59 => "Europe",
_ => "Unknown"
};
{
0x37 => "Beta",
0x41 => "Asia (NTSC)",
0x42 => "Brazil",
0x43 => "China",
0x44 => "Germany",
0x45 => "North America",
0x46 => "France",
0x47 => "Gateway 64 (NTSC)",
0x48 => "Netherlands",
0x49 => "Italy",
0x4A => "Japan",
0x4B => "Korea",
0x4C => "Gateway 64 (PAL)",
0x4E => "Canada",
0x50 => "Europe",
0x53 => "Spain",
0x55 => "Australia",
0x57 => "Scandinavia",
0x58 => "Europe",
0x59 => "Europe",
_ => "Unknown"
};
[StructLayout(LayoutKind.Sequential, Pack = 1), SuppressMessage("ReSharper", "MemberCanBePrivate.Local")]
struct Header