aaru-dps/Aaru
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2025-12-16 19:24:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Aaru.Core] Introduced constants for module names

Browse Source 
Introduces constant fields for respective debug module names, replacing the hardcoded ones.
This is done to standardize the naming convention, reduce redundancy and potentially avoid any typos or name mismatches across the project.
This change makes the code more maintainable and easier to update in case module names need to be changed.
This commit is contained in:
Natalia Portillo
2023-10-03 17:17:16 +01:00
parent 446c5f1c64
commit 874c7d92ff
20 changed files with 225 additions and 207 deletions
Download Patch File Download Diff File Expand all files Collapse all files

95
Aaru.Core/Media/Detection/MMC.cs
View File

@@ -63,6 +63,7 @@ public static class MMC
/// <summary>SHA256 of PlayStation 2 boot sectors, seen in Japanese discs</summary>
const string PS2_JAPANESE_HASH = "b82bffb809070d61fe050b7e1545df53d8f3cc648257cdff7502bc0ba6b38870";
const string MODULE_NAME = "Media detection";
static readonly byte[] _ps3Id =
{
@@ -295,7 +296,7 @@ public static class MMC
{
Features.SeparatedFeatures ftr = Features.Separate(cmdBuf);
AaruConsole.DebugWriteLine("Media-Info command", Localization.Core.GET_CONFIGURATION_current_profile_is_0,
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.GET_CONFIGURATION_current_profile_is_0,
ftr.CurrentProfile);
switch(ftr.CurrentProfile)
@@ -453,12 +454,12 @@ public static class MMC
switch(a0Track.PSEC)
{
case 0x10:
AaruConsole.DebugWriteLine("Media detection", Localization.Core.TOC_says_disc_type_is_CD_i);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.TOC_says_disc_type_is_CD_i);
mediaType = MediaType.CDI;
break;
case 0x20:
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.TOC_says_disc_type_is_CD_ROM_XA);
mediaType = MediaType.CDROMXA;
@@ -498,7 +499,7 @@ public static class MMC
switch(hasDataTrack)
{
case true when hasAudioTrack && allFirstSessionTracksAreAudio && sessions == 2:
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.
Disc_has_audio_and_data_two_sessions_all_data_second_CD_Plus);
@@ -506,7 +507,7 @@ public static class MMC
break;
case false when hasAudioTrack && sessions == 1:
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Disc_has_only_audio_in_a_session_CD_Digital_Audio);
mediaType = MediaType.CDDA;
@@ -518,7 +519,7 @@ public static class MMC
!hasAudioTrack &&
sessions == 1)
{
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Disc_has_only_data_in_a_session_CD_ROM);
mediaType = MediaType.CDROM;
@@ -528,7 +529,7 @@ public static class MMC
!hasDataTrack &&
sessions == 1)
{
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Disc_has_video_tracks_CD_Video);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Disc_has_video_tracks_CD_Video);
mediaType = MediaType.CDV;
}
@@ -568,7 +569,7 @@ public static class MMC
cmdBuf[15] != 0x02)
continue;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Disc_has_a_mode_two_data_track_CD_ROM_XA);
mediaType = MediaType.CDROMXA;
@@ -684,7 +685,7 @@ public static class MMC
{
mediaType = MediaType.CDIREADY;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Disc_has_hidden_CD_i_pregap_CD_i_Ready);
return;
@@ -739,7 +740,7 @@ public static class MMC
{
mediaType = MediaType.CDIREADY;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Disc_has_hidden_CD_i_pregap_CD_i_Ready);
return;
@@ -1138,7 +1139,7 @@ public static class MMC
{
if(DMI.IsXbox(cmdBuf))
{
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
"Found Xbox DMI, setting disc type to Xbox Game Disc (XGD).");
mediaType = MediaType.XGD;
@@ -1151,7 +1152,7 @@ public static class MMC
// All XGD3 all have the same number of blocks
if(blocks is 25063 or 4229664 or 4246304) // Wxripper unlock
{
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
"Found Xbox 360 DMI with {0} blocks, setting disc type to Xbox 360 Game Disc 3 (XGD3).");
mediaType = MediaType.XGD3;
@@ -1159,7 +1160,7 @@ public static class MMC
return;
}
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
"Found Xbox 360 DMI with {0} blocks, setting disc type to Xbox 360 Game Disc 2 (XGD2).");
mediaType = MediaType.XGD2;
@@ -1355,7 +1356,7 @@ public static class MMC
case "PHOTO_CD":
mediaType = MediaType.PCD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Photo_CD_description_file);
return;
@@ -1408,7 +1409,7 @@ public static class MMC
{
mediaType = MediaType.MEGACD;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_Mega_Sega_CD_IP_BIN);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_Mega_Sega_CD_IP_BIN);
return;
}
@@ -1417,7 +1418,7 @@ public static class MMC
{
mediaType = MediaType.SATURNCD;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_Sega_Saturn_IP_BIN);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_Sega_Saturn_IP_BIN);
return;
}
@@ -1427,7 +1428,7 @@ public static class MMC
{
mediaType = MediaType.GDROM;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_Sega_Dreamcast_IP_BIN);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_Sega_Dreamcast_IP_BIN);
return;
}
@@ -1442,7 +1443,7 @@ public static class MMC
string ps2BootSectorsHash = Sha256Context.Data(ps2BootSectors, out _);
AaruConsole.DebugWriteLine("Media-info Command",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.PlayStation_2_boot_sectors_SHA256_0,
ps2BootSectorsHash);
@@ -1450,7 +1451,7 @@ public static class MMC
{
mediaType = MediaType.PS2CD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Sony_PlayStation_2_boot_sectors);
goto hasPs2CdBoot;
@@ -1466,7 +1467,7 @@ public static class MMC
{
mediaType = MediaType.ThreeDO;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_Opera_filesystem);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_Opera_filesystem);
return;
}
@@ -1475,7 +1476,7 @@ public static class MMC
{
mediaType = MediaType.FMTOWNS;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_FM_Towns_boot);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_FM_Towns_boot);
return;
}
@@ -1495,7 +1496,7 @@ public static class MMC
{
mediaType = MediaType.Playdia;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_Playdia_copyright);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_Playdia_copyright);
return;
}
@@ -1510,7 +1511,7 @@ public static class MMC
{
mediaType = MediaType.SuperCDROM2;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_PC_Engine_CD_signature);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_PC_Engine_CD_signature);
return;
}
@@ -1525,7 +1526,7 @@ public static class MMC
{
mediaType = MediaType.PCFX;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_PC_FX_copyright);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_PC_FX_copyright);
return;
}
@@ -1544,7 +1545,7 @@ public static class MMC
mediaType = MediaType.JaguarCD;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_Atari_signature);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_Atari_signature);
break;
}
@@ -1559,7 +1560,7 @@ public static class MMC
{
mediaType = MediaType.MilCD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Sega_Dreamcast_IP_BIN_on_second_session);
return;
@@ -1572,7 +1573,7 @@ public static class MMC
{
mediaType = MediaType.VideoNowColor;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_VideoNow_Color_frame);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_VideoNow_Color_frame);
return;
}
@@ -1610,7 +1611,7 @@ public static class MMC
{
mediaType = MediaType.CDEG;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_enhanced_graphics_RW_packet);
return;
@@ -1620,7 +1621,7 @@ public static class MMC
{
mediaType = MediaType.CDG;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_graphics_RW_packet);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_graphics_RW_packet);
return;
}
@@ -1629,7 +1630,7 @@ public static class MMC
{
mediaType = MediaType.CDMIDI;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_MIDI_RW_packet);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_MIDI_RW_packet);
return;
}
@@ -1789,7 +1790,7 @@ public static class MMC
{
mediaType = MediaType.CD32;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_CD32_TM_file_in_root);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_CD32_TM_file_in_root);
return;
}
@@ -1798,7 +1799,7 @@ public static class MMC
{
mediaType = MediaType.CDTV;
AaruConsole.DebugWriteLine("Media detection", Localization.Core.Found_CDTV_TM_file_in_root);
AaruConsole.DebugWriteLine(MODULE_NAME, Localization.Core.Found_CDTV_TM_file_in_root);
return;
}
@@ -1939,7 +1940,7 @@ public static class MMC
{
mediaType = MediaType.NeoGeoCD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_correct_IPL_TXT_file_in_root);
return;
@@ -2021,21 +2022,21 @@ public static class MMC
case "VIDEO_CD":
mediaType = MediaType.VCD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Video_CD_description_file);
return;
case "SUPERVCD":
mediaType = MediaType.SVCD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Super_Video_CD_description_file);
break;
case "HQ-VCD":
mediaType = MediaType.CVD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_China_Video_Disc_description_file);
break;
@@ -2117,7 +2118,7 @@ public static class MMC
case "PHOTO_CD":
mediaType = MediaType.PCD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Photo_CD_description_file);
return;
@@ -2210,7 +2211,7 @@ public static class MMC
{
mediaType = MediaType.PS1CD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_correct_SYSTEM_CNF_file_in_root_PS1);
}
@@ -2219,7 +2220,7 @@ public static class MMC
{
mediaType = MediaType.PS2CD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_correct_SYSTEM_CNF_file_in_root_PS2);
}
}
@@ -2246,13 +2247,13 @@ public static class MMC
string ps2BootSectorsHash = Sha256Context.Data(ps2BootSectors, out _);
AaruConsole.DebugWriteLine("Media-info Command",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.PlayStation_2_boot_sectors_SHA256_0,
ps2BootSectorsHash);
if(ps2BootSectorsHash is PS2_PAL_HASH or PS2_NTSC_HASH or PS2_JAPANESE_HASH)
{
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Sony_PlayStation_2_boot_sectors_DVD);
mediaType = MediaType.PS2DVD;
@@ -2268,14 +2269,14 @@ public static class MMC
switch(mediaType)
{
case MediaType.BDROM:
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Sony_PlayStation_3_boot_sectors);
mediaType = MediaType.PS3BD;
break;
case MediaType.DVDROM:
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Sony_PlayStation_3_boot_sectors_DVD);
mediaType = MediaType.PS3DVD;
@@ -2291,7 +2292,7 @@ public static class MMC
{
mediaType = MediaType.PS4BD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Sony_PlayStation_4_boot_sectors);
}
}
@@ -2304,7 +2305,7 @@ public static class MMC
switch(blurayType)
{
case "XG4":
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Blu_ray_type_XG4_setting_disc_type_XGD4);
mediaType = MediaType.XGD4;
@@ -2322,14 +2323,14 @@ public static class MMC
{
mediaType = MediaType.PS5BD;
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Found_Sony_PlayStation_5_boot_sectors);
break;
}
}
AaruConsole.DebugWriteLine("Media detection",
AaruConsole.DebugWriteLine(MODULE_NAME,
Localization.Core.Blu_ray_type_BDU_setting_disc_type_UHD);
mediaType = MediaType.UHDBD;