FEATURE FREEZE: Removed TODO lines already implemented.

This commit is contained in:
2017-12-19 01:13:31 +00:00
parent 5ab5052775
commit 8c6d05eed3
8 changed files with 1 additions and 12 deletions

View File

@@ -56,7 +56,6 @@ namespace DiscImageChef.Core.Devices.Dumping
internal class CompactDisc internal class CompactDisc
{ {
// TODO: Add support for resume file
internal static void Dump(Device dev, string devicePath, string outputPrefix, ushort retryPasses, bool force, bool dumpRaw, bool persistent, bool stopOnError, ref CICMMetadataType sidecar, ref MediaType dskType, bool separateSubchannel, ref Resume resume, ref DumpLog dumpLog, Alcohol120 alcohol, bool dumpLeadIn) internal static void Dump(Device dev, string devicePath, string outputPrefix, ushort retryPasses, bool force, bool dumpRaw, bool persistent, bool stopOnError, ref CICMMetadataType sidecar, ref MediaType dskType, bool separateSubchannel, ref Resume resume, ref DumpLog dumpLog, Alcohol120 alcohol, bool dumpLeadIn)
{ {
MHDDLog mhddLog; MHDDLog mhddLog;

View File

@@ -79,9 +79,6 @@ namespace DiscImageChef.Core.Devices
break; break;
case DeviceType.NVMe: case DeviceType.NVMe:
throw new NotImplementedException("NVMe devices not yet supported."); throw new NotImplementedException("NVMe devices not yet supported.");
case DeviceType.MMC:
case DeviceType.SecureDigital:
throw new NotImplementedException("MMC/SD devices not yet supported.");
} }
} }

View File

@@ -615,9 +615,8 @@ namespace DiscImageChef.Core.Devices.Report
if((ataId.PhysLogSectorSize & 0x2000) == 0x2000) if((ataId.PhysLogSectorSize & 0x2000) == 0x2000)
{ {
// TODO: Bit shift 1 << value&F
#pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created #pragma warning disable IDE0004 // Cast is necessary, otherwise incorrect value is created
physicalsectorsize = logicalsectorsize * (uint)Math.Pow(2, (double)(ataId.PhysLogSectorSize & 0xF)); physicalsectorsize = (uint)(logicalsectorsize * (1 << ataId.PhysLogSectorSize & 0xF));
#pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created #pragma warning restore IDE0004 // Cast is necessary, otherwise incorrect value is created
} }
else else

View File

@@ -213,8 +213,6 @@ namespace DiscImageChef.Devices
else else
manufacturer = "ATA"; manufacturer = "ATA";
} }
// TODO: Get cached CID, CSD and SCR from kernel space
} }
ntDevicePath = Windows.Command.GetDevicePath((SafeFileHandle)fd); ntDevicePath = Windows.Command.GetDevicePath((SafeFileHandle)fd);

View File

@@ -136,7 +136,6 @@ namespace DiscImageChef.Filesystems
bool APMFromHDDOnCD = false; bool APMFromHDDOnCD = false;
// TODO: I don't like this, I can do better
if(imagePlugin.GetSectorSize() == 2352 || imagePlugin.GetSectorSize() == 2448 || imagePlugin.GetSectorSize() == 2048) if(imagePlugin.GetSectorSize() == 2352 || imagePlugin.GetSectorSize() == 2448 || imagePlugin.GetSectorSize() == 2048)
{ {
byte[] tmp_sector = imagePlugin.ReadSectors(partition.Start, 2); byte[] tmp_sector = imagePlugin.ReadSectors(partition.Start, 2);

View File

@@ -38,7 +38,6 @@ using DiscImageChef.CommonTypes;
namespace DiscImageChef.Filesystems namespace DiscImageChef.Filesystems
{ {
// Information from the Linux kernel // Information from the Linux kernel
// TODO: Get documentation, test files, and rewrite this mess
public class SysVfs : Filesystem public class SysVfs : Filesystem
{ {
const uint XENIX_MAGIC = 0x002B5544; const uint XENIX_MAGIC = 0x002B5544;

View File

@@ -353,7 +353,6 @@ namespace DiscImageChef.Settings
} }
} }
break; break;
// TODO: Use the Registry
default: default:
{ {
string configPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".config"); string configPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".config");

View File

@@ -157,7 +157,6 @@ namespace DiscImageChef.Commands
else else
checkStatus = null; checkStatus = null;
// TODO: Refactor
foreach(ulong failLBA in tempFailingLBAs) foreach(ulong failLBA in tempFailingLBAs)
FailingLBAs.Add(failLBA); FailingLBAs.Add(failLBA);