🎨REFACTOR: Plugins do not need to expose their methods as virtual.

This commit is contained in:
2017-12-26 07:28:40 +00:00
parent 6aee3c9cb1
commit 94d8173b3a
168 changed files with 2161 additions and 2161 deletions

View File

@@ -203,16 +203,16 @@ namespace DiscImageChef.DiscImages
};
}
public virtual ImageInfo Info => imageInfo;
public ImageInfo Info => imageInfo;
public virtual string Name => "CDRWin cuesheet";
public virtual Guid Id => new Guid("664568B2-15D4-4E64-8A7A-20BDA8B8386F");
public string Name => "CDRWin cuesheet";
public Guid Id => new Guid("664568B2-15D4-4E64-8A7A-20BDA8B8386F");
public virtual string ImageFormat => "CDRWin CUESheet";
public string ImageFormat => "CDRWin CUESheet";
public virtual List<Partition> Partitions => partitions;
public List<Partition> Partitions => partitions;
public virtual List<Track> Tracks
public List<Track> Tracks
{
get
{
@@ -259,10 +259,10 @@ namespace DiscImageChef.DiscImages
}
}
public virtual List<Session> Sessions => discimage.Sessions;
public List<Session> Sessions => discimage.Sessions;
// Due to .cue format, this method must parse whole file, ignoring errors (those will be thrown by OpenImage()).
public virtual bool IdentifyImage(IFilter imageFilter)
public bool IdentifyImage(IFilter imageFilter)
{
cdrwinFilter = imageFilter;
@@ -323,7 +323,7 @@ namespace DiscImageChef.DiscImages
}
}
public virtual bool OpenImage(IFilter imageFilter)
public bool OpenImage(IFilter imageFilter)
{
if(imageFilter == null) return false;
@@ -1192,7 +1192,7 @@ namespace DiscImageChef.DiscImages
}
}
public virtual byte[] ReadDiskTag(MediaTagType tag)
public byte[] ReadDiskTag(MediaTagType tag)
{
switch(tag)
{
@@ -1215,27 +1215,27 @@ namespace DiscImageChef.DiscImages
}
}
public virtual byte[] ReadSector(ulong sectorAddress)
public byte[] ReadSector(ulong sectorAddress)
{
return ReadSectors(sectorAddress, 1);
}
public virtual byte[] ReadSectorTag(ulong sectorAddress, SectorTagType tag)
public byte[] ReadSectorTag(ulong sectorAddress, SectorTagType tag)
{
return ReadSectorsTag(sectorAddress, 1, tag);
}
public virtual byte[] ReadSector(ulong sectorAddress, uint track)
public byte[] ReadSector(ulong sectorAddress, uint track)
{
return ReadSectors(sectorAddress, 1, track);
}
public virtual byte[] ReadSectorTag(ulong sectorAddress, uint track, SectorTagType tag)
public byte[] ReadSectorTag(ulong sectorAddress, uint track, SectorTagType tag)
{
return ReadSectorsTag(sectorAddress, 1, track, tag);
}
public virtual byte[] ReadSectors(ulong sectorAddress, uint length)
public byte[] ReadSectors(ulong sectorAddress, uint length)
{
foreach(KeyValuePair<uint, ulong> kvp in from kvp in offsetmap
where sectorAddress >= kvp.Value
@@ -1248,7 +1248,7 @@ namespace DiscImageChef.DiscImages
throw new ArgumentOutOfRangeException(nameof(sectorAddress), "Sector address not found");
}
public virtual byte[] ReadSectorsTag(ulong sectorAddress, uint length, SectorTagType tag)
public byte[] ReadSectorsTag(ulong sectorAddress, uint length, SectorTagType tag)
{
foreach(KeyValuePair<uint, ulong> kvp in from kvp in offsetmap
where sectorAddress >= kvp.Value
@@ -1261,7 +1261,7 @@ namespace DiscImageChef.DiscImages
throw new ArgumentOutOfRangeException(nameof(sectorAddress), "Sector address not found");
}
public virtual byte[] ReadSectors(ulong sectorAddress, uint length, uint track)
public byte[] ReadSectors(ulong sectorAddress, uint length, uint track)
{
CdrWinTrack dicTrack = new CdrWinTrack {Sequence = 0};
@@ -1365,7 +1365,7 @@ namespace DiscImageChef.DiscImages
return buffer;
}
public virtual byte[] ReadSectorsTag(ulong sectorAddress, uint length, uint track, SectorTagType tag)
public byte[] ReadSectorsTag(ulong sectorAddress, uint length, uint track, SectorTagType tag)
{
CdrWinTrack dicTrack = new CdrWinTrack {Sequence = 0};
@@ -1546,17 +1546,17 @@ namespace DiscImageChef.DiscImages
return buffer;
}
public virtual byte[] ReadSectorLong(ulong sectorAddress)
public byte[] ReadSectorLong(ulong sectorAddress)
{
return ReadSectorsLong(sectorAddress, 1);
}
public virtual byte[] ReadSectorLong(ulong sectorAddress, uint track)
public byte[] ReadSectorLong(ulong sectorAddress, uint track)
{
return ReadSectorsLong(sectorAddress, 1, track);
}
public virtual byte[] ReadSectorsLong(ulong sectorAddress, uint length)
public byte[] ReadSectorsLong(ulong sectorAddress, uint length)
{
foreach(KeyValuePair<uint, ulong> kvp in from kvp in offsetmap
where sectorAddress >= kvp.Value
@@ -1569,7 +1569,7 @@ namespace DiscImageChef.DiscImages
throw new ArgumentOutOfRangeException(nameof(sectorAddress), "Sector address not found");
}
public virtual byte[] ReadSectorsLong(ulong sectorAddress, uint length, uint track)
public byte[] ReadSectorsLong(ulong sectorAddress, uint length, uint track)
{
CdrWinTrack dicTrack = new CdrWinTrack {Sequence = 0};
@@ -1658,14 +1658,14 @@ namespace DiscImageChef.DiscImages
return buffer;
}
public virtual List<Track> GetSessionTracks(Session session)
public List<Track> GetSessionTracks(Session session)
{
if(discimage.Sessions.Contains(session)) return GetSessionTracks(session.SessionSequence);
throw new ImageNotSupportedException("Session does not exist in disc image");
}
public virtual List<Track> GetSessionTracks(ushort session)
public List<Track> GetSessionTracks(ushort session)
{
List<Track> tracks = new List<Track>();
@@ -1706,19 +1706,19 @@ namespace DiscImageChef.DiscImages
return tracks;
}
public virtual bool? VerifySector(ulong sectorAddress)
public bool? VerifySector(ulong sectorAddress)
{
byte[] buffer = ReadSectorLong(sectorAddress);
return CdChecksums.CheckCdSector(buffer);
}
public virtual bool? VerifySector(ulong sectorAddress, uint track)
public bool? VerifySector(ulong sectorAddress, uint track)
{
byte[] buffer = ReadSectorLong(sectorAddress, track);
return CdChecksums.CheckCdSector(buffer);
}
public virtual bool? VerifySectors(ulong sectorAddress, uint length, out List<ulong> failingLbas,
public bool? VerifySectors(ulong sectorAddress, uint length, out List<ulong> failingLbas,
out List<ulong> unknownLbas)
{
byte[] buffer = ReadSectorsLong(sectorAddress, length);
@@ -1748,7 +1748,7 @@ namespace DiscImageChef.DiscImages
return failingLbas.Count <= 0;
}
public virtual bool? VerifySectors(ulong sectorAddress, uint length, uint track, out List<ulong> failingLbas,
public bool? VerifySectors(ulong sectorAddress, uint length, uint track, out List<ulong> failingLbas,
out List<ulong> unknownLbas)
{
byte[] buffer = ReadSectorsLong(sectorAddress, length, track);
@@ -1778,7 +1778,7 @@ namespace DiscImageChef.DiscImages
return failingLbas.Count <= 0;
}
public virtual bool? VerifyMediaImage()
public bool? VerifyMediaImage()
{
return null;
}