From 9618e2c5498b49e5610282cc68b521bec1741b1f Mon Sep 17 00:00:00 2001 From: Natalia Portillo Date: Thu, 5 Oct 2023 01:05:23 +0100 Subject: [PATCH] Annotate or remove unused elements. --- Aaru.Checksums | 2 +- Aaru.CommonTypes | 2 +- Aaru.Compression/NonClosableStream.cs | 2 + Aaru.Console | 2 +- Aaru.Core/Devices/Reader.cs | 6 +- Aaru.Core/Sidecar/AudioMedia.cs | 2 + Aaru.Core/Sidecar/LinearMedia.cs | 2 + Aaru.Database/ContextFactory.cs | 2 + Aaru.Decoders | 2 +- Aaru.Decryption | 2 +- Aaru.Devices/Device/AtaCommands/Ata28.cs | 2 + Aaru.Devices/Device/AtaCommands/AtaCHS.cs | 5 + Aaru.Devices/Device/AtaCommands/MCPT.cs | 6 + Aaru.Devices/Device/MmcCommands/MMC.cs | 2 + Aaru.Devices/Device/ScsiCommands/Adaptec.cs | 2 + .../Device/ScsiCommands/ArchiveCorp.cs | 2 + Aaru.Devices/Device/ScsiCommands/HP.cs | 2 + Aaru.Devices/Device/ScsiCommands/MMC.cs | 3 + Aaru.Devices/Device/ScsiCommands/MiniDisc.cs | 2 + Aaru.Devices/Device/ScsiCommands/Plasmon.cs | 2 + Aaru.Devices/Device/ScsiCommands/SPC.cs | 3 + Aaru.Devices/Device/ScsiCommands/SSC.cs | 4 + Aaru.Devices/Device/ScsiCommands/SyQuest.cs | 2 + Aaru.Devices/Linux/Enums.cs | 6 + Aaru.Devices/Linux/Extern.cs | 3 - Aaru.Devices/Remote/Device.cs | 1 + Aaru.Devices/Remote/Enums.cs | 3 + Aaru.Devices/Windows/Extern.cs | 2 + Aaru.Devices/Windows/Structs.cs | 3 + Aaru.Devices/Windows/Usb.cs | 1 + Aaru.Devices/Windows/UsbFunctions.cs | 2 + Aaru.Dto | 2 +- Aaru.Filesystems/AppleCommon/Enums.cs | 2 + Aaru.Filesystems/HPOFS/Consts.cs | 2 + Aaru.Filesystems/ISO9660/Consts/AAIP.cs | 2 + Aaru.Filesystems/ProDOS/Structs.cs | 11 +- Aaru.Filesystems/QNX4/QNX4.cs | 1 + Aaru.Filesystems/QNX4/Structs.cs | 2 + Aaru.Filesystems/ZFS/Helpers.cs | 1 + Aaru.Filesystems/ZFS/Structs.cs | 2 + Aaru.Filters/OffsetStream.cs | 2 + Aaru.Filters/SplitJoinStream.cs | 2 + Aaru.Gui/ConsoleHandler.cs | 32 ------ Aaru.Gui/ResourceHandler.cs | 44 -------- Aaru.Gui/ViewLocator.cs | 5 +- .../ViewModels/Panels/ImageInfoViewModel.cs | 16 +-- .../ViewModels/Panels/MediaInfoViewModel.cs | 15 ++- Aaru.Gui/ViewModels/Tabs/DvdInfoViewModel.cs | 3 +- .../Tabs/DvdWritableInfoViewModel.cs | 12 +- Aaru.Helpers | 2 +- Aaru.Images/A2R/A2R.cs | 2 + Aaru.Images/A2R/Constants.cs | 3 + Aaru.Images/A2R/Enums.cs | 1 + Aaru.Images/A2R/Helpers.cs | 4 + Aaru.Images/A2R/Identify.cs | 2 + Aaru.Images/A2R/Properties.cs | 2 + Aaru.Images/A2R/Read.cs | 2 + Aaru.Images/A2R/Structs.cs | 2 + Aaru.Images/A2R/Write.cs | 2 + Aaru.Images/Aaru.Images.csproj.DotSettings | 105 ++++++------------ Aaru.Images/BLU/BLU.cs | 2 + Aaru.Images/BLU/Constants.cs | 3 + Aaru.Images/BLU/Identify.cs | 2 + Aaru.Images/BLU/Properties.cs | 2 + Aaru.Images/BLU/Read.cs | 2 + Aaru.Images/BLU/Unsupported.cs | 2 + Aaru.Images/BLU/Verify.cs | 2 + Aaru.Images/BLU/Write.cs | 2 + Aaru.Images/ByteAddressable/AtariLynx.cs | 1 + Aaru.Images/ByteAddressable/GameBoy.cs | 1 + Aaru.Images/ByteAddressable/GameBoyAdvance.cs | 1 + Aaru.Images/ByteAddressable/MasterSystem.cs | 1 + Aaru.Images/ByteAddressable/NES.cs | 2 + Aaru.Images/ByteAddressable/Nintendo64.cs | 1 + Aaru.Images/ByteAddressable/SegaMegaDrive.cs | 1 + Aaru.Images/ByteAddressable/SuperNintendo.cs | 1 + Aaru.Images/DIM/Constants.cs | 3 + Aaru.Images/DIM/DIM.cs | 2 + Aaru.Images/DIM/Enums.cs | 3 + Aaru.Images/DIM/Identify.cs | 2 + Aaru.Images/DIM/Properties.cs | 2 + Aaru.Images/DIM/Read.cs | 2 + Aaru.Images/DIM/Unsupported.cs | 2 + Aaru.Images/GDI/Constants.cs | 3 + Aaru.Images/GDI/GDI.cs | 2 + Aaru.Images/GDI/Identify.cs | 2 + Aaru.Images/GDI/Properties.cs | 2 + Aaru.Images/GDI/Read.cs | 2 + Aaru.Images/GDI/Structs.cs | 2 + Aaru.Images/GDI/Unsupported.cs | 2 + Aaru.Images/GDI/Verify.cs | 2 + Aaru.Images/Partimage/Constants.cs | 1 + Aaru.Images/Partimage/Enums.cs | 1 + Aaru.Images/Partimage/Helpers.cs | 3 + Aaru.Images/Partimage/Identify.cs | 2 + Aaru.Images/Partimage/Partimage.cs | 2 + Aaru.Images/Partimage/Properties.cs | 2 + Aaru.Images/Partimage/Read.cs | 2 + Aaru.Images/Partimage/Structs.cs | 1 + Aaru.Images/Partimage/Unsupported.cs | 2 + Aaru.Images/Partimage/Verify.cs | 3 + Aaru.Images/SuperCardPro/Enums.cs | 1 + Aaru.Images/SuperCardPro/Helpers.cs | 3 + Aaru.Images/SuperCardPro/Write.cs | 3 - Aaru.Images/T98/Identify.cs | 2 + Aaru.Images/T98/Properties.cs | 2 + Aaru.Images/T98/Read.cs | 2 + Aaru.Images/T98/T98.cs | 2 + Aaru.Images/T98/Unsupported.cs | 2 + Aaru.Images/T98/Write.cs | 2 + Aaru.Images/UkvFdi/Constants.cs | 3 + Aaru.Images/UkvFdi/Enums.cs | 1 + Aaru.Images/UkvFdi/Helpers.cs | 3 + Aaru.Images/UkvFdi/Identify.cs | 2 + Aaru.Images/UkvFdi/Properties.cs | 2 + Aaru.Images/UkvFdi/Read.cs | 2 + Aaru.Images/UkvFdi/Structs.cs | 2 + Aaru.Images/UkvFdi/UkvFdi.cs | 2 + Aaru.Images/UkvFdi/Unsupported.cs | 2 + Aaru.Images/WCDiskImage/Identify.cs | 2 + Aaru.Images/WCDiskImage/Properties.cs | 2 + Aaru.Images/WCDiskImage/Read.cs | 2 + Aaru.Images/WCDiskImage/Structs.cs | 2 + Aaru.Images/WCDiskImage/Unsupported.cs | 2 + Aaru.Images/WCDiskImage/WCDiskImage.cs | 1 + Aaru.Partitions/BSD.cs | 1 + Aaru.Settings/Settings.cs | 10 -- Aaru.Tests.Devices/NVMe.cs | 2 + Aaru.Tests/Issues/257.cs | 2 + Aaru.Tests/Issues/263/AaruFormat.cs | 2 + Aaru.Tests/Issues/263/Raw.cs | 2 + Aaru.Tests/Issues/266.cs | 2 + Aaru.Tests/Issues/286.cs | 2 + Aaru.Tests/Issues/288/18Wheeler.cs | 2 + Aaru.Tests/Issues/288/ArcadeHits.cs | 2 + Aaru.Tests/Issues/288/Roadsters.cs | 2 + Aaru.Tests/Issues/299.cs | 2 + Aaru.Tests/Issues/300.cs | 2 + Aaru.Tests/Issues/358.cs | 2 + Aaru.Tests/Issues/360.cs | 2 + Aaru.Tests/Issues/379.cs | 2 + Aaru.Tests/Issues/398.cs | 2 + Aaru.Tests/Issues/410.cs | 2 + Aaru.Tests/Issues/411.cs | 2 + Aaru.Tests/Issues/441.cs | 2 + Aaru.Tests/Issues/448.cs | 2 + Aaru.Tests/Issues/449.cs | 2 + Aaru.Tests/Issues/450.cs | 2 + Aaru.Tests/Issues/495.cs | 2 + Aaru.Tests/Issues/531.cs | 2 + Aaru.Tests/Issues/542/Sims.cs | 2 + Aaru.Tests/Issues/542/SimsEP.cs | 1 + Aaru.Tests/Issues/584.cs | 2 + .../590/asus-driver-gpu-tweak-v1231-2014.cs | 1 + Aaru.Tests/Issues/590/m5a99fx.cs | 1 + Aaru.Tests/Issues/590/win3.cs | 1 + Aaru.Tests/Issues/623.cs | 2 + Aaru.Tests/Issues/624.cs | 2 + Aaru.Tests/Issues/625.cs | 2 + Aaru.Tests/Structs.cs | 5 +- .../WritableImages/AaruFormat/V1/FromAaru.cs | 2 + Aaru.Tests/WritableImages/Alcohol/FromAaru.cs | 2 + Aaru.Tests/WritableImages/CDRDAO/FromAaru.cs | 2 + Aaru.Tests/WritableImages/CDRWin/FromAaru.cs | 2 + Aaru.Tests/WritableImages/CloneCD/FromAaru.cs | 2 + Aaru.sln.DotSettings | 25 ++++- Aaru/Commands/Media/Dump.cs | 8 +- Aaru/Commands/Media/Info.cs | 2 + 168 files changed, 397 insertions(+), 216 deletions(-) delete mode 100644 Aaru.Gui/ResourceHandler.cs diff --git a/Aaru.Checksums b/Aaru.Checksums index 16b2a4039..86c470a43 160000 --- a/Aaru.Checksums +++ b/Aaru.Checksums @@ -1 +1 @@ -Subproject commit 16b2a40390f9bc7519fcd8f20957fe337cff2a9f +Subproject commit 86c470a43659cb29b5bb8506f549140a41c0333c diff --git a/Aaru.CommonTypes b/Aaru.CommonTypes index 7796540b5..cfb704e3e 160000 --- a/Aaru.CommonTypes +++ b/Aaru.CommonTypes @@ -1 +1 @@ -Subproject commit 7796540b5e5e81ceb5dfc2b6e775925b33da8e3d +Subproject commit cfb704e3effaae4111a35f51f0c02676971deb0f diff --git a/Aaru.Compression/NonClosableStream.cs b/Aaru.Compression/NonClosableStream.cs index 1fd6e5b92..d36c17bdb 100644 --- a/Aaru.Compression/NonClosableStream.cs +++ b/Aaru.Compression/NonClosableStream.cs @@ -30,6 +30,7 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.Helpers; @@ -37,6 +38,7 @@ namespace Aaru.Compression; /// /// Creates a MemoryStream that ignores close commands +[SuppressMessage("ReSharper", "UnusedMember.Global")] sealed class NonClosableStream : Stream { readonly MemoryStream _baseStream; diff --git a/Aaru.Console b/Aaru.Console index 7fb3e7a44..4f1e2f10e 160000 --- a/Aaru.Console +++ b/Aaru.Console @@ -1 +1 @@ -Subproject commit 7fb3e7a44934431fa1bb47eb669d95cc580ecee5 +Subproject commit 4f1e2f10ed95f6da1559fc0b24aa2019ac6074fa diff --git a/Aaru.Core/Devices/Reader.cs b/Aaru.Core/Devices/Reader.cs index b81295b6a..698598894 100644 --- a/Aaru.Core/Devices/Reader.cs +++ b/Aaru.Core/Devices/Reader.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Structs.Devices.ATA; using Aaru.Core.Logging; @@ -39,6 +40,7 @@ using Aaru.Devices; namespace Aaru.Core.Devices; /// Reduces common code used for scanning and dumping +[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")] sealed partial class Reader { const string ATA_MODULE_NAME = "ATA Reader"; @@ -147,10 +149,6 @@ sealed partial class Reader out bool blankCheck) => ReadBlocks(out buffer, block, 1, out duration, out recoveredError, out blankCheck); - internal bool ReadBlocks(out byte[] buffer, ulong block, out double duration, out bool recoveredError, - out bool blankCheck) => ReadBlocks(out buffer, block, BlocksToRead, out duration, - out recoveredError, out blankCheck); - internal bool ReadBlocks(out byte[] buffer, ulong block, uint count, out double duration, out bool recoveredError, out bool blankCheck) { diff --git a/Aaru.Core/Sidecar/AudioMedia.cs b/Aaru.Core/Sidecar/AudioMedia.cs index a8603ba82..e77233c16 100644 --- a/Aaru.Core/Sidecar/AudioMedia.cs +++ b/Aaru.Core/Sidecar/AudioMedia.cs @@ -37,6 +37,8 @@ using System.Text; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Interfaces; +// ReSharper disable UnusedParameter.Local + namespace Aaru.Core; public sealed partial class Sidecar diff --git a/Aaru.Core/Sidecar/LinearMedia.cs b/Aaru.Core/Sidecar/LinearMedia.cs index 3dbe56d1f..df6b5d84f 100644 --- a/Aaru.Core/Sidecar/LinearMedia.cs +++ b/Aaru.Core/Sidecar/LinearMedia.cs @@ -37,6 +37,8 @@ using System.Text; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Interfaces; +// ReSharper disable UnusedParameter.Local + namespace Aaru.Core; public sealed partial class Sidecar diff --git a/Aaru.Database/ContextFactory.cs b/Aaru.Database/ContextFactory.cs index de3cb5180..a80a92f2a 100644 --- a/Aaru.Database/ContextFactory.cs +++ b/Aaru.Database/ContextFactory.cs @@ -30,12 +30,14 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore.Design; namespace Aaru.Database; /// /// Database context factory, for design time +[SuppressMessage("ReSharper", "UnusedType.Global")] public class AaruContextFactory : IDesignTimeDbContextFactory { #region IDesignTimeDbContextFactory Members diff --git a/Aaru.Decoders b/Aaru.Decoders index acbc11af9..bb23889fd 160000 --- a/Aaru.Decoders +++ b/Aaru.Decoders @@ -1 +1 @@ -Subproject commit acbc11af95f09d28f277650cad868dea5d8c8050 +Subproject commit bb23889fd5298e9c0c42515ac0a3ec42405c8f4d diff --git a/Aaru.Decryption b/Aaru.Decryption index 7786e94ee..a85f1ce49 160000 --- a/Aaru.Decryption +++ b/Aaru.Decryption @@ -1 +1 @@ -Subproject commit 7786e94ee52c8f65802f1fc071db994ab1b88c60 +Subproject commit a85f1ce494f35c23da7feba989c20ac1d45374de diff --git a/Aaru.Devices/Device/AtaCommands/Ata28.cs b/Aaru.Devices/Device/AtaCommands/Ata28.cs index 1567f5eb5..d1d3b7f0f 100644 --- a/Aaru.Devices/Device/AtaCommands/Ata28.cs +++ b/Aaru.Devices/Device/AtaCommands/Ata28.cs @@ -34,6 +34,8 @@ using System; using Aaru.Console; using Aaru.Decoders.ATA; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; public partial class Device diff --git a/Aaru.Devices/Device/AtaCommands/AtaCHS.cs b/Aaru.Devices/Device/AtaCommands/AtaCHS.cs index 0c94b46ed..3c0038dfd 100644 --- a/Aaru.Devices/Device/AtaCommands/AtaCHS.cs +++ b/Aaru.Devices/Device/AtaCommands/AtaCHS.cs @@ -31,11 +31,16 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using Aaru.Console; using Aaru.Decoders.ATA; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; +[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")] +[SuppressMessage("ReSharper", "OutParameterValueIsAlwaysDiscarded.Global")] public partial class Device { /// Sends the ATA IDENTIFY DEVICE command to the device, using default device timeout diff --git a/Aaru.Devices/Device/AtaCommands/MCPT.cs b/Aaru.Devices/Device/AtaCommands/MCPT.cs index cbc59592e..f7e614c5e 100644 --- a/Aaru.Devices/Device/AtaCommands/MCPT.cs +++ b/Aaru.Devices/Device/AtaCommands/MCPT.cs @@ -31,11 +31,17 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using Aaru.Console; using Aaru.Decoders.ATA; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; +[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")] +[SuppressMessage("ReSharper", "OutParameterValueIsAlwaysDiscarded.Global")] +[SuppressMessage("ReSharper", "MemberCanBeInternal")] public partial class Device { /// Enables media card pass through diff --git a/Aaru.Devices/Device/MmcCommands/MMC.cs b/Aaru.Devices/Device/MmcCommands/MMC.cs index 16cb6fcec..4ece875ed 100644 --- a/Aaru.Devices/Device/MmcCommands/MMC.cs +++ b/Aaru.Devices/Device/MmcCommands/MMC.cs @@ -33,6 +33,8 @@ using System; using Aaru.Console; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; public partial class Device diff --git a/Aaru.Devices/Device/ScsiCommands/Adaptec.cs b/Aaru.Devices/Device/ScsiCommands/Adaptec.cs index 5c5019274..7d34a1273 100644 --- a/Aaru.Devices/Device/ScsiCommands/Adaptec.cs +++ b/Aaru.Devices/Device/ScsiCommands/Adaptec.cs @@ -34,6 +34,8 @@ using System; using Aaru.Console; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; public partial class Device diff --git a/Aaru.Devices/Device/ScsiCommands/ArchiveCorp.cs b/Aaru.Devices/Device/ScsiCommands/ArchiveCorp.cs index d1fc44c89..3df1f6a27 100644 --- a/Aaru.Devices/Device/ScsiCommands/ArchiveCorp.cs +++ b/Aaru.Devices/Device/ScsiCommands/ArchiveCorp.cs @@ -33,6 +33,8 @@ using System; using Aaru.Console; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; public partial class Device diff --git a/Aaru.Devices/Device/ScsiCommands/HP.cs b/Aaru.Devices/Device/ScsiCommands/HP.cs index 8a7b2d532..ec05f8c00 100644 --- a/Aaru.Devices/Device/ScsiCommands/HP.cs +++ b/Aaru.Devices/Device/ScsiCommands/HP.cs @@ -32,6 +32,8 @@ using Aaru.Console; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; public partial class Device diff --git a/Aaru.Devices/Device/ScsiCommands/MMC.cs b/Aaru.Devices/Device/ScsiCommands/MMC.cs index f7d2c0717..2e917ea2a 100644 --- a/Aaru.Devices/Device/ScsiCommands/MMC.cs +++ b/Aaru.Devices/Device/ScsiCommands/MMC.cs @@ -35,8 +35,11 @@ using System.Diagnostics.CodeAnalysis; using System.Text; using Aaru.Console; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; +[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")] public partial class Device { /// Sends the MMC GET CONFIGURATION command for all Features diff --git a/Aaru.Devices/Device/ScsiCommands/MiniDisc.cs b/Aaru.Devices/Device/ScsiCommands/MiniDisc.cs index f9cbf4be3..9ac56bcf9 100644 --- a/Aaru.Devices/Device/ScsiCommands/MiniDisc.cs +++ b/Aaru.Devices/Device/ScsiCommands/MiniDisc.cs @@ -35,6 +35,8 @@ using System; using Aaru.Console; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; public partial class Device diff --git a/Aaru.Devices/Device/ScsiCommands/Plasmon.cs b/Aaru.Devices/Device/ScsiCommands/Plasmon.cs index 61360ac14..b7769d383 100644 --- a/Aaru.Devices/Device/ScsiCommands/Plasmon.cs +++ b/Aaru.Devices/Device/ScsiCommands/Plasmon.cs @@ -32,6 +32,8 @@ using Aaru.Console; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; public partial class Device diff --git a/Aaru.Devices/Device/ScsiCommands/SPC.cs b/Aaru.Devices/Device/ScsiCommands/SPC.cs index f7ea7bdb4..1a230527f 100644 --- a/Aaru.Devices/Device/ScsiCommands/SPC.cs +++ b/Aaru.Devices/Device/ScsiCommands/SPC.cs @@ -35,9 +35,12 @@ using System.Diagnostics.CodeAnalysis; using Aaru.Console; using PlatformID = Aaru.CommonTypes.Interop.PlatformID; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")] +[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")] public partial class Device { /// Sends the SPC INQUIRY command to the device using default device timeout. diff --git a/Aaru.Devices/Device/ScsiCommands/SSC.cs b/Aaru.Devices/Device/ScsiCommands/SSC.cs index 9feb2d709..244c33432 100644 --- a/Aaru.Devices/Device/ScsiCommands/SSC.cs +++ b/Aaru.Devices/Device/ScsiCommands/SSC.cs @@ -31,10 +31,14 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using Aaru.Console; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; +[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")] public partial class Device { /// Prepares the medium for reading diff --git a/Aaru.Devices/Device/ScsiCommands/SyQuest.cs b/Aaru.Devices/Device/ScsiCommands/SyQuest.cs index ef2a7ffb4..63d9b2af1 100644 --- a/Aaru.Devices/Device/ScsiCommands/SyQuest.cs +++ b/Aaru.Devices/Device/ScsiCommands/SyQuest.cs @@ -33,6 +33,8 @@ using System; using Aaru.Console; +// ReSharper disable UnusedMember.Global + namespace Aaru.Devices; public partial class Device diff --git a/Aaru.Devices/Linux/Enums.cs b/Aaru.Devices/Linux/Enums.cs index d258bb7b0..a5391e8d6 100644 --- a/Aaru.Devices/Linux/Enums.cs +++ b/Aaru.Devices/Linux/Enums.cs @@ -32,10 +32,12 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; namespace Aaru.Devices.Linux; [Flags] +[SuppressMessage("ReSharper", "UnusedMember.Global")] enum FileFlags { /// O_RDONLY @@ -89,6 +91,7 @@ enum ScsiIoctlDirection Unknown = -5 } +[SuppressMessage("ReSharper", "UnusedMember.Global")] enum LinuxIoctl : uint { // SCSI IOCtls @@ -101,6 +104,7 @@ enum LinuxIoctl : uint } [Flags] +[SuppressMessage("ReSharper", "UnusedMember.Global")] enum SgInfo : uint { /// Mask to check OK @@ -121,6 +125,7 @@ enum SgInfo : uint } [Flags] +[SuppressMessage("ReSharper", "UnusedMember.Global")] enum SgFlags : uint { DirectIo = 1, @@ -131,6 +136,7 @@ enum SgFlags : uint QAtHead = 0x20 } +[SuppressMessage("ReSharper", "UnusedMember.Global")] enum SeekWhence { Begin = 0, diff --git a/Aaru.Devices/Linux/Extern.cs b/Aaru.Devices/Linux/Extern.cs index 0abc0be3d..c6d0d7e07 100644 --- a/Aaru.Devices/Linux/Extern.cs +++ b/Aaru.Devices/Linux/Extern.cs @@ -43,9 +43,6 @@ static class Extern [DllImport("libc")] internal static extern int close(int fd); - [DllImport("libc", EntryPoint = "ioctl", SetLastError = true)] - internal static extern int ioctlInt(int fd, LinuxIoctl request, out int value); - [DllImport("libc", EntryPoint = "ioctl", SetLastError = true)] internal static extern int ioctlSg(int fd, LinuxIoctl request, ref SgIoHdrT value); diff --git a/Aaru.Devices/Remote/Device.cs b/Aaru.Devices/Remote/Device.cs index 0ec188cd4..6bc8c9dbf 100644 --- a/Aaru.Devices/Remote/Device.cs +++ b/Aaru.Devices/Remote/Device.cs @@ -59,6 +59,7 @@ public sealed partial class Device : Devices.Device } /// Current device is remote + // ReSharper disable once UnusedMember.Global public bool IsRemote => _remote != null; /// Remote application diff --git a/Aaru.Devices/Remote/Enums.cs b/Aaru.Devices/Remote/Enums.cs index 843b70815..26e78a12c 100644 --- a/Aaru.Devices/Remote/Enums.cs +++ b/Aaru.Devices/Remote/Enums.cs @@ -30,6 +30,8 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; + namespace Aaru.Devices.Remote; /// Packet type enumeration @@ -73,6 +75,7 @@ public enum AaruPacketType : sbyte } /// Reasons for non-data request or response +[SuppressMessage("ReSharper", "UnusedMember.Global")] public enum AaruNopReason : byte { /// Request or response has arrived unexpectedly diff --git a/Aaru.Devices/Windows/Extern.cs b/Aaru.Devices/Windows/Extern.cs index 3f58c8dda..ed1e942bc 100644 --- a/Aaru.Devices/Windows/Extern.cs +++ b/Aaru.Devices/Windows/Extern.cs @@ -32,11 +32,13 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using System.Runtime.InteropServices; using Microsoft.Win32.SafeHandles; namespace Aaru.Devices.Windows; +[SuppressMessage("ReSharper", "UnusedMember.Global")] static class Extern { [DllImport("kernel32.dll", CharSet = CharSet.Auto, SetLastError = true)] diff --git a/Aaru.Devices/Windows/Structs.cs b/Aaru.Devices/Windows/Structs.cs index 97d1a5182..b089354d6 100644 --- a/Aaru.Devices/Windows/Structs.cs +++ b/Aaru.Devices/Windows/Structs.cs @@ -155,6 +155,7 @@ struct StoragePropertyQuery [StructLayout(LayoutKind.Sequential)] [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")] +[SuppressMessage("ReSharper", "UnusedType.Global")] struct StorageDescriptorHeader { public uint Version; @@ -206,6 +207,7 @@ struct StorageDeviceNumber [StructLayout(LayoutKind.Sequential)] [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")] +[SuppressMessage("ReSharper", "UnusedType.Global")] struct DeviceInfoData { public int cbSize; @@ -237,6 +239,7 @@ struct UsbSetupPacket [StructLayout(LayoutKind.Sequential)] [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")] +[SuppressMessage("ReSharper", "UnusedType.Global")] struct UsbDescriptorRequest { public int ConnectionIndex; diff --git a/Aaru.Devices/Windows/Usb.cs b/Aaru.Devices/Windows/Usb.cs index 6bc8c1682..c8692b035 100644 --- a/Aaru.Devices/Windows/Usb.cs +++ b/Aaru.Devices/Windows/Usb.cs @@ -44,6 +44,7 @@ namespace Aaru.Devices.Windows; /// Implements functions for getting and accessing information from the USB bus [SuppressMessage("ReSharper", "UnusedMember.Local")] [SuppressMessage("ReSharper", "UnusedType.Local")] +[SuppressMessage("ReSharper", "UnusedMember.Global")] static partial class Usb { /// Return a list of USB Host Controllers diff --git a/Aaru.Devices/Windows/UsbFunctions.cs b/Aaru.Devices/Windows/UsbFunctions.cs index 293cf3149..5edc9a85c 100644 --- a/Aaru.Devices/Windows/UsbFunctions.cs +++ b/Aaru.Devices/Windows/UsbFunctions.cs @@ -33,6 +33,7 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.Runtime.InteropServices; namespace Aaru.Devices.Windows; @@ -43,6 +44,7 @@ namespace Aaru.Devices.Windows; // // TODO: Even after cleaning, refactoring and xml-documenting, this code needs some love /// Implements functions for getting and accessing information from the USB bus +[SuppressMessage("ReSharper", "UnusedMember.Global")] static partial class Usb { const int IOCTL_STORAGE_GET_DEVICE_NUMBER = 0x2D1080; diff --git a/Aaru.Dto b/Aaru.Dto index 6c69fe747..c601f821b 160000 --- a/Aaru.Dto +++ b/Aaru.Dto @@ -1 +1 @@ -Subproject commit 6c69fe747a99ce4b023cdd0922a26820a6751660 +Subproject commit c601f821b020b10310cbe8d53306909c20dc8485 diff --git a/Aaru.Filesystems/AppleCommon/Enums.cs b/Aaru.Filesystems/AppleCommon/Enums.cs index d9228e067..57e5d29dc 100644 --- a/Aaru.Filesystems/AppleCommon/Enums.cs +++ b/Aaru.Filesystems/AppleCommon/Enums.cs @@ -30,6 +30,8 @@ using System; +// ReSharper disable UnusedMember.Global + namespace Aaru.Filesystems; // Information from Inside Macintosh diff --git a/Aaru.Filesystems/HPOFS/Consts.cs b/Aaru.Filesystems/HPOFS/Consts.cs index 1f3f5d6aa..c024d3fc8 100644 --- a/Aaru.Filesystems/HPOFS/Consts.cs +++ b/Aaru.Filesystems/HPOFS/Consts.cs @@ -26,6 +26,8 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +// ReSharper disable UnusedMember.Local + namespace Aaru.Filesystems; public sealed partial class HPOFS diff --git a/Aaru.Filesystems/ISO9660/Consts/AAIP.cs b/Aaru.Filesystems/ISO9660/Consts/AAIP.cs index eb34f9025..68bb996db 100644 --- a/Aaru.Filesystems/ISO9660/Consts/AAIP.cs +++ b/Aaru.Filesystems/ISO9660/Consts/AAIP.cs @@ -31,6 +31,8 @@ using System; +// ReSharper disable UnusedType.Local + namespace Aaru.Filesystems; public sealed partial class ISO9660 diff --git a/Aaru.Filesystems/ProDOS/Structs.cs b/Aaru.Filesystems/ProDOS/Structs.cs index 356e6e6b6..fb50ea82e 100644 --- a/Aaru.Filesystems/ProDOS/Structs.cs +++ b/Aaru.Filesystems/ProDOS/Structs.cs @@ -31,6 +31,8 @@ using System; using System.Diagnostics.CodeAnalysis; +#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value + namespace Aaru.Filesystems; // Information from Apple ProDOS 8 Technical Reference @@ -38,11 +40,11 @@ namespace Aaru.Filesystems; /// Implements detection of Apple ProDOS filesystem [SuppressMessage("ReSharper", "UnusedMember.Local")] [SuppressMessage("ReSharper", "UnusedType.Local")] +[SuppressMessage("ReSharper", "InconsistentNaming")] public sealed partial class ProDOSPlugin { #region Nested type: DirectoryBlock - [SuppressMessage("ReSharper", "InconsistentNaming")] struct DirectoryBlock { /// Pointer to previous directory block Offset 0x00, 2 bytes @@ -57,7 +59,6 @@ public sealed partial class ProDOSPlugin #region Nested type: DirectoryHeader - [SuppressMessage("ReSharper", "InconsistentNaming")] struct DirectoryHeader { /// Constant 0x0E Offset 0x04, mask 0xF0 @@ -94,7 +95,6 @@ public sealed partial class ProDOSPlugin #region Nested type: DirectoryKeyBlock - [SuppressMessage("ReSharper", "InconsistentNaming")] struct DirectoryKeyBlock { /// Always 0 Offset 0x00, 2 bytes @@ -112,7 +112,6 @@ public sealed partial class ProDOSPlugin #region Nested type: Entry /// ProDOS directory entry, decoded structure - [SuppressMessage("ReSharper", "InconsistentNaming")] struct Entry { /// Type of file pointed by this entry Offset 0x00, mask 0xF0 @@ -152,7 +151,6 @@ public sealed partial class ProDOSPlugin #region Nested type: IndexBlock - [SuppressMessage("ReSharper", "InconsistentNaming")] struct IndexBlock { /// Up to 256 pointers to blocks, 0 to indicate the block is sparsed (non-allocated) @@ -163,7 +161,6 @@ public sealed partial class ProDOSPlugin #region Nested type: MasterIndexBlock - [SuppressMessage("ReSharper", "InconsistentNaming")] struct MasterIndexBlock { /// Up to 128 pointers to index blocks @@ -174,7 +171,6 @@ public sealed partial class ProDOSPlugin #region Nested type: RootDirectoryHeader - [SuppressMessage("ReSharper", "InconsistentNaming")] struct RootDirectoryHeader { /// Constant 0x0F Offset 0x04, mask 0xF0 @@ -212,7 +208,6 @@ public sealed partial class ProDOSPlugin #region Nested type: RootDirectoryKeyBlock - [SuppressMessage("ReSharper", "InconsistentNaming")] struct RootDirectoryKeyBlock { /// Always 0 Offset 0x00, 2 bytes diff --git a/Aaru.Filesystems/QNX4/QNX4.cs b/Aaru.Filesystems/QNX4/QNX4.cs index d05cbd81b..1f13671f2 100644 --- a/Aaru.Filesystems/QNX4/QNX4.cs +++ b/Aaru.Filesystems/QNX4/QNX4.cs @@ -37,6 +37,7 @@ namespace Aaru.Filesystems; [SuppressMessage("ReSharper", "UnusedType.Local")] public sealed partial class QNX4 : IFilesystem { + // ReSharper disable once UnusedMember.Local const string MODULE_NAME = "QNX4 plugin"; #region IFilesystem Members diff --git a/Aaru.Filesystems/QNX4/Structs.cs b/Aaru.Filesystems/QNX4/Structs.cs index 75da2ce1b..8793c84b7 100644 --- a/Aaru.Filesystems/QNX4/Structs.cs +++ b/Aaru.Filesystems/QNX4/Structs.cs @@ -38,11 +38,13 @@ public sealed partial class QNX4 { #region Nested type: Extent +#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value struct Extent { public uint Block; public uint Length; } +#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value #endregion diff --git a/Aaru.Filesystems/ZFS/Helpers.cs b/Aaru.Filesystems/ZFS/Helpers.cs index 19b6584a3..6d3ae298e 100644 --- a/Aaru.Filesystems/ZFS/Helpers.cs +++ b/Aaru.Filesystems/ZFS/Helpers.cs @@ -72,6 +72,7 @@ public sealed partial class ZFS } // TODO: Decode native nvlist + // ReSharper disable once UnusedParameter.Local static bool DecodeNvList(byte[] nvlist, out Dictionary decodedNvList, bool xdr, bool littleEndian) { decodedNvList = new Dictionary(); diff --git a/Aaru.Filesystems/ZFS/Structs.cs b/Aaru.Filesystems/ZFS/Structs.cs index 02b4faa9c..5acdbe14f 100644 --- a/Aaru.Filesystems/ZFS/Structs.cs +++ b/Aaru.Filesystems/ZFS/Structs.cs @@ -158,11 +158,13 @@ public sealed partial class ZFS #region Nested type: ZIO_Checksum +#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value struct ZIO_Checksum { [MarshalAs(UnmanagedType.ByValArray, SizeConst = 4)] public ulong[] word; } +#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value #endregion diff --git a/Aaru.Filters/OffsetStream.cs b/Aaru.Filters/OffsetStream.cs index 03ca9790d..41f4e12c2 100644 --- a/Aaru.Filters/OffsetStream.cs +++ b/Aaru.Filters/OffsetStream.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.Helpers; using Microsoft.Win32.SafeHandles; @@ -42,6 +43,7 @@ namespace Aaru.Filters; /// Creates a stream that is a subset of another stream. /// +[SuppressMessage("ReSharper", "UnusedMember.Global")] public sealed class OffsetStream : Stream { readonly Stream _baseStream; diff --git a/Aaru.Filters/SplitJoinStream.cs b/Aaru.Filters/SplitJoinStream.cs index 866da5f2d..6eb197208 100644 --- a/Aaru.Filters/SplitJoinStream.cs +++ b/Aaru.Filters/SplitJoinStream.cs @@ -1,6 +1,7 @@ using System; using System.Collections.Generic; using System.Data; +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using Aaru.CommonTypes.Interfaces; @@ -10,6 +11,7 @@ namespace Aaru.Filters; /// /// Implements a stream that joins two or more files (sequentially) as a single stream +[SuppressMessage("ReSharper", "UnusedMember.Global")] public class SplitJoinStream : Stream { readonly Dictionary _baseStreams; diff --git a/Aaru.Gui/ConsoleHandler.cs b/Aaru.Gui/ConsoleHandler.cs index d014e6be5..ad001a323 100644 --- a/Aaru.Gui/ConsoleHandler.cs +++ b/Aaru.Gui/ConsoleHandler.cs @@ -46,7 +46,6 @@ static class ConsoleHandler public static bool Debug { - get => _debug; set { if(_debug == value) @@ -61,23 +60,6 @@ static class ConsoleHandler } } - public static bool Verbose - { - get => _verbose; - set - { - if(_verbose == value) - return; - - _verbose = value; - - if(_verbose) - AaruConsole.VerboseWriteLineEvent += OnVerboseWriteHandler; - else - AaruConsole.VerboseWriteLineEvent -= OnVerboseWriteHandler; - } - } - public static ObservableCollection Entries { get; } = new(); internal static void Init() @@ -114,20 +96,6 @@ static class ConsoleHandler }); } - static void OnVerboseWriteHandler([CanBeNull] string format, [CanBeNull] params object[] arg) - { - if(format == null || arg == null) - return; - - Entries.Add(new LogEntry - { - Message = string.Format(format, arg), - Module = null, - Timestamp = DateTime.Now, - Type = "Verbose" - }); - } - static void OnDebugWriteHandler(string module, [CanBeNull] string format, [CanBeNull] params object[] arg) { if(format == null || arg == null) diff --git a/Aaru.Gui/ResourceHandler.cs b/Aaru.Gui/ResourceHandler.cs deleted file mode 100644 index ae8001c18..000000000 --- a/Aaru.Gui/ResourceHandler.cs +++ /dev/null @@ -1,44 +0,0 @@ -// /*************************************************************************** -// Aaru Data Preservation Suite -// ---------------------------------------------------------------------------- -// -// Filename : ResourceHandler.cs -// Author(s) : Natalia Portillo -// -// Component : Aaru GUI. -// -// --[ Description ] ---------------------------------------------------------- -// -// Handles embedded resources. -// -// --[ License ] -------------------------------------------------------------- -// -// This program is free software: you can redistribute it and/or modify -// it under the terms of the GNU General public License as -// published by the Free Software Foundation, either version 3 of the -// License, or (at your option) any later version. -// -// This program is distributed in the hope that it will be useful, -// but WITHOUT ANY WARRANTY; without even the implied warranty of -// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -// GNU General public License for more details. -// -// You should have received a copy of the GNU General public License -// along with this program. If not, see . -// -// ---------------------------------------------------------------------------- -// Copyright © 2011-2023 Natalia Portillo -// ****************************************************************************/ - -using System.IO; -using System.Reflection; -using JetBrains.Annotations; - -namespace Aaru.Gui; - -static class ResourceHandler -{ - [CanBeNull] - internal static Stream GetResourceStream([NotNull] string resourcePath) => - Assembly.GetExecutingAssembly().GetManifestResourceStream(resourcePath); -} \ No newline at end of file diff --git a/Aaru.Gui/ViewLocator.cs b/Aaru.Gui/ViewLocator.cs index 22399104e..e75fdfd8a 100644 --- a/Aaru.Gui/ViewLocator.cs +++ b/Aaru.Gui/ViewLocator.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using Aaru.Gui.ViewModels; using Avalonia.Controls; using Avalonia.Markup.Xaml.Templates; @@ -38,12 +39,14 @@ using JetBrains.Annotations; namespace Aaru.Gui; +[SuppressMessage("ReSharper", "UnusedMember.Global")] +[SuppressMessage("ReSharper", "UnusedMember.Global")] public sealed class ViewLocator : DataTemplate { public bool SupportsRecycling => false; [CanBeNull] - public Control Build([NotNull] object data) + public Control Build([JetBrains.Annotations.NotNull] object data) { string name = data.GetType().FullName?.Replace("ViewModel", "View"); diff --git a/Aaru.Gui/ViewModels/Panels/ImageInfoViewModel.cs b/Aaru.Gui/ViewModels/Panels/ImageInfoViewModel.cs index bfab4109d..cec51404b 100644 --- a/Aaru.Gui/ViewModels/Panels/ImageInfoViewModel.cs +++ b/Aaru.Gui/ViewModels/Panels/ImageInfoViewModel.cs @@ -446,8 +446,8 @@ public sealed class ImageInfoViewModel : ViewModelBase DvdInfo = new DvdInfo { - DataContext = new DvdInfoViewModel(imageFormat.Info.MediaType, dvdPfi, dvdDmi, dvdCmi, - hddvdCopyrightInformation, dvdBca, null, decodedPfi, view) + DataContext = new DvdInfoViewModel(dvdPfi, dvdDmi, dvdCmi, hddvdCopyrightInformation, dvdBca, null, + decodedPfi, view) }; byte[] dvdRamDds = null; @@ -509,12 +509,12 @@ public sealed class ImageInfoViewModel : ViewModelBase DvdWritableInfo = new DvdWritableInfo { - DataContext = new DvdWritableInfoViewModel(imageFormat.Info.MediaType, dvdRamDds, dvdRamCartridgeStatus, - dvdRamSpareArea, lastBorderOutRmd, dvdPreRecordedInfo, - dvdrMediaIdentifier, dvdrPhysicalInformation, hddvdrMediumStatus, - null, dvdrLayerCapacity, dvdrDlMiddleZoneStart, - dvdrDlJumpIntervalSize, dvdrDlManualLayerJumpStartLba, null, - dvdPlusAdip, dvdPlusDcb, view) + DataContext = new DvdWritableInfoViewModel(dvdRamDds, dvdRamCartridgeStatus, dvdRamSpareArea, + lastBorderOutRmd, dvdPreRecordedInfo, dvdrMediaIdentifier, + dvdrPhysicalInformation, hddvdrMediumStatus, null, + dvdrLayerCapacity, dvdrDlMiddleZoneStart, dvdrDlJumpIntervalSize, + dvdrDlManualLayerJumpStartLba, null, dvdPlusAdip, dvdPlusDcb, + view) }; byte[] blurayBurstCuttingArea = null; diff --git a/Aaru.Gui/ViewModels/Panels/MediaInfoViewModel.cs b/Aaru.Gui/ViewModels/Panels/MediaInfoViewModel.cs index 941fd746e..6d3c51b36 100644 --- a/Aaru.Gui/ViewModels/Panels/MediaInfoViewModel.cs +++ b/Aaru.Gui/ViewModels/Panels/MediaInfoViewModel.cs @@ -154,7 +154,7 @@ public sealed class MediaInfoViewModel : ViewModelBase DvdInfo = new DvdInfo { - DataContext = new DvdInfoViewModel(scsiInfo.MediaType, scsiInfo.DvdPfi, scsiInfo.DvdDmi, scsiInfo.DvdCmi, + DataContext = new DvdInfoViewModel(scsiInfo.DvdPfi, scsiInfo.DvdDmi, scsiInfo.DvdCmi, scsiInfo.HddvdCopyrightInformation, scsiInfo.DvdBca, scsiInfo.DvdAacs, scsiInfo.DecodedPfi, _view) }; @@ -167,13 +167,12 @@ public sealed class MediaInfoViewModel : ViewModelBase DvdWritableInfo = new DvdWritableInfo { - DataContext = new DvdWritableInfoViewModel(scsiInfo.MediaType, scsiInfo.DvdRamDds, - scsiInfo.DvdRamCartridgeStatus, scsiInfo.DvdRamSpareArea, - scsiInfo.LastBorderOutRmd, scsiInfo.DvdPreRecordedInfo, - scsiInfo.DvdrMediaIdentifier, scsiInfo.DvdrPhysicalInformation, - scsiInfo.HddvdrMediumStatus, scsiInfo.HddvdrLastRmd, - scsiInfo.DvdrLayerCapacity, scsiInfo.DvdrDlMiddleZoneStart, - scsiInfo.DvdrDlJumpIntervalSize, + DataContext = new DvdWritableInfoViewModel(scsiInfo.DvdRamDds, scsiInfo.DvdRamCartridgeStatus, + scsiInfo.DvdRamSpareArea, scsiInfo.LastBorderOutRmd, + scsiInfo.DvdPreRecordedInfo, scsiInfo.DvdrMediaIdentifier, + scsiInfo.DvdrPhysicalInformation, scsiInfo.HddvdrMediumStatus, + scsiInfo.HddvdrLastRmd, scsiInfo.DvdrLayerCapacity, + scsiInfo.DvdrDlMiddleZoneStart, scsiInfo.DvdrDlJumpIntervalSize, scsiInfo.DvdrDlManualLayerJumpStartLba, scsiInfo.DvdrDlRemapAnchorPoint, scsiInfo.DvdPlusAdip, scsiInfo.DvdPlusDcb, _view) diff --git a/Aaru.Gui/ViewModels/Tabs/DvdInfoViewModel.cs b/Aaru.Gui/ViewModels/Tabs/DvdInfoViewModel.cs index ebaebb7ad..fa1ac6e34 100644 --- a/Aaru.Gui/ViewModels/Tabs/DvdInfoViewModel.cs +++ b/Aaru.Gui/ViewModels/Tabs/DvdInfoViewModel.cs @@ -34,7 +34,6 @@ using System.Collections.Generic; using System.IO; using System.Reactive; using System.Threading.Tasks; -using Aaru.CommonTypes; using Aaru.Decoders.DVD; using Aaru.Localization; using Avalonia.Controls; @@ -53,7 +52,7 @@ public sealed class DvdInfoViewModel readonly byte[] _hddvdCopyrightInformation; readonly Window _view; - public DvdInfoViewModel(MediaType mediaType, [CanBeNull] byte[] pfi, [CanBeNull] byte[] dmi, [CanBeNull] byte[] cmi, + public DvdInfoViewModel([CanBeNull] byte[] pfi, [CanBeNull] byte[] dmi, [CanBeNull] byte[] cmi, [CanBeNull] byte[] hdCopyrightInformation, [CanBeNull] byte[] bca, [CanBeNull] byte[] aacs, PFI.PhysicalFormatInformation? decodedPfi, Window view) { diff --git a/Aaru.Gui/ViewModels/Tabs/DvdWritableInfoViewModel.cs b/Aaru.Gui/ViewModels/Tabs/DvdWritableInfoViewModel.cs index da7299b44..e3e921b65 100644 --- a/Aaru.Gui/ViewModels/Tabs/DvdWritableInfoViewModel.cs +++ b/Aaru.Gui/ViewModels/Tabs/DvdWritableInfoViewModel.cs @@ -34,7 +34,6 @@ using System.Collections.Generic; using System.IO; using System.Reactive; using System.Threading.Tasks; -using Aaru.CommonTypes; using Aaru.Decoders.DVD; using Aaru.Localization; using Avalonia.Controls; @@ -62,12 +61,11 @@ public sealed class DvdWritableInfoViewModel readonly byte[] _hddvdrMediumStatus; readonly Window _view; - public DvdWritableInfoViewModel(MediaType mediaType, byte[] dds, byte[] cartridgeStatus, byte[] spareArea, - byte[] lastBorderOutRmd, byte[] preRecordedInfo, byte[] mediaIdentifier, - byte[] physicalInformation, byte[] mediumStatus, byte[] hdLastRmd, - byte[] layerCapacity, byte[] middleZoneStart, byte[] jumpIntervalSize, - byte[] manualLayerJumpStartLba, byte[] remapAnchorPoint, byte[] adip, byte[] dcb, - Window view) + public DvdWritableInfoViewModel(byte[] dds, byte[] cartridgeStatus, byte[] spareArea, byte[] lastBorderOutRmd, + byte[] preRecordedInfo, byte[] mediaIdentifier, byte[] physicalInformation, + byte[] mediumStatus, byte[] hdLastRmd, byte[] layerCapacity, byte[] middleZoneStart, + byte[] jumpIntervalSize, byte[] manualLayerJumpStartLba, byte[] remapAnchorPoint, + byte[] adip, byte[] dcb, Window view) { _view = view; SaveDvdRamDdsCommand = ReactiveCommand.Create(ExecuteSaveDvdRamDdsCommand); diff --git a/Aaru.Helpers b/Aaru.Helpers index e59bc3822..a03ee5efe 160000 --- a/Aaru.Helpers +++ b/Aaru.Helpers @@ -1 +1 @@ -Subproject commit e59bc38221d3ee973fc4b991234d959182f6e502 +Subproject commit a03ee5efee746bfd60689fa28da759aabe14ba06 diff --git a/Aaru.Images/A2R/A2R.cs b/Aaru.Images/A2R/A2R.cs index 820ba41bc..66517534a 100644 --- a/Aaru.Images/A2R/A2R.cs +++ b/Aaru.Images/A2R/A2R.cs @@ -34,6 +34,7 @@ // Version 3 documentation: https://web.archive.org/web/20220526215820/https://applesaucefdc.com/a2r/ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Interfaces; @@ -43,6 +44,7 @@ namespace Aaru.DiscImages; /// /// Implements reading A2R flux images +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class A2R : IFluxImage, IMediaImage, IWritableImage, IWritableFluxImage { const string MODULE_NAME = "A2R plugin"; diff --git a/Aaru.Images/A2R/Constants.cs b/Aaru.Images/A2R/Constants.cs index ba174c019..067c44349 100644 --- a/Aaru.Images/A2R/Constants.cs +++ b/Aaru.Images/A2R/Constants.cs @@ -30,8 +30,11 @@ // Copyright © 2011-2023 Rebecca Wallander // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; + namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class A2R { readonly byte[] _a2rV2Signature = diff --git a/Aaru.Images/A2R/Enums.cs b/Aaru.Images/A2R/Enums.cs index 7b3e7e617..3656b04d0 100644 --- a/Aaru.Images/A2R/Enums.cs +++ b/Aaru.Images/A2R/Enums.cs @@ -34,6 +34,7 @@ using System.Diagnostics.CodeAnalysis; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class A2R { #region A2rDiskType enum diff --git a/Aaru.Images/A2R/Helpers.cs b/Aaru.Images/A2R/Helpers.cs index 32b1f703a..6f81274b4 100644 --- a/Aaru.Images/A2R/Helpers.cs +++ b/Aaru.Images/A2R/Helpers.cs @@ -32,11 +32,13 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.Linq; using Aaru.CommonTypes; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class A2R { /// @@ -111,10 +113,12 @@ public sealed partial class A2R uint over = ticks / 255; if(over == 0) + { return new[] { (byte)ticks }; + } var expanded = new byte[over + 1]; diff --git a/Aaru.Images/A2R/Identify.cs b/Aaru.Images/A2R/Identify.cs index 57f2501a3..d85e6c7f7 100644 --- a/Aaru.Images/A2R/Identify.cs +++ b/Aaru.Images/A2R/Identify.cs @@ -30,6 +30,7 @@ // Copyright © 2011-2023 Rebecca Wallander // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using Aaru.CommonTypes.Interfaces; @@ -37,6 +38,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class A2R { #region IFluxImage Members diff --git a/Aaru.Images/A2R/Properties.cs b/Aaru.Images/A2R/Properties.cs index 7fc4b8f21..8d8a804e2 100644 --- a/Aaru.Images/A2R/Properties.cs +++ b/Aaru.Images/A2R/Properties.cs @@ -32,6 +32,7 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Enums; @@ -39,6 +40,7 @@ using Aaru.CommonTypes.Structs; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class A2R { bool IsWritingRwcps { get; set; } diff --git a/Aaru.Images/A2R/Read.cs b/Aaru.Images/A2R/Read.cs index 532a9990f..4bc98f909 100644 --- a/Aaru.Images/A2R/Read.cs +++ b/Aaru.Images/A2R/Read.cs @@ -32,6 +32,7 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using System.Text; @@ -43,6 +44,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class A2R { #region IFluxImage Members diff --git a/Aaru.Images/A2R/Structs.cs b/Aaru.Images/A2R/Structs.cs index fcb53c60b..ca477ef6a 100644 --- a/Aaru.Images/A2R/Structs.cs +++ b/Aaru.Images/A2R/Structs.cs @@ -30,10 +30,12 @@ // Copyright © 2011-2023 Rebecca Wallander // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using System.Runtime.InteropServices; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class A2R { #region Nested type: A2rHeader diff --git a/Aaru.Images/A2R/Write.cs b/Aaru.Images/A2R/Write.cs index b07a98f71..794cc7dd6 100644 --- a/Aaru.Images/A2R/Write.cs +++ b/Aaru.Images/A2R/Write.cs @@ -32,6 +32,7 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using System.Text; @@ -43,6 +44,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class A2R { #region IWritableFluxImage Members diff --git a/Aaru.Images/Aaru.Images.csproj.DotSettings b/Aaru.Images/Aaru.Images.csproj.DotSettings index e639e22d9..de67c95e9 100644 --- a/Aaru.Images/Aaru.Images.csproj.DotSettings +++ b/Aaru.Images/Aaru.Images.csproj.DotSettings @@ -1,93 +1,62 @@  - True + xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation" + xml:space="preserve"> + True + True True - True + True True True True True True True - True - True - True - True - True - True - True - True + True + True + True + True + True + True + True + True True - True - True - True - True + True + True + True + True True True True True True - True - True - True + True + True + True True - True + True True - True - True - True + True + True + True True True True - True - True - True - True - True + True + True + True + True + True True - True - True + True + True True - True - True - True - True - True + True + True + True + True + True True - True + True True True \ No newline at end of file diff --git a/Aaru.Images/BLU/BLU.cs b/Aaru.Images/BLU/BLU.cs index 9791e45c6..f83d74e71 100644 --- a/Aaru.Images/BLU/BLU.cs +++ b/Aaru.Images/BLU/BLU.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Interfaces; @@ -40,6 +41,7 @@ namespace Aaru.DiscImages; /// /// Implements reading Basic Lisa Utility disk images +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Blu : IWritableImage, IVerifiableSectorsImage { const string MODULE_NAME = "BLU plugin"; diff --git a/Aaru.Images/BLU/Constants.cs b/Aaru.Images/BLU/Constants.cs index 701ce5e0c..857ebdfdb 100644 --- a/Aaru.Images/BLU/Constants.cs +++ b/Aaru.Images/BLU/Constants.cs @@ -30,8 +30,11 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; + namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Blu { const string PROFILE_NAME = "PROFILE "; diff --git a/Aaru.Images/BLU/Identify.cs b/Aaru.Images/BLU/Identify.cs index e8159e6bd..b3e6eb336 100644 --- a/Aaru.Images/BLU/Identify.cs +++ b/Aaru.Images/BLU/Identify.cs @@ -31,12 +31,14 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Blu { #region IWritableImage Members diff --git a/Aaru.Images/BLU/Properties.cs b/Aaru.Images/BLU/Properties.cs index 0048997fb..bf6e4c46e 100644 --- a/Aaru.Images/BLU/Properties.cs +++ b/Aaru.Images/BLU/Properties.cs @@ -32,6 +32,7 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Enums; @@ -39,6 +40,7 @@ using Aaru.CommonTypes.Structs; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Blu { #region IWritableImage Members diff --git a/Aaru.Images/BLU/Read.cs b/Aaru.Images/BLU/Read.cs index 788960df6..e8329ec2c 100644 --- a/Aaru.Images/BLU/Read.cs +++ b/Aaru.Images/BLU/Read.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Enums; @@ -40,6 +41,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Blu { #region IWritableImage Members diff --git a/Aaru.Images/BLU/Unsupported.cs b/Aaru.Images/BLU/Unsupported.cs index 1a0262bbb..2dbf488dc 100644 --- a/Aaru.Images/BLU/Unsupported.cs +++ b/Aaru.Images/BLU/Unsupported.cs @@ -30,10 +30,12 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.Enums; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Blu { #region IWritableImage Members diff --git a/Aaru.Images/BLU/Verify.cs b/Aaru.Images/BLU/Verify.cs index 3bcf554c6..1b1ad2ddf 100644 --- a/Aaru.Images/BLU/Verify.cs +++ b/Aaru.Images/BLU/Verify.cs @@ -31,9 +31,11 @@ // ****************************************************************************/ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Blu { #region IVerifiableSectorsImage Members diff --git a/Aaru.Images/BLU/Write.cs b/Aaru.Images/BLU/Write.cs index 7a9479d31..b7aeffb6c 100644 --- a/Aaru.Images/BLU/Write.cs +++ b/Aaru.Images/BLU/Write.cs @@ -32,6 +32,7 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using System.Text; @@ -45,6 +46,7 @@ using Version = Aaru.CommonTypes.Interop.Version; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Blu { #region IWritableImage Members diff --git a/Aaru.Images/ByteAddressable/AtariLynx.cs b/Aaru.Images/ByteAddressable/AtariLynx.cs index 348afbbb4..2b5dad71b 100644 --- a/Aaru.Images/ByteAddressable/AtariLynx.cs +++ b/Aaru.Images/ByteAddressable/AtariLynx.cs @@ -14,6 +14,7 @@ using Marshal = Aaru.Helpers.Marshal; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class AtariLynx : IByteAddressableImage { byte[] _data; diff --git a/Aaru.Images/ByteAddressable/GameBoy.cs b/Aaru.Images/ByteAddressable/GameBoy.cs index 73b6d7ccd..8df97fe12 100644 --- a/Aaru.Images/ByteAddressable/GameBoy.cs +++ b/Aaru.Images/ByteAddressable/GameBoy.cs @@ -14,6 +14,7 @@ using Marshal = Aaru.Helpers.Marshal; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class GameBoy : IByteAddressableImage { byte[] _data; diff --git a/Aaru.Images/ByteAddressable/GameBoyAdvance.cs b/Aaru.Images/ByteAddressable/GameBoyAdvance.cs index 3fc3f5af1..5467f8177 100644 --- a/Aaru.Images/ByteAddressable/GameBoyAdvance.cs +++ b/Aaru.Images/ByteAddressable/GameBoyAdvance.cs @@ -14,6 +14,7 @@ using Marshal = Aaru.Helpers.Marshal; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class GameBoyAdvance : IByteAddressableImage { byte[] _data; diff --git a/Aaru.Images/ByteAddressable/MasterSystem.cs b/Aaru.Images/ByteAddressable/MasterSystem.cs index 85a6ec3ec..8d874e494 100644 --- a/Aaru.Images/ByteAddressable/MasterSystem.cs +++ b/Aaru.Images/ByteAddressable/MasterSystem.cs @@ -14,6 +14,7 @@ using Marshal = Aaru.Helpers.Marshal; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class MasterSystem : IByteAddressableImage { byte[] _data; diff --git a/Aaru.Images/ByteAddressable/NES.cs b/Aaru.Images/ByteAddressable/NES.cs index f4d02c39c..747585099 100644 --- a/Aaru.Images/ByteAddressable/NES.cs +++ b/Aaru.Images/ByteAddressable/NES.cs @@ -1,5 +1,6 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using System.Text; @@ -16,6 +17,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class Nes : IByteAddressableImage { int _chrLen; diff --git a/Aaru.Images/ByteAddressable/Nintendo64.cs b/Aaru.Images/ByteAddressable/Nintendo64.cs index 47c139e50..9c67f96b1 100644 --- a/Aaru.Images/ByteAddressable/Nintendo64.cs +++ b/Aaru.Images/ByteAddressable/Nintendo64.cs @@ -48,6 +48,7 @@ namespace Aaru.DiscImages; /// /// Implements support for Nintendo 64 cartridge dumps +[SuppressMessage("ReSharper", "UnusedType.Global")] public class Nintendo64 : IByteAddressableImage { byte[] _data; diff --git a/Aaru.Images/ByteAddressable/SegaMegaDrive.cs b/Aaru.Images/ByteAddressable/SegaMegaDrive.cs index 33467dc0d..af5a9ffb2 100644 --- a/Aaru.Images/ByteAddressable/SegaMegaDrive.cs +++ b/Aaru.Images/ByteAddressable/SegaMegaDrive.cs @@ -48,6 +48,7 @@ namespace Aaru.DiscImages; /// /// Implements support for Sega Mega Drive, 32X, Genesis and Pico cartridge dumps +[SuppressMessage("ReSharper", "UnusedType.Global")] public class SegaMegaDrive : IByteAddressableImage { byte[] _data; diff --git a/Aaru.Images/ByteAddressable/SuperNintendo.cs b/Aaru.Images/ByteAddressable/SuperNintendo.cs index 550231b8c..4bd272842 100644 --- a/Aaru.Images/ByteAddressable/SuperNintendo.cs +++ b/Aaru.Images/ByteAddressable/SuperNintendo.cs @@ -14,6 +14,7 @@ using Marshal = Aaru.Helpers.Marshal; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class SuperNintendo : IByteAddressableImage { byte[] _data; diff --git a/Aaru.Images/DIM/Constants.cs b/Aaru.Images/DIM/Constants.cs index 899069f66..b102f1684 100644 --- a/Aaru.Images/DIM/Constants.cs +++ b/Aaru.Images/DIM/Constants.cs @@ -30,8 +30,11 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; + namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Dim { /// Start of data sectors in disk image, should be 0x100 diff --git a/Aaru.Images/DIM/DIM.cs b/Aaru.Images/DIM/DIM.cs index d0c2b1688..d289678bb 100644 --- a/Aaru.Images/DIM/DIM.cs +++ b/Aaru.Images/DIM/DIM.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Interfaces; using Aaru.CommonTypes.Structs; @@ -40,6 +41,7 @@ namespace Aaru.DiscImages; // TODO: What are the real supported floppies for this image format? /// /// Implements reading DIM disk images +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Dim : IMediaImage { byte[] _comment; diff --git a/Aaru.Images/DIM/Enums.cs b/Aaru.Images/DIM/Enums.cs index 66c16aa98..ab68903a8 100644 --- a/Aaru.Images/DIM/Enums.cs +++ b/Aaru.Images/DIM/Enums.cs @@ -30,8 +30,11 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; + namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Dim { #region Nested type: DiskType diff --git a/Aaru.Images/DIM/Identify.cs b/Aaru.Images/DIM/Identify.cs index 1acb44b40..8c570ab37 100644 --- a/Aaru.Images/DIM/Identify.cs +++ b/Aaru.Images/DIM/Identify.cs @@ -30,6 +30,7 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using Aaru.CommonTypes.Interfaces; @@ -37,6 +38,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Dim { #region IMediaImage Members diff --git a/Aaru.Images/DIM/Properties.cs b/Aaru.Images/DIM/Properties.cs index eaa1f5b3b..1e467d71a 100644 --- a/Aaru.Images/DIM/Properties.cs +++ b/Aaru.Images/DIM/Properties.cs @@ -32,11 +32,13 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Structs; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Dim { #region IMediaImage Members diff --git a/Aaru.Images/DIM/Read.cs b/Aaru.Images/DIM/Read.cs index 77123ea63..e35bc6e0c 100644 --- a/Aaru.Images/DIM/Read.cs +++ b/Aaru.Images/DIM/Read.cs @@ -30,6 +30,7 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using System.Text; @@ -41,6 +42,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Dim { #region IMediaImage Members diff --git a/Aaru.Images/DIM/Unsupported.cs b/Aaru.Images/DIM/Unsupported.cs index ccfd22855..13d12b413 100644 --- a/Aaru.Images/DIM/Unsupported.cs +++ b/Aaru.Images/DIM/Unsupported.cs @@ -30,10 +30,12 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.Enums; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Dim { #region IMediaImage Members diff --git a/Aaru.Images/GDI/Constants.cs b/Aaru.Images/GDI/Constants.cs index 3f0568e7a..e3a266ffe 100644 --- a/Aaru.Images/GDI/Constants.cs +++ b/Aaru.Images/GDI/Constants.cs @@ -30,8 +30,11 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; + namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Gdi { const string REGEX_TRACK = diff --git a/Aaru.Images/GDI/GDI.cs b/Aaru.Images/GDI/GDI.cs index 3d7b7effd..b62bd7323 100644 --- a/Aaru.Images/GDI/GDI.cs +++ b/Aaru.Images/GDI/GDI.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Interfaces; @@ -43,6 +44,7 @@ namespace Aaru.DiscImages; // TODO: This format doesn't support to specify pregaps that are included in the file (like Redump ones) /// /// Implements reading Dreamcast GDI disc images +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Gdi : IOpticalMediaImage { const string MODULE_NAME = "GDI plugin"; diff --git a/Aaru.Images/GDI/Identify.cs b/Aaru.Images/GDI/Identify.cs index b815dab13..8ce3c148e 100644 --- a/Aaru.Images/GDI/Identify.cs +++ b/Aaru.Images/GDI/Identify.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Text.RegularExpressions; using Aaru.CommonTypes.Interfaces; @@ -39,6 +40,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Gdi { #region IOpticalMediaImage Members diff --git a/Aaru.Images/GDI/Properties.cs b/Aaru.Images/GDI/Properties.cs index 5a7b0e130..d56dc2a71 100644 --- a/Aaru.Images/GDI/Properties.cs +++ b/Aaru.Images/GDI/Properties.cs @@ -32,6 +32,7 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Structs; @@ -41,6 +42,7 @@ using TrackType = Aaru.CommonTypes.Enums.TrackType; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Gdi { #region IOpticalMediaImage Members diff --git a/Aaru.Images/GDI/Read.cs b/Aaru.Images/GDI/Read.cs index b15bc7a78..e66eed9b3 100644 --- a/Aaru.Images/GDI/Read.cs +++ b/Aaru.Images/GDI/Read.cs @@ -32,6 +32,7 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using System.Text.RegularExpressions; @@ -45,6 +46,7 @@ using Session = Aaru.CommonTypes.Structs.Session; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Gdi { #region IOpticalMediaImage Members diff --git a/Aaru.Images/GDI/Structs.cs b/Aaru.Images/GDI/Structs.cs index 888a36201..3f13713a9 100644 --- a/Aaru.Images/GDI/Structs.cs +++ b/Aaru.Images/GDI/Structs.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Interfaces; @@ -38,6 +39,7 @@ using Aaru.CommonTypes.Structs; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Gdi { #region Nested type: GdiDisc diff --git a/Aaru.Images/GDI/Unsupported.cs b/Aaru.Images/GDI/Unsupported.cs index abbf9a8bb..c4d1e7276 100644 --- a/Aaru.Images/GDI/Unsupported.cs +++ b/Aaru.Images/GDI/Unsupported.cs @@ -30,10 +30,12 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.Enums; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Gdi { #region IOpticalMediaImage Members diff --git a/Aaru.Images/GDI/Verify.cs b/Aaru.Images/GDI/Verify.cs index 5b779695e..53c4b4fba 100644 --- a/Aaru.Images/GDI/Verify.cs +++ b/Aaru.Images/GDI/Verify.cs @@ -32,11 +32,13 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.Checksums; using Aaru.CommonTypes.Enums; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Gdi { #region IOpticalMediaImage Members diff --git a/Aaru.Images/Partimage/Constants.cs b/Aaru.Images/Partimage/Constants.cs index 86301767f..b96e472d2 100644 --- a/Aaru.Images/Partimage/Constants.cs +++ b/Aaru.Images/Partimage/Constants.cs @@ -35,6 +35,7 @@ using System.Diagnostics.CodeAnalysis; namespace Aaru.DiscImages; [SuppressMessage("ReSharper", "UnusedMember.Local")] +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Partimage { const int MAX_DESCRIPTION = 4096; diff --git a/Aaru.Images/Partimage/Enums.cs b/Aaru.Images/Partimage/Enums.cs index 4ad697f45..8bab12df8 100644 --- a/Aaru.Images/Partimage/Enums.cs +++ b/Aaru.Images/Partimage/Enums.cs @@ -35,6 +35,7 @@ using System.Diagnostics.CodeAnalysis; namespace Aaru.DiscImages; [SuppressMessage("ReSharper", "UnusedMember.Local")] +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Partimage { #region Nested type: PCompression diff --git a/Aaru.Images/Partimage/Helpers.cs b/Aaru.Images/Partimage/Helpers.cs index 0f15502c6..131c0c4fc 100644 --- a/Aaru.Images/Partimage/Helpers.cs +++ b/Aaru.Images/Partimage/Helpers.cs @@ -30,8 +30,11 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; + namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Partimage { ulong BlockOffset(ulong sectorAddress) diff --git a/Aaru.Images/Partimage/Identify.cs b/Aaru.Images/Partimage/Identify.cs index 97d110f82..578546a75 100644 --- a/Aaru.Images/Partimage/Identify.cs +++ b/Aaru.Images/Partimage/Identify.cs @@ -30,6 +30,7 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using Aaru.CommonTypes.Interfaces; @@ -37,6 +38,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Partimage { #region IMediaImage Members diff --git a/Aaru.Images/Partimage/Partimage.cs b/Aaru.Images/Partimage/Partimage.cs index f3fac28f7..d85f6226e 100644 --- a/Aaru.Images/Partimage/Partimage.cs +++ b/Aaru.Images/Partimage/Partimage.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Extents; @@ -43,6 +44,7 @@ namespace Aaru.DiscImages; /// /// Implements reading partimage disk images +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Partimage : IMediaImage, IVerifiableImage { const string MODULE_NAME = "Partimage plugin"; diff --git a/Aaru.Images/Partimage/Properties.cs b/Aaru.Images/Partimage/Properties.cs index 04df1eee6..3ad34c5b7 100644 --- a/Aaru.Images/Partimage/Properties.cs +++ b/Aaru.Images/Partimage/Properties.cs @@ -32,11 +32,13 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Structs; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Partimage { #region IMediaImage Members diff --git a/Aaru.Images/Partimage/Read.cs b/Aaru.Images/Partimage/Read.cs index a2c33aa33..1ae8ab738 100644 --- a/Aaru.Images/Partimage/Read.cs +++ b/Aaru.Images/Partimage/Read.cs @@ -33,6 +33,7 @@ using System; using System.Collections.Generic; using System.Diagnostics; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Enums; @@ -43,6 +44,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Partimage { #region IMediaImage Members diff --git a/Aaru.Images/Partimage/Structs.cs b/Aaru.Images/Partimage/Structs.cs index 4abc48c3c..000779ffb 100644 --- a/Aaru.Images/Partimage/Structs.cs +++ b/Aaru.Images/Partimage/Structs.cs @@ -37,6 +37,7 @@ using System.Runtime.InteropServices; namespace Aaru.DiscImages; [SuppressMessage("ReSharper", "UnusedType.Local")] +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Partimage { #region Nested type: CCheck diff --git a/Aaru.Images/Partimage/Unsupported.cs b/Aaru.Images/Partimage/Unsupported.cs index f5dcfaf56..8dc9acfb4 100644 --- a/Aaru.Images/Partimage/Unsupported.cs +++ b/Aaru.Images/Partimage/Unsupported.cs @@ -30,10 +30,12 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.Enums; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Partimage { #region IMediaImage Members diff --git a/Aaru.Images/Partimage/Verify.cs b/Aaru.Images/Partimage/Verify.cs index 599930488..9b273b993 100644 --- a/Aaru.Images/Partimage/Verify.cs +++ b/Aaru.Images/Partimage/Verify.cs @@ -30,8 +30,11 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; + namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class Partimage { #region IVerifiableImage Members diff --git a/Aaru.Images/SuperCardPro/Enums.cs b/Aaru.Images/SuperCardPro/Enums.cs index 3a7518f6c..744c17e82 100644 --- a/Aaru.Images/SuperCardPro/Enums.cs +++ b/Aaru.Images/SuperCardPro/Enums.cs @@ -40,6 +40,7 @@ public sealed partial class SuperCardPro #region ScpDiskType enum [SuppressMessage("ReSharper", "InconsistentNaming")] + [SuppressMessage("ReSharper", "UnusedMember.Global")] public enum ScpDiskType : byte { Commodore64 = 0x00, diff --git a/Aaru.Images/SuperCardPro/Helpers.cs b/Aaru.Images/SuperCardPro/Helpers.cs index 87ad22fc2..b8d4e23d3 100644 --- a/Aaru.Images/SuperCardPro/Helpers.cs +++ b/Aaru.Images/SuperCardPro/Helpers.cs @@ -66,6 +66,7 @@ public sealed partial class SuperCardPro /// The track number /// The sub-track number /// SCP format track number + // ReSharper disable once UnusedParameter.Local static long HeadTrackSubToScpTrack(uint head, ushort track, byte subTrack) => // TODO: Support single-sided disks @@ -76,10 +77,12 @@ public sealed partial class SuperCardPro uint over = ticks / 255; if(over == 0) + { return new[] { (byte)ticks }; + } var expanded = new byte[over + 1]; diff --git a/Aaru.Images/SuperCardPro/Write.cs b/Aaru.Images/SuperCardPro/Write.cs index 8a8ebea66..9a6837b4e 100644 --- a/Aaru.Images/SuperCardPro/Write.cs +++ b/Aaru.Images/SuperCardPro/Write.cs @@ -38,7 +38,6 @@ using Aaru.CommonTypes; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Structs; -using Track = Aaru.CommonTypes.AaruMetadata.Track; namespace Aaru.DiscImages; @@ -257,6 +256,4 @@ public sealed partial class SuperCardPro } #endregion - - public bool SetTracks(List tracks) => false; } \ No newline at end of file diff --git a/Aaru.Images/T98/Identify.cs b/Aaru.Images/T98/Identify.cs index ec08c6d6e..0b16db413 100644 --- a/Aaru.Images/T98/Identify.cs +++ b/Aaru.Images/T98/Identify.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.Console; @@ -38,6 +39,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class T98 { #region IWritableImage Members diff --git a/Aaru.Images/T98/Properties.cs b/Aaru.Images/T98/Properties.cs index 223e78a9c..0b5704bc7 100644 --- a/Aaru.Images/T98/Properties.cs +++ b/Aaru.Images/T98/Properties.cs @@ -32,6 +32,7 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Enums; @@ -39,6 +40,7 @@ using Aaru.CommonTypes.Structs; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class T98 { #region IWritableImage Members diff --git a/Aaru.Images/T98/Read.cs b/Aaru.Images/T98/Read.cs index 85334a33f..99f546849 100644 --- a/Aaru.Images/T98/Read.cs +++ b/Aaru.Images/T98/Read.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Enums; @@ -39,6 +40,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class T98 { #region IWritableImage Members diff --git a/Aaru.Images/T98/T98.cs b/Aaru.Images/T98/T98.cs index 98a90281f..aec663774 100644 --- a/Aaru.Images/T98/T98.cs +++ b/Aaru.Images/T98/T98.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Interfaces; @@ -40,6 +41,7 @@ namespace Aaru.DiscImages; /// /// Implements reading and writing T98 disk images +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class T98 : IWritableImage { const string MODULE_NAME = "T98 plugin"; diff --git a/Aaru.Images/T98/Unsupported.cs b/Aaru.Images/T98/Unsupported.cs index df6390308..c4428ca8f 100644 --- a/Aaru.Images/T98/Unsupported.cs +++ b/Aaru.Images/T98/Unsupported.cs @@ -30,10 +30,12 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.Enums; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class T98 { #region IWritableImage Members diff --git a/Aaru.Images/T98/Write.cs b/Aaru.Images/T98/Write.cs index 28b5b5b20..d4405aa2e 100644 --- a/Aaru.Images/T98/Write.cs +++ b/Aaru.Images/T98/Write.cs @@ -32,6 +32,7 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using Aaru.CommonTypes; @@ -41,6 +42,7 @@ using Aaru.CommonTypes.Structs; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class T98 { #region IWritableImage Members diff --git a/Aaru.Images/UkvFdi/Constants.cs b/Aaru.Images/UkvFdi/Constants.cs index ee746d8bf..19f15bbcb 100644 --- a/Aaru.Images/UkvFdi/Constants.cs +++ b/Aaru.Images/UkvFdi/Constants.cs @@ -30,8 +30,11 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; + namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class UkvFdi { readonly byte[] _signature = "FDI"u8.ToArray(); diff --git a/Aaru.Images/UkvFdi/Enums.cs b/Aaru.Images/UkvFdi/Enums.cs index 7e53de96f..9b34dd7a3 100644 --- a/Aaru.Images/UkvFdi/Enums.cs +++ b/Aaru.Images/UkvFdi/Enums.cs @@ -36,6 +36,7 @@ using System.Diagnostics.CodeAnalysis; namespace Aaru.DiscImages; [SuppressMessage("ReSharper", "UnusedMember.Local")] +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class UkvFdi { #region Nested type: DiskFlags diff --git a/Aaru.Images/UkvFdi/Helpers.cs b/Aaru.Images/UkvFdi/Helpers.cs index 99c442f13..983e34f42 100644 --- a/Aaru.Images/UkvFdi/Helpers.cs +++ b/Aaru.Images/UkvFdi/Helpers.cs @@ -30,8 +30,11 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; + namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class UkvFdi { (ushort cylinder, byte head, byte sector) LbaToChs(ulong lba) diff --git a/Aaru.Images/UkvFdi/Identify.cs b/Aaru.Images/UkvFdi/Identify.cs index 03129ca20..8df7070e3 100644 --- a/Aaru.Images/UkvFdi/Identify.cs +++ b/Aaru.Images/UkvFdi/Identify.cs @@ -30,6 +30,7 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Linq; using Aaru.CommonTypes.Interfaces; @@ -37,6 +38,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class UkvFdi { #region IMediaImage Members diff --git a/Aaru.Images/UkvFdi/Properties.cs b/Aaru.Images/UkvFdi/Properties.cs index 67e77060a..b61b741fa 100644 --- a/Aaru.Images/UkvFdi/Properties.cs +++ b/Aaru.Images/UkvFdi/Properties.cs @@ -32,11 +32,13 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Structs; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class UkvFdi { #region IMediaImage Members diff --git a/Aaru.Images/UkvFdi/Read.cs b/Aaru.Images/UkvFdi/Read.cs index 61f69cbd9..b58641840 100644 --- a/Aaru.Images/UkvFdi/Read.cs +++ b/Aaru.Images/UkvFdi/Read.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Enums; @@ -40,6 +41,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class UkvFdi { #region IMediaImage Members diff --git a/Aaru.Images/UkvFdi/Structs.cs b/Aaru.Images/UkvFdi/Structs.cs index 87379825e..ea52df830 100644 --- a/Aaru.Images/UkvFdi/Structs.cs +++ b/Aaru.Images/UkvFdi/Structs.cs @@ -30,10 +30,12 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using System.Runtime.InteropServices; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class UkvFdi { #region Nested type: Header diff --git a/Aaru.Images/UkvFdi/UkvFdi.cs b/Aaru.Images/UkvFdi/UkvFdi.cs index 9c9f60782..0fb5300c1 100644 --- a/Aaru.Images/UkvFdi/UkvFdi.cs +++ b/Aaru.Images/UkvFdi/UkvFdi.cs @@ -31,6 +31,7 @@ // ****************************************************************************/ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.Enums; using Aaru.CommonTypes.Interfaces; using Aaru.CommonTypes.Structs; @@ -39,6 +40,7 @@ namespace Aaru.DiscImages; /// /// Implements reading UKV FDI disk images +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class UkvFdi : IMediaImage { const string MODULE_NAME = "UkvFdi plugin"; diff --git a/Aaru.Images/UkvFdi/Unsupported.cs b/Aaru.Images/UkvFdi/Unsupported.cs index c14bce173..87abb43ba 100644 --- a/Aaru.Images/UkvFdi/Unsupported.cs +++ b/Aaru.Images/UkvFdi/Unsupported.cs @@ -30,10 +30,12 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.Enums; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class UkvFdi { #region IMediaImage Members diff --git a/Aaru.Images/WCDiskImage/Identify.cs b/Aaru.Images/WCDiskImage/Identify.cs index 5be3329cf..56b3fc0a4 100644 --- a/Aaru.Images/WCDiskImage/Identify.cs +++ b/Aaru.Images/WCDiskImage/Identify.cs @@ -31,6 +31,7 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Text; using Aaru.CommonTypes.Interfaces; @@ -38,6 +39,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class WCDiskImage { #region IMediaImage Members diff --git a/Aaru.Images/WCDiskImage/Properties.cs b/Aaru.Images/WCDiskImage/Properties.cs index f87aa8413..5c0c7224e 100644 --- a/Aaru.Images/WCDiskImage/Properties.cs +++ b/Aaru.Images/WCDiskImage/Properties.cs @@ -33,11 +33,13 @@ using System; using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.AaruMetadata; using Aaru.CommonTypes.Structs; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class WCDiskImage { #region IMediaImage Members diff --git a/Aaru.Images/WCDiskImage/Read.cs b/Aaru.Images/WCDiskImage/Read.cs index 371210575..1479b6244 100644 --- a/Aaru.Images/WCDiskImage/Read.cs +++ b/Aaru.Images/WCDiskImage/Read.cs @@ -32,6 +32,7 @@ // ****************************************************************************/ using System; +using System.Diagnostics.CodeAnalysis; using System.IO; using System.Text; using Aaru.Checksums; @@ -43,6 +44,7 @@ using Aaru.Helpers; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class WCDiskImage { #region IMediaImage Members diff --git a/Aaru.Images/WCDiskImage/Structs.cs b/Aaru.Images/WCDiskImage/Structs.cs index ee1b1ff8c..240f411a4 100644 --- a/Aaru.Images/WCDiskImage/Structs.cs +++ b/Aaru.Images/WCDiskImage/Structs.cs @@ -31,10 +31,12 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using System.Runtime.InteropServices; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class WCDiskImage { /// The expected signature of a proper image file. diff --git a/Aaru.Images/WCDiskImage/Unsupported.cs b/Aaru.Images/WCDiskImage/Unsupported.cs index 79f24d632..43de007c0 100644 --- a/Aaru.Images/WCDiskImage/Unsupported.cs +++ b/Aaru.Images/WCDiskImage/Unsupported.cs @@ -30,10 +30,12 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using Aaru.CommonTypes.Enums; namespace Aaru.DiscImages; +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class WCDiskImage { #region IMediaImage Members diff --git a/Aaru.Images/WCDiskImage/WCDiskImage.cs b/Aaru.Images/WCDiskImage/WCDiskImage.cs index 622c7e0c8..47120cdd2 100644 --- a/Aaru.Images/WCDiskImage/WCDiskImage.cs +++ b/Aaru.Images/WCDiskImage/WCDiskImage.cs @@ -43,6 +43,7 @@ namespace Aaru.DiscImages; /// Manages floppy disk images created with d2f by DataPackRat [SuppressMessage("ReSharper", "NotAccessedField.Local")] [SuppressMessage("ReSharper", "InconsistentNaming")] +[SuppressMessage("ReSharper", "UnusedType.Global")] public sealed partial class WCDiskImage : IMediaImage { const string MODULE_NAME = "d2f plugin"; diff --git a/Aaru.Partitions/BSD.cs b/Aaru.Partitions/BSD.cs index 94d86f6a4..f76001457 100644 --- a/Aaru.Partitions/BSD.cs +++ b/Aaru.Partitions/BSD.cs @@ -477,6 +477,7 @@ public sealed class BSD : IPartition /// Filesystem type [SuppressMessage("ReSharper", "InconsistentNaming")] + [SuppressMessage("ReSharper", "UnusedMember.Global")] internal enum fsType : byte { /// Unused entry diff --git a/Aaru.Settings/Settings.cs b/Aaru.Settings/Settings.cs index 746094298..60c92f57a 100644 --- a/Aaru.Settings/Settings.cs +++ b/Aaru.Settings/Settings.cs @@ -71,16 +71,6 @@ public class DicSettings public StatsSettings Stats; } -// TODO: Use this -/// User settings, for media dumps, completely unused -public class UserSettings -{ - /// User email - public string Email; - /// User name or nick - public string Name; -} - /// Statistics settings public class StatsSettings { diff --git a/Aaru.Tests.Devices/NVMe.cs b/Aaru.Tests.Devices/NVMe.cs index 4c7db5037..e5eb530a7 100644 --- a/Aaru.Tests.Devices/NVMe.cs +++ b/Aaru.Tests.Devices/NVMe.cs @@ -26,11 +26,13 @@ // Copyright © 2011-2023 Natalia Portillo // ****************************************************************************/ +using System.Diagnostics.CodeAnalysis; using Aaru.Console; using Aaru.Devices; namespace Aaru.Tests.Devices; +[SuppressMessage("ReSharper", "UnusedParameter.Global")] static partial class MainClass { public static void NVMe(string devPath, Device dev) diff --git a/Aaru.Tests/Issues/257.cs b/Aaru.Tests/Issues/257.cs index 8bd08ecef..eaa04dca7 100644 --- a/Aaru.Tests/Issues/257.cs +++ b/Aaru.Tests/Issues/257.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.DiscImages; @@ -17,6 +18,7 @@ namespace Aaru.Tests.Issues; // 20200311 CLAUNIA: Fixed in f4a1c28feabb50a43036944cf7f6c028eb6f8b93 // 20200621 CLAUNIA: Fixed in c80baa5efb4ea8a9e4347278086b2414469ae4c6 +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _257 : OpticalImageConvertIssueTest { public override Dictionary ParsedOptions => new(); diff --git a/Aaru.Tests/Issues/263/AaruFormat.cs b/Aaru.Tests/Issues/263/AaruFormat.cs index 8c2d326b7..e57842db2 100644 --- a/Aaru.Tests/Issues/263/AaruFormat.cs +++ b/Aaru.Tests/Issues/263/AaruFormat.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues._263; @@ -14,6 +15,7 @@ namespace Aaru.Tests.Issues._263; */ // 20200309 CLAUNIA: Fixed in 3b2bb0ebf0c6c615c5622aebff494ed34b51055d +[SuppressMessage("ReSharper", "UnusedType.Global")] public class AaruFormat : FsExtractIssueTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue263"); diff --git a/Aaru.Tests/Issues/263/Raw.cs b/Aaru.Tests/Issues/263/Raw.cs index 7486ba28f..847afec14 100644 --- a/Aaru.Tests/Issues/263/Raw.cs +++ b/Aaru.Tests/Issues/263/Raw.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues._263; @@ -14,6 +15,7 @@ namespace Aaru.Tests.Issues._263; */ // 20200309 CLAUNIA: Fixed in 3b2bb0ebf0c6c615c5622aebff494ed34b51055d +[SuppressMessage("ReSharper", "UnusedType.Global")] public class Raw : FsExtractIssueTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue263"); diff --git a/Aaru.Tests/Issues/266.cs b/Aaru.Tests/Issues/266.cs index 74c993ef2..bd1754aea 100644 --- a/Aaru.Tests/Issues/266.cs +++ b/Aaru.Tests/Issues/266.cs @@ -1,6 +1,7 @@ // ReSharper disable StringLiteralTypo using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -15,6 +16,7 @@ namespace Aaru.Tests.Issues; */ // 20200309 CLAUNIA: Fixed in 3b2bb0ebf0c6c615c5622aebff494ed34b51055d +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _266 : FsExtractHashIssueTest { protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue266"); diff --git a/Aaru.Tests/Issues/286.cs b/Aaru.Tests/Issues/286.cs index 638280426..932e3f9bb 100644 --- a/Aaru.Tests/Issues/286.cs +++ b/Aaru.Tests/Issues/286.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.DiscImages; @@ -13,6 +14,7 @@ namespace Aaru.Tests.Issues; // 20200309 CLAUNIA: Fixed in 21e81753cd106a52ee599281f0b977cda90484a7 // 20210307 CLAUNIA: Reopened. +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _286 : OpticalImageConvertIssueTest { public override Dictionary ParsedOptions => new(); diff --git a/Aaru.Tests/Issues/288/18Wheeler.cs b/Aaru.Tests/Issues/288/18Wheeler.cs index fa5e37633..cbae8eafa 100644 --- a/Aaru.Tests/Issues/288/18Wheeler.cs +++ b/Aaru.Tests/Issues/288/18Wheeler.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.DiscImages; @@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues._288; */ // 20200309 CLAUNIA: Fixed in af0abca12d429276fc864e1de14a7a40f12bde26 +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _18Wheeler : OpticalImageConvertIssueTest { public override Dictionary ParsedOptions => new(); diff --git a/Aaru.Tests/Issues/288/ArcadeHits.cs b/Aaru.Tests/Issues/288/ArcadeHits.cs index daedd56d3..76bba247f 100644 --- a/Aaru.Tests/Issues/288/ArcadeHits.cs +++ b/Aaru.Tests/Issues/288/ArcadeHits.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.DiscImages; @@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues._288; */ // 20200309 CLAUNIA: Fixed in af0abca12d429276fc864e1de14a7a40f12bde26 +[SuppressMessage("ReSharper", "UnusedType.Global")] public class ArcadeHits : OpticalImageConvertIssueTest { public override Dictionary ParsedOptions => new(); diff --git a/Aaru.Tests/Issues/288/Roadsters.cs b/Aaru.Tests/Issues/288/Roadsters.cs index a119228b0..d22b5cb5d 100644 --- a/Aaru.Tests/Issues/288/Roadsters.cs +++ b/Aaru.Tests/Issues/288/Roadsters.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.DiscImages; @@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues._288; */ // 20200309 CLAUNIA: Fixed in af0abca12d429276fc864e1de14a7a40f12bde26 +[SuppressMessage("ReSharper", "UnusedType.Global")] public class Roadsters : OpticalImageConvertIssueTest { public override Dictionary ParsedOptions => new(); diff --git a/Aaru.Tests/Issues/299.cs b/Aaru.Tests/Issues/299.cs index 7550d64da..f5bacb3f3 100644 --- a/Aaru.Tests/Issues/299.cs +++ b/Aaru.Tests/Issues/299.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.DiscImages; @@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues; * http://dcevolution.sourceforge.net/index.php?id=house_of_terror can be converted to DICF. */ +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _299 : OpticalImageConvertIssueTest { public override Dictionary ParsedOptions => new(); diff --git a/Aaru.Tests/Issues/300.cs b/Aaru.Tests/Issues/300.cs index 00f518fc5..ef1aae368 100644 --- a/Aaru.Tests/Issues/300.cs +++ b/Aaru.Tests/Issues/300.cs @@ -1,6 +1,7 @@ // ReSharper disable StringLiteralTypo using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -19,6 +20,7 @@ namespace Aaru.Tests.Issues; */ // 20200309 CLAUNIA: Fixed in 48f067d79ff30cfd10e084085ff479bbb0939512 +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _300 : FsExtractHashIssueTest { protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue300"); diff --git a/Aaru.Tests/Issues/358.cs b/Aaru.Tests/Issues/358.cs index 574be9f3f..76c2fe7fb 100644 --- a/Aaru.Tests/Issues/358.cs +++ b/Aaru.Tests/Issues/358.cs @@ -1,6 +1,7 @@ // ReSharper disable StringLiteralTypo using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -14,6 +15,7 @@ namespace Aaru.Tests.Issues; */ // 20200621 CLAUNIA: Fixed in 83a28237fab9e21b23bd43eb91b5b29f1bf9f220 +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _358 : FsExtractHashIssueTest { protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue358"); diff --git a/Aaru.Tests/Issues/360.cs b/Aaru.Tests/Issues/360.cs index 3787bd4ed..63a62e8bd 100644 --- a/Aaru.Tests/Issues/360.cs +++ b/Aaru.Tests/Issues/360.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -12,6 +13,7 @@ namespace Aaru.Tests.Issues; // 20201107 CLAUNIA: Fixed in c45f1bff6d75a2e31b2b2d889455eefd3262b2cc // 20210307 CLAUNIA: Reopened +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _360 : FsExtractIssueTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue360"); diff --git a/Aaru.Tests/Issues/379.cs b/Aaru.Tests/Issues/379.cs index 1b5501a02..cb8c59cf8 100644 --- a/Aaru.Tests/Issues/379.cs +++ b/Aaru.Tests/Issues/379.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.DiscImages; @@ -15,6 +16,7 @@ namespace Aaru.Tests.Issues; */ // 20201103 CLAUNIA: Fixed in 532b2adddc900d8e4c61a6399d4da20a566d4876 +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _379 : OpticalImageConvertIssueTest { public override Dictionary ParsedOptions => new(); diff --git a/Aaru.Tests/Issues/398.cs b/Aaru.Tests/Issues/398.cs index 2008b07f8..c557b4593 100644 --- a/Aaru.Tests/Issues/398.cs +++ b/Aaru.Tests/Issues/398.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.DiscImages; @@ -14,6 +15,7 @@ namespace Aaru.Tests.Issues; */ // 20201104 CLAUNIA: Fixed in 7723fc2d0dbe0a6e6dc7b5cabc17f6798bb5eebb +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _398 : OpticalImageConvertIssueTest { public override Dictionary ParsedOptions => new(); diff --git a/Aaru.Tests/Issues/410.cs b/Aaru.Tests/Issues/410.cs index 74d5b9eac..afa19aa61 100644 --- a/Aaru.Tests/Issues/410.cs +++ b/Aaru.Tests/Issues/410.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -19,6 +20,7 @@ namespace Aaru.Tests.Issues; */ // 20201106 CLAUNIA: Fixed in d30a6d18cd1f6d8b9075f096bd56e23fc5106dbf +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _410 : FsExtractIssueTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue410"); diff --git a/Aaru.Tests/Issues/411.cs b/Aaru.Tests/Issues/411.cs index 58f6e9091..d73483ad9 100644 --- a/Aaru.Tests/Issues/411.cs +++ b/Aaru.Tests/Issues/411.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -19,6 +20,7 @@ namespace Aaru.Tests.Issues; */ // 20201106 CLAUNIA: Fixed in d30a6d18cd1f6d8b9075f096bd56e23fc5106dbf +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _411 : FsExtractIssueTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue411"); diff --git a/Aaru.Tests/Issues/441.cs b/Aaru.Tests/Issues/441.cs index a4c3dbd55..f579bcdbe 100644 --- a/Aaru.Tests/Issues/441.cs +++ b/Aaru.Tests/Issues/441.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues; * "Error EINVAL reading file". */ +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _441 : FsExtractIssueTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue441"); diff --git a/Aaru.Tests/Issues/448.cs b/Aaru.Tests/Issues/448.cs index 2e14cf286..12bbb743e 100644 --- a/Aaru.Tests/Issues/448.cs +++ b/Aaru.Tests/Issues/448.cs @@ -1,3 +1,4 @@ +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Interfaces; @@ -6,6 +7,7 @@ using BlindWrite5 = Aaru.DiscImages.BlindWrite5; namespace Aaru.Tests.Issues; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _448 : OpticalMediaImageTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Pending", "issue448"); diff --git a/Aaru.Tests/Issues/449.cs b/Aaru.Tests/Issues/449.cs index 3d62c5cc7..adfc976b4 100644 --- a/Aaru.Tests/Issues/449.cs +++ b/Aaru.Tests/Issues/449.cs @@ -1,3 +1,4 @@ +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -7,6 +8,7 @@ namespace Aaru.Tests.Issues; * Aaru doesn't support specific NRG (Version 1) image */ +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _449 : OpticalImageReadIssueTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue449"); diff --git a/Aaru.Tests/Issues/450.cs b/Aaru.Tests/Issues/450.cs index 62444b118..03c053a34 100644 --- a/Aaru.Tests/Issues/450.cs +++ b/Aaru.Tests/Issues/450.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes.Interfaces; using Aaru.DiscImages; @@ -10,6 +11,7 @@ namespace Aaru.Tests.Issues; * Error converting NRG version 2 to other formats */ +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _450 : OpticalImageConvertIssueTest { public override Dictionary ParsedOptions => new(); diff --git a/Aaru.Tests/Issues/495.cs b/Aaru.Tests/Issues/495.cs index b97165ab9..8c05537b5 100644 --- a/Aaru.Tests/Issues/495.cs +++ b/Aaru.Tests/Issues/495.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -10,6 +11,7 @@ namespace Aaru.Tests.Issues; * Trying to extract files from a CDTV image crashes with "Error reading file: Object reference not set to an instance of an object." */ +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _495 : FsExtractIssueTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue495"); diff --git a/Aaru.Tests/Issues/531.cs b/Aaru.Tests/Issues/531.cs index e228c0ec4..70d235461 100644 --- a/Aaru.Tests/Issues/531.cs +++ b/Aaru.Tests/Issues/531.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues; * "Error reading file: Object reference not set to an instance of an object.". */ +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _531 : FsExtractIssueTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue531"); diff --git a/Aaru.Tests/Issues/542/Sims.cs b/Aaru.Tests/Issues/542/Sims.cs index 995a39ef7..6eb6f780a 100644 --- a/Aaru.Tests/Issues/542/Sims.cs +++ b/Aaru.Tests/Issues/542/Sims.cs @@ -1,6 +1,7 @@ // ReSharper disable StringLiteralTypo using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues._542; @@ -12,6 +13,7 @@ namespace Aaru.Tests.Issues._542; * When extracting an image of a SafeDisc protected CD, most files aren't properly extracted. */ +[SuppressMessage("ReSharper", "UnusedType.Global")] public class Sims : FsExtractHashIssueTest { protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue542", "sims"); diff --git a/Aaru.Tests/Issues/542/SimsEP.cs b/Aaru.Tests/Issues/542/SimsEP.cs index d9bffc58f..799b4bc54 100644 --- a/Aaru.Tests/Issues/542/SimsEP.cs +++ b/Aaru.Tests/Issues/542/SimsEP.cs @@ -14,6 +14,7 @@ namespace Aaru.Tests.Issues._542; */ [SuppressMessage("ReSharper", "InconsistentNaming")] +[SuppressMessage("ReSharper", "UnusedType.Global")] public class SimsEP : FsExtractHashIssueTest { protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue542", "exp"); diff --git a/Aaru.Tests/Issues/584.cs b/Aaru.Tests/Issues/584.cs index 3f7787945..afff5ed40 100644 --- a/Aaru.Tests/Issues/584.cs +++ b/Aaru.Tests/Issues/584.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; using System.IO; namespace Aaru.Tests.Issues; @@ -10,6 +11,7 @@ namespace Aaru.Tests.Issues; * When performing file extraction, the following exception is raised */ +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _584 : FsExtractIssueTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue584"); diff --git a/Aaru.Tests/Issues/590/asus-driver-gpu-tweak-v1231-2014.cs b/Aaru.Tests/Issues/590/asus-driver-gpu-tweak-v1231-2014.cs index d8d960884..f25ff32f3 100644 --- a/Aaru.Tests/Issues/590/asus-driver-gpu-tweak-v1231-2014.cs +++ b/Aaru.Tests/Issues/590/asus-driver-gpu-tweak-v1231-2014.cs @@ -14,6 +14,7 @@ namespace Aaru.Tests.Issues._590; */ [SuppressMessage("ReSharper", "InconsistentNaming")] +[SuppressMessage("ReSharper", "UnusedType.Global")] public class asus_driver_gpu_tweak_v1231_2014 : FsExtractHashIssueTest { protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue590", diff --git a/Aaru.Tests/Issues/590/m5a99fx.cs b/Aaru.Tests/Issues/590/m5a99fx.cs index a57e835ec..9d59ae0a5 100644 --- a/Aaru.Tests/Issues/590/m5a99fx.cs +++ b/Aaru.Tests/Issues/590/m5a99fx.cs @@ -14,6 +14,7 @@ namespace Aaru.Tests.Issues._590; */ [SuppressMessage("ReSharper", "InconsistentNaming")] +[SuppressMessage("ReSharper", "UnusedType.Global")] public class m5a99fx : FsExtractHashIssueTest { protected override string DataFolder => diff --git a/Aaru.Tests/Issues/590/win3.cs b/Aaru.Tests/Issues/590/win3.cs index 7e5aeefcc..2c68833d7 100644 --- a/Aaru.Tests/Issues/590/win3.cs +++ b/Aaru.Tests/Issues/590/win3.cs @@ -14,6 +14,7 @@ namespace Aaru.Tests.Issues._590; */ [SuppressMessage("ReSharper", "InconsistentNaming")] +[SuppressMessage("ReSharper", "UnusedType.Global")] public class win3 : FsExtractHashIssueTest { protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue590", "win3"); diff --git a/Aaru.Tests/Issues/623.cs b/Aaru.Tests/Issues/623.cs index 9a590d6eb..513d24ed4 100644 --- a/Aaru.Tests/Issues/623.cs +++ b/Aaru.Tests/Issues/623.cs @@ -1,3 +1,4 @@ +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Interfaces; @@ -6,6 +7,7 @@ using Aaru.Tests.WritableImages; namespace Aaru.Tests.Issues; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _623 : WritableOpticalMediaImageTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue623"); diff --git a/Aaru.Tests/Issues/624.cs b/Aaru.Tests/Issues/624.cs index 1b4f843ca..7a207280f 100644 --- a/Aaru.Tests/Issues/624.cs +++ b/Aaru.Tests/Issues/624.cs @@ -1,3 +1,4 @@ +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Interfaces; @@ -6,6 +7,7 @@ using Aaru.Tests.WritableImages; namespace Aaru.Tests.Issues; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _624 : WritableOpticalMediaImageTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Pending", "issue624"); diff --git a/Aaru.Tests/Issues/625.cs b/Aaru.Tests/Issues/625.cs index 2795b8089..3baf47872 100644 --- a/Aaru.Tests/Issues/625.cs +++ b/Aaru.Tests/Issues/625.cs @@ -1,3 +1,4 @@ +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Interfaces; @@ -6,6 +7,7 @@ using Aaru.Tests.WritableImages; namespace Aaru.Tests.Issues; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class _625 : WritableOpticalMediaImageTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue625"); diff --git a/Aaru.Tests/Structs.cs b/Aaru.Tests/Structs.cs index 670638956..83d149c98 100644 --- a/Aaru.Tests/Structs.cs +++ b/Aaru.Tests/Structs.cs @@ -111,7 +111,6 @@ public class VolumeData public class BlockPartitionVolumes { - public ulong Length; - public ulong Start; - public VolumeData[] Volumes; + public ulong Length; + public ulong Start; } \ No newline at end of file diff --git a/Aaru.Tests/WritableImages/AaruFormat/V1/FromAaru.cs b/Aaru.Tests/WritableImages/AaruFormat/V1/FromAaru.cs index a39f173c6..e882dace0 100644 --- a/Aaru.Tests/WritableImages/AaruFormat/V1/FromAaru.cs +++ b/Aaru.Tests/WritableImages/AaruFormat/V1/FromAaru.cs @@ -1,9 +1,11 @@ +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Interfaces; namespace Aaru.Tests.WritableImages.AaruFormat.V1; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class FromAaru : WritableOpticalMediaImageTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Media image formats", "AaruFormat", "V1"); diff --git a/Aaru.Tests/WritableImages/Alcohol/FromAaru.cs b/Aaru.Tests/WritableImages/Alcohol/FromAaru.cs index 5806d64c9..9a9d9b756 100644 --- a/Aaru.Tests/WritableImages/Alcohol/FromAaru.cs +++ b/Aaru.Tests/WritableImages/Alcohol/FromAaru.cs @@ -1,3 +1,4 @@ +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Interfaces; @@ -5,6 +6,7 @@ using Aaru.DiscImages; namespace Aaru.Tests.WritableImages.Alcohol; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class FromAaru : WritableOpticalMediaImageTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Media image formats", "AaruFormat", "V1"); diff --git a/Aaru.Tests/WritableImages/CDRDAO/FromAaru.cs b/Aaru.Tests/WritableImages/CDRDAO/FromAaru.cs index 9089dd706..0c4ad9e9f 100644 --- a/Aaru.Tests/WritableImages/CDRDAO/FromAaru.cs +++ b/Aaru.Tests/WritableImages/CDRDAO/FromAaru.cs @@ -1,3 +1,4 @@ +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Interfaces; @@ -5,6 +6,7 @@ using Aaru.DiscImages; namespace Aaru.Tests.WritableImages.CDRDAO; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class FromAaru : WritableOpticalMediaImageTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Media image formats", "AaruFormat", "V1"); diff --git a/Aaru.Tests/WritableImages/CDRWin/FromAaru.cs b/Aaru.Tests/WritableImages/CDRWin/FromAaru.cs index 77fd7f1a9..572956b8e 100644 --- a/Aaru.Tests/WritableImages/CDRWin/FromAaru.cs +++ b/Aaru.Tests/WritableImages/CDRWin/FromAaru.cs @@ -1,3 +1,4 @@ +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Interfaces; @@ -5,6 +6,7 @@ using Aaru.DiscImages; namespace Aaru.Tests.WritableImages.CDRWin; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class FromAaru : WritableOpticalMediaImageTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Media image formats", "AaruFormat", "V1"); diff --git a/Aaru.Tests/WritableImages/CloneCD/FromAaru.cs b/Aaru.Tests/WritableImages/CloneCD/FromAaru.cs index cab931d35..ec584daaf 100644 --- a/Aaru.Tests/WritableImages/CloneCD/FromAaru.cs +++ b/Aaru.Tests/WritableImages/CloneCD/FromAaru.cs @@ -1,3 +1,4 @@ +using System.Diagnostics.CodeAnalysis; using System.IO; using Aaru.CommonTypes; using Aaru.CommonTypes.Interfaces; @@ -5,6 +6,7 @@ using Aaru.DiscImages; namespace Aaru.Tests.WritableImages.CloneCD; +[SuppressMessage("ReSharper", "UnusedType.Global")] public class FromAaru : WritableOpticalMediaImageTest { public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Media image formats", "AaruFormat", "V1"); diff --git a/Aaru.sln.DotSettings b/Aaru.sln.DotSettings index f2219b093..9fc05226b 100644 --- a/Aaru.sln.DotSettings +++ b/Aaru.sln.DotSettings @@ -1,6 +1,9 @@ - + Null - ExplicitlyExcluded + ExplicitlyExcluded WARNING WARNING WARNING @@ -627,7 +630,23 @@ XZ ZFS <Policy Inspect="True" Prefix="" Suffix="" Style="AA_BB" /> - <Policy Inspect="True" Prefix="_" Suffix="" Style="aaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="AaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="AaBb_AaBb" /> + <Policy Inspect="True" Prefix="I" Suffix="" Style="AaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="aaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="AaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="aaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="AaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="AaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="aaBb_AaBb" /> + <Policy Inspect="True" Prefix="_" Suffix="" Style="aaBb_AaBb" /> + <Policy Inspect="True" Prefix="_" Suffix="" Style="aaBb_AaBb" /> + <Policy Inspect="True" Prefix="_" Suffix="" Style="aaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="AaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="AaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="AaBb_AaBb" /> + <Policy Inspect="True" Prefix="T" Suffix="" Style="AaBb_AaBb" /> + <Policy Inspect="True" Prefix="" Suffix="" Style="AaBb_AaBb" /> /opt/dotnet/sdk/3.0.100/MSBuild.dll 1048576 diff --git a/Aaru/Commands/Media/Dump.cs b/Aaru/Commands/Media/Dump.cs index ce498477a..607c60c07 100644 --- a/Aaru/Commands/Media/Dump.cs +++ b/Aaru/Commands/Media/Dump.cs @@ -53,7 +53,6 @@ using Aaru.Core; using Aaru.Core.Devices.Dumping; using Aaru.Core.Logging; using Aaru.Localization; -using Humanizer; using Schemas; using Spectre.Console; using Dump = Aaru.Core.Devices.Dumping.Dump; @@ -64,10 +63,9 @@ namespace Aaru.Commands.Media; // TODO: Add raw dumping sealed class DumpMediaCommand : Command { - const string MODULE_NAME = "Dump-Media command"; - static ProgressTask _progressTask1; - static ProgressTask _progressTask2; - static readonly TimeSpan OneSecond = 1.Seconds(); + const string MODULE_NAME = "Dump-Media command"; + static ProgressTask _progressTask1; + static ProgressTask _progressTask2; public DumpMediaCommand() : base("dump", UI.Media_Dump_Command_Description) { diff --git a/Aaru/Commands/Media/Info.cs b/Aaru/Commands/Media/Info.cs index a0a114b44..b1404b932 100644 --- a/Aaru/Commands/Media/Info.cs +++ b/Aaru/Commands/Media/Info.cs @@ -186,8 +186,10 @@ sealed class MediaInfoCommand : Command static void DoAtaMediaInfo() => AaruConsole.ErrorWriteLine(UI.Please_use_device_info_command_for_ATA_devices); + // ReSharper disable UnusedParameter.Local static void DoNvmeMediaInfo(string outputPrefix, Devices.Device dev) => throw new NotImplementedException(Localization.Core.NVMe_devices_not_yet_supported); + // ReSharper restore UnusedParameter.Local static void DoSdMediaInfo() => AaruConsole.ErrorWriteLine(UI.Please_use_device_info_command_for_MMC_SD_devices);