From a759557fe0a2c7e171e08f7da3e3351f43553d63 Mon Sep 17 00:00:00 2001
From: Natalia Portillo <claunia@claunia.com>
Date: Tue, 17 Aug 2021 17:27:21 +0100
Subject: [PATCH] Fix missing parameter comment documentation.

---
 Aaru.CommonTypes                           | 2 +-
 Aaru.Core/Devices/Dumping/ResumeSupport.cs | 1 +
 Aaru.Core/Filesystems.cs                   | 1 +
 Aaru.Core/Sidecar/AudioMedia.cs            | 1 +
 Aaru.Core/Sidecar/BlockMedia.cs            | 1 +
 Aaru.Core/Sidecar/LinearMedia.cs           | 1 +
 Aaru.Core/Sidecar/OpticalDisc.cs           | 1 +
 Aaru.Filters/SplitJoinStream.cs            | 3 ++-
 8 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/Aaru.CommonTypes b/Aaru.CommonTypes
index 9e9af262b..874a3d4bc 160000
--- a/Aaru.CommonTypes
+++ b/Aaru.CommonTypes
@@ -1 +1 @@
-Subproject commit 9e9af262bd069dc62c811d0a11f921c90cd025e2
+Subproject commit 874a3d4bcbd6df7d3d60a7cf7deab9f5e903af44
diff --git a/Aaru.Core/Devices/Dumping/ResumeSupport.cs b/Aaru.Core/Devices/Dumping/ResumeSupport.cs
index b2b022f0d..48b76bea7 100644
--- a/Aaru.Core/Devices/Dumping/ResumeSupport.cs
+++ b/Aaru.Core/Devices/Dumping/ResumeSupport.cs
@@ -57,6 +57,7 @@ namespace Aaru.Core.Devices.Dumping
         /// <param name="firmware">Firmware revision</param>
         /// <param name="isTape">Set to <c>true</c> if device is a streaming tape, <c>false</c> otherwise</param>
         /// <param name="private">Disable saving paths or serial numbers in images and logs</param>
+        /// <param name="force">Force dump enabled</param>
         /// <exception cref="System.NotImplementedException">If device uses CHS addressing</exception>
         /// <exception cref="System.InvalidOperationException">
         ///     If the provided resume does not correspond with the current in
diff --git a/Aaru.Core/Filesystems.cs b/Aaru.Core/Filesystems.cs
index 6f7224811..c2a76b056 100644
--- a/Aaru.Core/Filesystems.cs
+++ b/Aaru.Core/Filesystems.cs
@@ -49,6 +49,7 @@ namespace Aaru.Core
         /// <param name="imagePlugin">Media image</param>
         /// <param name="idPlugins">List of plugins recognizing the filesystem</param>
         /// <param name="partition">Partition</param>
+        /// <param name="getGuid">Gets plugin GUID</param>
         public static void Identify(IMediaImage imagePlugin, out List<string> idPlugins, Partition partition,
                                     bool getGuid = false)
         {
diff --git a/Aaru.Core/Sidecar/AudioMedia.cs b/Aaru.Core/Sidecar/AudioMedia.cs
index 4b7862712..c6f6dacec 100644
--- a/Aaru.Core/Sidecar/AudioMedia.cs
+++ b/Aaru.Core/Sidecar/AudioMedia.cs
@@ -51,6 +51,7 @@ namespace Aaru.Core
         /// <param name="plugins">Image plugins</param>
         /// <param name="imgChecksums">List of image checksums</param>
         /// <param name="sidecar">Metadata sidecar</param>
+        /// <param name="encoding">Encoding to be used for filesystem plugins</param>
         static void AudioMedia(IMediaImage image, Guid filterId, string imagePath, FileInfo fi, PluginBase plugins,
                                List<ChecksumType> imgChecksums, ref CICMMetadataType sidecar, Encoding encoding)
         {
diff --git a/Aaru.Core/Sidecar/BlockMedia.cs b/Aaru.Core/Sidecar/BlockMedia.cs
index 5b0517e5b..7311e8fb3 100644
--- a/Aaru.Core/Sidecar/BlockMedia.cs
+++ b/Aaru.Core/Sidecar/BlockMedia.cs
@@ -61,6 +61,7 @@ namespace Aaru.Core
         /// <param name="plugins">Image plugins</param>
         /// <param name="imgChecksums">List of image checksums</param>
         /// <param name="sidecar">Metadata sidecar</param>
+        /// <param name="encoding">Encoding to be used for filesystem plugins</param>
         void BlockMedia(IMediaImage image, Guid filterId, string imagePath, FileInfo fi, PluginBase plugins,
                         List<ChecksumType> imgChecksums, ref CICMMetadataType sidecar, Encoding encoding)
         {
diff --git a/Aaru.Core/Sidecar/LinearMedia.cs b/Aaru.Core/Sidecar/LinearMedia.cs
index 1fc5770ce..ca84cefb4 100644
--- a/Aaru.Core/Sidecar/LinearMedia.cs
+++ b/Aaru.Core/Sidecar/LinearMedia.cs
@@ -51,6 +51,7 @@ namespace Aaru.Core
         /// <param name="plugins">Image plugins</param>
         /// <param name="imgChecksums">List of image checksums</param>
         /// <param name="sidecar">Metadata sidecar</param>
+        /// <param name="encoding">Encoding to be used for filesystem plugins</param>
         void LinearMedia(IMediaImage image, Guid filterId, string imagePath, FileInfo fi, PluginBase plugins,
                          List<ChecksumType> imgChecksums, ref CICMMetadataType sidecar, Encoding encoding) =>
             sidecar.LinearMedia = new[]
diff --git a/Aaru.Core/Sidecar/OpticalDisc.cs b/Aaru.Core/Sidecar/OpticalDisc.cs
index 1d58e1135..fabc3c7ea 100644
--- a/Aaru.Core/Sidecar/OpticalDisc.cs
+++ b/Aaru.Core/Sidecar/OpticalDisc.cs
@@ -61,6 +61,7 @@ namespace Aaru.Core
         /// <param name="plugins">Image plugins</param>
         /// <param name="imgChecksums">List of image checksums</param>
         /// <param name="sidecar">Metadata sidecar</param>
+        /// <param name="encoding">Encoding to be used for filesystem plugins</param>
         void OpticalDisc(IOpticalMediaImage image, Guid filterId, string imagePath, FileInfo fi, PluginBase plugins,
                          List<ChecksumType> imgChecksums, ref CICMMetadataType sidecar, Encoding encoding)
         {
diff --git a/Aaru.Filters/SplitJoinStream.cs b/Aaru.Filters/SplitJoinStream.cs
index e428b7283..80da974f7 100644
--- a/Aaru.Filters/SplitJoinStream.cs
+++ b/Aaru.Filters/SplitJoinStream.cs
@@ -111,6 +111,7 @@ namespace Aaru.Filters
         /// <param name="handle">A file handle for the file that the stream will encapsulate.</param>
         /// <param name="access">A bitwise combination of the enumeration values that determines how the file can be accessed by a <see cref="FileStream" /> object.</param>
         /// <param name="bufferSize">A positive Int32 value greater than 0 indicating the buffer size. The default buffer size is 4096.</param>
+        /// <param name="isAsync">Specifies whether to use asynchronous I/O or synchronous I/O.</param>
         public void Add(SafeFileHandle handle, FileAccess access, int bufferSize, bool isAsync) =>
             Add(new FileStream(handle, access, bufferSize, isAsync));
 
@@ -180,7 +181,7 @@ namespace Aaru.Filters
         /// <param name="index">The index into <paramref name="buffer"/> at which the stream begins.</param>
         /// <param name="count">The length in bytes to add to the end of the current stream.</param>
         /// <param name="writable">The setting of the CanWrite property, currently ignored.</param>
-        public void Add(byte[] buffer, int index, int count, bool writable, long start, long end) =>
+        public void Add(byte[] buffer, int index, int count, bool writable) =>
             Add(new MemoryStream(buffer, index, count, writable));
 
         /// <summary>