aaru-dps/Aaru
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2025-12-16 19:24:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

[GUI] Suppress warnings for async void methods in MediaScanViewModel

Browse Source
This commit is contained in:
Natalia Portillo
2025-11-20 02:34:56 +00:00
parent c1ddebe52c
commit c540bd794d
1 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
Aaru.Gui/ViewModels/Windows/MediaScanViewModel.cs
View File

@@ -55,6 +55,12 @@ using MsBox.Avalonia.Enums;
namespace Aaru.Gui.ViewModels.Windows; namespace Aaru.Gui.ViewModels.Windows;
[SuppressMessage("Usage", "VSTHRD100:Avoid async void methods", Justification = "Event handlers")]
[SuppressMessage("Philips Maintainability", "PH2096:Avoid async void", Justification = "Event handlers")]
[SuppressMessage("AsyncUsage",
"AsyncFixer03:Fire-and-forget async-void methods or delegates",
Justification = "Event handlers")]
[SuppressMessage("ReSharper", "AsyncVoidMethod", Justification = "Event handlers")]
public sealed partial class MediaScanViewModel : ViewModelBase public sealed partial class MediaScanViewModel : ViewModelBase
{ {
readonly Device _device; readonly Device _device;
@@ -171,7 +177,6 @@ public sealed partial class MediaScanViewModel : ViewModelBase
} }
// TODO: Allow to save MHDD and ImgBurn log files // TODO: Allow to save MHDD and ImgBurn log files
[SuppressMessage("ReSharper", "AsyncVoidMethod")]
async void DoWork() async void DoWork()
{ {
_localResults = new ScanResults(); _localResults = new ScanResults();
@@ -245,7 +250,6 @@ public sealed partial class MediaScanViewModel : ViewModelBase
await WorkFinished(); await WorkFinished();
} }
[SuppressMessage("ReSharper", "AsyncVoidMethod")]
async void ScanSpeed(ulong sector, double currentSpeed) => await Dispatcher.UIThread.InvokeAsync(() => async void ScanSpeed(ulong sector, double currentSpeed) => await Dispatcher.UIThread.InvokeAsync(() =>
{ {
SpeedData.Add((sector, currentSpeed)); SpeedData.Add((sector, currentSpeed));
@@ -253,7 +257,6 @@ public sealed partial class MediaScanViewModel : ViewModelBase
if(currentSpeed > MaxY) MaxY = currentSpeed + currentSpeed / 10d; if(currentSpeed > MaxY) MaxY = currentSpeed + currentSpeed / 10d;
}); });
[SuppressMessage("ReSharper", "AsyncVoidMethod")]
async void InitBlockMap(ulong blocks, ulong blockSize, ulong blocksToRead, ushort currentProfile) => async void InitBlockMap(ulong blocks, ulong blockSize, ulong blocksToRead, ushort currentProfile) =>
await Dispatcher.UIThread.InvokeAsync(() => await Dispatcher.UIThread.InvokeAsync(() =>
{ {
@@ -327,10 +330,8 @@ public sealed partial class MediaScanViewModel : ViewModelBase
ProgressVisible = false; ProgressVisible = false;
}); });
[SuppressMessage("ReSharper", "AsyncVoidMethod")]
async void EndProgress() => await Dispatcher.UIThread.InvokeAsync(() => { Progress1Visible = false; }); async void EndProgress() => await Dispatcher.UIThread.InvokeAsync(() => { Progress1Visible = false; });
[SuppressMessage("ReSharper", "AsyncVoidMethod")]
async void UpdateProgress(string text, long current, long maximum) => await Dispatcher.UIThread.InvokeAsync(() => async void UpdateProgress(string text, long current, long maximum) => await Dispatcher.UIThread.InvokeAsync(() =>
{ {
ProgressText = text; ProgressText = text;
@@ -340,19 +341,15 @@ public sealed partial class MediaScanViewModel : ViewModelBase
ProgressValue = current; ProgressValue = current;
}); });
[SuppressMessage("ReSharper", "AsyncVoidMethod")]
async void InitProgress() => await Dispatcher.UIThread.InvokeAsync(() => { Progress1Visible = true; }); async void InitProgress() => await Dispatcher.UIThread.InvokeAsync(() => { Progress1Visible = true; });
[SuppressMessage("ReSharper", "AsyncVoidMethod")]
async void PulseProgress(string text) => await Dispatcher.UIThread.InvokeAsync(() => async void PulseProgress(string text) => await Dispatcher.UIThread.InvokeAsync(() =>
{ {
ProgressText = text; ProgressText = text;
ProgressIndeterminate = true; ProgressIndeterminate = true;
}); });
[SuppressMessage("ReSharper", "AsyncVoidMethod")] #pragma warning disable AsyncFixer01
// ReSharper disable once AsyncVoidLambda
async void StoppingErrorMessage(string text) => await Dispatcher.UIThread.InvokeAsync(async () => async void StoppingErrorMessage(string text) => await Dispatcher.UIThread.InvokeAsync(async () =>
{ {
ProgressText = text; ProgressText = text;
@@ -362,18 +359,16 @@ public sealed partial class MediaScanViewModel : ViewModelBase
await WorkFinished(); await WorkFinished();
}); });
#pragma warning restore AsyncFixer01
[SuppressMessage("ReSharper", "AsyncVoidMethod")]
async void UpdateStatus(string text) => await Dispatcher.UIThread.InvokeAsync(() => { ProgressText = text; }); async void UpdateStatus(string text) => await Dispatcher.UIThread.InvokeAsync(() => { ProgressText = text; });
[SuppressMessage("ReSharper", "AsyncVoidMethod")]
async void OnScanUnreadable(ulong sector) => await Dispatcher.UIThread.InvokeAsync(() => async void OnScanUnreadable(ulong sector) => await Dispatcher.UIThread.InvokeAsync(() =>
{ {
_localResults.Errored += _blocksToRead; _localResults.Errored += _blocksToRead;
UnreadableSectors = string.Format(Localization.Core._0_sectors_could_not_be_read, _localResults.Errored); UnreadableSectors = string.Format(Localization.Core._0_sectors_could_not_be_read, _localResults.Errored);
}); });
[SuppressMessage("ReSharper", "AsyncVoidMethod")]
async void OnScanTime(ulong sector, double duration) async void OnScanTime(ulong sector, double duration)
{ {
// Update local results counters (thread-safe, no UI dispatch needed) // Update local results counters (thread-safe, no UI dispatch needed)