diff --git a/Aaru.CommonTypes b/Aaru.CommonTypes
index 8d40f3e39..7455b48f8 160000
--- a/Aaru.CommonTypes
+++ b/Aaru.CommonTypes
@@ -1 +1 @@
-Subproject commit 8d40f3e395e751ff62e7678252e9eac6b21b27ff
+Subproject commit 7455b48f8f33cb3d201165fb975c3dbb86284f09
diff --git a/Aaru.Compression/ADC.cs b/Aaru.Compression/ADC.cs
index 53c720269..42f0dabcd 100644
--- a/Aaru.Compression/ADC.cs
+++ b/Aaru.Compression/ADC.cs
@@ -42,6 +42,7 @@ using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
/// Implements the Apple version of RLE
+// ReSharper disable once InconsistentNaming
public static class ADC
{
const int PLAIN = 1;
@@ -51,7 +52,7 @@ public static class ADC
public static bool IsSupported => true;
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern int AARU_adc_decode_buffer(byte[] dst_buffer, int dst_size, byte[] src_buffer, int src_size);
+ static extern int AARU_adc_decode_buffer(byte[] dstBuffer, int dstSize, byte[] srcBuffer, int srcSize);
[MethodImpl(MethodImplOptions.AggressiveInlining)]
static int GetChunkType(byte byt) => (byt & 0x80) == 0x80
diff --git a/Aaru.Compression/AppleRle.cs b/Aaru.Compression/AppleRle.cs
index 0f3baad55..5f8dd818d 100644
--- a/Aaru.Compression/AppleRle.cs
+++ b/Aaru.Compression/AppleRle.cs
@@ -43,7 +43,7 @@ public static class AppleRle
public static bool IsSupported => true;
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern int AARU_apple_rle_decode_buffer(byte[] dst_buffer, int dst_size, byte[] src_buffer, int src_size);
+ static extern int AARU_apple_rle_decode_buffer(byte[] dstBuffer, int dstSize, byte[] srcBuffer, int srcSize);
/// Decodes a buffer compressed with Apple RLE
/// Encoded buffer
diff --git a/Aaru.Compression/BZip2.cs b/Aaru.Compression/BZip2.cs
index a8b30bd1a..9accf5278 100644
--- a/Aaru.Compression/BZip2.cs
+++ b/Aaru.Compression/BZip2.cs
@@ -38,11 +38,11 @@ public class BZip2
public static bool IsSupported => true;
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern int AARU_bzip2_decode_buffer(byte[] dst_buffer, ref uint dst_size, byte[] src_buffer, uint src_size);
+ static extern int AARU_bzip2_decode_buffer(byte[] dstBuffer, ref uint dstSize, byte[] srcBuffer, uint srcSize);
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern int AARU_bzip2_encode_buffer(byte[] dst_buffer, ref uint dst_size, byte[] src_buffer, uint src_size,
- int blockSize100k);
+ static extern int AARU_bzip2_encode_buffer(byte[] dstBuffer, ref uint dstSize, byte[] srcBuffer, uint srcSize,
+ int blockSize100K);
/// Decodes a buffer compressed with BZIP2
/// Encoded buffer
@@ -68,21 +68,21 @@ public class BZip2
/// Compresses a buffer using BZIP2
/// Data to compress
/// Buffer to store the compressed data
- /// Block size in 100KiB units
+ /// Block size in 100KiB units
///
- public static int EncodeBuffer(byte[] source, byte[] destination, int blockSize100k)
+ public static int EncodeBuffer(byte[] source, byte[] destination, int blockSize100K)
{
var destinationSize = (uint)destination.Length;
if(Native.IsSupported)
{
- AARU_bzip2_encode_buffer(destination, ref destinationSize, source, (uint)source.Length, blockSize100k);
+ AARU_bzip2_encode_buffer(destination, ref destinationSize, source, (uint)source.Length, blockSize100K);
return (int)destinationSize;
}
using var cmpMs = new MemoryStream(source);
- using var encStream = new BZip2OutputStream(new MemoryStream(destination), blockSize100k);
+ using var encStream = new BZip2OutputStream(new MemoryStream(destination), blockSize100K);
encStream.Write(source, 0, source.Length);
return source.Length;
diff --git a/Aaru.Compression/FLAC.cs b/Aaru.Compression/FLAC.cs
index 74e780142..5bf9567f8 100644
--- a/Aaru.Compression/FLAC.cs
+++ b/Aaru.Compression/FLAC.cs
@@ -33,24 +33,25 @@ using System.Runtime.InteropServices;
using CUETools.Codecs;
using CUETools.Codecs.Flake;
+// ReSharper disable once InconsistentNaming
public class FLAC
{
/// Set to true if this algorithm is supported, false otherwise.
public static bool IsSupported => true;
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern nuint AARU_flac_decode_redbook_buffer(byte[] dst_buffer, nuint dst_size, byte[] src_buffer,
- nuint src_size);
+ static extern nuint AARU_flac_decode_redbook_buffer(byte[] dstBuffer, nuint dstSize, byte[] srcBuffer,
+ nuint srcSize);
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern nuint AARU_flac_encode_redbook_buffer(byte[] dst_buffer, nuint dst_size, byte[] src_buffer,
- nuint src_size, uint blocksize, int do_mid_side_stereo,
- int loose_mid_side_stereo, string apodization,
- uint max_lpc_order, uint qlp_coeff_precision,
- int do_qlp_coeff_prec_search, int do_exhaustive_model_search,
- uint min_residual_partition_order,
- uint max_residual_partition_order, string application_id,
- uint application_id_len);
+ static extern nuint AARU_flac_encode_redbook_buffer(byte[] dstBuffer, nuint dstSize, byte[] srcBuffer,
+ nuint srcSize, uint blocksize, int doMidSideStereo,
+ int looseMidSideStereo, string apodization,
+ uint maxLpcOrder, uint qlpCoeffPrecision,
+ int doQlpCoeffPrecSearch, int doExhaustiveModelSearch,
+ uint minResidualPartitionOrder,
+ uint maxResidualPartitionOrder, string applicationID,
+ uint applicationIDLen);
/// Decodes a buffer compressed with FLAC
/// Encoded buffer
@@ -78,14 +79,14 @@ public class FLAC
/// Buffer to store the compressed data
///
public static int EncodeBuffer(byte[] source, byte[] destination, uint blockSize, bool doMidSideStereo,
- bool looseMidSideStereo, string apodization, uint max_lpc_order,
+ bool looseMidSideStereo, string apodization, uint maxLpcOrder,
uint qlpCoeffPrecision, bool doQlpCoeffPrecSearch, bool doExhaustiveModelSearch,
uint minResidualPartitionOrder, uint maxResidualPartitionOrder, string applicationID)
{
if(Native.IsSupported)
return (int)AARU_flac_encode_redbook_buffer(destination, (nuint)destination.Length, source,
(nuint)source.Length, blockSize, doMidSideStereo ? 1 : 0,
- looseMidSideStereo ? 1 : 0, apodization, max_lpc_order,
+ looseMidSideStereo ? 1 : 0, apodization, maxLpcOrder,
qlpCoeffPrecision, doQlpCoeffPrecSearch ? 1 : 0,
doExhaustiveModelSearch ? 1 : 0, minResidualPartitionOrder,
maxResidualPartitionOrder, applicationID,
diff --git a/Aaru.Compression/LZFSE.cs b/Aaru.Compression/LZFSE.cs
index 9992fc957..d3ae4d2bd 100644
--- a/Aaru.Compression/LZFSE.cs
+++ b/Aaru.Compression/LZFSE.cs
@@ -30,18 +30,19 @@ namespace Aaru.Compression;
using System.Runtime.InteropServices;
+// ReSharper disable once InconsistentNaming
public class LZFSE
{
/// Set to true if this algorithm is supported, false otherwise.
public static bool IsSupported => Native.IsSupported;
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern nuint AARU_lzfse_decode_buffer(byte[] dst_buffer, nuint dst_size, byte[] src_buffer, nuint src_size,
- byte[] scratch_buffer);
+ static extern nuint AARU_lzfse_decode_buffer(byte[] dstBuffer, nuint dstSize, byte[] srcBuffer, nuint srcSize,
+ byte[] scratchBuffer);
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern nuint AARU_lzfse_encode_buffer(byte[] dst_buffer, nuint dst_size, byte[] src_buffer, nuint src_size,
- byte[] scratch_buffer);
+ static extern nuint AARU_lzfse_encode_buffer(byte[] dstBuffer, nuint dstSize, byte[] srcBuffer, nuint srcSize,
+ byte[] scratchBuffer);
/// Decodes a buffer compressed with LZFSE
/// Encoded buffer
diff --git a/Aaru.Compression/LZIP.cs b/Aaru.Compression/LZIP.cs
index f669fc2dc..66af13402 100644
--- a/Aaru.Compression/LZIP.cs
+++ b/Aaru.Compression/LZIP.cs
@@ -30,17 +30,18 @@ namespace Aaru.Compression;
using System.Runtime.InteropServices;
+// ReSharper disable once InconsistentNaming
public class LZIP
{
/// Set to true if this algorithm is supported, false otherwise.
public static bool IsSupported => Native.IsSupported;
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern int AARU_lzip_decode_buffer(byte[] dst_buffer, int dst_size, byte[] src_buffer, int src_size);
+ static extern int AARU_lzip_decode_buffer(byte[] dstBuffer, int dstSize, byte[] srcBuffer, int srcSize);
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern int AARU_lzip_encode_buffer(byte[] dst_buffer, int dst_size, byte[] src_buffer, int src_size,
- int dictionary_size, int match_len_limit);
+ static extern int AARU_lzip_encode_buffer(byte[] dstBuffer, int dstSize, byte[] srcBuffer, int srcSize,
+ int dictionarySize, int matchLenLimit);
/// Decodes a buffer compressed with LZIP
/// Encoded buffer
diff --git a/Aaru.Compression/LZMA.cs b/Aaru.Compression/LZMA.cs
index e855eac86..7f05f6a22 100644
--- a/Aaru.Compression/LZMA.cs
+++ b/Aaru.Compression/LZMA.cs
@@ -38,11 +38,11 @@ public class LZMA
public static bool IsSupported => true;
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern int AARU_lzma_decode_buffer(byte[] dst_buffer, ref nuint dst_size, byte[] src_buffer,
- ref nuint src_size, byte[] props, nuint propsSize);
+ static extern int AARU_lzma_decode_buffer(byte[] dstBuffer, ref nuint dstSize, byte[] srcBuffer,
+ ref nuint srcSize, byte[] props, nuint propsSize);
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern int AARU_lzma_encode_buffer(byte[] dst_buffer, ref nuint dst_size, byte[] src_buffer, nuint src_size,
+ static extern int AARU_lzma_encode_buffer(byte[] dstBuffer, ref nuint dstSize, byte[] srcBuffer, nuint srcSize,
byte[] outProps, ref nuint outPropsSize, int level, uint dictSize, int lc,
int lp, int pb, int fb, int numThreads);
@@ -90,9 +90,9 @@ public class LZMA
return (int)dstSize;
}
- var _lzmaEncoderProperties = new LzmaEncoderProperties(true, (int)dictSize, fb);
+ var lzmaEncoderProperties = new LzmaEncoderProperties(true, (int)dictSize, fb);
- using var lzmaStream = new LzmaStream(_lzmaEncoderProperties, false, new MemoryStream(destination));
+ using var lzmaStream = new LzmaStream(lzmaEncoderProperties, false, new MemoryStream(destination));
lzmaStream.Write(source, 0, source.Length);
properties = new byte[lzmaStream.Properties.Length];
diff --git a/Aaru.Compression/ZSTD.cs b/Aaru.Compression/ZSTD.cs
index 0ea2791cf..9ee226b09 100644
--- a/Aaru.Compression/ZSTD.cs
+++ b/Aaru.Compression/ZSTD.cs
@@ -30,16 +30,17 @@ namespace Aaru.Compression;
using System.Runtime.InteropServices;
+// ReSharper disable once InconsistentNaming
public class ZSTD
{
/// Set to true if this algorithm is supported, false otherwise.
public static bool IsSupported => Native.IsSupported;
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern nuint AARU_zstd_decode_buffer(byte[] dst_buffer, nuint dst_size, byte[] src_buffer, nuint src_size);
+ static extern nuint AARU_zstd_decode_buffer(byte[] dstBuffer, nuint dstSize, byte[] srcBuffer, nuint srcSize);
[DllImport("libAaru.Compression.Native", SetLastError = true)]
- static extern nuint AARU_zstd_encode_buffer(byte[] dst_buffer, nuint dst_size, byte[] src_buffer, nuint src_size,
+ static extern nuint AARU_zstd_encode_buffer(byte[] dstBuffer, nuint dstSize, byte[] srcBuffer, nuint srcSize,
int compressionLevel);
/// Decodes a buffer compressed with ZSTD
diff --git a/Aaru.Filesystems/ISO9660/Consts/ElTorito.cs b/Aaru.Filesystems/ISO9660/Consts/ElTorito.cs
index 1c78e4a74..109b29e7b 100644
--- a/Aaru.Filesystems/ISO9660/Consts/ElTorito.cs
+++ b/Aaru.Filesystems/ISO9660/Consts/ElTorito.cs
@@ -38,6 +38,7 @@
namespace Aaru.Filesystems;
using System;
+using System.Diagnostics.CodeAnalysis;
public sealed partial class ISO9660
{
@@ -53,6 +54,7 @@ public sealed partial class ISO9660
LastHeader = 0x91
}
+ [SuppressMessage("ReSharper", "InconsistentNaming")]
enum ElToritoPlatform : byte
{
x86 = 0,
diff --git a/Aaru.Filesystems/exFAT.cs b/Aaru.Filesystems/exFAT.cs
index 46fe3dc61..f53b81aa6 100644
--- a/Aaru.Filesystems/exFAT.cs
+++ b/Aaru.Filesystems/exFAT.cs
@@ -47,6 +47,7 @@ using Marshal = Aaru.Helpers.Marshal;
///
/// Implements detection of the exFAT filesystem
[SuppressMessage("ReSharper", "UnusedMember.Local")]
+// ReSharper disable once InconsistentNaming
public sealed class exFAT : IFilesystem
{
readonly Guid _oemFlashParameterGuid = new("0A0C7E46-3399-4021-90C8-FA6D389C4BA2");
diff --git a/Aaru.Filesystems/ext2FS.cs b/Aaru.Filesystems/ext2FS.cs
index 6601a7586..5046f0aa2 100644
--- a/Aaru.Filesystems/ext2FS.cs
+++ b/Aaru.Filesystems/ext2FS.cs
@@ -47,6 +47,7 @@ using Marshal = Aaru.Helpers.Marshal;
///
/// Implements detection of the Linux extended filesystem v2, v3 and v4
[SuppressMessage("ReSharper", "UnusedMember.Local")]
+// ReSharper disable once InconsistentNaming
public sealed class ext2FS : IFilesystem
{
const int SB_POS = 0x400;
@@ -147,6 +148,7 @@ public sealed class ext2FS : IFilesystem
/// Volume use extents *ext4*
const uint EXT4_FEATURE_INCOMPAT_EXTENTS = 0x00000040;
/// Supports volumes bigger than 2^32 blocks *ext4*
+ // ReSharper disable once InconsistentNaming
const uint EXT4_FEATURE_INCOMPAT_64BIT = 0x00000080;
/// Multi-mount protection *ext4*
const uint EXT4_FEATURE_INCOMPAT_MMP = 0x00000100;
diff --git a/Aaru.Filesystems/extFS.cs b/Aaru.Filesystems/extFS.cs
index 93e921e62..f430334a1 100644
--- a/Aaru.Filesystems/extFS.cs
+++ b/Aaru.Filesystems/extFS.cs
@@ -43,6 +43,7 @@ using Schemas;
// Information from the Linux kernel
///
/// Implements detection of the Linux extended filesystem
+// ReSharper disable once InconsistentNaming
public sealed class extFS : IFilesystem
{
const int SB_POS = 0x400;
diff --git a/Aaru.Images/CHD/Constants.cs b/Aaru.Images/CHD/Constants.cs
index f33dcf87d..7c0e5db5f 100644
--- a/Aaru.Images/CHD/Constants.cs
+++ b/Aaru.Images/CHD/Constants.cs
@@ -69,6 +69,7 @@ public sealed partial class Chd
const string REGEX_METADATA_GDROM =
@"TRACK:(?