aaru-dps/Aaru
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2025-12-16 19:24:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allocate SENSE buffer only once.

Browse Source
This commit is contained in:
Natalia Portillo
2025-08-22 19:57:09 +01:00
parent 8e2fdd91a6
commit e4f55d3b3c
73 changed files with 1892 additions and 2565 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Aaru.Decoders/SCSI/Sense.cs
View File

@@ -219,7 +219,7 @@ public static class Sense
return decoded;
}
public static DecodedSense? Decode(byte[] sense)
public static DecodedSense? Decode(ReadOnlySpan<byte> sense)
{
var decoded = new DecodedSense();
@@ -227,12 +227,12 @@ public static class Sense
{
case 0x70:
case 0x71:
decoded.Fixed = DecodeFixed(sense);
decoded.Fixed = DecodeFixed(sense.ToArray());
break;
case 0x72:
case 0x73:
decoded.Descriptor = DecodeDescriptor(sense);
decoded.Descriptor = DecodeDescriptor(sense.ToArray());
break;
}
@@ -310,7 +310,7 @@ public static class Sense
senseDescription = GetSenseDescription(decoded.ASC, decoded.ASCQ);
var offset = 8;
int offset = 8;
while(offset < sense.Length)
{
@@ -319,7 +319,7 @@ public static class Sense
byte descType = sense[offset];
int descLen = sense[offset + 1] + 2;
var desc = new byte[descLen];
byte[] desc = new byte[descLen];
if(offset + descLen >= sense.Length) descLen = sense.Length - offset;
@@ -466,7 +466,7 @@ public static class Sense
{
if(descriptor.Length != 12 || descriptor[0] != 0x00) return 0;
var temp = new byte[8];
byte[] temp = new byte[8];
temp[0] = descriptor[11];
temp[1] = descriptor[10];
@@ -487,7 +487,7 @@ public static class Sense
{
if(descriptor.Length != 12 || descriptor[0] != 0x01) return 0;
var temp = new byte[8];
byte[] temp = new byte[8];
temp[0] = descriptor[11];
temp[1] = descriptor[10];
@@ -508,7 +508,7 @@ public static class Sense
{
if(descriptor.Length != 8 || descriptor[0] != 0x02) return null;
var temp = new byte[3];
byte[] temp = new byte[3];
Array.Copy(descriptor, 4, temp, 0, 3);
return temp;
@@ -2705,4 +2705,6 @@ public static class Sense
? string.Format(Localization.ASC_0_WITH_VENDOR_SPECIFIC_ASCQ_1, ASC, ASCQ)
: string.Format(Localization.ASC_0_WITH_ASCQ_1, ASC, ASCQ);
}
public static string PrettifySense(ReadOnlySpan<byte> senseBuffer) => PrettifySense(senseBuffer.ToArray());
}