aaru-dps/Aaru
1
0
Fork 0
mirror of https://github.com/aaru-dps/Aaru.git synced 2025-12-16 19:24:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor IMediaImage.Open to return error status instead of boolean.

Browse Source
This commit is contained in:
Natalia Portillo
2021-09-16 19:10:39 +01:00
parent ac275aa8cb
commit ef2fc1788a
86 changed files with 699 additions and 512 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
Aaru.Tests/Images/TapeMediaImageTest.cs
View File

@@ -2,6 +2,7 @@ using System;
using System.IO;
using Aaru.Checksums;
using Aaru.CommonTypes;
using Aaru.CommonTypes.Enums;
using Aaru.CommonTypes.Interfaces;
using FluentAssertions;
using FluentAssertions.Execution;
@@ -42,10 +43,10 @@ namespace Aaru.Tests.Images
var image = Activator.CreateInstance(_plugin.GetType()) as ITapeImage;
Assert.NotNull(image, $"Could not instantiate filesystem for {testFile}");
bool opened = image.Open(filter);
Assert.AreEqual(true, opened, $"Open: {testFile}");
ErrorNumber opened = image.Open(filter);
Assert.AreEqual(ErrorNumber.NoError, opened, $"Open: {testFile}");
if(!opened)
if(opened != ErrorNumber.NoError)
continue;
Assert.AreEqual(true, image.IsTape, $"Is tape?: {testFile}");
@@ -90,10 +91,10 @@ namespace Aaru.Tests.Images
var image = Activator.CreateInstance(_plugin.GetType()) as IMediaImage;
Assert.NotNull(image, $"Could not instantiate filesystem for {testFile}");
bool opened = image.Open(filter);
Assert.AreEqual(true, opened, $"Open: {testFile}");
ErrorNumber opened = image.Open(filter);
Assert.AreEqual(ErrorNumber.NoError, opened, $"Open: {testFile}");
if(!opened)
if(opened != ErrorNumber.NoError)
continue;
using(new AssertionScope())
@@ -135,10 +136,10 @@ namespace Aaru.Tests.Images
var image = Activator.CreateInstance(_plugin.GetType()) as IMediaImage;
Assert.NotNull(image, $"Could not instantiate filesystem for {testFile}");
bool opened = image.Open(filter);
Assert.AreEqual(true, opened, $"Open: {testFile}");
ErrorNumber opened = image.Open(filter);
Assert.AreEqual(ErrorNumber.NoError, opened, $"Open: {testFile}");
if(!opened)
if(opened != ErrorNumber.NoError)
continue;
ulong doneSectors = 0;