Use Array.Empty<T>.

This commit is contained in:
2021-08-17 18:21:12 +01:00
parent f14592b392
commit fdff1d74c9
41 changed files with 98 additions and 86 deletions

View File

@@ -30,6 +30,7 @@
// Copyright © 2011-2021 Natalia Portillo
// ****************************************************************************/
using System;
using Aaru.Console;
namespace Aaru.Devices
@@ -82,7 +83,7 @@ namespace Aaru.Devices
public bool ArchiveCorpSeekBlock(out byte[] senseBuffer, bool immediate, uint lba, uint timeout,
out double duration)
{
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
byte[] cdb = new byte[6];
senseBuffer = new byte[64];

View File

@@ -30,6 +30,7 @@
// Copyright © 2011-2021 Natalia Portillo
// ****************************************************************************/
using System;
using System.Diagnostics.CodeAnalysis;
using Aaru.Console;
@@ -59,7 +60,7 @@ namespace Aaru.Devices
/// <param name="duration">Duration.</param>
public bool CertanceParkUnpark(out byte[] senseBuffer, bool park, uint timeout, out double duration)
{
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
byte[] cdb = new byte[6];
senseBuffer = new byte[64];

View File

@@ -46,7 +46,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[6];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.KreonCommand;
cdb[1] = 0x08;
@@ -97,7 +97,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[6];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.KreonCommand;
cdb[1] = 0x08;

View File

@@ -556,7 +556,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[6];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.PreventAllowMediumRemoval;
@@ -626,7 +626,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[6];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.StartStopUnit;
@@ -757,7 +757,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[12];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.SetCdRomSpeed;
cdb[1] = (byte)((byte)rotationalControl & 0x03);

View File

@@ -30,6 +30,7 @@
// Copyright © 2011-2021 Natalia Portillo
// ****************************************************************************/
using System;
using Aaru.Console;
// ReSharper disable InconsistentNaming
@@ -144,7 +145,7 @@ namespace Aaru.Devices
cdb[0] = (byte)ScsiCommands.MiniDiscStopPlay;
buffer = new byte[0];
buffer = Array.Empty<byte>();
LastError = SendScsiCommand(cdb, ref buffer, out senseBuffer, timeout, ScsiDirection.None, out duration,
out bool sense);

View File

@@ -30,6 +30,7 @@
// Copyright © 2011-2021 Natalia Portillo
// ****************************************************************************/
using System;
using Aaru.Console;
using Aaru.Decoders.SCSI;
@@ -63,7 +64,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[10];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
foundLba = 0;
foundBlocks = 0;

View File

@@ -389,7 +389,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[6];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.Seek6;
cdb[1] = (byte)((lba & 0x1F0000) >> 16);
@@ -415,7 +415,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[10];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.Seek10;
cdb[2] = (byte)((lba & 0xFF000000) >> 24);

View File

@@ -202,7 +202,7 @@ namespace Aaru.Devices
(byte)ScsiCommands.TestUnitReady, 0, 0, 0, 0, 0
};
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
LastError = SendScsiCommand(cdb, ref buffer, out senseBuffer, timeout, ScsiDirection.None, out duration,
out bool sense);
@@ -420,7 +420,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[6];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.PreventAllowMediumRemoval;
cdb[4] = (byte)((byte)preventMode & 0x03);

View File

@@ -71,7 +71,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[6];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.LoadUnload;
@@ -151,7 +151,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[10];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.Locate;
@@ -235,7 +235,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[16];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
byte[] idBytes = BitConverter.GetBytes(identifier);
cdb[0] = (byte)ScsiCommands.Locate16;
@@ -910,7 +910,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[6];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.Rewind;
@@ -937,7 +937,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[6];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
cdb[0] = (byte)ScsiCommands.TrackSelect;
cdb[5] = track;
@@ -965,7 +965,7 @@ namespace Aaru.Devices
{
senseBuffer = new byte[64];
byte[] cdb = new byte[6];
byte[] buffer = new byte[0];
byte[] buffer = Array.Empty<byte>();
byte[] countB = BitConverter.GetBytes(count);
cdb[0] = (byte)ScsiCommands.Space;

View File

@@ -30,6 +30,7 @@
// Copyright © 2011-2021 Natalia Portillo
// ****************************************************************************/
using System;
using Aaru.Console;
namespace Aaru.Devices
@@ -99,7 +100,7 @@ namespace Aaru.Devices
cdb[4] = 1;
}
else
buffer = new byte[0];
buffer = Array.Empty<byte>();
if(!inhibitDma)
LastError = SendScsiCommand(cdb, ref buffer, out senseBuffer, timeout, ScsiDirection.In, out duration,
@@ -178,7 +179,7 @@ namespace Aaru.Devices
cdb[4] = 1;
}
else
buffer = new byte[0];
buffer = Array.Empty<byte>();
if(!inhibitDma)
LastError = SendScsiCommand(cdb, ref buffer, out senseBuffer, timeout, ScsiDirection.In, out duration,