aaru-dps/RedBookPlayer
1
0
Fork 0
mirror of https://github.com/aaru-dps/RedBookPlayer.git synced 2026-02-11 13:34:57 +00:00
Code Issues 41 Packages Projects Releases Wiki Activity

[Refactor] Update initialization #28

New Issue
Closed
opened 2026-01-30 21:22:58 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 21:22:58 +00:00
Owner
Copy Link

Originally created by @mnadareski on GitHub (Jul 10, 2021).

Currently, initialization acts like both initialize and load. These pieces of functionality should be separated out. This would allow for some parts of the state to maintain consistency, like the current playback volume.

Originally created by @mnadareski on GitHub (Jul 10, 2021). Currently, initialization acts like both initialize and load. These pieces of functionality should be separated out. This would allow for some parts of the state to maintain consistency, like the current playback volume.
claunia commented 2026-01-30 21:22:59 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jul 10, 2021):

Notes to self:

  • Make initialization just init of internal state
  • Make loading of images decoupled from init
  • Make more settings persistent, such as auto-play, loading tracks, etc
  • Make current playback volume consistent if loading a new image
@mnadareski commented on GitHub (Jul 10, 2021): Notes to self: - Make initialization just init of internal state - Make loading of images decoupled from init - Make more settings persistent, such as auto-play, loading tracks, etc - Make current playback volume consistent if loading a new image
claunia commented 2026-01-30 21:22:59 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jul 10, 2021):

Open question: What should care about autoplay? Currently, everything down to the sound output cares about autoplay. Should only the Player care? The PlayerViewModel? The PlayerView?

@mnadareski commented on GitHub (Jul 10, 2021): Open question: What should care about autoplay? Currently, everything down to the sound output cares about autoplay. Should only the Player care? The PlayerViewModel? The PlayerView?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/RedBookPlayer#28
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?