[PR #12] [MERGED] Player Refactor #53

New Issue

claunia · 2026-01-30T21:23:12Z

claunia commented

2026-01-30 21:23:12 +00:00

📋 Pull Request Information

Original PR: https://github.com/aaru-dps/RedBookPlayer/pull/12
Author: @mnadareski
Created: 6/22/2021
Status: ✅ Merged
Merged: 6/29/2021
Merged by: @claunia

Base: devel ← Head: player-refactor

📝 Commits (10+)

28a7e47 Migrate to official CSCore repo
1715388 Split PlayableDisc from Player
02193ad Only check disc init for displaying the time
7fba90d Remove unnecessary async from TOC load
5d0e16f Fix PreviousIndex behavior
49ff21e Update Aaru submodule
a8ccfe2 Separate loading into a new method
60edd57 Use IOpticalMediaImage, check 4CH, better subchannel usage
f28de1a Fix comments
34c1d7a Fix track flags, fix track changing again

📊 Changes

8 files changed (+833 additions, -688 deletions)

View changed files

📝 .gitmodules (+1 -1)
📝 Aaru (+1 -1)
➕ RedBookPlayer/PlayableDisc.cs (+699 -0)
📝 RedBookPlayer/Player.cs (+25 -628)
📝 RedBookPlayer/PlayerView.xaml (+2 -0)
📝 RedBookPlayer/PlayerView.xaml.cs (+98 -56)
📝 RedBookPlayer/PlayerViewModel.cs (+7 -0)
📝 RedBookPlayer/SettingsWindow.xaml.cs (+0 -2)

📄 Description

This PR does the following:

Migrate to official CSCore repo instead of a fork of a fork (fixes #6)
Splits out all image reading and manipulation into a new file called PlayableDisc
Fixes some issues present in loading a disc with a data first track
Fixes some initialization issues that could be present
Removed the Player code from being able to directly manipulate most of the disc state
Fix PreviousIndex and PreviousTrack behavior
Update included Aaru version

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aaru-dps/RedBookPlayer/pull/12 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/22/2021 **Status:** ✅ Merged **Merged:** 6/29/2021 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `devel` ← **Head:** `player-refactor` --- ### 📝 Commits (10+) - [`28a7e47`](https://github.com/aaru-dps/RedBookPlayer/commit/28a7e470a2dab3bc30162e1a0a4f1bda6d9fcae0) Migrate to official CSCore repo - [`1715388`](https://github.com/aaru-dps/RedBookPlayer/commit/1715388e2996423af26889556ead26f6b8a77d5a) Split PlayableDisc from Player - [`02193ad`](https://github.com/aaru-dps/RedBookPlayer/commit/02193adc51e432f771be85da36887dcf33dab042) Only check disc init for displaying the time - [`7fba90d`](https://github.com/aaru-dps/RedBookPlayer/commit/7fba90d870671c1c27b980f2a379c26fdbbfcf10) Remove unnecessary async from TOC load - [`5d0e16f`](https://github.com/aaru-dps/RedBookPlayer/commit/5d0e16f881368eb9e56a0b4128dfc490ca37e0e6) Fix PreviousIndex behavior - [`49ff21e`](https://github.com/aaru-dps/RedBookPlayer/commit/49ff21eaf4b9520beb290470e64f6a870ecbc92f) Update Aaru submodule - [`a8ccfe2`](https://github.com/aaru-dps/RedBookPlayer/commit/a8ccfe2034edc66f284d0f86632cfa76c00d2e28) Separate loading into a new method - [`60edd57`](https://github.com/aaru-dps/RedBookPlayer/commit/60edd5777173089b6203a0cde4591220fff3aec3) Use IOpticalMediaImage, check 4CH, better subchannel usage - [`f28de1a`](https://github.com/aaru-dps/RedBookPlayer/commit/f28de1a13d04fb928eb61e16c4a605096afc2685) Fix comments - [`34c1d7a`](https://github.com/aaru-dps/RedBookPlayer/commit/34c1d7a450937ff60bbcf20f3d63920f63f6ed64) Fix track flags, fix track changing again ### 📊 Changes **8 files changed** (+833 additions, -688 deletions) <details> <summary>View changed files</summary> 📝 `.gitmodules` (+1 -1) 📝 `Aaru` (+1 -1) ➕ `RedBookPlayer/PlayableDisc.cs` (+699 -0) 📝 `RedBookPlayer/Player.cs` (+25 -628) 📝 `RedBookPlayer/PlayerView.xaml` (+2 -0) 📝 `RedBookPlayer/PlayerView.xaml.cs` (+98 -56) 📝 `RedBookPlayer/PlayerViewModel.cs` (+7 -0) 📝 `RedBookPlayer/SettingsWindow.xaml.cs` (+0 -2) </details> ### 📄 Description This PR does the following: - Migrate to official CSCore repo instead of a fork of a fork (fixes #6) - Splits out all image reading and manipulation into a new file called PlayableDisc - Fixes some issues present in loading a disc with a data first track - Fixes some initialization issues that could be present - Removed the Player code from being able to directly manipulate most of the disc state - Fix PreviousIndex and PreviousTrack behavior - Update included Aaru version --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-30 21:23:12 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: aaru-dps/RedBookPlayer#53