aaru-dps/RedBookPlayer
1
0
Fork 0
mirror of https://github.com/aaru-dps/RedBookPlayer.git synced 2026-02-09 21:24:06 +00:00
Code Issues 41 Packages Projects Releases Wiki Activity

[PR #46] [MERGED] MVVM v2 Feature Work #63

New Issue
Open
opened 2026-01-30 21:23:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 21:23:14 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/aaru-dps/RedBookPlayer/pull/46
Author: @mnadareski
Created: 8/25/2021
Status: ✅ Merged
Merged: 10/1/2021
Merged by: @claunia

Base: devel ← Head: mvvm-v2-features

📝 Commits (6)

  • a799d5e Port only distinct new feature work
  • b795d1f Make *nix build script executable by default
  • 22b00b1 DataPlayback option applies to saving tracks
  • 0251dae Extract filtering to new file
  • f7e8aaf Use Aaru nuget packages
  • 9b723ff Update Aaru nuget packages to 5.3.0 LTS

📊 Changes

17 files changed (+466 additions, -224 deletions)

View changed files

📝 .gitmodules (+0 -3)
➖ Aaru (+0 -1)
📝 README.md (+6 -0)
📝 RedBookPlayer.GUI/ViewModels/MainViewModel.cs (+23 -0)
📝 RedBookPlayer.GUI/ViewModels/PlayerViewModel.cs (+55 -5)
📝 RedBookPlayer.GUI/ViewModels/SettingsViewModel.cs (+37 -0)
📝 RedBookPlayer.GUI/Views/SettingsWindow.xaml (+16 -0)
📝 RedBookPlayer.Models/Discs/CompactDisc.cs (+85 -4)
📝 RedBookPlayer.Models/Discs/OpticalDiscBase.cs (+18 -0)
📝 RedBookPlayer.Models/Discs/OpticalDiscOptions.cs (+5 -0)
📝 RedBookPlayer.Models/Enums.cs (+37 -0)
➕ RedBookPlayer.Models/Hardware/FilterStage.cs (+58 -0)
📝 RedBookPlayer.Models/Hardware/Player.cs (+69 -2)
📝 RedBookPlayer.Models/Hardware/SoundOutput.cs (+54 -51)
📝 RedBookPlayer.Models/RedBookPlayer.Models.csproj (+3 -3)
📝 RedBookPlayer.sln (+0 -155)
📝 build.sh (+0 -0)

📄 Description

This PR does the following:

  • Migrate to Aaru Nuget packages (fixes #7)
  • Add WAV saving for both single track and all tracks (fixes #20)
  • Add repeat modes (fixes #27)
  • Add eject functionality (fixes #29)
  • Add multiple session handling (fixes #32)
  • Add data track saving (fixes #47)
  • Bumped sector readahead to 10
  • Made build.sh executable by default

This PR is the second of two to be split off from https://github.com/aaru-dps/RedBookPlayer/pull/40.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aaru-dps/RedBookPlayer/pull/46 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 8/25/2021 **Status:** ✅ Merged **Merged:** 10/1/2021 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `devel` ← **Head:** `mvvm-v2-features` --- ### 📝 Commits (6) - [`a799d5e`](https://github.com/aaru-dps/RedBookPlayer/commit/a799d5ede9151c335dc7847a41eba4687cefe392) Port only distinct new feature work - [`b795d1f`](https://github.com/aaru-dps/RedBookPlayer/commit/b795d1ffdacd859c63482416b0e9f4c4fe4aa176) Make *nix build script executable by default - [`22b00b1`](https://github.com/aaru-dps/RedBookPlayer/commit/22b00b1bd5c787101532987c921e924aa264bc5a) DataPlayback option applies to saving tracks - [`0251dae`](https://github.com/aaru-dps/RedBookPlayer/commit/0251dae9810baed49fbb40bb21769ccc1e6e308e) Extract filtering to new file - [`f7e8aaf`](https://github.com/aaru-dps/RedBookPlayer/commit/f7e8aaf4f30092cdf47c24dfd3ee7636dabbfd17) Use Aaru nuget packages - [`9b723ff`](https://github.com/aaru-dps/RedBookPlayer/commit/9b723ffeffe89ab3f0604194875f38ec9a305ecf) Update Aaru nuget packages to 5.3.0 LTS ### 📊 Changes **17 files changed** (+466 additions, -224 deletions) <details> <summary>View changed files</summary> 📝 `.gitmodules` (+0 -3) ➖ `Aaru` (+0 -1) 📝 `README.md` (+6 -0) 📝 `RedBookPlayer.GUI/ViewModels/MainViewModel.cs` (+23 -0) 📝 `RedBookPlayer.GUI/ViewModels/PlayerViewModel.cs` (+55 -5) 📝 `RedBookPlayer.GUI/ViewModels/SettingsViewModel.cs` (+37 -0) 📝 `RedBookPlayer.GUI/Views/SettingsWindow.xaml` (+16 -0) 📝 `RedBookPlayer.Models/Discs/CompactDisc.cs` (+85 -4) 📝 `RedBookPlayer.Models/Discs/OpticalDiscBase.cs` (+18 -0) 📝 `RedBookPlayer.Models/Discs/OpticalDiscOptions.cs` (+5 -0) 📝 `RedBookPlayer.Models/Enums.cs` (+37 -0) ➕ `RedBookPlayer.Models/Hardware/FilterStage.cs` (+58 -0) 📝 `RedBookPlayer.Models/Hardware/Player.cs` (+69 -2) 📝 `RedBookPlayer.Models/Hardware/SoundOutput.cs` (+54 -51) 📝 `RedBookPlayer.Models/RedBookPlayer.Models.csproj` (+3 -3) 📝 `RedBookPlayer.sln` (+0 -155) 📝 `build.sh` (+0 -0) </details> ### 📄 Description This PR does the following: - Migrate to Aaru Nuget packages (fixes #7) - Add WAV saving for both single track and all tracks (fixes #20) - Add repeat modes (fixes #27) - Add eject functionality (fixes #29) - Add multiple session handling (fixes #32) - Add data track saving (fixes #47) - Bumped sector readahead to 10 - Made `build.sh` executable by default This PR is the second of two to be split off from https://github.com/aaru-dps/RedBookPlayer/pull/40. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-30 21:23:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/RedBookPlayer#63
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?