[PR #25] [MERGED] Better customizable UI support #64

New Issue

claunia · 2026-01-30T21:23:14Z

claunia commented

2026-01-30 21:23:14 +00:00

📋 Pull Request Information

Original PR: https://github.com/aaru-dps/RedBookPlayer/pull/25
Author: @mnadareski
Created: 7/1/2021
Status: ✅ Merged
Merged: 7/4/2021
Merged by: @claunia

Base: devel ← Head: better-theme-support

📝 Commits (10+)

4540100 Fix a couple oddities in PlayerView
a256266 Add hardcoded navigation buttons
cfb2d31 Fix and surface de-emphasis flag
afa064e Make loading custom XAML safer
7c940e1 Move hardcoded key values to settings
565b289 Make keybinds UI-accessible
2156fd3 Add keyboard volume controls
fe6b352 Change default volume change keys
abd81d2 Make volume setting safer
2b0de55 Add modifiers for keyboard volume changes

📊 Changes

10 files changed (+831 additions, -207 deletions)

View changed files

📝 README.md (+24 -0)
📝 RedBookPlayer/Discs/CompactDisc.cs (+2 -2)
📝 RedBookPlayer/GUI/MainWindow.xaml.cs (+97 -2)
📝 RedBookPlayer/GUI/PlayerView.xaml.cs (+38 -24)
📝 RedBookPlayer/GUI/PlayerViewModel.cs (+224 -3)
📝 RedBookPlayer/GUI/SettingsWindow.xaml (+118 -36)
📝 RedBookPlayer/GUI/SettingsWindow.xaml.cs (+101 -0)
📝 RedBookPlayer/Hardware/Player.cs (+101 -136)
📝 RedBookPlayer/Hardware/SoundOutput.cs (+29 -3)
📝 RedBookPlayer/Settings.cs (+97 -1)

📄 Description

The majority of this PR focuses around making the UI more accessible, especially given theme support. Notable changes include:

Making loading custom themes safer
Adding user-customizable keyboard bindings for all major UI interactions (fixes #24)
- This also adds some more internal event handlers for things that are not present in the existing default theme such as toggled play/pause, volume up/down, and toggle mute
- The settings window has been overhauled slightly to account for all of the new keybind settings
Documenting default keybinds in README
Surface more of the current player state to the UI for use, for the assumption that the current UI code won't work for all themes
Remove more direct interactions needed between the UI and player code, instead relying more on the view-model

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aaru-dps/RedBookPlayer/pull/25 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 7/1/2021 **Status:** ✅ Merged **Merged:** 7/4/2021 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `devel` ← **Head:** `better-theme-support` --- ### 📝 Commits (10+) - [`4540100`](https://github.com/aaru-dps/RedBookPlayer/commit/4540100fdce5a46dbf872d275f07d87cb376cb4d) Fix a couple oddities in PlayerView - [`a256266`](https://github.com/aaru-dps/RedBookPlayer/commit/a25626648fd332c1a89d4b0bb0b43b9367cd7065) Add hardcoded navigation buttons - [`cfb2d31`](https://github.com/aaru-dps/RedBookPlayer/commit/cfb2d316d7baf5e19e37ba9a9ea4eb018fbc427a) Fix and surface de-emphasis flag - [`afa064e`](https://github.com/aaru-dps/RedBookPlayer/commit/afa064e4292d1dd2b6737969464d4407742a6592) Make loading custom XAML safer - [`7c940e1`](https://github.com/aaru-dps/RedBookPlayer/commit/7c940e157680fa94865b032283a45ad2a3fcdb3b) Move hardcoded key values to settings - [`565b289`](https://github.com/aaru-dps/RedBookPlayer/commit/565b289a45ea1fba61b16543cbec2040531ad032) Make keybinds UI-accessible - [`2156fd3`](https://github.com/aaru-dps/RedBookPlayer/commit/2156fd3b63f3c3bd057c7dcc4ffd7085dcc8e842) Add keyboard volume controls - [`fe6b352`](https://github.com/aaru-dps/RedBookPlayer/commit/fe6b3523c326a450c67fd18d9974565e4ce73598) Change default volume change keys - [`abd81d2`](https://github.com/aaru-dps/RedBookPlayer/commit/abd81d255b97a14230aae76ce9b98de76b0455ea) Make volume setting safer - [`2b0de55`](https://github.com/aaru-dps/RedBookPlayer/commit/2b0de556a168a02f35e8010e3a95efbd19b2f0c1) Add modifiers for keyboard volume changes ### 📊 Changes **10 files changed** (+831 additions, -207 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+24 -0) 📝 `RedBookPlayer/Discs/CompactDisc.cs` (+2 -2) 📝 `RedBookPlayer/GUI/MainWindow.xaml.cs` (+97 -2) 📝 `RedBookPlayer/GUI/PlayerView.xaml.cs` (+38 -24) 📝 `RedBookPlayer/GUI/PlayerViewModel.cs` (+224 -3) 📝 `RedBookPlayer/GUI/SettingsWindow.xaml` (+118 -36) 📝 `RedBookPlayer/GUI/SettingsWindow.xaml.cs` (+101 -0) 📝 `RedBookPlayer/Hardware/Player.cs` (+101 -136) 📝 `RedBookPlayer/Hardware/SoundOutput.cs` (+29 -3) 📝 `RedBookPlayer/Settings.cs` (+97 -1) </details> ### 📄 Description The majority of this PR focuses around making the UI more accessible, especially given theme support. Notable changes include: - Making loading custom themes safer - Adding user-customizable keyboard bindings for all major UI interactions (fixes #24) - This also adds some more internal event handlers for things that are not present in the existing default theme such as toggled play/pause, volume up/down, and toggle mute - The settings window has been overhauled slightly to account for all of the new keybind settings - Documenting default keybinds in README - Surface more of the current player state to the UI for use, for the assumption that the current UI code won't work for all themes - Remove more direct interactions needed between the UI and player code, instead relying more on the view-model --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-30 21:23:14 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: aaru-dps/RedBookPlayer#64