[PR #45] MVVM v2 and Only Fixes #65

New Issue

claunia · 2026-01-30T21:23:14Z

claunia commented

2026-01-30 21:23:14 +00:00

Original Pull Request: https://github.com/aaru-dps/RedBookPlayer/pull/45

State: closed
Merged: Yes

This PR does the following:

Update initialization to be more consistent (fixes #30)
Implement internal playback state instead of using bool? (fixes #31)
Remove the majority of code from the .xaml.cs files (fixes #38)
Add new data playback options (fixes #39)
Add a new OpticalDiscOptions class to avoid method signature creep
Renamed Settings to SettingsViewModel to better reflect its use
Made the default theme act a little more consistently
Bumped sector readahead to 5

This PR is the first of two to be split off from https://github.com/aaru-dps/RedBookPlayer/pull/40, the second of which will focus on adding the other features.

**Original Pull Request:** https://github.com/aaru-dps/RedBookPlayer/pull/45 **State:** closed **Merged:** Yes --- This PR does the following: - Update initialization to be more consistent (fixes #30) - Implement internal playback state instead of using `bool?` (fixes #31) - Remove the majority of code from the `.xaml.cs` files (fixes #38) - Add new data playback options (fixes #39) - Add a new `OpticalDiscOptions` class to avoid method signature creep - Renamed `Settings` to `SettingsViewModel` to better reflect its use - Made the default theme act a little more consistently - Bumped sector readahead to 5 This PR is the first of two to be split off from https://github.com/aaru-dps/RedBookPlayer/pull/40, the second of which will focus on adding the other features.

claunia added the pull-request label 2026-01-30 21:23:14 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: aaru-dps/RedBookPlayer#65