aaru-dps/RedBookPlayer
1
0
Fork 0
mirror of https://github.com/aaru-dps/RedBookPlayer.git synced 2026-02-09 05:24:53 +00:00
Code Issues 41 Packages Projects Releases Wiki Activity

[PR #40] MVVM v2 and Other Fixes/Additions #66

New Issue
Open
opened 2026-01-30 21:23:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 21:23:14 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/aaru-dps/RedBookPlayer/pull/40

State: closed
Merged: No

THIS PR HAS BEEN SUPERCEDED BY https://github.com/aaru-dps/RedBookPlayer/pull/45 AND https://github.com/aaru-dps/RedBookPlayer/pull/46

This PR does the following:

  • Add WAV saving for both single track and all tracks (fixes #20)
  • Add repeat modes (fixes #27)
  • Add eject functionality (fixes #29)
  • Update initialization to be more consistent (fixes #30)
  • Implement internal playback state instead of using bool? (fixes #31)
  • Add multiple session handling (fixes #32)
  • Remove the majority of code from the .xaml.cs files (fixes #38)
  • Add new data playback options (fixes #39)
  • Add a new OpticalDiscOptions class to avoid method signature creep
  • Renamed Settings to SettingsViewModel to better reflect its use
  • Added session to PlayerViewModel so it can be used by themes
  • Made the default theme act a little more consistently
  • Bumped sector readahead to 5
**Original Pull Request:** https://github.com/aaru-dps/RedBookPlayer/pull/40 **State:** closed **Merged:** No --- **THIS PR HAS BEEN SUPERCEDED BY https://github.com/aaru-dps/RedBookPlayer/pull/45 AND https://github.com/aaru-dps/RedBookPlayer/pull/46** This PR does the following: - Add WAV saving for both single track and all tracks (fixes #20) - Add repeat modes (fixes #27) - Add eject functionality (fixes #29) - Update initialization to be more consistent (fixes #30) - Implement internal playback state instead of using `bool?` (fixes #31) - Add multiple session handling (fixes #32) - Remove the majority of code from the `.xaml.cs` files (fixes #38) - Add new data playback options (fixes #39) - Add a new `OpticalDiscOptions` class to avoid method signature creep - Renamed `Settings` to `SettingsViewModel` to better reflect its use - Added session to `PlayerViewModel` so it can be used by themes - Made the default theme act a little more consistently - Bumped sector readahead to 5
claunia added the pull-request label 2026-01-30 21:23:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/RedBookPlayer#66
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?