aaru-dps/RedBookPlayer
1
0
Fork 0
mirror of https://github.com/aaru-dps/RedBookPlayer.git synced 2026-02-13 05:24:58 +00:00
Code Issues 41 Packages Projects Releases Wiki Activity

[PR #25] Better customizable UI support #68

New Issue
Closed
opened 2026-01-30 21:23:15 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 21:23:15 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/aaru-dps/RedBookPlayer/pull/25

State: closed
Merged: Yes

The majority of this PR focuses around making the UI more accessible, especially given theme support. Notable changes include:

  • Making loading custom themes safer
  • Adding user-customizable keyboard bindings for all major UI interactions (fixes #24)
    • This also adds some more internal event handlers for things that are not present in the existing default theme such as toggled play/pause, volume up/down, and toggle mute
    • The settings window has been overhauled slightly to account for all of the new keybind settings
  • Documenting default keybinds in README
  • Surface more of the current player state to the UI for use, for the assumption that the current UI code won't work for all themes
  • Remove more direct interactions needed between the UI and player code, instead relying more on the view-model
**Original Pull Request:** https://github.com/aaru-dps/RedBookPlayer/pull/25 **State:** closed **Merged:** Yes --- The majority of this PR focuses around making the UI more accessible, especially given theme support. Notable changes include: - Making loading custom themes safer - Adding user-customizable keyboard bindings for all major UI interactions (fixes #24) - This also adds some more internal event handlers for things that are not present in the existing default theme such as toggled play/pause, volume up/down, and toggle mute - The settings window has been overhauled slightly to account for all of the new keybind settings - Documenting default keybinds in README - Surface more of the current player state to the UI for use, for the assumption that the current UI code won't work for all themes - Remove more direct interactions needed between the UI and player code, instead relying more on the view-model
claunia added the pull-request label 2026-01-30 21:23:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/RedBookPlayer#68
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?